- 10 Aug, 2020 40 commits
-
-
Livvie Lin authored
Change-Id: Ia12de00773aca815151b4475e37152b524b21bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347045Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796495}
-
kylechar authored
SkiaOutputSurfaceImplOnGpu uses kInProcessCommandBufferClientId as it's client id. Tell GrShaderCache to cache shaders from kInProcessCommandBufferClientId to disk. Bug: 1114763 Change-Id: I71d66b007abf76358b28937eae505198e7f882d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346986Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796494}
-
Ella Ge authored
Tbr: katie@chromium.org Tbr: ellyjones@chromium.org No-try: true Bug: 1054641 Change-Id: I0d5896afccb2012beea0edb9505ee620f263c318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346055Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#796493}
-
Xing Liu authored
This CL adds a flag to enable Chime push notification channel on canary. Bug: 1105693 Change-Id: I647a64743399f07c65652728345bdb7d96b0e153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346832Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796492}
-
Elly Fong-Jones authored
The way it's implemented is very non-obvious and hard to find via code search, so add a comment explaining it and an explicit xref to the involved PlatformStyle constant. Bug: None Change-Id: Ia1756752d403cffac434d6249897b2d5d35eeba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342572 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#796491}
-
Joshua Bell authored
A follow-on to a previous fix[1] to handle the recursive case. A limit was imposed on key length to prevent OOMs as JS arrays are converted to IDB keys. Array keys were handled, but not nested arrays. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2304445 Bug: 1113505 Change-Id: I6eb184cf75e5b39eecfdb79f1d10536d68251452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346839 Commit-Queue: Joshua Bell <jsbell@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#796490}
-
Steven Bennetts authored
This addresses some inconsistencies with the 'Other' APN UI encountered when switching between carrier networks within a Cellular Service. It also adds support for 'Other' entries with accessPointName values matching an existing entry but with different username or password values. Additionally it fixes some instability in the UI while scanning (when the device properties become unavailable). This fixes that by postponing Cellular property updates until scanning completes. Bug: 986921 Change-Id: If5a012e38e5af32ffe4832c553396b94361b86d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333536Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#796489}
-
Jonah Chin authored
This CL splits GetRasterSkImage() into two explicit functions: GetSwSkImage() will always do a readback for texture backed images. GetAcceleratedSkImage() will return a texture backed SkImage and is limited to specific callers. PaintImage::readPixels() handles callers who previously used PaintImage::GetSkImage()->readPixels(). This is necessary for GetSkImage()'s deprecation. In the OOPR case, this new API is routed through the readback on RasterInterface via TextureBacking. More details about overall PaintImage effort: crbug.com/1023259 Info about the OOPR-Canvas2D project: crbug.com/1018894 Bug: 1031050 Change-Id: Icdbb4941ba199e04bfc163f8638d8293131480c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316413Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796488}
-
Becca Hughes authored
Change-Id: Ib25fc8454cac9db5c17e0fd4c1952bbe7a2a4c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342388Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#796487}
-
Sebastien Lalancette authored
Adding a new SharingCoordinator initializer and updating ActivityServiceCoordinator's initializers to enable triggering a URL sharing flow for URLs that aren't necessarily associated with a WebState. Some activities that depended on a WebState have been disabled for that flow (e.g. Print, Find in Page). Also, this CL makes ThumbnailGenerator optional for ChromeActivityURLSource, as no thumbnail can be generated without a WebState. This CL also modifies the initialization of ActivityServiceCoordinator to use a new ActivityParams object which will contain the properties used to configure the various sharing flows. Bug: 1102892 Change-Id: I0b28d5fcc7bae78e669dbfac33ba252165ce86bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319793 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796486}
-
adamta authored
When feed reloads and goes back to being one page (10 articles long), infinite feed would stop working because saved height was higher. We should only check if the saved height is different instead. Bug: 1085419 Change-Id: I89fe5a5c854bdf1b3b46c0b78aa012088bd0011f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342582Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#796485}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/039f681a841a..ea8be2120ee6 2020-08-10 johnstiles@google.com Update ProcessorClone test to re-verify problems without using clone(). 2020-08-10 egdaniel@google.com Add plumbing for dst read render passes into GrVkRenderPass. 2020-08-10 johnstiles@google.com Add style guidance for `k` prefix on constants. 2020-08-10 robertphillips@google.com Move more atlas functionality from GrSmallPathRenderer to GrSmallPathAtlasMgr 2020-08-10 tdenniston@google.com Lower cubic stroke recursion limit to 24 2020-08-10 jmbetancourt@google.com add terminating file on complete of CorrectnessActivity 2020-08-10 brianosman@google.com Reland "Untangle dependency cycle in sksl dehydration" 2020-08-10 mtklein@google.com simplify skvm blitter main logic 2020-08-10 nifong@google.com Add more perf tests and other minor improvemnts 2020-08-10 mtklein@google.com make skvm lerp() a little smarter 2020-08-10 borenet@google.com [recipes] Dump debugging information before running tests on Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I37bfe928af41da62d4de800289e6aeecb3c7017b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346871Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796484}
-
Tommy Martino authored
Bug: 1099268 Change-Id: I1e279858e48f65d1b842caa9943777f50aadc9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332840Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#796483}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1662e97f324e..ccf01e74ec70 2020-08-10 brandon1.jones@intel.com Re-add heap usage tracking for textures in a pass If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If423f0624633cd32acb65051f5fa2dd347b5a859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346948Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796482}
-
Gayane Petrosyan authored
As url is not set in ShareParams when text is shared, url should be passed from tab. If url is passed through ShareParams, it will add first party options for sharing url and will share text+url. Bug: 1102382 Change-Id: I83d5e883b6e1f1f05cd9768d7618ceb61396185c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343295 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#796481}
-
John Smith authored
The issue was that previously, the tabs/toolbar area used the NativeThemeDarkAura for colors, which was not OS accent aware. This was replaced by a forced-to-dark version of the platform's native theme. On Mac, I added a check to maintain the old behavior that skipped the accent colors because there was an issue with how the light/dark theme was applied on Mac. This was since fixed, so we can remove this check and use the accent colors in incognito. This also makes the color behavior more consistent between regular dark mode and incognito. Bug: 1049360 Change-Id: If9a40955391b3c6d9603c66d4eedb99afb0af752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337575Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Joan Barnett <johnsm@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796480}
-
Khushal Sagar authored
R=backer@chromium.org Bug: 757605 Change-Id: I39872742a535ad7d632c374332d36b949a0c0558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341945 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796479}
-
Avi Drissman authored
Do not try to derive one weight of font from another. Use the API to directly generate them. PlatformFontMacTest.FontWeightAPIConsistency tested that our understanding of shifting weights up and down was correct. The code no longer shifts weights up and down as that is unreliable and version-specific, so there is no need to test weight shifting and it is removed. This also fixes Big Sur issues. This re-lands c2e39ede. It turns out that DCHECKs do evaluate everything in them so wrap it with DCHECK_IS_ON(). Bug: 1101426 Change-Id: I1194b4aa127223456b432d12c47d248264d87c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342387Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796478}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.48-1596451266-benchmark-86.0.4221.0-r1 to 86-4183.57-1597053344-benchmark-86.0.4228.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id2ef8c1d1300cd08e8df855ff9a4ea48afa1b9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346876Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796477}
-
Ilia Samsonov authored
This cl removes blinkpy support for Mac10.10, Mac10.11, and Mac Retina. blink web tests for these versions has been removed from waterfall. Bug: 1077312, 1107003, 1114680 Change-Id: I819d0bf7316119b2f5bc127f6eda1deaba7e0cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343548 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796476}
-
Orin Jaworski authored
To aid in smoke testing Pedal concept matching data for all the new languages, a unit test is added that ensures each locale's data set can be loaded and used. Bug: 893183 Change-Id: Ic4686e5cf85dd0f1734fa1a2129f9b4ac3c72da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337107 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796475}
-
Lei Zhang authored
The The is a band, but the the is not. Change-Id: I8c0dc1d4984cf90fe6d83449415e0799f0ec8024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345713Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#796474}
-
Liquan (Max) Gu authored
Change: * Move JourneyLogger into ComponentPRImpl to facilitate the moving of PRImpl#close() into ComponentPRImpl. * Move the PRImpl.Delegate.isOffTheRecord interface method into PRFactory. The value of isOffTheRecord will be set according to the merchant page's state at PRFactory#createImpl(). Bug: 1102522 Change-Id: I46de04bdde95e48d8ecdf1c31cf2685fef213001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341948 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796473}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.48-1596448621-benchmark-86.0.4221.0-r1 to 86-4183.57-1597055597-benchmark-86.0.4228.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1104aeba79d1853d9318c7c1df33df9329dc78c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346880Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796472}
-
Patrick Noland authored
This starts the process of hiding the MenuButton view behind the coordinator. Primarily, ToolbarAppMenuManager (renamed to MenuButtonCoordinator) now directly manipulates the MenuButton instead of doing so through TopToolbarCoordinator. MenuButton related functionality is removed from the Toolbar interface, with a few mechanical adjustments to match. Bug: 1086676 Change-Id: I9d8e63e320feec671df5cbd82aed9e330b543865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327315Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#796471}
-
Yicheng Li authored
This enables reusing LoginPasswordView and LoginPinView with custom colors, e.g. for in-session auth dialog and dark mode in the future. Bug: b:156258540 Test: deploy to Nami device, looks the same as without the change. Change-Id: Ic7ec4be3327fa4a94571543d41ba5030807389b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333823Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796470}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.39-1596449559-benchmark-86.0.4221.0-r1 to 86-4183.48-1597052523-benchmark-86.0.4228.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iac91130f7397a64d750169081560d49e33ec3e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346879Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796469}
-
James Zern authored
-O2 is ~11-17% faster than -Os on a pixel 3a using a ndk build of the decoder (r21d) Bug: 1047051 Change-Id: Ifa67bcd7352f535a71f726c32320d6c0353263d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340497Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#796468}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: CrComponentsCrPolicyNetworkIndicatorMojoTestV3.All Change-Id: I6cabdf0cda77044e2a2e77c07ef174531d6f1852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345520Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#796467}
-
liberato@chromium.org authored
Change-Id: I151f491c0e3729cff3a20c4b8ec9fd628ce5898b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343630 Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#796466}
-
Koji Ishii authored
|NGLineBreaker::RewindOverflow| assumes that |Rewind| rewinds the current |item_index_| to the specified value. However, at some point |Rewind| was changed to not to rewind positioned floats. The DCHECK was to ensure the assumption. This sometimes hits when the line width saturates |LayoutUnit|, and it was considered not too harmful. But crbug.com/1114324 suggested that it may create unexpected internal states which can lead to crashes. This patch removes the assumption from |RewindOverflow|. Bug: 1114324, 1020101, 1029599 Change-Id: I221e87d4ed089ae97aa21a99c2be73dc555f6d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344431Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#796465}
-
Adam Ettenberger authored
This CL addresses a bug where Role::kButton, and possibly other roles that derive their name from descendant contents, were not firing Text Changed when a descendant Node.TEXT_NODE modifies its text |data|. ax_object_cache_impl.cc : - When firing a text changed event, also fire a text changed event for the first ancestor that derives its name from descendant contents. This ensures the nodes are invalidated, send appropriate text changed events, and the changes are serialized to the browser process AXTree. browser_accessibility_manager_win.cc : - FireUiaTextContainerEvent made it possible to fire text events more than once for a given text provider so it has been removed. - Instead, populate a set |text_changed_events_| which contains the text providers via |GetUiaTextPatternProvider| and fire the UIA text events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents - |text_selection_changed_events_| could also potentially end up with the same double-event problem, so it uses GetUiaTextPatternProvider now as well. - Removing usage of std::unordered_set based on the guidance in base/containers/README.md. In general these sets shouldn't grow large enough to benefit from being unordered. AX-Relnotes: Fix bug where after updating the content of complex button might not notify ATs, causing the wrong accessible name to be announced. Bug: 1105262 Change-Id: I02dc7798686b09f780c90af52aeb2e36fe8fe048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296564 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#796464}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/db0253c93b9b..13ebfa60c3f2 $ git log db0253c93..13ebfa60c --date=short --no-merges --format='%ad %ae %s' 2020-08-10 wub Deprecate --gfe2_reloadable_flag_quic_save_user_agent_in_quic_session. 2020-08-07 nharper Expose ProofSource::Details on QuicCryptoServerStream 2020-08-07 renjietang Add version DCHECKS in GOAWAY handling. 2020-08-07 nharper Tighten content-length header parsing in shared spdy code, not flag protected Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src remove deprecated flag R=dschinazi@chromium.org Change-Id: Ia065ee167b59261845f652258cbeb47584cd8a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346909 Auto-Submit: Dan Zhang <danzh@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796463}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008100800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/IVemt3pOQOKoaDEDMgqmUBfRju4WJsHWYff7SymNScAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159394333,b/159394534,b/159964708,b/160646592,b/160930327,b/161170553,b/161179660,b/162901119,b/163099117 Tbr: help-app@grotations.appspotmail.com Change-Id: I6879e2d711d88064544f2f94459621a93305a18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346944Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796462}
-
Ben Pastene authored
It's green now: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-arc-r-chrome/2555 But keep the sanity test experimental. Bug: 1092973 Change-Id: I18085bf954fd512a1a4d0099a292f864a0ea02c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346946 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#796461}
-
Ella Ge authored
The non-virtual one also times out on Linux Leak bot Tbr: hiroshige@chromium.org No-try: true Bug: 1068175 Change-Id: I3b7be7d8d067449f6a811241bbf863a59b8d43ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346851Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#796460}
-
OlivierLi authored
This scope object can be used to disable hang watching when it is known an operation can run in unbounded time. HangWatchScope is renamed to HangWatchScopeEnabled as part of this change also for symmetry. This is done through the introduction of a new persistent flag kHasActiveHangWatchScopeDisabled that can ensure that new HangWatchScopeEnabled instances do not count towards hang watching. Bug: 1034046 Change-Id: I9d8d8b2812a31fe29ba7980d64567798ada3b432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288195Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796459}
-
Elly Fong-Jones authored
Bug: None Change-Id: If52c1528ba8cd0f6f3461bf6bb20ba7d3b5b605b Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346791Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796458}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/577cc158d1e2..01e0ccdc9b8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1f31db9279c9b7e848ccefc510aec1001074f43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796457}
-
Andrew Grieve authored
This reverts commit 67fc091c. Reason for reland: Writing both build_vars.json & build_vars.txt Original change's description: > Revert "build_vars.txt: Changed to build_vars.json" > > This reverts commit 6e002e1f. > > Reason for revert: Official build failure crbug.com/1114609 > > Original change's description: > > build_vars.txt: Changed to build_vars.json > > > > And moved helper function into gn_helpers.py > > > > It was only ever in .properties format so that it > > could be easily parsed by bash, but we no longer need > > that. > > > > Also fixes default_android_sdk_version to be a string. > > -next builds need it to be a string. > > > > Bug: None > > Change-Id: I99541f18510de93dae4c0d68b734638564f74ee2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340673 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#796020} > > TBR=dpranke@google.com,agrieve@chromium.org,mheikal@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: None > Change-Id: Iad8597f6af00c534245fd1a40d1809d952758f47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344626 > Reviewed-by: Ben Mason <benmason@chromium.org> > Commit-Queue: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796387} Bug: 1114750 Change-Id: I1019351a294e54701c093911f67a1fb6b7bd34d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346965Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#796456}
-