GitLab

in SdchDictionaryFetcher to DLOG(FATAL).

BUG=416639
R=rch@chromium.org

Review URL: https://codereview.chromium.org/599143002

Cr-Commit-Position: refs/heads/master@{#296465}

Adding split view divider widget which could be dragged to exit the split view.
Resubmit of https://codereview.chromium.org/545393002

TBR=mukai@chromium.org
BUG=403207, 408691

Review URL: https://codereview.chromium.org/598083002

Cr-Commit-Position: refs/heads/master@{#296464}

We were initializing permissions before checking that the extension existed.
Fix this.

BUG=415986

Review URL: https://codereview.chromium.org/584313002

Cr-Commit-Position: refs/heads/master@{#296463}

BUG=none
R=maruel@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/596113002

Cr-Commit-Position: refs/heads/master@{#296462}

BUG=348066
TEST=None
R=bruening@chromium.org,dpranke@chromium.org,jamescook@chromium.org

Review URL: https://codereview.chromium.org/588903002

Cr-Commit-Position: refs/heads/master@{#296461}

BUG=none

Review URL: https://codereview.chromium.org/598033002

Cr-Commit-Position: refs/heads/master@{#296460}

Revert of Roll breakpad a513e85:7caf028 (svn 1384:1385) (patchset #1 id:1 of https://codereview.chromium.org/590403003/)

Reason for revert:
Broke TSANv2 builder:

breakpad/src/client/linux/minidump_writer/minidump_writer.cc:554:37: error: use of undeclared identifier 'time'
    header.get()->time_date_stamp = time(NULL);

Original issue's description:
> Roll breakpad a513e85:7caf028 (svn 1384:1385)
>
> r1385: Linux: Call memset() in a couple places in ExceptionHandler.
>
> BUG=332335
>
> Committed: https://crrev.com/ec86bac94da60dc9286bb49b87745570a83a6a55
> Cr-Commit-Position: refs/heads/master@{#296446}

TBR=timurrrr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=332335

Review URL: https://codereview.chromium.org/595343003

Cr-Commit-Position: refs/heads/master@{#296459}

BUG=410946
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/594963002

Cr-Commit-Position: refs/heads/master@{#296458}

Revert of Large wallpaper decoding in utility process (patchset #5 id:190001 of https://codereview.chromium.org/482163002/)

Reason for revert:
Speculative revert for unit_tests failures:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31845/steps/unit_tests/logs/DecodeImageSizeLimit

Original issue's description:
> Handle large wallpaper decoding in utility process:
> Images over 32M pixels exceed IPC message limit size.  In ChromeContentUtilityClient::DecodeImage(), cut image dimensions in half to minimize quality loss and allow decoded image to be returned via IPC message.
>
> BUG=366825
> TEST=ChromeContentUtilityClientTest.DecodeImageSizeLimit; Set ChromeOS wallpaper using JPGs attached to bug
>
> Committed: https://crrev.com/d9d0e601c4c45ec8f2fb1d148e68458d9baa4e24
> Cr-Commit-Position: refs/heads/master@{#296407}

TBR=dcheng@chromium.org,bshe@chromium.org,skuhne@chromium.org,sky@chromium.org,tsepez@chromium.org,yoz@chromium.org,glevin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=366825

Review URL: https://codereview.chromium.org/600913002

Cr-Commit-Position: refs/heads/master@{#296457}

R=arv@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/594373002

Cr-Commit-Position: refs/heads/master@{#296456}

This will zoom in/out the view properly.

This CL is dependant on http://crrev.com/597653002

BUG=416332
Test=Load chrome with --enable-mime-handler-view and --out-of-process-pdf
Navigate to a pdf file, Ctrl + wheel up and down should zoom in/out the pdf
properly.

Review URL: https://codereview.chromium.org/591243003

Cr-Commit-Position: refs/heads/master@{#296455}

Revert of Instrumented libraries: update the libnspr4 build script. (patchset #1 id:1 of https://codereview.chromium.org/600793002/)

Reason for revert:
MSAN bots failed.

FAILED: cd ../../third_party/instrumented_libraries; ../../third_party/instrumented_libraries/download_build_install.py "--product-directory=../../out/Release" "--package=libnspr4" "--intermediate-directory=../../out/Release/obj/third_party/instrumented_libraries/msan-libnspr4.gen" "--sanitizer-type=msan" "--extra-configure-flags=--enable-64bit --disable-debug" "--cflags=-O2 -gline-tables-only -fPIC -w -U_FORITFY_SOURCE \"-fsanitize=memory\" \"-fsanitize-memory-track-origins=0\"" "--ldflags=-Wl,-z,origin -Wl,-R,XORIGIN/. \"-fsanitize=memory\"" "--cc=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang" "--cxx=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang++" "--jobs=10" "--build-method=destdir" "--run-before-build=scripts/libnspr4.sh"
mv: cannot stat `nspr/*': No such file or directory

Original issue's description:
> Instrumented libraries: update the libnspr4 build script.
>
> There has been a security update in Precise which changed the paths somewhat.
>
> BUG=313751
> TBR=glider@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/91e9dd404b29bcbb847b98530e83f3c40720b890
> Cr-Commit-Position: refs/heads/master@{#296395}

TBR=glider@chromium.org,earthdok@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=313751

Review URL: https://codereview.chromium.org/598983004

Cr-Commit-Position: refs/heads/master@{#296454}

Collection of memory statistics is broken in OSX 10.9+. I've disabled the
checks in ProcessInfoSnapshotMacTest that expect collection of memory
statistics to work.

BUG=383553, 390276

Review URL: https://codereview.chromium.org/583193006

Cr-Commit-Position: refs/heads/master@{#296453}

Revert of Roll src/third_party/skia cd523eb:34a9895 (patchset #1 id:1 of https://codereview.chromium.org/601813002/)

Reason for revert:
Broke build:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/4087/steps/compile/logs/stdio

Original issue's description:
> Roll src/third_party/skia cd523eb:34a9895
>
> Summary of changes available at:
> https://chromium.googlesource.com/skia/+log/cd523eb..34a9895
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
> TBR=borenet@google.com
>
> Committed: https://crrev.com/b8201c1963db05126f9d997c4935b918a53a8a67
> Cr-Commit-Position: refs/heads/master@{#296442}

TBR=borenet@google.com,skia-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/601853002

Cr-Commit-Position: refs/heads/master@{#296452}

BUG=357769
R=mef@chromium.org

Review URL: https://codereview.chromium.org/593863002

Cr-Commit-Position: refs/heads/master@{#296451}

isAcceleratedCompositingActive is a racy check asking if the page has
had a compositing update with a non-null root layer.  This check in
WebTestProxy was added as a part of converting layout tests to force
compositing mode to make sure that any test asking for a readback was
going down the composited path rather than the legacy software path.

It should be possible to finish a test and ask for an asynchronous
readback prior to having done any compositing updates.  This check does
not seem legit in the first place, so just remove it.

BUG=397321

Review URL: https://codereview.chromium.org/597773002

Cr-Commit-Position: refs/heads/master@{#296450}

Contains:

Revert "Workaround to prevent crashes when destroying CGL contexts"
This reverts commit 282049cc.

Revert "Log erros while presenting an IOSurface to about:gpu"
This reverts commit 090e36f0.

Revert "Simplify IOSurface CoreAnimation code: Part 2"
This reverts commit 672e23e9.
Resolved conflicts:
	content/browser/compositor/io_surface_layer_mac.mm

Fixed call ccameron@ pointed out in: https://codereview.chromium.org/490393002/diff/260001/content/browser/compositor/io_surface_layer_mac.mm#oldcode149

Build fixes for recent scoped_refptr changes.

BUG=314190,408986,411782
R=piman@chromium.org
TBR=ccameron@chromium.org,pfeldman@chromium.org

Review URL: https://codereview.chromium.org/596703006

Cr-Commit-Position: refs/heads/master@{#296449}

call OnTerminating in unit test.

BUG=None

Committed: https://crrev.com/828338e278350941febbfbede2b34d721be6dab1
Cr-Commit-Position: refs/heads/master@{#296348}

Review URL: https://codereview.chromium.org/599683003

Cr-Commit-Position: refs/heads/master@{#296448}

This CL removes the duplicate fields for the README.chromium file for
android_protobuf.

BUG=377891

Review URL: https://codereview.chromium.org/595133002

Cr-Commit-Position: refs/heads/master@{#296447}

r1385: Linux: Call memset() in a couple places in ExceptionHandler.

BUG=332335

Review URL: https://codereview.chromium.org/590403003

Cr-Commit-Position: refs/heads/master@{#296446}

This is to help diagnose an issue where the perf bots seem to be running without
flash.

BUG=416849

Review URL: https://codereview.chromium.org/597213002

Cr-Commit-Position: refs/heads/master@{#296445}

Add filenames support. DO_NOT_CONVERT_FILENAMES policy is not
supported because writing NSFilenamesPboardType to NSPasteboard always
populates the URL types.

Modify SetURL so that it doesn't overwrite previous SetString.

The following tests now passes:
OSExchangeDataTest.URLAndString
OSExchangeDataTest.TestFileToURLConversion

BUG=378134

Review URL: https://codereview.chromium.org/542203004

Cr-Commit-Position: refs/heads/master@{#296444}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4d5ca33..440c1ed

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/602733003

Cr-Commit-Position: refs/heads/master@{#296443}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cd523eb..34a9895

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/601813002

Cr-Commit-Position: refs/heads/master@{#296442}

Updated wording as well.

BUG=413337
TEST=manual

Review URL: https://codereview.chromium.org/597673003

Cr-Commit-Position: refs/heads/master@{#296441}

The original usage of the method was added to fix a rendering issue
with the YouTube plugin: see http://crrev.com/2862031 .
Setting an appropriate viewport seems to work as well
and removes usage of a method I'm trying to remove.

BUG=417221

Review URL: https://codereview.chromium.org/596253002

Cr-Commit-Position: refs/heads/master@{#296440}

BUG=78512, 407376
TEST=no change

Review URL: https://codereview.chromium.org/596543002

Cr-Commit-Position: refs/heads/master@{#296439}

Revert of Swarm tests on Linux release tester. (patchset #2 id:20001 of https://codereview.chromium.org/598053002/)

Reason for revert:
since I disabled the recipe side

Original issue's description:
> Swarm tests on Linux release tester.
>
> BUG=414808
> TBR=maruel@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/01b2eb0b5e291faa238d6a21def3e62056bc1fdd

TBR=maruel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=414808

Review URL: https://codereview.chromium.org/602603004

Cr-Commit-Position: refs/heads/master@{#296438}

On CrOS, app windows can already be minimized by clicking their icon in the
taskbar. This just makes them show a minimize button as well.

On Windows, we prevent minimize if the window can't maximize, which
doesn't really make sense. They will now be able to minimize and show a
minimize button.

On Mac and Linux they could always minimize.

BUG=351179

Review URL: https://codereview.chromium.org/603523002

Cr-Commit-Position: refs/heads/master@{#296437}

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/600003002

Cr-Commit-Position: refs/heads/master@{#296436}

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/603453003

Cr-Commit-Position: refs/heads/master@{#296435}

Revert of Another attempt to fix debug info stripping for ASan on OSX (patchset #5 id:80001 of https://codereview.chromium.org/560323004/)

Reason for revert:
Broke mac asan content_browsertests:
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%281%29/builds/4311/steps/content_browsertests/logs/stdio

Original issue's description:
> Another attempt to fix debug info stripping for ASan on OSX
>
> Unce upon a time the ASan runtime library used to be statically linked into
> the executables on OSX.
> Because that library provided a number of API functions needed by the shared
> libraries, we had custom ASan-specific .saves files that told the `strip`
> utility to preserve those functions when stripping the executables.
>
> Then ASan switched to using dynamic runtime library, which instantly broke the
> stripping step, because the executables weren't necessarily referencing all the
> ASan API functions (issue 242503).
> As a result, stripping has been disabled, and we haven't had .dSYM debug info
> for ASan builds for more than a year now (issue 148383).
>
> Because the ASan API functions are now undefined in the executables, it's
> actually senseless to use the .saves files to preserve those functions in each
> executable. However __asan_default_options still must be preserved to be accessible
> from the ASan runtime.
>
> This CL removes all ASan symbols except for __asan_default_options from the .saves files
> and makes Chromium.app and Chromium Helper.app correctly use app_asan.saves.
> It also turns mac_strip_release on for ASan builds.
>
> BUG=148383,242503,170739,166857
> R=mark@chromium.org
> TBR=cpu@chromium.org
>
> Committed: https://crrev.com/d051b21c75afc414190db331fd608cc61e3056dc
> Cr-Commit-Position: refs/heads/master@{#296413}

TBR=mark@chromium.org,cpu@chromium.org,glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=148383,242503,170739,166857

Review URL: https://codereview.chromium.org/597873004

Cr-Commit-Position: refs/heads/master@{#296434}

Revert of Adding split view divider widget. (patchset #15 id:280001 of https://codereview.chromium.org/545393002/)

Reason for revert:
DragHandleTest.ScrollTest is failing on the bots: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36880

Original issue's description:
> Adding split view divider widget.
>
> Adding split view divider widget which could be dragged to exit the split view.
>
> BUG=403207,408691
>
> Committed: https://crrev.com/b47c16517f0882cbabf8c9aa9ce66711f026fd5b
> Cr-Commit-Position: refs/heads/master@{#296351}

TBR=mukai@chromium.org,oshima@chromium.org,sadrul@chromium.org,tdanderson@chromium.org,pkotwicz@chromium.org,mfomitchev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=403207,408691

Review URL: https://codereview.chromium.org/602603003

Cr-Commit-Position: refs/heads/master@{#296433}

Since we use an embedder provided thread everywhere, we should also let
the embedder do the yielding.

BUG=301514
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/596243002

Cr-Commit-Position: refs/heads/master@{#296432}

Change this ManagePasswordsBubbleCocoaTest to use the tab strip model API
active_index() to determine if tab content is active.

TBR=rohitrao
BUG=417253

Review URL: https://codereview.chromium.org/592353005

Cr-Commit-Position: refs/heads/master@{#296431}

BUG=414808
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/598053002

Cr-Commit-Position: refs/heads/master@{#296430}

BUG=none
R=inferno@chromium.org

Review URL: https://codereview.chromium.org/598063002

Cr-Commit-Position: refs/heads/master@{#296429}

This is a reland of http://crrev.com/3882aae7 since
http://crrev.com/40d8624d should have fixed the problem leading to
diff update failures.

BUG=340387
TEST=N/A

Review URL: https://codereview.chromium.org/596353002

Cr-Commit-Position: refs/heads/master@{#296428}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5fa19f3..4d5ca33

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/603573003

Cr-Commit-Position: refs/heads/master@{#296427}

Revert of Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) (patchset #1 id:1 of https://codereview.chromium.org/601803002/)

Reason for revert:
Wrong revert. I misread the buildbot failure email.

Original issue's description:
> Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) (patchset #1 id:1 of https://codereview.chromium.org/595313002/)
>
> Reason for revert:
> Break build:
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/19333
>
> Original issue's description:
> > Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594)
> >
> > Summary of changes available at:
> > https://chromium.googlesource.com/chromium/blink/+log/f2b7b089..5fa19f3
> >
> > TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org
> >
> > Committed: https://crrev.com/0ae73de143b645c376ac0e503e9627d33bb3c4f1
> > Cr-Commit-Position: refs/heads/master@{#296414}
>
> TBR=ager@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/677a9222f8fbf4e581ba4461ae700c8c380bc78c
> Cr-Commit-Position: refs/heads/master@{#296418}

TBR=ager@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/595353002

Cr-Commit-Position: refs/heads/master@{#296426}