GitLab

https://chromium.googlesource.com/angle/angle.git/+log/be75fbcca886..68a5baeb5ba0

2020-09-24 jmadill@chromium.org Revert "Vulkan: Implement a SharedResourceUse pool"
2020-09-24 syoussefi@chromium.org Vulkan: Support MSRTT depth/stencil resolve
2020-09-24 geofflang@chromium.org Add a Vulkan feature to compress float32 vertex formats.
2020-09-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from ae8b33cdea62 to 8ab1c000aaa0 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: syoussefi@google.com
Change-Id: I2b55bc6ca304f9df29faeddc97bd69b1215bb0e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429324Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810324}

Bug: 1131819, 1131834
Change-Id: I08e4a82d5d6ec6b6def379888e439f60c2c8f87d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428532
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810323}

Add cmd-{/} keyboard shortcuts to match Mac desktop, in addition to the
commands that are already there. Additionally fix up the directionality
to take RTL into account.

BUG=988313

Change-Id: I9b8b69c30a85f0dbc9e38a5d8a6b72a97355d06f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427422
Auto-Submit: Mike Pinkerton <pinkerton@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810322}

The ARM DTK does not specify a PCI device ID for the GPU. Do not fail
in this configuration.

Bug: 1121672
Change-Id: Idf2d35ed7ff15d43c300203160cec6a74a31d5ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427567Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810321}

CTAP2 specifies that an authenticator's ECDH key is regenerated after
a PIN error. This change makes the virtual authenticator mirror that. It
also adds a test to ensure that we can work with a valid PIN after an
invalid one is entered. (See linked bug.)

BUG=1129713

Change-Id: I2473d674df4a72312f529ebb60826df4282e8392
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418808Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810320}

Populates an Observer List to be triggered by a Pending Service Request
DBus Signal from the system CfmServiceContext service, providing access to chromium services and APIs.

New mojoms are added for APIs which are tailored to the services that
require them such as messaging_layer.

Services are added to the primary cfm chromium mojom pending security
reviews such as cros_healthd

Note: The primary goal of this cl is to establish the correct directory
structure for registering new services to the |CfmServiceContext|.

Future projects requires dependencies on directories including but not
limited to:
 * //chromium/src/services/video_capture/
 * //chrome/browser/policy/messaging_layer/
 * //chromeos/services/cros_healthd/
 * etc.

BUG=chromium:1105567, b:165864612
TEST='autoninja -C out/Default chromeos:chromeos_unittests \
       && ./out/Default/chromeos_unittests --dbus-stub \
         --single-process-tests --gtest_filter=CfmHotlineClientTest.*'

Change-Id: Id0c687a88b126dc10975803020b1ec431af6ebaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419799Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Kyle Williams <kdgwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810319}

This CL adds tuneable parameters to Tab Search's fuzzy search
implementation.

Defaults have been chosen to effectively emulate an exact match
algorithm over the title and hostname. These feature parameters
allow updates to the fuzzy search parameters either via command
line args or finch experiment.

Bug: 1099917
Change-Id: I86f6cd7f819136db0452a8268bdb74a614be7fa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425724
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810318}

This CL only adds the class and its initialization. The
MessageQueueManager is owned by RootUiCoordinator and exposed through
WindowAndroid to be available for the code in /components/...

BUG=1123947
R=lazzzis@chromium.org

Change-Id: I2f3e8084b483b1604ce2f9f344ec6ff85ecd005b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399079Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Lijin Shen <lazzzis@google.com>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810317}

When in a fragmentation context, there was this bug where an OOF node
position did not appear to be relative to the fragmentainer ancestor.
This was only a paint issue. This CL fixes it.

Bug: 1113911
Change-Id: Ic9a4e5bab3a22fe3c25228cbbd2efec52ed1742a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386382Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#810316}

Default enables "retransmittable_on_wire_timeout_milliseconds": 200.
This corresponsds to finch config change in cl/333005962.

Bug: 155818758
Change-Id: Ia94eafb209816ce820a6970216d7fcd257be4b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425763Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810315}

1. Check path and session id from request and accept WebSocket connection
if valid
2. Only allow one connection per session
3. If connection closed, session id can be reused to establish connection
4. Add tests for accepting and rejecting connection
5. Reverted some changes in https://chromium-review.googlesource.com/c/chromium/src/+/1730860

Public design doc:
https://docs.google.com/document/d/1zixFBPtgFFwhc5pT1IfneFoW6yZfpvYdQRsNN4tbghk/

Previous CL chain(I, II and III):
I. https://chromium-review.googlesource.com/c/chromium/src/+/2382299
II. https://chromium-review.googlesource.com/c/chromium/src/+/2389053
II. https://chromium-review.googlesource.com/c/chromium/src/+/2391903

Bug: chromedriver:3588
Change-Id: Idbdd2c17e2b04f23c78c5a36f1f5585e94819d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406661
Commit-Queue: Shengfa Lin <shengfa@google.com>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810314}

This makes MailboxTextureBacking keep a reference to MailboxRef and
updates its release SyncToken when MailboxTextureBacking goes out of
life.

Bug: 897297, 1121019, 1131123
Change-Id: Ia121d3c3898eeab89f814eba6de43406871f4c37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351452
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810313}

This API is suspected to leak cross-site entropy about users.
This instrumentation reports digests of the values read using this API
to UKM to determine the available entropy of the API for identifying
users across sites.

Bug: 973801
Change-Id: If46f692a3f644a2b97381c4709b521a997b0c9d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424858Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#810312}

This CL reverts all the recent changes to audio_buffer_source_node
that was splitting up the code to make optimizations easier.  We're
now restoring the code back to the way it was in 86.0.4215.0, which
was the last version before the offending 86.0.4232.0 was landed.

While the change is somewhat large a lot of it is for undoing the
experiments trying to figure out where the problem was coming from.

Bug: 1116104
Change-Id: I5febac0cb9b1409f54e2f3a8d24cd58951308631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427133Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810311}

The IPH_NewTab feature no longer appears to be used in the code.

Bug: 1126640
Change-Id: Ia74ecf49241aefd99cb4fd2b95f03cad2575ded3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427353
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810310}

Change-Id: Ib32c839baee0be8e5a9785a5df85774f61c337c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429374
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810309}

The "DnsOverHttps" feature along with the "ShowUi" param is approved for
launch and will soon be launched to 100% for win/mac/cros/android, so
enable the feature/param by default for those platforms.

There shouldn't be anything left with the feature enabled but the ShowUi
param disabled, but I'm still switching the param on platform because I
don't understand the UI code enough to be sure nothing in there will
only check the param without the feature and not accidentally enable the
UI.  I'll figure that out and handle it later in a more thorough cleanup
to fully delete the ShowUi param.

Also note that it is traditional to delete the fieldtrial testing config
entries when changing experiments to be enabled by default, but I'm
leaving it in place here because it is covering testing of the
"DisabledProviders" param that is not yet launching to a final state.

Bug: 878582,1098039
Change-Id: I57bb6264047b7ed426bf57fca9f6301f71312ba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429243
Commit-Queue: Eric Orth <ericorth@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Auto-Submit: Eric Orth <ericorth@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810308}

This makes it easier to manage and update android BUILD.gn files that
are scattered throughout the codebase.

Bug: None
Change-Id: I6957ff13bc4bb9804ac6a8e4d3a290b18f2aef11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429843
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810307}

Change-Id: I802011805e0e2accfce7de6b49a9acb7db9559aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425012Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810306}

https://swiftshader.googlesource.com/SwiftShader.git/+log/a09406249fa3..b94db86cf9b3

2020-09-24 sdefresne@chromium.org Explicitly filter assigments to sources variable

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1018739
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ie0d9c9866e6df215e49cd592e66f63560936973d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428220Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810305}

Some type of the resources were deprecated but not marked as such.
This CL marks them using the [[deprecated]] attribute.

Bug: 1131514
Change-Id: Ia36acc7933d0fa0abee8138f07955837ff1568cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426249
Auto-Submit: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810304}

Surfacing server card nickname is already fully enabled in M84.
Clean up all the usages.

Will remove the Phase 1 histogram logging in a follow up CL.

Bug: 1059087
Change-Id: I1394d5563e072f3a3cb8bdf0fee3fceda6c208ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422784
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Siyu An <siyua@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#810303}

Add a set of histogram name to folder name mapping to aggregate or split
histograms in a semantically clearer way. Also update
print_histograms_name to tolerate the case when the new histograms.xml
file is not present in the previous version.

Bug: 993193
Change-Id: Iad6fea2f3d8443f0a2518b3473fcece2a981d45d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427437
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810302}

Bug: 992019
Change-Id: Iab178d111664799f815843f84b9df94de83bb281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429464Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#810301}

https://android.googlesource.com/platform/external/perfetto.git/+log/3d8fd27d9a8a..71ee049b6b17

2020-09-24 taylori@google.com Merge "perfetto-ui: Make metrics non-breaking in UI"
2020-09-24 hjd@google.com Merge changes I3ac1b577,I174ae837,I9d1f40a5
2020-09-24 taylori@google.com Merge "Load trace and discard old state"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: If7b85adbfc223724eddc91d10ba367aace68656f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428822Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810300}

Factors out the IdentifiableTokenBuilder construction and addition of
the FontSelectionRequest's hash. Also factors out the logic for
insertion of the typeface digest into the appropriate hash map (using
the input key), including avoiding digest computation when the key is
already present in the hash map. Finally, collapses repeated code during
metric publishing into an additional for loop.

These changes have no functional impact, but improve readability and
reduce the risk that future changes might inadvertently miss a spot.

Bug: 1126634
Change-Id: Ic825fb74fb177b8bee12c21b6458432bc3aafbc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402109
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810299}

Use default argument true for creating a horizontal ScrollBarViews by
default.

Bug: 1108460
Change-Id: Ic19c4e34e6c06372d9004ccbb9d17cc72d31c9cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427525Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810298}

- Inkdrop ripple and highlight colors are based on the background color
  currently. And the color is WHITE in dark and BLACK in light mode.
  Removing the hard code, get the colors from AshColorProvider instead.
- There is no need to set the inkdrop color on the underneath image's
  color now. Removing the |ink_drop_color_| related logic inside
  SystemMenuButton.

Bug: 1107056
Change-Id: Id67a5b22845aae5df6fa85be775e892f7a958c5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426548Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810297}

Want to see if the signing block size is proportional to file sizes, or
if it tends to fluctuate in size.

Bug: 1130754
Change-Id: Idf2d8662418375a243750959ecdd9f162d513885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426551
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810296}

Use MainActivity context to startActivity instead of calling the
fragment#startActivity to avoid the exception thrown when the fragment
is detached.

Bug: 1130732
Test: Manually launch the app, click settings
Test: run_webview_instrumentation_test_apk -f "*android_webview.devui*"
Change-Id: Ib43df575edf34154b4297fac2bc1b8216250cdae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424151
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810295}

When a new WebContents arrives, the current WindowAndroid's
destroy() is invoked. To prevent this from happening multiple
times on the same windowAndroid, create a new instance for each
incoming WebContents.

Bug: internal b/167950522
Test: Cast one app, then another
Change-Id: I7c6d87f313d0215b1f35c767bce6a3ab192f63fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427216
Auto-Submit: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810294}

Was previously an autoupgrade-only provider.

Test: Manually confirmed UI change for multiple regions.
Fixed: 1082456
Change-Id: Ie9241d6f468b7175fd3b10cfaf56f3a16cdfc183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427352Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810293}

This feature launched as enabled by default on M81, and there are no
plans to revert it. This CL cleans up the feature flag (and should
cause no behavior changes).

There is still cleanup left from the feature launch, notably removing
the shield UI that is no longer used. That will be cleaned up
in a follow up CL.

Bug: 1078193
Change-Id: I34007e68e876c231e76dbcdedafe8de9a0d17121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418810Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810292}

This reverts commit affe1977.

Reason for revert: Causing flaky crashes on Mac, see
https://bugs.chromium.org/p/chromium/issues/detail?id=1085222#c28.

Original change's description:
> Add ModuleCache API contract checks
>
> Adds checks to ensure early detection of API contract violations that
> would lead to use-after-frees.
>
> Bug: 1127466
> Change-Id: Ic73b30f115f5206572a427ac44674ff6a9b9f249
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425523
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809987}

TBR=wittman@chromium.org,etiennep@chromium.org

Change-Id: Iae2cd6197448b8f54e8ba6918979c1b6f43157b5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1127466, 1085222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429867Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810291}

This allows a screen reader to read the updated text of the dialog.

Bug: 1131565
Change-Id: I73a2df8067ffc96148ebf5d50a9412cf34b67feb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424841
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810290}

This CL shows the identity disc when user is signed-in. The
corresponding tests will be added in the subsequent CL after we add the
new sign-in methods to AccountManagerFacade.

Bug: 1131920
Change-Id: Ic5992cf9c0561206ceee3f9e68c53bda72661468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428929
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810289}

This change adds tests that validate scenarios where requesting XR
compatibility should fail:
- If the WebXR feature policy isn't allowed, a SecurityError is thrown
- If there are no devices available, an InvalidStateError is thrown

A runtime enabled feature is added for WebXR multi GPU that syncs with
the corresponding Chromium feature flag.

Bug: 1124024
Change-Id: Ia79b06ecffa936471a6fd80172717c7724245bf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416856Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Patrick To <patrto@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#810288}

We switched to use chrome://favicon2 from base64 stream for favicon.
But for OTR profile chrome://favicon2 is not available. This CL fixes
favicon not showing up correctly in guest mode.

Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2406932

Bug: 1099917
Change-Id: I5fdd1dda997d08024d6ce3aa6d6a569d38ac026e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424510
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810287}

In a prior CL [1], I added the CheckIdempotency() function, which tests
that GURL canonicalization produces a fixed point the first time it's
called.

There was some confusion whether CheckIdempotency was duplicating logic
that already existed in the fuzzer; the fuzzer already had a few lines
to copy the GURL with a no-op call to ReplaceComponents and check that
the spec string is unchanged.

This "copy check" is subtly different than the idempotency check. In
particular, it cannot catch the "file:///.//" -> "file:////" ->
"file:///" bug because it never reaches DoParseFileURL.

For context, the non-idempotency bug for "file:///.//" arises because
  * DoPartialPath drops "./", taking "file:///.//" to "file:////"
  * DoParseFileURL collapses "//" to "/", taking "file:////" to
    "file:///".

[1]: http://crrev.com/c/2414615

Bug: 1128999
Change-Id: Ib35982f56cac3ced23d13def74f073a0245bdee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424764Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810286}

This change introduces a TILE_NAVSUGGEST suggestion type for the
most-visited suggestions.
The TILE_NAVSUGGEST is built in a similar way to NAVSUGGEST and
TILE_SUGGEST elements, where a list of tiles is held as a vector of
elements arranged in the order these are scored.

The TILE_NAVSUGGEST is currently meant specifically for zero-prefix
most-visited URL suggestions and should be positioned below the
QueryTiles. These elements are currently not meant to be
cached as these URLs are used specifically when user is visiting a
website (ie. not a ZPS on a NTP).

The change does not create any logic wiring up TILE_NAVSUGGEST items;
instead, it simply creates a new suggestion type and adds
corresponding data to that object on both Native and Java sides.

Change-Id: Ia4c5141143d6a49f963bcf66fecae9b84d3d4b5e
Doc: http://doc/1IFsDKYhy_ARMOdT8jd1pMtk497xe03lb3hVnsaY-dOM
Slides: http://slides/1c1SzJLzEsTjLmqIVLTomC8l9EgslBgYaBN6I7t8mbDI#slide=id.g8b3736bab3_0_0
Figma: https://www.figma.com/file/h8qjD0s9tezRzHdCMxIhYJ/On-Focus-Suggestions?node-id=290%3A309
Bug: 1106109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422808
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810285}