- 18 Jan, 2021 40 commits
-
-
Patrick Monette authored
At first, this class will own the performance_monitor::SystemMonitor. In the future, it will also own the ProcessMonitor when it no longer is a leaky singleton. Bug: 1166820 Change-Id: Ie47865c3b6e9afcae91be14c22342f3b27685426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630228Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#844571}
-
Keishi Hattori authored
If GigaCage isn't enabled, this DCHECK gets triggered PartitionRoot()->PartitionRefCountPointer()->DCheckGetSlotOffsetsZero()->PartitionGetSlotOffset()->DCheckIfManagedByPartitionAllocNormalBuckets() We should check IsPartitionAllocGigaCageEnabled before calling IsManagedByPartitionAllocNormalBuckets. Also removed, PartitionRefCountPointerNoDCheck() as it would no longer be needed. Bug: 1073933 Change-Id: Ida270d718f0299837d1b506966d46512a8c60f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631980 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#844570}
-
Michael Ershov authored
* Replace `EXPECT_CALL(..., Func(_))` into `EXPECT_CALL(..., Func)` where checking arguments is not useful. (in most cases it expects a pointer to client object). * Expect specific arguments for function calls where it's not a pointer (just a couple of places with empty vector). Bug: 1150887 Test: CloudPolicyClientTest* Change-Id: I23dd01ad2d868e312d9bdc4135ff7a3b5e7249fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550919Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#844569}
-
Omar Morsi authored
In this CL, the 412 pending approval HTTP status error code is handled by the certificate provisioning client by trying the request after a different delay depending on the request that received this error. Bug: 1167055 Change-Id: Id92ea8f3bc47337144b3e81af2aa7c99a8aa465a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632687Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
-
Caitlin Fischer authored
The server-side configs show that these studies have ended. Bug: 1126640 Change-Id: I4df424208d21cbfe4da72c51693185b6bc9910ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631933Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844567}
-
Miyoung Shin authored
This CL keep a swap promise as active when DidNotSwap is called with the commit fail to fix the problem that WebViewClient#onPageCommitVisible callback is not invoked or callbacks arrive at once. This problem was introduced since the CL[1] converted FrameMsg_VisualStateRequest to mojo because the CL missed the migration from the original code[2] which was being ported. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2342532 [2] https://chromium.googlesource.com/chromium/src/+/c75c53f04b0207e654fd2f7f05e6b785988ea30e/content/renderer/frame_swap_message_queue.cc#124 Bug: 1148808 Change-Id: I935bee95332e775fd13fea15fedc856d34b37649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636094Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#844566}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610959165-ca87807bfba7d6db298cc69229704c835aeb25f8.profdata to chrome-win64-master-1610970273-10063fdcfa50f030104140b77891927983b7acbd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I53ea8f8a0e1ad61a4f44464c05d4c9bc7a4350a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636255Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844565}
-
Ella Ge authored
Pass the Supplier<ModalDialogManager> directly when creating CustomTabLocationBar, so that no need to get it from ChromeActivity. Bug: 1155353 Change-Id: Ibdea28fdd85cbda48cf6c9233afee00f862cdd86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633685Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#844564}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5c20f1ec9ca9..4b316994ad01 2021-01-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from c068cfc1397a to 4a110c2726e9 (1 revision) Also rolling transitive DEPS: https://dawn.googlesource.com/tint from c068cfc1397a to 4a110c2726e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I02d04afd2670999e81f1a8e6265d1d865d64ab04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636337Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610959165-8386a0e84f434425b7043e7053c588f46a3ee84d.profdata to chrome-win32-master-1610970273-d0f0048b36f7949e3d42c84fb209656aa5017f8c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I69fe2399215ad8d7487d258f257e0d33005688aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636293Reviewed-by:
-
Ella Ge authored
Cast the activity to a ModalDialogManagerHolder to get the ModalDialogManager. Bug: 1155804 Change-Id: Ieae4f796f3e7b93b670ff6e5b8e2a120f2da1c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633363Reviewed-by:
-
Colin Blundell authored
This CL changes the subresource filter to handle detected ad violations entirely within the component, rather than delegating to the embedder. This change concretely means that WebLayer now obtains this behavior for free. To test proper integration in WebLayer, this CL also adds browsertests of the expected behavior in //weblayer. These browsertests are straight ports of the tests in //chrome's ads_intervention_manager_browsertest.cc with one exception: those tests verify that ChromeSubresourceFilterClient::ShowNotification() is called on page activations via checking a histogram bucket that is updated in that method. //weblayer does not currently update this histogram (although I will shortly be componentizing that code), so I removed these checks from the //weblayer tests as other //weblayer tests verify directly that the infobar is shown on a page activation. I disabled these browsertests on Windows due to https://crbug.com/1152429. Bug: 1116095 Change-Id: Ieba4ac17988a711c658cdb2b731bdb952b669f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612890 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#844560}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a36b28c1..e02dfe6c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8929beb2a0d319bd5922c6acfb8cd1be8dcb173e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635718Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844559}
-
Owen Min authored
Rename the policy to WindowOcclusionEnabled. The old policy is kept for backward compatibility. Bug: 1163293 Change-Id: I6ff1ebf56e6bb5ec02a449773e407e18c914aea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611675Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844558}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101180600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/69VjTA0ZKwsJNTOyvk6Q68sahYC23kY9GOAyQSnd2wEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: If193403e5501af2d723d3a53acb2a984113700ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636253Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844557}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/149733cead63..765e4f6f0ef4 2021-01-18 swiftshader.regress@gmail.com Regres: Update test lists @ 149733ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic4b4fbf9af3971cf847b6ca7db89d739a89c3f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636235Reviewed-by:
-
Ehimare Okoyomon authored
Change dialog result reporting system to have its own observers in order to prevent having to add ModalDialogManagerObserver workarounds. For example, when a secondary os-level prompt is created after the user accepts a site-level prompt. This way, we only trigger an update directly after the permission changes. Bug: 1158288 Change-Id: I496ceb8f35495e61dd4f161256e56cf40c172ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632756 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#844555}
-
Ossama Mahmoud authored
Migrate ArcToSScreen to multistep behavior. Get rid of display: none; and display: block; Bug: 1156667 Change-Id: I4c2fc425edd4883c5edfceb0a5a9f67a6227de7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603744 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844554}
-
Nico Weber authored
Looks like response file support in ld64 might be less crashy in this release, so we can try turning that back on after this roll. (It's currently enabled for static libraries but not for shared libraries or executables. We should first disable it for static libraries to get a self-consistent state, and then try enabling it for everything.) Apparently `otool` now (sometimes?) calls `otool-classic`, so add that to xcode_binaries.yaml and to content_shell_crash_test data. Bug: 1147968 Change-Id: I90f45942e6f7d735b5fb3be242a517f002f2e072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633748 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844553}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101180600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/ASfyiPo0gQ5e7I8KW1f86nFK6CdK4HjdLqg4cLkv3VEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/175532928,b/176035799,b/177381366,b/177472560,b/177604649,b/177784709 Tbr: media-app@grotations.appspotmail.com Change-Id: Ia5ed3f3a862fc0c59659b04630f8b36a15d1cfd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636177Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Icaa62b40bd6d8041cde6e2bca8c72c1367e8cfcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627884Reviewed-by:
Per Kjellander <perkj@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844551}
-
Sigurdur Asgeirsson authored
Bug: 1143281 Change-Id: Ibc54e560a2a2a5f38c6ef48c7352c40c1b82109c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636273 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#844550}
-
behdad authored
The interval of last frame in sliding window is used to calculate the total expected frames in window. Test are also updated to reflect this change in calculation of percent dropped frames. Bug: 1167213 Change-Id: I5dd7e608d35b33af90046867d70bc652cced0366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633922Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844549}
-
Mustaq Ahmed authored
This CL adds fields to postMessage data structures that convey the sender Window's intention to delegate a capability to the receiver Window. The change is behind two runtime flags: one flag ("CapabilityDelegation") enables the parsing of a new postMessage option for delegation, while the other flag ("CapabilityDelegationPaymentRequest") enables transmission of payment request delegation information to the receiver Window. Bug: 1130558 Change-Id: Ifad482bc9629ea69b9bd802d5f0f7df7c24645f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568627 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844548}
-
Vidhan authored
profile dedupe has already run The profile deduplication is run once every chrome version. Since, AlternativeStateNameMap needs to be populated before running the deduplication logic, it does not make sense to synchronize populating the map every time on browser startup. With this change, AlternativeStateNameMapUpdater would be populating the AlternativeStateNameMap on the browser startup if the profile deduplication logic has already been run for the current chrome version. Bug: 1111960 Change-Id: I2964d292c726083dcde069bf1e2596e723db2679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632671Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#844547}
-
Matthias Körber authored
Change-Id: I3e7214e59f822812eee25e084a3ee0d61b6d28f1 Bug: 1007974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626288 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#844546}
-
Dominic Battre authored
This CL move the tracking of some form controls to unique renderer IDs. This mitigates a user visible (temporary) leak. Bug: 1144739 Change-Id: I4199750622ea6bfda681a07120ace0b1ad08510a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632951Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#844545}
-
Roman Sorokin authored
Bug: 1162271 Change-Id: I08ec5ae65ac7b6228752fec11490497bb6a5fa9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602284 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844544}
-
Yaron Friedman authored
Bug: 783819 Change-Id: I4c7d5c75a8f58a517324ed2a9d8cd2c475cbd784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633369 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1bb49a870088..2a27413fde15 2021-01-18 reed@google.com Remove legacy code from picture-shader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I35f2a6965bda1407d021a23fc1fa3e59f01321b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635943Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5fcf0fa9382e..66a69e614cbb 2021-01-18 henrysun@google.com dedede: add factory-dedede-13683.B into builder 2021-01-17 manojgupta@chromium.org Revert "sysroot_lib: add -O to MAKEOPTS" 2021-01-16 vapier@chromium.org sysroot_lib: add -O to MAKEOPTS 2021-01-16 saklein@chromium.org dependency_graph.py: A new dependency graph class. 2021-01-15 geohsu@google.com Instantiate M89 builders 2021-01-15 tcwang@google.com afdo: Fix orderfile script path inside chroot If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I17b3175d73dcc85d121e2be4bc0cacaa4de78afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636254Reviewed-by:
-
Egor Pasko authored
On Android the call is backed by gettid(3). With bionic this call has gotten a fast TLS cache since [1], which seems to cover all releases supported by Chrome. Keeping the thread id in a thread_local variable adds extra latency from emutls: pthread_getspecific() and an atomic load. Leaving it unchanged on other platforms. Preliminary performance tests show occasional improvements on speedometer2 and regressions on blink_perf. Since the former is more important than the latter, let's land this and go through alerts (green+red) from chromeperf. [1] https://android.git.corp.google.com/platform/bionic/+/5d9a7ba0dc9c24ed4e4efa9cac0e796fd524b308 Bug: None Change-Id: I8a5c5319bdddd368bc44ab4f1e3f066447997172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339669Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844540}
-
Alex Ilin authored
This CL adds more tests to profile_card_menu_test.js test suite. The new tests check: - profile and account names in the remove confirmation dialog - statistics table in the remove confirmation dialog Change-Id: I9284b85d1b0ece2f958da60dd1566f9addf2857f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630048 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#844539}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b06ebb493f2c..f572da65b858 2021-01-18 alexrudenko@chromium.org Enable flexbox tooling experiment by default 2021-01-18 petermarshall@chromium.org [startup] Wait until settings are loaded to load locale data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1167695 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie4abd90b6cbf41135bdd048cb122fce3cde58bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636234Reviewed-by:
-
Matthias Körber authored
This CL also introduces a class enum for the parsing outcome and moves some code from the test utils header into the cc file. Change-Id: I34c6538a68fe2c33a02646eddb6692b88b155a6e Bug: 1007974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626647 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
-
Liviu Tinta authored
Because we use static_cast<int> to cast from double to int we expose ourselves to float-cast-overflow. We use clampTo to make sure the result is in int limits. MouseEvent: :layerX, MouseEvent::layerY are returned as integers. Bug: 1164520 Change-Id: I0881323f5508b3f4d3fb2f3f73d6b138aa4202c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622870Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#844536}
-
Ella Ge authored
Bug: 1155353 Change-Id: Icfc48b9f991dbccf8c2fbc96a6bdf3ceab0c62ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630225Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
-
Cheick authored
This CL adds a feature flag for shared highlighting color change. Bug: 1166249 Change-Id: I355710abddc4c2c10dd9d673b5d9a21e30142f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626270Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Cheick Cisse <cheickcisse@google.com> Cr-Commit-Position: refs/heads/master@{#844534}
-
Wan-Teh Chang authored
Document that within blink/renderer we can get a a UkmRecorder instance by using blink::Document::UkmRecorder(). Change-Id: I6c06c87d4e0a2a4fba459ae57e75779a14a91277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634228Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#844533}
-
Monica Basta authored
UIs affected: Profile card on the main view, remove confirmation dialog. After this CL: * The full Gaia name instead of gaia given name. * Use font size: 1em for the gaia name and 1.16em for the local profile name. Screenshots: https://drive.google.com/file/d/1-duldVHMSbdSZELmlJEAB0nTV8Sg3Cvs/view?usp=sharing&resourcekey=0-32oL_7guOgsf9pGzhzKq9Q https://drive.google.com/file/d/1PV9mGbS2Hb_06dKKtsCYKv5SQAOPgMou/view?usp=sharing&resourcekey=0-C_8QVvlFSG3tsRdgXB341Q Fixed: 1167184 Change-Id: Ic6db3698b07d11eb988a6ed6fea9d866d6a2a405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632611 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#844532}
-
