GitLab

AwURLRequestContextGetter now owns an instance of net::NetLog.

BUG=277075
R=boliu@chromium.org

Review URL: https://codereview.chromium.org/557733002

Cr-Commit-Position: refs/heads/master@{#294359}

Followup to CL 469993007, which added a c++11 style enum scope,
but we haven't officially switched to c++11 yet.

BUG=360088

Review URL: https://codereview.chromium.org/562513005

Cr-Commit-Position: refs/heads/master@{#294358}

This patch resolves very old todos about missing descriptions of arguments
of methods in the metadata directory.

TEST=No change. Comments only.
BUG=413100

Review URL: https://codereview.chromium.org/562763006

Cr-Commit-Position: refs/heads/master@{#294357}

BUG=402684

Review URL: https://codereview.chromium.org/546803002

Cr-Commit-Position: refs/heads/master@{#294356}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/562693004

Cr-Commit-Position: refs/heads/master@{#294355}

R=sdefresne@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/548343005

Cr-Commit-Position: refs/heads/master@{#294354}

Currently there is not enough unit test cases available to cover
the functionality of Paste Popup menu behavior. This patch covers
essential unit test cases for the same.

These tests originally landed in r293222, but were incidentally reverted
due to some pre-existing test failures in the same file.

BUG=

Review URL: https://codereview.chromium.org/560883002

Cr-Commit-Position: refs/heads/master@{#294353}

https://skia.googlesource.com/skia/+log/97bf60ff7f3dd7d6e782b706ec94efb2b414b27e..26a4b514999dcbd8c6a4a2e85bcc5dbd55f02236

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/561133003

Cr-Commit-Position: refs/heads/master@{#294352}

The whole purpose of FileManagerPrivateAPI class was to hold an
EventRouter instance. It's simpler to just make EventRouter a
KeyedService and get rid of FileManagerPrivateAPI.

Note that BrowserContextKeyedAPI could not be used for EventRouter as
EventRouter needs a Profile rather than a BrowserContext.

In the next patch, EventRouter will be renamed to something like
FileManagerService.

BUG=412643
TEST=Files.app works as before

Review URL: https://codereview.chromium.org/553393002

Cr-Commit-Position: refs/heads/master@{#294351}

Before, the specified playback position was ignored so this patch fixes the bug.

BUG=395868

Review URL: https://codereview.chromium.org/556493002

Cr-Commit-Position: refs/heads/master@{#294350}

When onDraw is called, everytime RectF is created which allocates new object. To compute the rect, it needs to be created only once and re-used every time when onDraw() is called altering its values, else too many RectF objects could affect performance.

This issue is found from below lint warning:
../../../tmp/tmppzTHqO/0/PopupZoomer.java:466 Avoid object allocations during draw/layout operations (preallocate and reuse instead): DrawAllocation [warning]
            RectF rect = new RectF();

Bug=None.

Review URL: https://codereview.chromium.org/549163002

Cr-Commit-Position: refs/heads/master@{#294349}

Blink GC plugin: Add plugin flags for generating raw-pointer errors and unneeded-finalizer warnings.

R=haraken@chromium.org
BUG=334149
NOTRY=true

Review URL: https://codereview.chromium.org/551343002

Cr-Commit-Position: refs/heads/master@{#294348}

Previously, the maximize button would be hidden if the window is
created with a maxWidth or maxHeight, or non-resizable. Once the size
constraint is removed, the maximize button remains hidden. Similarly,
a size constraint that is applied after the window is created would
not hide the maximize button.

This adds Widget::OnSizeConstraintsChanged which causes the native
widget to update the window's properties, and the non client view to
update the visibility of the maximize button.

BUG=351181,412241

Review URL: https://codereview.chromium.org/554183002

Cr-Commit-Position: refs/heads/master@{#294347}

* NotificationRegister and NotificationObserver is need to collect
  file information.

* This CL is related to https://codereview.chromium.org/530553006

BUG=412691

Review URL: https://codereview.chromium.org/566433004

Cr-Commit-Position: refs/heads/master@{#294346}

DevTools code needs access to platform thread id in order to collect Worker thread ids and based on them differentiate worker threads in recorded trace events.

Blink part of the change: https://codereview.chromium.org/514193002/

BUG=401895

Review URL: https://codereview.chromium.org/515243002

Cr-Commit-Position: refs/heads/master@{#294345}

https://chromium.googlesource.com/chromium/blink/+log/ac6fda4a504cc8837dcd763d22aceb9d7935980f..a54014ac471a9d5980ca18a582f1f4a1a767efa4
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/567443002

Cr-Commit-Position: refs/heads/master@{#294344}

Cr-Commit-Position: refs/heads/master@{#294343}

Review URL: https://codereview.chromium.org/549273002

Cr-Commit-Position: refs/heads/master@{#294342}

This is a very minor change to the motion of pages (fast start and slow
end), but brings the launcher in line with the material design spec.

BUG=406222

Review URL: https://codereview.chromium.org/543403004

Cr-Commit-Position: refs/heads/master@{#294341}

Review URL: https://codereview.chromium.org/554563002

Cr-Commit-Position: refs/heads/master@{#294340}

Visulaizer ==> Visualizer

R=dmikurube@chromium.org
BUG=405447

Review URL: https://codereview.chromium.org/494593002

Cr-Commit-Position: refs/heads/master@{#294339}

Currently 'Bookmark all tabs' and 'Bookmark Edit' window have different minimum and default sizes. Make them consistent.

XIB Changes:
BookmarkAllTabs & Bookmark Editor window's minimum and default sizes are set in .xib file located at
chrome/app/nibs/BookmarkAllTabs.xib
chrome/app/nibs/BookmarkEditor.xib

Their window's default and minimum width and height values are decided by NSWindowRect & NSWindowContentMinSize key strings repectively. Set the correct values such that BookmarkAllTabs & Bookmark Editor windows are consistent

BUG=401491
R=asvitkine@chromium.org

TEST=
1) Launch chrome, open 2-3 tabs, right click on last tab and select 'Bookmark all tabs'.
2) On opened window increase the size by dragging towards R.H.S, and then try to decrease the size by dragging towards L.H.S and Observe.
3) The bookmark window should be minimize upto default size as of "Bookmark Edit" window.

Review URL: https://codereview.chromium.org/537553002

Cr-Commit-Position: refs/heads/master@{#294338}

closure_linter: temporarily add support for @suppress {suspiciousCode} to unblock compiling settings.

R=vitalyp@chromium.org
TBR=tbreisacher@chromium.org
BUG=393873
NOTRY=true

Review URL: https://codereview.chromium.org/561873004

Cr-Commit-Position: refs/heads/master@{#294337}

XIB Changes:
Font style for 'New folder' title in BookmarksAllTabs and BookmarkEditor window is set in .xib files placed at following locations.
chrome/app/nibs/BookmarkAllTabs.xib
chrome/app/nibs/BookmarkEditor.xib
Removing the 'fontBold' key string for the 'newFolder' object.

BUG=397086

R=asvitkine@chromium.org

TEST=
1) Launch chrome and bookmark any page.
2) Now in the Bookmarks bar right click on the bookmarked page and click on edit.
3) In the edit box click on 'New folder' and observe.
4) The 'New folder' name font style should not be bold.

Review URL: https://codereview.chromium.org/535083002

Cr-Commit-Position: refs/heads/master@{#294336}

Windows Server 2012 returns code 1285L instead of ERROR_ACCESS_DENIED.
So sbox_validation_tests fails on Windows Server 2012 R2.

R=cpu@chromium.org
BUG=411859

Review URL: https://codereview.chromium.org/543003002

Cr-Commit-Position: refs/heads/master@{#294335}

The CL removes "device scanning" notification and the relative logic in device_event_router.cc.

BUG=408011
TEST=manually
TBR=benwells@chromium.org
TBR for removing two event types from IDL.

Review URL: https://codereview.chromium.org/541623002

Cr-Commit-Position: refs/heads/master@{#294334}

After recent refactorings moving almost the remaining pieces into
storage/, looks like nobody is including this header.

So we can remove it now.

BUG=338338
TEST=None
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/555323003

Cr-Commit-Position: refs/heads/master@{#294333}

https://chromium.googlesource.com/chromium/blink/+log/ed7de93f3c7434f11196f45486e9cda62e52a21d..ac6fda4a504cc8837dcd763d22aceb9d7935980f
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/566493002

Cr-Commit-Position: refs/heads/master@{#294332}

Cleaning up weak_ptr_factory destruction order in "src/remoting" module.
WeakPtrFactory should remain the last member so it'll be destroyed
and invalidate its weak pointers before any other members are
destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/551393003

Cr-Commit-Position: refs/heads/master@{#294331}

BUG=413002

Review URL: https://codereview.chromium.org/564563002

Cr-Commit-Position: refs/heads/master@{#294330}

BUG=370433
TEST=None
R=sky@chromium.org
TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/562693002

Cr-Commit-Position: refs/heads/master@{#294329}

BUG=411415
TEST=covered by unit tests.

Review URL: https://codereview.chromium.org/562003002

Cr-Commit-Position: refs/heads/master@{#294328}

This pulls in the following changes:

1195796 Ensure x86_64 perlasm output ends with a newline.
f7768e4 Test SHA-256 and SHA-384 CBC-mode cipher suites.
71dad68 OPENSSL_EXPORT SSL_CTX_set_keylog_bio.

BUG=none

Review URL: https://codereview.chromium.org/565503002

Cr-Commit-Position: refs/heads/master@{#294327}

Move embedded extension options guest view files from
chrome/browser/guest_view/extension_options/ to
extensions/browser/guest_view/extension_options. Also add a
ExtensionOptionsGuestDelegate in chrome/ to handle certain tasks, like
opening tabs and handling context menus, which cannot be run from
within extensions/.

This move makes the extension_options codebase more consistent with the
other guest views, which are organized similarly.

BUG=409316

Review URL: https://codereview.chromium.org/556563003

Cr-Commit-Position: refs/heads/master@{#294326}

Makes the clock offset estimator more accurate and reacts faster.
This comes from issue 519163002 (but without the tracing.)

Review URL: https://codereview.chromium.org/556693002

Cr-Commit-Position: refs/heads/master@{#294325}

IDR_STATUS_TRAY_ICON_PRESSED is only used in unit testcases. So we remove
this so that it should not endup in pak files.

BUG=367339

Review URL: https://codereview.chromium.org/464163003

Cr-Commit-Position: refs/heads/master@{#294324}

When the enrollment is in progress, the button shows "Enrolling..." and is
disabled.

Also made BrowserOptionsHandler an observer of ConsumerManagementService, so
that the settings page is updated when the enrollment state is changed.

BUG=chromium:353050
TEST=unit_tests

Review URL: https://codereview.chromium.org/493613002

Cr-Commit-Position: refs/heads/master@{#294323}

R=estade@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/439313004

Cr-Commit-Position: refs/heads/master@{#294322}

Revert of Simplify test locales in ui_unittests Framework (patchset #1 id:1 of https://codereview.chromium.org/552963002/)

Reason for revert:
Bizarrely, this is causing valgrind on Snow Leopard to pick up a
bunch of leaks from allocations within system libraries.
Reverting while I figure out how best to fix that.

BUG=413034

Original issue's description:
> Simplify test locales in Mac's ui_unittests Framework
>
> Mac creates a mini-framework in `ui_unittests Framework` so that ui
> tests can get a resource bundle without depending on the Chrome
> framework.
>
> The way it generated locale information was causing build flakes since
> two instances of repack_locales.py could be writing to
> out/../gen/repack. Tests always use en-US, so instead just do what iOS
> does and copy ui_test.pak to en.lproj/locale.pak and roll it into the
> mini-framework bundle.
>
> BUG=410468
>
> Committed: https://crrev.com/bac8fafd3d056f1277c2fdf44d2a66ca19252e54
> Cr-Commit-Position: refs/heads/master@{#294052}

TBR=avi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410468

Review URL: https://codereview.chromium.org/560993004

Cr-Commit-Position: refs/heads/master@{#294321}

The API is for ensuring the files are downloaded in local storage, and wad used in two places in Files.app.

The first is mounting ZIP. We don't need to care about it. We can mount ZIP
without downloading it in advance.

The second is selecting files in the file select dialog. We can download files
when fileManagerPrivate.selectFiles(s), and UI shows the progress correctly. But
previously, if downloading is cancelled, the API is regarded as success and it
passes the selected file inforamtion to the browser. The CL handles the case and
has the API report an error if the downloading is cancelled.

BUG=326082
TEST=delete cache, open the file in the file select dialog. Also cancel uploading in the dialog.

Review URL: https://codereview.chromium.org/557223003

Cr-Commit-Position: refs/heads/master@{#294320}