GitLab

Revert of Revert of Clean up Smart Lock cryptohome keys logic: (patchset #1 id:1 of https://codereview.chromium.org/789793005/)

Reason for revert:
This didn't fix the problem, so reverting the revert.

Original issue's description:
> Revert of Clean up Smart Lock cryptohome keys logic: (patchset #5 id:80001 of https://codereview.chromium.org/808563004/)
>
> Reason for revert:
> Once this change landed chromeos file manager tests started failing across the MSAN bots.
>
> This is the most likely culprit, so reverting speculatively. If this does not help will reland this change.
>
> See http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Browser%20%282%29/builds/139
>
> Original issue's description:
> > Clean up Smart Lock cryptohome keys logic:
> >
> > 1. Queue all cryptohome keys operations.
> > 2. Roll ClearRemoteDevices as a specific case of SetRemoteDevices
> > 3. Introduce new RefreshKeys operation using the existing add and remove keys
> >    operations to replace the current cryptohome keys with new keys.
> > 4. After reauthenticating for setup, remove the old cryptohome keys.
> >
> > BUG=432996
> >
> > Committed: https://crrev.com/275152c34d8edc5346757288cfffe63444650faa
> > Cr-Commit-Position: refs/heads/master@{#309094}
>
> TBR=tbarzic@chromium.org,xiyuan@chromium.org,tengs@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=432996
>
> Committed: https://crrev.com/8ffa00af2d4e322e91859c502aa02e0c9b0e1f2a
> Cr-Commit-Position: refs/heads/master@{#309519}

TBR=tbarzic@chromium.org,xiyuan@chromium.org,tengs@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=432996

Review URL: https://codereview.chromium.org/814153003

Cr-Commit-Position: refs/heads/master@{#309540}

BUG=none

Review URL: https://codereview.chromium.org/818873002

Cr-Commit-Position: refs/heads/master@{#309539}

Covers testing/, tools/, ui/, and win8/.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/819223002

Cr-Commit-Position: refs/heads/master@{#309538}

This ensures that compiler optimizations are restored to the state as it was before ReduceLarge function. Previous CL https://codereview.chromium.org/814273004 could have a possible side effect of enabling "tree-vectorize" optimizations for the rest of the file even when they were disabled in build settings.

BUG=439566

Review URL: https://codereview.chromium.org/819893002

Cr-Commit-Position: refs/heads/master@{#309537}

This is timing out pretty consistently now.

TBR=thakis@chromium.org
NOTRY=true
BUG=400490

Review URL: https://codereview.chromium.org/810953006

Cr-Commit-Position: refs/heads/master@{#309536}

R=erickung@chromium.org
TBR=lcwu@chromium.org
BUG=408189

Review URL: https://codereview.chromium.org/794253004

Cr-Commit-Position: refs/heads/master@{#309535}

Currently if postMessage messages are sent to a MimeHandlerView guest before
it has loaded, they will just be dropped. It also isn't possible to know
when the guest has fully loaded. This CL queues messages until the guest
has fully loaded and then dispatches them to the guest so that none are lost.

BUG=415858

Review URL: https://codereview.chromium.org/811263002

Cr-Commit-Position: refs/heads/master@{#309534}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0acf1b4..b1c6843

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/822873002

Cr-Commit-Position: refs/heads/master@{#309533}

These tests timeout there.

TBR=dalecurtis@chromium.org
NOTRY=true
BUG=444578

Review URL: https://codereview.chromium.org/811193003

Cr-Commit-Position: refs/heads/master@{#309532}

Revert of Explicitly suppress scrolling for wheel events that will trigger zooming (patchset #10 id:360001 of https://codereview.chromium.org/739013008/)

Reason for revert:
Broke layout tests that use wheel events:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/15918

Original issue's description:
> Explicitly suppress scrolling for wheel events that will trigger zooming
>
> We added a flag in Blink to decide if Ctrl-wheel-scroll should scroll or zoom, and now we use this flag in chromium code.
>
> This patch is part of a series:
>
> patch #1: https://codereview.chromium.org/759073002
> patch #2: This CL
> patch #3: https://codereview.chromium.org/768443002
>
> BUG=397027, 378755
>
> Committed: https://crrev.com/b3361bcdd3766a67c702c19781154c895fee75ca
> Cr-Commit-Position: refs/heads/master@{#309472}

TBR=rbyers@chromium.org,tdresser@chromium.org,jdduke@chromium.org,sievers@chromium.org,lanwei@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=397027, 378755

Review URL: https://codereview.chromium.org/819993002

Cr-Commit-Position: refs/heads/master@{#309531}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/be75b55..68cf7f6

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/815883004

Cr-Commit-Position: refs/heads/master@{#309530}

Make the main function Click() and then change ButtonClick to simply call Click().

BUG=443754

Review URL: https://codereview.chromium.org/801023004

Cr-Commit-Position: refs/heads/master@{#309529}

If the scroll and the overscroll stretch are pointing in different
directions, then reconcile the two by adding the scroll to the
overscroll stretch (up to the point where the overscroll stretch
vanishes), and subtracting the same amount from the scroll.

Apply this operation just before drawing the frame so that there are no
glimpses of odd content.

Simplify the interface to the ScrollElasticityHelper, querying the
scroll offset and maximum scroll offset directly (from which the other
properties can be inferred).

As it is necessary that the InputScrollElasticityController be informed
of any of these reconciliations, have that structure be the one to do
the work, being called into via the InputHandlerProxy's cc::InputHandler
interface.

BUG=133097

Review URL: https://codereview.chromium.org/813123003

Cr-Commit-Position: refs/heads/master@{#309528}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/804533005

Cr-Commit-Position: refs/heads/master@{#309527}

Both cl.exe and clang-cl don't use trigraphs on Windows by default, but
clang still warns about them.  Since the standard does include trigraphs,
fix the code to not (accidentally) include a trigraph rather than siliencing
the warning.

BUG=82385

Review URL: https://codereview.chromium.org/822813003

Cr-Commit-Position: refs/heads/master@{#309526}

BUG=444430

Review URL: https://codereview.chromium.org/822863002

Cr-Commit-Position: refs/heads/master@{#309525}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/16c8f14..0acf1b4

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/821833002

Cr-Commit-Position: refs/heads/master@{#309524}

The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
we are updating the include paths to fix this.

BUG=395370
TEST=unit_tests, content_unittests, extensions_unittests ...
TBR=sky@chromium.org,danakj@chromium.org

Review URL: https://codereview.chromium.org/823703003

Cr-Commit-Position: refs/heads/master@{#309523}

This CL moves the search provider check into the function which
determines how to display hotwording. Prior to this, it was only being
updated when the search provider was changed and other javascript could
come along and re-show the hotword section (even though it was now
supposed to be hidden). Now every time the hotwording should be
displayed, the search provider is checked beforehand. This is the
logically correct way to do it.

BUG=442938

Review URL: https://codereview.chromium.org/815683003

Cr-Commit-Position: refs/heads/master@{#309522}

BUG=426119, 437750

Review URL: https://codereview.chromium.org/787023002

Cr-Commit-Position: refs/heads/master@{#309521}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/818033004

Cr-Commit-Position: refs/heads/master@{#309520}

Revert of Clean up Smart Lock cryptohome keys logic: (patchset #5 id:80001 of https://codereview.chromium.org/808563004/)

Reason for revert:
Once this change landed chromeos file manager tests started failing across the MSAN bots.

This is the most likely culprit, so reverting speculatively. If this does not help will reland this change.

See http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Browser%20%282%29/builds/139

Original issue's description:
> Clean up Smart Lock cryptohome keys logic:
>
> 1. Queue all cryptohome keys operations.
> 2. Roll ClearRemoteDevices as a specific case of SetRemoteDevices
> 3. Introduce new RefreshKeys operation using the existing add and remove keys
>    operations to replace the current cryptohome keys with new keys.
> 4. After reauthenticating for setup, remove the old cryptohome keys.
>
> BUG=432996
>
> Committed: https://crrev.com/275152c34d8edc5346757288cfffe63444650faa
> Cr-Commit-Position: refs/heads/master@{#309094}

TBR=tbarzic@chromium.org,xiyuan@chromium.org,tengs@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=432996

Review URL: https://codereview.chromium.org/789793005

Cr-Commit-Position: refs/heads/master@{#309519}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/824683003

Cr-Commit-Position: refs/heads/master@{#309518}

Removed the permission message generating code that was duplicated
across SocketPermission and SocketManifestPermission and combined it
into a single static function in SocketManifestPermission.

Based on crrev.com/795543002.

BUG=398257

Review URL: https://codereview.chromium.org/794063002

Cr-Commit-Position: refs/heads/master@{#309517}

If the user updates the pref (e.g., via chrome://settings) then they
presumably already know about always on hotwording so there's no reason to
annoy them with a notification. This CL adds a pref registrar observer
to the always on pref and when it's changed, marks the notification as seen
and then removes the observer.

This will only work for new users since once they have the always on pref,
this observer will get hit on switching between profiles, but presumably
once they have the always on pref, it means they enabled it or disabled it
at some point.

BUG=443805

Review URL: https://codereview.chromium.org/815223003

Cr-Commit-Position: refs/heads/master@{#309516}

Made possible by the new Tuple implementation.
No intended behavior change.

BUG=440675

Review URL: https://codereview.chromium.org/818123002

Cr-Commit-Position: refs/heads/master@{#309515}

Also copy a few helper functions from extension_function_test_utils.h to
api_test_utils.h so we don't need to depend on chrome/. These helper
functions are needed by tests other than the display test and will help with
the migration.

BUG=392842

Review URL: https://codereview.chromium.org/779083002

Cr-Commit-Position: refs/heads/master@{#309514}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463
TBR=rogerta@chromoium.org

Review URL: https://codereview.chromium.org/802413003

Cr-Commit-Position: refs/heads/master@{#309513}

This adds PostMessage support for MimeHandlerView allow sites that embed extension mime handlers to communicate with them.

BUG=415858

Review URL: https://codereview.chromium.org/729333002

Cr-Commit-Position: refs/heads/master@{#309512}

Another of these tests is now failing.

TBR=ckehoe@chromium.org
NOTRY=true
BUG=444516

Review URL: https://codereview.chromium.org/826433002

Cr-Commit-Position: refs/heads/master@{#309511}

ui_java target was ported in
https://chromium.googlesource.com/chromium/src/+/26046b5fe46738a9c214a64862831e9417f27850
by cjhopman.

This patch was tested with the following command lines:

$ out/Debug/gn gen out_gn/Debug/ --args='os="android" cpu_arch="arm"'

$ ninja -C out_gn/Debug/ ui/base

BUG=None
TEST=see above
TBR=sky@chromium.org,brettw@chromium.org

Review URL: https://codereview.chromium.org/819233002

Cr-Commit-Position: refs/heads/master@{#309510}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d582cab..16c8f14

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/819963002

Cr-Commit-Position: refs/heads/master@{#309509}

When '<' and '>' Android keyboard generates KEYCODE_SHIFT_LEFT followed by
KEYCODE_COMMA or KEYCODE_PERIOD. Android client sends shift event as a key
event and then the actual character is sent as a text event. As result
when the input injector tries to inject text event shift key is pressed
and as result injected keys are not interpreted correctly. Fixed input
injector to release all keys before trying to inject text events.

BUG=407463

Review URL: https://codereview.chromium.org/806223008

Cr-Commit-Position: refs/heads/master@{#309508}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/55af1ae..be75b55

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/809323004

Cr-Commit-Position: refs/heads/master@{#309507}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/817413002

Cr-Commit-Position: refs/heads/master@{#309506}

nullptr is one of the C++11 allowed features. See https://chromium-cpp.appspot.com/ and https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/4mijeJHzxLg.

This patch was generated with the following command lines:

$ ninja -C out/Debug -t compdb cxx > out/Debug/compile_commands.json
$ cd out/Debug
$ find ../../tools/gn -name '*.cc'  | xargs -n 16 -P 32 \
~/src/repos/llvm/build/bin/clang-modernize -use-nullptr -p . -include \
tools/gn -format -style=Chromium
$ ninja gn gn_unittests

BUG=None
TEST=compiles + gn_unittests
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/798333005

Cr-Commit-Position: refs/heads/master@{#309505}

One tile memory takes 160 bytes currently.
This patch can reduce the tile memory by removing unnecessary
variables and packing the booleans to 144 bytes.

BUG=341919

Review URL: https://codereview.chromium.org/810713002

Cr-Commit-Position: refs/heads/master@{#309504}

New metrics to record when cast_shell makes an initial paint for a
webpage.

R=gunsch@chromium.org
BUG=

Review URL: https://codereview.chromium.org/819213002

Cr-Commit-Position: refs/heads/master@{#309503}

Covers jingle/, media/, ppapi/, remoting/, rlz/, skia/, and sync/.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/819203002

Cr-Commit-Position: refs/heads/master@{#309502}

The GN version 'gn_unittests' target has template_unittest.cc in its
source list, but the GYP version not. This patch fixes that making them
match.

BUG=None
TEST=gn_unittests --gtest_filter=Template*
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/825543002

Cr-Commit-Position: refs/heads/master@{#309501}