GitLab

We are always in compositing mode now, so this flag is not valid and
we are deleting the code paths it would trigger.

R=fsamuel@chromium.org, piman@chromium.org
BUG=362164

Review URL: https://codereview.chromium.org/233393007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263080 0039d316-1c4b-4281-b951-d872f2087c98

* extracting CheckinRequest::RequestInfo to better manage checkin parameters
* adding G-services settings digest to RequestInfo of the checkin (will be sent with checkin request)
* extracting G-services settings from checkin response
* storing and loading of the G-services settings in GCM Store

This patch relands https://codereview.chromium.org/215363007/ after all
of the trybots, buildbots and CQ have been updated to run gcm_unit_tests

TBR=zea@chromium.org,jianli@chromium.org
BUG=359254

Review URL: https://codereview.chromium.org/233103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263079 0039d316-1c4b-4281-b951-d872f2087c98

Scheme-and-host patterns are not persisted in the HostZoomMap and get cleared
on the next browser restart. Therefore, they are not so privacy sensitive and
don't need to be displayed in the content settings.

BUG=361575

Review URL: https://codereview.chromium.org/230503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263078 0039d316-1c4b-4281-b951-d872f2087c98

Make BookmarksProvider set inline_autocompletion and
allowed_to_be_default_match.

This has no effect unless bookmarks are made to score more highly (and
so they'll empirically end up as the top-scoring match).

Includes unit tests.

In the process, fix whether trailing slashes are omitted, for consistency
with other providers.  This will reduce jank if bookmarks are
ever inlining.  Tested interactively.

Likewise, fix whether http:// is omitted.  Tested interactively.

Also, refactor a common piece of code from ShortcutsProvider
to URLPrefix.

Likewise, make a protected function in HistoryProvider public
for use elsewhere.  Mark it static (because it can be).

Also, fix a PreventInlineAutocomplete bug in ShortcutsProvider.
Adds a test for this.  These tests fail before this change.

Also, fix a PreventInlineAutocomplete bug in BuiltinProvider.
Didn't bother adding a test for this because no tests examine
inline_autocompletion here and I didn't want to bother adding
some just for this minor change.  Tested it interactively.
These tests fail before this change.

BUG=

Review URL: https://codereview.chromium.org/229733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263077 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit http://crrev.com/238501 in favor  a simpler approach
which delays stream creation around suspend and resume events:
http://crrev.com/247026

Care must be taken to monitor the UMA stat for increases after this lands.
I'll also communicate with the YT team on the bug/ to ensure they provide
some assistance in testing.

BUG=160920
TEST=No stream hangs.

Review URL: https://codereview.chromium.org/190553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263076 0039d316-1c4b-4281-b951-d872f2087c98

Move GetInstalledApp() to ExtensionSet::GetAppByURL().
- More accurately named.
- Forces callers to understand that they are only searching the given extension
  set (GetInstalledApp() implied it may have searched more than just enabled
  extensions).

Remove IsInstalledApp(), since this was used in only two places and can be substituted with GetAppByUrl() != NULL.

BUG=351891
TBR=dzhioev@chromium.org (c/b/chromeos/first_run/)
TBR=kinuko@chromium.org (c/b/sync_file_system/)
TBR=nick@chromium.org (c/b/task_manager/)
(All TBRs are for strictly mechanical changes)

Review URL: https://codereview.chromium.org/218683011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263075 0039d316-1c4b-4281-b951-d872f2087c98

Plumbing for Blink's containerCullingEnabled (experimental Skia culling
for containers).

R=jamesr@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/227593007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263074 0039d316-1c4b-4281-b951-d872f2087c98

This also tickled a bug in the generator because I named a variable
with "http". Which made the generator tests run on presubmit. Which
tickled a bug in the tests :-). So those are fixed here as an aside.

BUG=239656

Review URL: https://codereview.chromium.org/231243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263073 0039d316-1c4b-4281-b951-d872f2087c98

Seems to have busted Mac builds, e.g.,
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder%20%28dbg%29&number=65094:

FAILED: cd ../../net; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug; export CONFIGURATION=Debug; export PRODUCT_NAME=net_unittests_run; export SDKROOT=/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug/../../net; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug; export TEMP_DIR="${TMPDIR}";python ../tools/isolate_driver.py check --isolated "../out/Debug/net_unittests.isolated" --isolate "net_unittests.isolate" --path-variable PRODUCT_DIR "../out/Debug " --extra-variable "version_full=36.0.1935.0" --config-variable "OS=mac" --config-variable "chromeos=0" --config-variable "component=shared_library" --config-variable "internal_gles2_conform_tests=0" --config-variable "icu_use_data_file_flag=1" --config-variable "libpeer_target_type=static_library" --config-variable "use_openssl=0" --extra-variable mac_product_name Chromium --ignore_broken_items
[------ Swarming Error ------]
File /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug/net_resources_target_net_resources_d558be7de16a8d003a6e7f7fae73e582 doesn't exist
Traceback (most recent call last):
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 1516, in main
    return dispatcher.execute(OptionParserIsolate(version=__version__), argv)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/third_party/depot_tools/subcommand.py", line 242, in execute
    return command(parser, args[1:])
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 1082, in CMDcheck
    options, os.getcwd(), options.subdir, False)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 888, in load_complete_state
    options.extra_variables, options.ignore_broken_items)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 762, in load_isolate
    ignore_broken_items)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 63, in expand_directories_and_symlinks
    indir, relfile, blacklist, follow_symlinks))
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolateserver.py", line 1450, in expand_directory_and_symlink
    relfile, symlinks = expand_symlinks(indir, relfile)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolateserver.py", line 1358, in expand_symlinks
    todo = file_path.fix_native_path_case(done, todo)
  File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/utils/file_path.py", line 488, in fix_native_path_case
    os.path.join(native_case_path, raw_part))
OSError: File /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug/net_resources_target_net_resources_d558be7de16a8d003a6e7f7fae73e582 doesn't exist
[----------------------------]

> Make isolate_driver.py process build.ninja and extract dependencies.
> 
> This uses a few assumption:
> - This basically breaks non-ninja build for component builds. This never worked
>   anyway.
> - This assumes the file format of .ninja files. This will likely be quite
>   obvious when this breaks.
> - It makes some assumptions about the build steps, for example '.so.TOC' ->
>   '.so'.
> 
> On the other hand, it creates a deterministic dependency tree, which is awesome.
> Technically it would work as well for non-component builds but I don't want to
> go this far yet. But in the end, that's the goal that nobody has to enter the
> binary dependencies in the .isolate files.
> 
> R=csharp@chromium.org
> BUG=360223,333473
> 
> Review URL: https://codereview.chromium.org/228463003

TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/233743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263072 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263071 0039d316-1c4b-4281-b951-d872f2087c98

R=ronghuawu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/233393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263070 0039d316-1c4b-4281-b951-d872f2087c98

The new net_nacl target builds net code for PNaCl. It will be used for
remoting client, and so it excludes parts that are not used in the
remoting, e.g. net/disk_cache, net/proxy, net/spdy, net/quic.

BUG=276739

Review URL: https://codereview.chromium.org/188873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361082

Review URL: https://codereview.chromium.org/226743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361508

Review URL: https://codereview.chromium.org/231793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263067 0039d316-1c4b-4281-b951-d872f2087c98

Basically just ensures you can always directly get a ContentViewCore
in ContentShell code. There's too many callers for one CL to switch everyone
over to that.

More clean-up is needed but it seems like the next strings I pull result
in a fair bit of diff. Seems like a small enough chunk that is a logical
change.

BUG=360664

Review URL: https://codereview.chromium.org/227653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263066 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263065 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171269:171290&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/233573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263064 0039d316-1c4b-4281-b951-d872f2087c98

The FaviconService is not a CancelableRequestProvider anymore.
Fixed external classes that were incorrectly using "Handle", a type inherited from CancelableRequestProvider.

BUG=359599

Review URL: https://codereview.chromium.org/230873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359186

Review URL: https://codereview.chromium.org/224963010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263062 0039d316-1c4b-4281-b951-d872f2087c98

This has been replaced with SetDisplay a while ago.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263043

R=ben@chromium.org, tdanderson@chromium.org

Review URL: https://codereview.chromium.org/233053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263061 0039d316-1c4b-4281-b951-d872f2087c98

R=earthdok@chromium.org
TBR=earthdok@chromium.org
BUG=38138,122717,145703,245828,342591,345432,348863
TEST=waterfall

Review URL: https://codereview.chromium.org/233643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263060 0039d316-1c4b-4281-b951-d872f2087c98

Nautilus prefers _NETSCAPE_URL over XDS unfortunately, so we skip
setting _NETSCAPE_URL content in this case.

BUG=328401

Review URL: https://codereview.chromium.org/229763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263059 0039d316-1c4b-4281-b951-d872f2087c98

This uses a few assumption:
- This basically breaks non-ninja build for component builds. This never worked
  anyway.
- This assumes the file format of .ninja files. This will likely be quite
  obvious when this breaks.
- It makes some assumptions about the build steps, for example '.so.TOC' ->
  '.so'.

On the other hand, it creates a deterministic dependency tree, which is awesome.
Technically it would work as well for non-component builds but I don't want to
go this far yet. But in the end, that's the goal that nobody has to enter the
binary dependencies in the .isolate files.

R=csharp@chromium.org
BUG=360223,333473

Review URL: https://codereview.chromium.org/228463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263058 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354062
R=rjkroege@chromium.org, sky@chromium.org
TBR=darin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/231863010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263057 0039d316-1c4b-4281-b951-d872f2087c98

GrContextForWebGraphicsContext3D::OnLostContext() was
calling GrContext::contextLost() which has the wrong
behavior: it assumes that the gpu context is still valid
but that all of its resources have been lost, so it
attempts to reinitialize resources that are used internally
by skia. The correct action is to call
GrContext::contextDestroyed(),  which signals that the gpu
context is no longer usable.

BUG=361555

Review URL: https://codereview.chromium.org/233583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267773

Review URL: https://codereview.chromium.org/221823011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297026
R=jam@chromium.org

Review URL: https://codereview.chromium.org/226413006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263054 0039d316-1c4b-4281-b951-d872f2087c98

- add gpu_unittests

R=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/233393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263053 0039d316-1c4b-4281-b951-d872f2087c98

Apparently gtest doesn't support [] in regexs. While it can match too much, for
the given input page, it's correct.

BUG=353349

Review URL: https://codereview.chromium.org/225813008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263052 0039d316-1c4b-4281-b951-d872f2087c98

Reset surface format in ContentViewRenderView. This prevents issues with the tab not rendering if an activity starts over the FS video view.

BUG=356663

Review URL: https://codereview.chromium.org/230223008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263050 0039d316-1c4b-4281-b951-d872f2087c98

> Remove obsolete scale related APIs for cursor
> This has been replaced with SetDisplay a while ago.
> 
> BUG=None
> 
> Review URL: https://codereview.chromium.org/233053003

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/233693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263048 0039d316-1c4b-4281-b951-d872f2087c98

As found in https://crbug.com/361440#c9.

BUG=none

Review URL: https://codereview.chromium.org/232843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263047 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358713, 361943
TEST=Go to about:flags, change a flag, and click relaunch. The browser starts again.

Review URL: https://codereview.chromium.org/231843007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263046 0039d316-1c4b-4281-b951-d872f2087c98

This need not be exposed as part of the Manifest interface.

Review URL: https://codereview.chromium.org/231853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263045 0039d316-1c4b-4281-b951-d872f2087c98

In order to move InfoBarDelegate to the infobar components, all dependencies on
content/ must be removed.
This CL removes the InfoBarDelegate::web_contents() method and callers use
InfoBarService::WebContentsFromInfobar() instead.

BUG=354379
TBR=jochen

Review URL: https://codereview.chromium.org/230453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263044 0039d316-1c4b-4281-b951-d872f2087c98

This has been replaced with SetDisplay a while ago.

BUG=None

Review URL: https://codereview.chromium.org/233053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263043 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/228703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263042 0039d316-1c4b-4281-b951-d872f2087c98

Also filled in some JavaDocs to satisfy the linter.

BUG=355072
TEST=AndroidWebviewTest

Review URL: https://codereview.chromium.org/230673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263041 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Suspect this broke RenderTextTest.ElidedText in http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/27081.


Original issue's description:
> Fix creating platform font on Windows
> 
> fdwCharSet param changed from 0 to DEFAULT_CHARSET (which is defined to
> 1). ScriptShape fails to generate glyphs on Windows XP for some complex
> scripts (Hindi text for instance) if font is created with fdwCharSet=0.
> 
> Other paramaters are unchanged because they still expand to 0.
> 
> BUG=361994
> 
> TEST=On Windows XP, go to Control Panel and Regional and
> Language Options. Under Languages tab check Install files
> for Complex Script and right-to-left languages (including
> Thai) and Install files for East Asian languages. Click
> Details and install Hindi language. Launch Chromium. Go to
> advanced settings and go to Languages. Add Hindi language
> and click Display Chromium in this language button. Restart
> Chromium. Expected result: Hindi font glyphs should be
> properly generated for all UI elements (tabs, menus,
> notification panels).
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263001

TBR=asvitkine@chromium.org,msw@chromium.org,tmoniuszko@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=361994

Review URL: https://codereview.chromium.org/228703007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=355611

Review URL: https://codereview.chromium.org/230773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263037 0039d316-1c4b-4281-b951-d872f2087c98