GitLab

This CL changes what domains we consider for the lookalike interstitial.
Previously, if Chrome saw a navigation that looked like
    A -> B -> C -> D
(where site A is redirecting to B, etc.), the lookalike logic would
inspect each stage, A through D, for lookalikes. It accomplished this by
implementing DidRedirectNavigation() and DidFinishNavigation(). This
added a bunch of complexity, but allowed us to stop a navigation
mid-redirect.

This CL changes that behavior to wait until the entire redirect chain
has completed, and then inspect only sites A and D. These domains are
the only ones visible to the user, and thus the only ones wherein a
lookalike URL might be effective. This change also means that we no
longer implement DidRedirectNavigation().

Bug: 1092690
Change-Id: I2cfa724b9793b60dd5200d1bf6847cc6919fa469
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438888Reviewed-by: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812173}

There are certain arm devices that do not populate the model name of the
CPU in sysfs. This change makes the model_name field optional to reflect
this.

Bug: chromium:1132875
Change-Id: I7f8c814bf77c22cc7f7ca6f482d37f46097a4335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436383Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Commit-Queue: Trent Begin <tbegin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812172}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f7bee82a..b531fa82

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6f882a5cf5c01ed13c43f74b6380b37b8e721a97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440237Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812171}

This aligns with the best practices in the "Web Platform Team Bug SLOs" document.

NOTRY=true

Change-Id: If7a1116526f581fa79182c7f287baa3c2b0d6c79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440196
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812170}

This is needed for the field to show up chrome://sync-internals.

Bug: 1082115
Change-Id: I94c59365486bcf3a30f5e57d171351fcbba8e181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440580Reviewed-by: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Paula Vidas <paulavidas@google.com>
Cr-Commit-Position: refs/heads/master@{#812169}

The Convert*ToDIP() and Convert*ToPixel() functions are problematic in
that they hide what decision is being taken in the underlying code
when moving from floating point to integer, and consumers should be
thinking about what they want for correctness. They also act in
inconsistent ways when converting a Rect vs its components. This
removes the functions that perform float->int conversions in order to
have callers show what they intend to happen and make it clear that
data is being lost in some fashion.

R=sky@chromium.org

Bug: 1130050
Change-Id: I042735e7cc761da1a581ddb7b909bbedf4bd86be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429143
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812168}

This reverts commit cd9c0f48.

Reason for revert:
Test is failing: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/86822

Original change's description:
> Record if the navigation's initiator is available.
>
> In NavigationRequest::BeginNavigation(), records whether the
> navigation's initiator can be found using its ID or not.
>
> We suspect not finding it is a very rare event. This histogram will help
> us figure out what kind of solution should be used to support
> PolicyContainer for this edge case.
>
> Bug:1129416
>
> Change-Id: I501bf0150935679667d5bd2a4cc351a70b6653ab
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416450
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#812124}

TBR=isherman@chromium.org,clamy@chromium.org,arthursonzogni@chromium.org,pmeuleman@chromium.org,antoniosartori@chromium.org

Change-Id: I11e26c0b5c69063ebcb2e5bac8a5a09eb2202467
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1129416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440263Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812167}

Instead of abusing set_sources_assignement_filter, use the two
gn function filter_{exclude,include} to partition the list in
two.

Expected to be a no-op change.

Bug: 1018739
Change-Id: If6d5e2d8c300358bb31b8773d629cdb95f09421b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440583
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812166}

TBR=jianli@chromium.org
NOTRY=true

Bug: 1131373
Change-Id: I2260778f2cdcee94665c33ec12cb8971d333c204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441111
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812165}

TBR=jianli@chromium.org
NOTRY=true

Bug: 1130016d
Change-Id: Iec2d947fd1df590fe92101b646071b9e0bf3073f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441270
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812164}

Allow browser tree selectors syntax for ax_dump_events, for example, ax_dump_events --safari to log all accessibility events fired by Safari browser

Bug: 1131921
Change-Id: I198891a7d391c510c696b9885ff69b0a267af493
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436274
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812163}

The getPackageDirectoryEntry won't work and will not be supported.

Bug: 1133034
Change-Id: I70bee9f127815e1690612eafeb926c6e2d0b6441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437707
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812162}

This should not change deep scanning behaviour with Connectors.

Bug: 1103390
Change-Id: I4def9558e1e185ac684110054a2be15f04388d86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430025Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812161}

This CL extracts CookieWaiter class from the GaiaScreenHandler and reuse
it in the EnrollmentScreenHandler.

Bug: b/167404108
Change-Id: Idaeca9cf93157b42819eac33a653eebe27def867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429025Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812160}

TBR=sinhak@chromium.org
NOTRY=true

Bug: 1133604
Change-Id: Ie632de37b9521aba2e0e448b1d3a2d868b02ebca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439500
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812159}

Bug: 1075444, 1131038
Change-Id: I925317fd7667be5b94f1c74565e82f7df896ffd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416079Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/master@{#812158}

This CL is announcing for screen readers when the state of the password
Save bubble changes its state between Save and Update.

TBR=vasilii@chromium.org

Bug: 1099697
Change-Id: Iba5e3de59e86b4605f82f507379ed600d0772233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438354Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812157}

Fixed: 1120823
Change-Id: Ibe0ca8a10b7623fd60dc97d19963ce67f73e4c63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439295Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812156}

Since there is now a context menu option to show full URLs, this
feature is no longer needed in the Chrome extension. This allows
more flexibility, since users can now use the extension and keep
simplified domain display.

Change-Id: I4e8a3b7baeca34983ee2bff82535bd332c1087cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435960Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812155}

This CL fixes the gesture recognizer for non PDFs files.
The OPEN IN.. toolbar is now displayed/hidden on tap, for all supported
file types.

Bug: 1133293, 1133280
Change-Id: I52b9628fc87c40383421c993f932295d7fdd7f4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438133
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812154}

https://android.googlesource.com/platform/external/perfetto.git/+log/adc22042d09d..810b74c0d7e4

2020-09-30 treehugger-gerrit@google.com Merge "Aggregate flamegraph by name rather than type id."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Iefa87915e13a21b7f9c3b42e5e5b8fa2738427b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440777Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812153}

This CL introduces ContentDirectoryLoaderFactory::CreateAndBind static
method that allows creating an ContentDirectoryLoaderFactory that is
owned by its |receivers_| and will self-delete when the last receiver
disconnects.

This CL removes the ability to directly construct and own a
std::unique_ptr<ContentDirectoryLoaderFactory>, because this ability
means that the factory can be destructed while receivers bound via the
Clone method are still alive (see the associated bug).  In particular,
this CL stops exposing ContentDirectoryLoaderFactory constructor as a
public member, which forces construction to go via the new CreateAndBind
static method.

This CL mostly just follows the pattern established earlier by
https://crrev.com/c/2337411.

Bug: 1106995
Change-Id: I5ed88648637eed43f23dfab234115bfa33281ccc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357964
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812152}

This change removes the "multiple-document-handling" attribute
from the map in CapabilityLocalizationMap(); as a side effect,
this removes the attribute from the "advanced" section of the
print preview dialog.

Bug: chromium:1127436
Test: inspect print preview
Change-Id: I8583ea485bfb0b41768a8bcca30f21c7683b4bc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438729Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812151}

Scripts should not be offered on Chrome clients with version less than
min_version provided in scripts.

Bug: 1132942
Change-Id: Iec209027b6f7c2fff0f637adbb0badeef66aa9d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435352
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812150}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2494f4964a64..9418e43a9c9d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC xidachen@google.com,sinhak@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: xidachen@google.com,sinhak@google.com
Change-Id: I230c68e0cf1b8833f9340c40c308ab32b79c9ed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440465Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812149}

Inspired by the corresponding cross-origin isolation test in
https://chromium-review.googlesource.com/c/chromium/src/+/2417872.

Bug: 1042415
Change-Id: I490fc7a2f624b70d2e7fc71c3b45970c627b8835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427066Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812148}

Bug: 1131856, 1106636
Change-Id: Ib37302ce4c53050ee35bb9bd5296feee18819b45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438752Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Giovanni Panaro <tsrwebgl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812147}

* Silence several warning logs about normal things
* Add source paths for libyoga.so and libelements.so
* Change pak overhead symbol to use a key that cannot theoretically
  collide with pak ids
* Add an up-front os.path.exists() for all main inputs when using
  .ssargs

Bug: None
Change-Id: I2d90f89c0b18d5c1edff866cf0b5f889d9d5cdd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439681
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812146}

Test launcher relies on the fact that TaskScheduler won't have more
concurrency than max_tasks to control |num_parallel_jobs|. The
TaskScheduler is allowed to run more tasks concurrently than
|max_tasks| when some of these tasks are blocked.
This CL converts Test launcher to using Jobs and ensures that
|runner_count_| concurrency is respected.

Bug: 905788
Change-Id: Ia090271e11b322140da1bf7e1526f4ba16bfb524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414556
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812145}

The [coop-reporting-explainer] defined several URLs that might be
reported:
- openeeURL
- openerURL
- otherDocumentURL
- referrerURL
- initialPopupURL

This adds the first 3.

[coop-reporting-explainer]:
https://github.com/camillelamy/explainers/blob/master/coop_reporting.md

Bug: 1090273
Change-Id: Ibd9710139e0065bd36fe6e798b50521f6d24baf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398619
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812144}

This is a reland of 2d4e58ed

Original change's description:
> Repeat path canonicalization in ContentSettingsPattern::Builder
>
> The fuzzer discovered an input that uncovers non-idempotency in
> ContentSettingsPattern::Builder::Canonicalize. First, the function
> changes |parts->path| from "/.//" to "//". On a second call, the "//" is
> changed to "/".
>
> This CL repeats the path canonicalization until we reach a fixed point.
>
> Bug: 1117622, 1132957, 1128999
> Change-Id: I96da902e50a4a9b654a7d4184ef4ad2c0689e705
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406332
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811717}

TBR=engedy@chromium.org

Bug: 1117622
Bug: 1132957
Bug: 1128999
Change-Id: I60a53922088a3a187226c7864ea50b386efb5068
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438731Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812143}

TBR=jianli@chromium.org
NOTRY=true

Bug: 1129847
Change-Id: Id423f04485fda389119d532f1a528703d7476446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441010Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812142}

Instead of a button in the Settings page that will take the
user to the Chrome Panel in Settings.app to set the default browser,
the row will open a page with the same button and the steps
to make Chrome the default browser.

Screenshot:
https://drive.google.com/file/d/1_CEPv563hGMi_Ol4KQsrcNu3V4XE5egy/view

Bug: 1131251
Change-Id: I7561d3f40d0b786c85a1a6caf46c53df33457002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425118
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812141}

This CL adds download later feature to fild trial json config file.

TBR=mpearson@chromium.org

Bug: NONE
Change-Id: I0de7dcb2afeb796ac02083a65a8cf6ee2f205d97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438576
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812140}

This CL introduces ExternalFileURLLoaderFactory::Create static method
that allows creating a ExternalFileURLLoaderFactory that is owned by its
|receivers_| and will self-delete when the last receiver disconnects.

This CL removes the ability to directly construct and own a
std::unique_ptr<ExternalFileURLLoaderFactory>, because this ability
means that the factory can be destructed while receivers bound via the
Clone method are still alive (see the associated bug).  In particular,
this CL stops exposing ExternalFileURLLoaderFactory constructor as a
public member, which forces construction to go via the new Create static
method.

This CL mostly just follows the pattern established earlier by
https://crrev.com/c/2337411.

Bug: 1106995
Change-Id: I4bd235cf9132668d80657aece34de6fe7b60f78b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357620Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812139}

This reverts commit 09255d96.

Reason for revert: WPT bots on GitHub caught a possibly (probably) flaky test

https://github.com/web-platform-tests/wpt/pull/25845/checks?check_run_id=1187933269

Original change's description:
> [client-hints] Test client hint availability in service workers
>
> Change-Id: Icbb9de8fa340ac216a05a1093a1840c7903ba53c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432187
> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#812131}

TBR=yoavweiss@chromium.org,aarontag@chromium.org

Change-Id: I017b04cf0ba8b47e5fa271254f69816956397aed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441268Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812138}

The sw600dp layout location_bar_icon differed from the unqualified
variant only with the value of end padding until they diverged in
http://crrev.com/c/1653842

Now the alternative layout is merged back into the default variant.
All overrides are now in values-sw600dp/dimens.xml

Values location_bar_icon_* and location_bar_start_icon_* were
identical, so now the latter values are removed.

Bug: 1130414
Change-Id: I087861fbab00768009ed881bc3753a83a8458f0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427211Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Auto-Submit: who/bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812137}

This API is suspected of leaking information that could be used to
identify users.

We instrument this API to report digests of the value to UKM for
analysis on the available entropy in this API for identifying users
across different origins.

Bug: 973801
Change-Id: Ia13b4b9fb7553a5e0b2ef3572c138d295c61c564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439796Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#812136}

This CL modifies the extraction code for complex selectors such that
it can be called recursively from ExtractInvalidationSetFeaturesFrom-
SelectorList.

This is a step on the way towards correct invalidation behavior for
:is/:where.

Bug: 568705
Change-Id: I3ad09e09586032d409cea91b7ae457b832b49c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435087
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812135}

For macOS, when the updater self updates, it uses the .install.sh
script, and this CL should fix a bug in running the script properly.

Change-Id: Ib745fbb3e998fc864ab61a8f9aba99f432c6e757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441007Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Michael Chang <donchan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#812134}