- 24 Dec, 2018 40 commits
-
-
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 TBR=rogerta@chromium.org Change-Id: I9a1fe160e17c708c7fe14bdd1bf2a9fec2d51341 Reviewed-on: https://chromium-review.googlesource.com/c/1390114Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#618840}
-
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 TBR=csharrison@chromium.org Change-Id: I867dac0d7aa249a07203f5be1cf15033d11a3150 Reviewed-on: https://chromium-review.googlesource.com/c/1390108Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8be4b02b4c72..088b74e51314 git log 8be4b02b4c72..088b74e51314 --date=short --no-merges --format='%ad %ae %s' 2018-12-24 reed@google.com use font instead of paint Created with: gclient setdep -r src/third_party/skia@088b74e51314 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Id2f40fc5a2251751eafc7edda98587b3291109f4 Reviewed-on: https://chromium-review.googlesource.com/c/1390613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618838}
-
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 TBR=fmalita@chromium.org Change-Id: Idb79e622b4532baa1f1b81a07dccadac064357e0 Reviewed-on: https://chromium-review.googlesource.com/c/1390111Reviewed-by:
-
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 TBR=jbudorick@chromium.org Change-Id: I65f8cb1557478dff4826ddab93764be0eeaf987d Reviewed-on: https://chromium-review.googlesource.com/c/1390110Reviewed-by:
-
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 TBR=thakis@chromium.org Change-Id: I3d6c3cdc444b942e2f719075235d372d77891c44 Reviewed-on: https://chromium-review.googlesource.com/c/1390109Reviewed-by:
-
Avi Drissman authored
fast/js/try-catch-crash.html failed after https://chromium-review.googlesource.com/c/chromium/src/+/1388160; revert that roll. BUG=917714 TBR=hablich@chromium.org Change-Id: I1da33bfea7d1a06fc8cefb38f210127fef840b2a Reviewed-on: https://chromium-review.googlesource.com/c/1390431 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Avi Drissman authored
This reverts commit f9b0441a. Reason for revert: Must revert, sorry, as a dependent CL broke the tree. Nothing personal. Original change's description: > Remove JSON manifest usage from Service Manager > > This wipes out all code inside //services/service_manager and > //services/catalog for supporting base::Value-based service manifests. > > All JSON manifests are now either used to generate compiled C++ Manifest > definitions at build time or are loaded from resources and parsed for > Manifest::FromValueDeprecated at runtime (namely for overlays). > > Also wipes out some misc random crud that isn't used anymore, like > ManifestProvider and ServiceOverrides. > > TBR=eugenebut@chromium.org > > Bug: 895616 > Change-Id: I6ae51893a9e68347ac2004fdb1202922082c22bd > Reviewed-on: https://chromium-review.googlesource.com/c/1388210 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#618702} TBR=avi@chromium.org,sky@chromium.org,rockot@google.com,eugenebut@chromium.org,oksamyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 895616 Change-Id: If5c9fe4573846d727d2727d2a24485f3e91b0744 Reviewed-on: https://chromium-review.googlesource.com/c/1390428Reviewed-by:
-
Florin Malita authored
fast/dom/HTMLMeterElement/meter-styles.html (fallout from https://crrev.com/909793b85dd2eb0bd37954ec50fbc86d547be50a) NOTRY=true TBR=avi@chromium.org Bug: 630695 Change-Id: I0c548f9a6206febb6228e4b5da3b17d65400e72f Reviewed-on: https://chromium-review.googlesource.com/c/1390430 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#618832}
-
Wan-Teh Chang authored
https://aomedia.googlesource.com/aom.git/+log/f90004a14ea8..20a747b9ce5e $ git log f90004a14..20a747b9c --date=short --no-merges --format='%ad %ae %s' 2018-12-20 wtc Fix -Wmissing-declarations fft_avx2.c fft_sse2.c. 2018-12-20 huisu Cosmetic changes in motion_mode_rd() 2018-12-21 yunqingwang Make the debug code work 2018-12-21 wtc Don't use ax, bx, cx, dx as vars for cpuid macro. 2018-12-21 wtc Add float casts to silence MSVC compiler warnings. 2018-12-20 huisu Fix int overflow in get_est_rate_dist() 2018-12-21 satish.suman Fix valgrind error in EndToEndTestLarge unit test 2018-12-21 ravi.chaudhary Use common SyncRange for SB=128 & 64 in enc row-mt 2018-12-20 jimbankoski Inspector : skip means not a transform Created with: roll-dep src/third_party/libaom/source/libaom R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@chromium.org Change-Id: Ibb4f4c1c64d3c3faeb3428502479218f80bed34c Reviewed-on: https://chromium-review.googlesource.com/c/1389972Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#618831}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1a1d3418568c..1cc600d354eb Created with: gclient setdep -r src-internal@1cc600d354eb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic18e4aa48518c79aecaa5d65fdff1d688b156291 Reviewed-on: https://chromium-review.googlesource.com/c/1390610Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618830}
-
Avi Drissman authored
This reverts commit 8f244ddf. Reason for revert: Must revert, sorry, as a dependent CL broke the tree. Nothing personal. Original change's description: > [SM] Generate C++ sources for all manifest targets > > Changes the service_manifest target to emit C++ sources for that > specific Manifest definition. Previously we only generated sources > for catalog_cpp_source targets, which aggregated JSON data from > multiple service_manifest targets. > > Every service_manifest GN template thus now emits two artifacts: > the same collated JSON as before (including packaged services and > overlays), since embedders use this to generate runtime > manifest resources; and a new source_set target which expresses the > same manifest in terms of C++ sources, with proper dependencies > on each dependency manifest's source_set. > > The point of this is to make it possible for incremental migration away > from generated code and over to code that lives in the source tree. > For example, many implementations of ContentBrowserClient override > GetServiceManifestOverlay() and use parsed JSON resources at runtime > to construct a Manifest object. After this change, any of those > cases can be individually converted to use the generated source_set > instead of the generated JSON, and the JSON resource can be deleted. > > Once this lands, catalog targets can also be eliminated and replaced by > helpers in the tree which return the same lists of manifests that the > catalog-generated code returns now. Finally, after all that, remaining > service manifests can be (mostly) independently pulled out of generated > code. The end result will be: no more JSON manifests anywhere, no more > catalog() or catalog_cpp_source() GN targets, and no more > service_manifest() GN targets. > > TBR=sky@chromium.org > > Bug: 895616 > Change-Id: Ie3d53a96ac79952383e473f23d390583306be2fa > Reviewed-on: https://chromium-review.googlesource.com/c/1388158 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618718} TBR=sky@chromium.org,rockot@google.com,dpranke@chromium.org,oksamyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 895616 Change-Id: Ie6ad50dc8d84101380d79db2d1e43135a9adde4e Reviewed-on: https://chromium-review.googlesource.com/c/1390429Reviewed-by:
-
Avi Drissman authored
This reverts commit dc3fde2e. Reason for revert: fast/js/try-catch-crash.html is burning on WebKit Linux Trusty MSAN; this is a suspect Original change's description: > Oilpan: Replace Main/WorkerThreadMutex with one ActiveThreadMutex > > TSAN reported lock-order-inversion because we were using two mutexes. Simplify the code to use just one. > > Bug: 915200 > Change-Id: I5dbda4ca21cd4f5fa95ecb1c9b51922262798169 > Reviewed-on: https://chromium-review.googlesource.com/c/1384384 > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618754} TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 915200 Change-Id: If4be6a8156292d27790a7f12a62f2d559c730236 Reviewed-on: https://chromium-review.googlesource.com/c/1390426Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4fca3ea6434f..1a1d3418568c Created with: gclient setdep -r src-internal@1a1d3418568c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iece8e04a6af350c6acc649889b37496002d59d9e Reviewed-on: https://chromium-review.googlesource.com/c/1390609Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62aa69accd93..4fca3ea6434f Created with: gclient setdep -r src-internal@4fca3ea6434f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I740dc4c97ec29e5faa09d337325a87e6534999bc Reviewed-on: https://chromium-review.googlesource.com/c/1390608Reviewed-by:
-
Florin Malita authored
According to both CSS [1] and Canvas2D [2], the implementation is expected to perform a Gaussian blur with a standard deviation of half blur-radius. (SVG wisely chose to define the shadow parameters directly in terms of sigma [3]) Currently, for historical reasons, Blink uses a significantly smaller scale factor when computing sigma: ~0.28 instead of 0.5 -- thus shadows in Blink are about half the expected size. This change updates the sigma computation to match specs, and aligns Blink's shadow rendering with FF & WebKit. Newly passing (manual) test: http://test.csswg.org/suites/css3-background/nightly-unstable/html4/box-shadow-blur-definition-001.htm [1] https://www.w3.org/TR/css-backgrounds-3/#shadow-blur [2] https://html.spec.whatwg.org/multipage/canvas.html#when-shadows-are-drawn [3] https://drafts.fxtf.org/filter-effects/#element-attrdef-fedropshadow-stddeviation Bug: 179006 Test: wpt/css/css-backgrounds/box-shadow/box-shadow-blur-definition-001.xht Change-Id: Idb6e01f39f86bafa7b3c351bd1bff2f7f7ce1f92 Reviewed-on: https://chromium-review.googlesource.com/c/1377519 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#618825}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/335ca59e..a2ea6730 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I589176e86c01f3f1097d537fe2cc84c49d6ed882 Reviewed-on: https://chromium-review.googlesource.com/c/1390266Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618824}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/beaa7f6945cf..62aa69accd93 Created with: gclient setdep -r src-internal@62aa69accd93 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I14fd331a203e903ec38a405d84b16160c00e31b1 Reviewed-on: https://chromium-review.googlesource.com/c/1390607Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aa0bb5ee..335ca59e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c57a8943b819933b4ce69af1a8464258e244912 Reviewed-on: https://chromium-review.googlesource.com/c/1390325Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/481dd46cc368..8be4b02b4c72 git log 481dd46cc368..8be4b02b4c72 --date=short --no-merges --format='%ad %ae %s' 2018-12-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6d8d3c368d60..050698222644 (1 commits) Created with: gclient setdep -r src/third_party/skia@8be4b02b4c72 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Ibb3e67865561b7d0e8551b24a1ed07709f855c9c Reviewed-on: https://chromium-review.googlesource.com/c/1390602Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e40c11c72538..beaa7f6945cf Created with: gclient setdep -r src-internal@beaa7f6945cf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I628d35bf984bc99dca48ae6027935611f9ecd4bb Reviewed-on: https://chromium-review.googlesource.com/c/1390606Reviewed-by:
-
Rayan Kanso authored
The progress value was being reset with every new fetch being processed. Bug: 917382 Change-Id: Iaf353ea4a144d5cc5259f2601f5b7b4b490e5da7 Reviewed-on: https://chromium-review.googlesource.com/c/1388109Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#618819}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9c5e068f068..e40c11c72538 Created with: gclient setdep -r src-internal@e40c11c72538 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I01c63c2313db2ca58ca985cd405f8a42b481a849 Reviewed-on: https://chromium-review.googlesource.com/c/1390604Reviewed-by:
-
Dan Elphick authored
Replace deprecated GetPropertyNames() with GetPropertyNames(context).ToLocalChecked(). The previous version obtained the Context implicitly which could be wrong if the Context was not properly restored. Additionally the previous version does not force checking of the exception status which the new version does via the V8_WARN_UNUSED_RESULT macro. Bug: v8:7286, v8:8562 Change-Id: If144eb10b4ba0f045ac13af02d1054ffa7e492c1 Reviewed-on: https://chromium-review.googlesource.com/c/1388107 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#618817}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ic42a1038c932c8374f09b44d8ddcd837df23bfe2 Reviewed-on: https://chromium-review.googlesource.com/c/1390603Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74dcd5b2e265..c9c5e068f068 Created with: gclient setdep -r src-internal@c9c5e068f068 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I40a3924330188386327c34c75e82cefac9b4df66 Reviewed-on: https://chromium-review.googlesource.com/c/1390601Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5b56f06de8ea..74dcd5b2e265 Created with: gclient setdep -r src-internal@74dcd5b2e265 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I90004bb686d30929663930027e401c23df546c87 Reviewed-on: https://chromium-review.googlesource.com/c/1390600Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc5863c4d665..481dd46cc368 git log dc5863c4d665..481dd46cc368 --date=short --no-merges --format='%ad %ae %s' 2018-12-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@481dd46cc368 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I98e24143eb62d44f9c497d2514fe214b473d8b3e Reviewed-on: https://chromium-review.googlesource.com/c/1390599Reviewed-by:
-
Dominic Mazzoni authored
On some platforms, a simple text field, and a contenteditable region of the page are handled differently, so we don't explicitly have a role for the root of a contenteditable region. On Android, TalkBack won't recognize it as a text field if it doesn't have the correct class name, so set the class name appropriately for contenteditable too so that Android will treat it as a text field. Bug: 614907 Change-Id: Ib923452a17604a3dd0a79030ae1fec64dd71f995 Reviewed-on: https://chromium-review.googlesource.com/c/1388387Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#618812}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fc701eec41d0..5b56f06de8ea Created with: gclient setdep -r src-internal@5b56f06de8ea The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4049989e6ebe9d1dc8ca2dd56bcbb1b45aa5ffcb Reviewed-on: https://chromium-review.googlesource.com/c/1390597Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f6f84c97..aa0bb5ee Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I07c8f4c90a5b2086da1d15046ff3bcc420b06e74 Reviewed-on: https://chromium-review.googlesource.com/c/1390260Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f16825ed3c71..dc5863c4d665 git log f16825ed3c71..dc5863c4d665 --date=short --no-merges --format='%ad %ae %s' 2018-12-24 reed@google.com use font in SkTextUtils Created with: gclient setdep -r src/third_party/skia@dc5863c4d665 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Iea53a62617859d77e28667f685860178448a8db3 Reviewed-on: https://chromium-review.googlesource.com/c/1390595Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d38ee1fd2870..fc701eec41d0 Created with: gclient setdep -r src-internal@fc701eec41d0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I86b3bd499833cf8961bf1e57fc9a487dfcd012c9 Reviewed-on: https://chromium-review.googlesource.com/c/1390594Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2c7033857220..3d335bee0f8d git log 2c7033857220..3d335bee0f8d --date=short --no-merges --format='%ad %ae %s' 2018-12-24 achuith@chromium.org commands: Use autoninja. Created with: gclient setdep -r src/third_party/chromite@3d335bee0f8d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6945b5510985804dbe61fd601ed3e8f65b8bf553 Reviewed-on: https://chromium-review.googlesource.com/c/1390314Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/532ee2ffdef4..d38ee1fd2870 Created with: gclient setdep -r src-internal@d38ee1fd2870 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7de2c9d7ce2846b83a8482b313f2492ff6d9eb00 Reviewed-on: https://chromium-review.googlesource.com/c/1390313Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I94bdf687232d1cef52c7ad179c5594ddf4b89bc3 Reviewed-on: https://chromium-review.googlesource.com/c/1390421Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#618805}
-
Dmitry Gozman authored
Currently, we simulate navigation requests using SimRequest not quite similar to the real navigation requests. We allow asynchronous Start() call which is not the case for browser-side navigation requests which come with synchronous response. We plan to commit navigation synchronously after receiving response, and tests should be ready for that. Changes in this patch: - SimRequest now starts immediately when response is received. Most SimRequests in tests are navigation requests, so they are now compatible to the browser-side navigation flow. - To emulate subresources which may start asynchronously, a new SimSubresourceRequest is introduced. This one is currently used for all existing subresources in tests, to preserve the behavior. In reality, there should rarely be a need for asynchronous response, even for subresources. Bug: 855189 Change-Id: I125fd6dbe5522947d34ae755b653783246eb4695 Reviewed-on: https://chromium-review.googlesource.com/c/1387667 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#618804}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5582f44afc8b..532ee2ffdef4 Created with: gclient setdep -r src-internal@532ee2ffdef4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I68077731877dc5d99ef57fda5be891284f7dad62 Reviewed-on: https://chromium-review.googlesource.com/c/1390312Reviewed-by:
-
Jérôme Lebel authored
SyncSwitchItem is to replace LegacySyncSwitchCell for UITableView. The item uses SettingsSwitchCell. Change-Id: I62933ec77c30813bda489dce3f89a1ff642b2b7c Reviewed-on: https://chromium-review.googlesource.com/c/1384254 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#618802}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b189efe4132..5582f44afc8b Created with: gclient setdep -r src-internal@5582f44afc8b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0d7bc3c9b132fa5778c1f56c6e3119949a82f777 Reviewed-on: https://chromium-review.googlesource.com/c/1390311Reviewed-by:
-
