- 20 Jul, 2017 40 commits
-
-
Ian Vollick authored
With this CL, we add a LinearLayout element whose responsibility is the positioning of its child elements. Bug: None Change-Id: Ied896a84a1f5615b3a22e1857469766a21883cad Reviewed-on: https://chromium-review.googlesource.com/577193 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#488367}
-
Changwan Ryu authored
BUG=414219 Change-Id: I5fda048452466a5bbbc164a9f0924a3b886b74d5 Reviewed-on: https://chromium-review.googlesource.com/580153 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#488366}
-
Albert J. Wong authored
Leverages mojo EDK utils to remove one platform divergence in pipe creation, and then another within the Posix world for handling sendmsg vs write which differs signficantly between SysV-ish Linux and BSDish OsX. Bug: Change-Id: I27391043a05e0c917bed1f99acd3811ef92b2d19 Reviewed-on: https://chromium-review.googlesource.com/578381Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#488365}
-
Michael Wasserman authored
Add the placeholder in ShelfModel's ctor, like the app list item. Only call OnShelfItemDelegateChanged for items with delegates. Rename CLC::InitBrowserShortcutItem, update expectations/behavior. Bail early in CLC::OnShelfItemAdded for the browser shortcut too. This should make mash_browser_tests run more reliably. (avoids a race between ChromeLauncherController adding the shortcut and ShelfWindowWatcher observing the first chrome window) Bug: 743050 Test: No ChromeOS shelf behavior changes; more mash_browser_tests pass. Change-Id: I96b3adb4fc3eff35f720d8b22048523dc6f1a6a3 Reviewed-on: https://chromium-review.googlesource.com/578547 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#488364}
-
Wenzhao Zang authored
(1) Remove extra focus on the disabled dropdown menu button. (2) Make password field focused only once instead of three times. (3) Assign the user name as ARIA label for the entire pod. (4) Skip image until more descriptive texts are available. Bug: 746568 Change-Id: I4ed9918947a3a7f03fe84ebbf64ab94be7e88475 Reviewed-on: https://chromium-review.googlesource.com/578459Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488363}
-
jdonnelly authored
Revert of Don't reset the omnibox state on command-return. (patchset #1 id:1 of https://codereview.chromium.org/2904243002/ ) Reason for revert: This change caused a new issue: https://crbug.com/743288. While we decide how to proceed, it would be better to revert to the previous behavior. Original issue's description: > Don't reset the omnibox state on command-return. > > This was originally added in https://codereview.chromium.org/260008/, > motivated it appears by a desire to match Safari's behavior. Safari no > longer does this (the address field state is preserved on command-return > as the new tab is openeed in the background). > > This change makes Chrome's behavior consistent with Safari, simplifies > the code, fixes a bug, and is more useful IMO. If you want to open > several tabs with variations on some search, for example, you can press > command-return after each, then keep typing to produce the next. > > See discussion in the bug for more info. > > BUG=513966 > > Review-Url: https://codereview.chromium.org/2904243002 > Cr-Commit-Position: refs/heads/master@{#475542} > Committed: https://chromium.googlesource.com/chromium/src/+/1f35c3ffdebd60917647555ac6ec572098967035 TBR=rohitrao@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=513966 Review-Url: https://codereview.chromium.org/2983193002 Cr-Commit-Position: refs/heads/master@{#488362}
-
Jun Cai authored
This is a follow-up CL from the comment at: https://codereview.chromium.org/2929603003/diff/180001/device/generic_sensor/relative_orientation_fusion_algorithm.h This CL does the following to update sensor data documentation at sensor_readings.h: 1. Add units information for ACCELEROMETER and LINEAR_ACCELERATION. 2. Add units information for GYROSCOPE. 3. Add more comments about the correspoinding values in the W3C DeviceOrientation Event Specification for ABSOLUTE_ORIENTATION_EULER_ANGLES and RELATIVE_ORIENTATION_EULER_ANGLES. Bug: None Change-Id: Ie7820d84f6a21cc55a50f1f98d1b7f4630c222d4 Reviewed-on: https://chromium-review.googlesource.com/580089 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488361}
-
Hayley Ferr authored
Report how often the effective touch action computed by blink is or is not equivalent to the whitelisted touch action computed by the compositor. Bug: 745718 Change-Id: Ieb080bbd6791d8bfaafafd134c2406537000287a Reviewed-on: https://chromium-review.googlesource.com/575585 Commit-Queue: Hayley Ferr <hayleyferr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488360}
-
Victor Costan authored
Bug: 746653 Change-Id: Idda88c827b237b0bde4517ad9532537dc4977313 Reviewed-on: https://chromium-review.googlesource.com/578736 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#488359}
-
Evan Stade authored
Bug: none Change-Id: I8a7313d1007b2cb8e6a9fe5cd584c5286afd818d Reviewed-on: https://chromium-review.googlesource.com/575348Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#488358}
-
sebsg authored
Bug: 746990 Change-Id: Ib5aff32726225192d07c1a55b895d4f959110253 Reviewed-on: https://chromium-review.googlesource.com/579576 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#488357}
-
Nate Fischer authored
This changes our logic to fetch Safe Browsing user opt-out very early in WebView initialization. This treats user-opt out as a tri-state (opted-in, opted-out, unknown). The hope is that: 1. isVerifyAppsEnabled responds before the network request completes 2. Failing that, isVerifyAppsEnabled responds before lookupUri responds. If neither of the above is the case, and we still have not received a response from isVerifyAppsEnabled, then we will mark the URL as safe in downstream code and not show an interstitial. Bug: 731927 Test: manual - custom app Change-Id: Ie6c647828710d7e49e2e962bf3b334c4c8fcec15 Reviewed-on: https://chromium-review.googlesource.com/578947Reviewed-by:Selim Gurun <sgurun@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#488356}
-
Toni Barzic authored
The entry point for note taking on lock screen has been added to the lock screen UI for webui lock screen implementation - this means that the item in the system tray is not longer needed in this case. Keep the tray item around for views based lock screen (i.e. when show-md-login flag is set) - in this case the lock screen UI has yet to be updated, so there is still a need for an entry point in the tray. BUG=737067 Change-Id: I53c53c7154c1dfec165c6a9898359b29b366db3f Reviewed-on: https://chromium-review.googlesource.com/578647 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Terry Anderson <tdanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#488355}
-
jbauman authored
Create a new type of GLImage representing an NV12 DXGI share handle (and array level) and support displaying it in an overlay. BUG=729238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2968503003 Cr-Original-Commit-Position: refs/heads/master@{#485701} Committed: https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b0004c705463140 Review-Url: https://codereview.chromium.org/2968503003 Cr-Commit-Position: refs/heads/master@{#488354}
-
Sean O'Brien authored
Scroll events from the touchpad may arrive in the |GestureEventQueue| out of order, such that a GestureFlingStart arrives before a GestureScrollUpdate. Currently, the debounce filter removes the GestureFlingStart. This CL will forward the GestureFlingStart after emptying the debounce queue. BUG=717205 Change-Id: I42bd147195b9a2be8e34391c534c625cc785e2e0 Reviewed-on: https://chromium-review.googlesource.com/553424 Commit-Queue: Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#488353}
-
Matthew Halpern authored
Currently GRC's process CPU measurement mechanisms are tightly integrated with the process coordination unit implementation. This CL moves the CPU usage measurement from the resource_coordinator service to the content_browser service. Decoupling process CPU measurement from the CU model allows the coordination units to focus on representing browser state within GRC, rather than updating it. In GRC terms, the migrated render process CPU measurement infrastructure is a "probe" that externally triggers updates to the CU graph. A new feature flag has been added for enabling render process CPU usage profiling. To do so, run: out/Default/chrome --enable-features=GlobalResourceCoordinator,GRCRenderProcessCPUProfiling \ http://example.com BUG=691886,741768 Change-Id: I2fc7609c6963776a167c5f76abe078dedb0e2efe Reviewed-on: https://chromium-review.googlesource.com/565906 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oystein Eftevaag <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#488352}
-
Yipeng Wang authored
Generated jni headers should not be included by multiple .cc files. This double-include is breaking upcoming changes to the JNI generator. BUG=683256 Change-Id: I92318e46de45841557544bf04503bee27fc52e9a Reviewed-on: https://chromium-review.googlesource.com/578743Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yipeng Wang <yipengw@chromium.org> Cr-Commit-Position: refs/heads/master@{#488351}
-
Brett Wilson authored
Fixes linking in Windows non-component builds since the profiling process is now a child process. Move AllocationTracker::Alloc into a separate class AllocationEvent so it can be used in the exporter. Hooks up a simple test for the exporter. The exporter is not currently hooked up to any triggering. Change-Id: Ic9dda085032694ff1a5872e357ca2e03c0d42ad3 Reviewed-on: https://chromium-review.googlesource.com/575395 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#488350}
-
Peter Kasting authored
Ensure that the KeyValueImport test actually checks that GetFormValuesForElementName() overwrites the existing consumer value. This test would have failed in the initial version we wrote to convert the WebDataService off the DB thread, and was noticed by eye. This also refactors some common caller code into the callee in a couple places. Bug: none Change-Id: I3fc17a97b95e28c019f98e6692eedceb3fee260a Reviewed-on: https://chromium-review.googlesource.com/578586Reviewed-by:
mahmadi <mahmadi@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#488349}
-
Alexei Filippov authored
Change-Id: I9f6597ba0c296a478e5501c7f13a536210c4ceff Reviewed-on: https://chromium-review.googlesource.com/578740Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#488348}
-
Lei Zhang authored
Change-Id: Ib89e0f4a329b0e9ae844a90ca7506b330655a61f Reviewed-on: https://chromium-review.googlesource.com/578987Reviewed-by:
Dan Sinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#488347}
-
Kevin Marshall authored
Fix threading bug in RemovableStorageProvider test path RemovableStorageProvider replies to GetAllDevices() queries on the FILE thread instead of the caller's thread for test cases. This fixes the issue by posting the reply to the correct thread. (Caught by the stricter WeakPtr impl; see CL 2908073007) R=sky@chromium.org CC=wez@chromium.org Bug: 729716 Change-Id: Ie0983e03ba91c8c09ba339ea6c7061de28e69030 Reviewed-on: https://chromium-review.googlesource.com/529864Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#488346}
-
yunlian authored
When I try to enable thinlto on ChromeOS build, I hit this assert. This CL fixes that. BUG=None TEST=USE="thinlto" emerge-terra chromeos-chrome, the assertion is gone. Review-Url: https://codereview.chromium.org/2960273002 Cr-Commit-Position: refs/heads/master@{#488345} -
Matt Menke authored
https://chromium-review.googlesource.com/569298 added an extra check for hostname validity before doing a DNS lookup, but it only covered the main Resolve() path, not the two Resolve*FromCache ones. This prevents bad domains from getting into the cache, but certain bad domain names can still be resolved from the Resolve*FromCache calls without a DNS lookup, like *.localhost domains. This CL fixes that, and merges more common code between the different resolution methods, so hopefully this will be less likely to regress in the future. Bug: 496468 Change-Id: I3ec16ae77a1f1a074e37a2c29a23d2423a4b42e0 Reviewed-on: https://chromium-review.googlesource.com/578207 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#488344}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c7c5420fbc58..f1ed1692b568 $ git log c7c5420fb..f1ed1692b --date=short --no-merges --format='%ad %ae %s' 2017-07-20 sullivan Migrate benchmark health report to an experimental script using APIs. 2017-07-20 loloangela Fix errors related to bad-continuation param Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4f86d7c4b13cd7d1d62442112a5382042b5b0e81 Reviewed-on: https://chromium-review.googlesource.com/579665 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488343}
-
Nico Weber authored
I had removed this in https://codereview.chromium.org/2959083002, but it looks like dump_syms still needs it on arm for now. Bug: 744956,735027 Change-Id: Ia438c53abc6d6f7f39aada563bdcb68d328b1115 Reviewed-on: https://chromium-review.googlesource.com/579930Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#488342}
-
Max Morin authored
Changing which device is the default one will change the device enumeration result since https://chromium-review.googlesource.com/c/538754/. This CL makes sure to invalidate the device cache in MediaDevicesManager when this happens. Tested by plugging in various devices into a Pixel, verifying that input and output from each device has the same group id, and in addition that the "default" device has the same group id as the actual device that is considered default. Moreover, after changing the default device in the system UI and re-enumerating the result, the group id is updated accordingly. BUG=636300 R=jennyz Change-Id: Ie847bd052a609022826f31fbc3059a98049b875d Reviewed-on: https://chromium-review.googlesource.com/577532Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488341}
-
Scott Violet authored
_classic is mildly misleading given some of these files are used in mushrome, but it's better than aura. BUG=none TEST=none Change-Id: I688be31ecc92138d3f53781519972c8172c64645 Reviewed-on: https://chromium-review.googlesource.com/578654 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#488340}
-
Nico Weber authored
Bug: 330631 Change-Id: I930ef6a08833811313cd4cec61a400d283d12aa6 Reviewed-on: https://chromium-review.googlesource.com/580128Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#488339}
-
Jun Cai authored
This CL removes some unnecessary class forward declaration at SensorProxy.h Bug: None Change-Id: Ia626f912dcd604e12927dd8c2fe1e0da1a65b8be Reviewed-on: https://chromium-review.googlesource.com/579660Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#488338}
-
Kyle Milka authored
This is part 3 of 6 for FieldTrial refactoring for WebView Part 1: https://chromium-review.googlesource.com/c/562098/ Part 2: https://chromium-review.googlesource.com/c/561920/ Part 3: https://chromium-review.googlesource.com/c/561922/ Part 4: https://chromium-review.googlesource.com/c/561980/ Part 5: https://chromium-review.googlesource.com/c/562417/ Part 6: https://chromium-review.googlesource.com/c/562021/ This CL fixes a bug introduced in https://chromium-review.googlesource.com/c/561922/. It also contains a unit test for the bug. This new class contains the code previously in VariationsService that is needed by both Chrome and WebView, mainly the portions needed to call CreateTrialsFromSeed. The VariationsService class now contains an instance of this new class. BUG=678288 Change-Id: Ib1acf1a30ad50baded043b2fc05e9d87cd1fb4a3 Reviewed-on: https://chromium-review.googlesource.com/576288 Commit-Queue: Kyle Milka <kmilka@google.com> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#488337}
-
Xiaoqian Dai authored
This reverts commit dd9a923e. Reason for revert: It broke ash_unittests https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/28342. I'll investigate into it later. Original change's description: > Cros Tablet Window management - Split Screen part II > > This is a reland of https://codereview.chromium.org/2955203002/. The > original CL broke ash_unittests. > > Wire up the SplitViewController with the overview mode. It's a following > up CL of https://codereview.chromium.org/2960843004/. > > Changes in this CL: > 1. The split view mode can be initiated by dragging the window in > overview mode to the side of the screen > 2. After one window is snapped to one side of the screen, all the other > overview windows will display in the other side of the screen, allowing > the user to select another window to snap. When two windows are snapped > to both sides of the screen, the overview mode will be ended. > 3. The first snapped window will remain snapped until the user > explicitly exit the split view mode. All the other windows (incluing > newly created window) will be open in the other side of the screen. > Clicking/Tapping on the overview button also open the overview windows > in the other side of the screen. > > Not covered in this CL: > 1. The highlighted region showing where split will occur is not > implemented in this CL. > 2. The split divider is not implemented in this CL. > > BUG=725683 > TBR=oshima@chromium.org, varkha@chromium.org > > Change-Id: I307ac438bb45c0df5e347be296964375782ef3e7 > Reviewed-on: https://chromium-review.googlesource.com/578490 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488272} TBR=oshima@chromium.org,varkha@chromium.org,xdai@chromium.org Change-Id: I6c852c91bc93fa749cbf0f2fb1d56c2dee41a9b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 725683 Reviewed-on: https://chromium-review.googlesource.com/580347Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#488336}
-
Steven Holte authored
Bug: 745939 Change-Id: I30d487641e5cb3130961c46305e4999e2e7ef63d Reviewed-on: https://chromium-review.googlesource.com/577062 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#488335}
-
Victor Costan authored
Bug: 746653 Change-Id: Ieb6e9bcc5e119573f98d6e629caf47d099eba774 Reviewed-on: https://chromium-review.googlesource.com/578393Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#488334}
-
Amber Won authored
On the placeholder page, add a PDF icon in the center and a bar on the bottom of the page, which includes the file name and a link to the view the PDF. Bug: 737787 Change-Id: Ia3612ee812118514666bafa195720b2191d31f6b Reviewed-on: https://chromium-review.googlesource.com/578309 Commit-Queue: Amber Won <amberwon@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#488333}
-
Neal Gompa authored
Mageia 6 introduces DNF as an alternative package manager. In addition, Mageia 6 switches the PackageKit backend to the DNF one, meaning that the urpmi configuration does not apply to tools like Apper, GNOME Software, and Plasma Discover, which use PackageKit as the package management backend. Since DNF (being the successor to Yum) is configured the same way as Yum is, let's reuse the Yum configuration setup for Fedora to configure it for Mageia. We do this by changing to declare an array PACKAGEMANAGERS and iterate through them and execute the actions for each PACKAGEMANAGER. This way, we can easily support future transitions and parallel package manager configurations from distributions in the future. Bug: 729888 Change-Id: I19a80ee1e150d8cfea53944a2030e6ea0ae1ce44 Reviewed-on: https://chromium-review.googlesource.com/572394Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#488332}
-
Mark Cogan authored
This CL removes the last parts of contextual search from shipping code. The settings UI is moved into contextual_search/, and is still built and tested for unit tests, but all of the remaining logic around initializing CS and enabling it, and possibly showing the settings, is removed. The IDC_SHOW_CONTEXTUAL_SEARCH_SETTINGS command is also removed. Bug: 738881 Change-Id: I41226091de512660b5969623083c6a450d86cd59 Reviewed-on: https://chromium-review.googlesource.com/577870Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#488331}
-
arthursonzogni authored
This is a followup of https://codereview.chromium.org/2975623002/. It prevents the renderer from ignoring main resource requests with the "cid" scheme and adds tests that check an Android Webview can intercept any requests with this scheme. BUG=739658 Change-Id: I03e039f5e84f2be8638c46812f2216803a0f1d4d Reviewed-on: https://chromium-review.googlesource.com/574591Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#488330}
-
Hidehiko Abe authored
ArcProvisionNotificationService internally accessed to ArcSessionManager::profile(). Instead, it will use the given BrowserContext. BUG=672829 TEST=Ran trybot. Change-Id: Ic1f60318d4727863a41654cd5aa73b3bd319725d Reviewed-on: https://chromium-review.googlesource.com/579890Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#488329}
-
mfomitchev authored
Proper fix is in https://codereview.chromium.org/2983883002/, but I'd rather not land that while on leave. I will land the proper fix when I come back if this is still not replaced with the new UI. BUG=668296 Review-Url: https://codereview.chromium.org/2985543002 Cr-Commit-Position: refs/heads/master@{#488328}
-