- 18 Sep, 2019 40 commits
-
-
Antonio Gomes authored
Now that their solely client [1] has been Onion soup'ed, it is possible to bypass (and remove) these helpers in favor of accessing blink::RtcVideoDecoderFactory's and RtcVideoEncoderFactory's ctors directly. [1] //third_party/blink/renderer/platform/peerconnection/video_codec_factory.cc BUG=787254, 919392 Change-Id: Ieb090709080de71fb98d8b2be68afa57ad88fee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807714 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#697700}
-
Sebastien Marchand authored
The bug causing TabLifecycleUnitTest.CannotFreezeOrDiscardIfConnectedToBluetooth was due to the test running right before it, which was modifying a global state without resetting it to the proper value. Bug: 1004578 Change-Id: I0c8fa306e0d2f40911c18de52c062352d380fb5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808335 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#697699}
-
Tarun Bansal authored
Add experiment to preconnect to predicted redirect target. The redirect target is returned as part of loading prediction by the loading predictor. Change-Id: I9e00363db609470d92dd5f2196aad71868dc68ed Bug: 983234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699738 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#697698}
-
Eric Karl authored
Change-Id: I2249d8380a3c46764476d5ec59aec65705c4344d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809114 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697697}
-
Maksim Ivanov authored
Refactor the SystemTokenCertDBInitializer class to live in its own .h+.cc files, rather than being defined inside the already heavy chrome_browser_main_chromeos.cc. Other minor changes made there: 1. Removed the Initialize() method, and added a ShutDown() method (the latter will become non-empty in a follow-up CL:1796426). 2. Replaced base::Bind/base::Callback with their modern Once/Repeating analogs. Bug: 725500 Change-Id: Ia172f3cf1e049171914f5fd251a8cc88f6643e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806859 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#697696}
-
Connor Clark authored
Bug: 1004875 Change-Id: I3fc4cc0d6fdaaa366bfb20b95ab7d79049b3c21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809102 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#697695}
-
Jan Wilken Dörrie authored
This change implements base::CheckedRandomAccessConstIterator in terms of base::CheckedRandomAccessIterator, while still allowing safe conversions between iterators. Bug: 817982, 828324 Change-Id: Ibc3a80cf01e30fc60b33c4c92324a728b8635cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807331 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#697694}
-
Brandon Wylie authored
This is to comply with the new presubmit rule which enforces the following keyword order: public protected private abstract default static final transient volatile synchronized native strictfp Bug: 1003711 Change-Id: I6b2d98814427b9e9c14b8d705a4a8a114aac2c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810018 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#697693}
-
Matt Simmons authored
Add vertical space below MV tiles. R=yusufo@chromium.org Bug: 985386 Change-Id: Id72f1339c9150530248173e5a9dc4bec6681fc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808792Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#697692}
-
Jae Hoon Kim authored
This creates the DlcserviceClient to call into dlcservice daemon's exposed DBus API. The dlcservice daemon provides management of DLC (Downloadable Content) modules. Exposures from DlcserviceClient is to allow for Install/Uninstall/GetInstalled in a manner that wraps the respective DBus API exported from the dlcservice daemon in a Chrome style callable interface. Information on building a DLC and how what dlcservice daemon is can be followed at: https://chromium.googlesource.com/chromiumos/platform2/+/HEAD/dlcservice Bug: 1000711 Test: autoninja -C out/Default chromeos_unittests && testing/xvfb.py out/Default/chromeos_unittests --gtest_filter=DlcserviceClientTest* Test: autoninja -C out/Default unit_tests && testing/xvfb.py ./out/Default/unit_tests Test: autoninja -C out_${SDK_BOARD}/Release chrome nacl_helper && deploy_chrome --build-dir=out_${SDK_BOARD}/Release --to=$TEST_IP Test: modifications to actually call into to DlcserviceClient with nebraska.py as payload path server. $> restart ui Test: Custom CHROMEOS_AUSERVER within /mnt/stateful_partition/etc/lsb-release on DUT with local nebraska.py port. Change-Id: Ia269cab18d7fcc4c1c6d0ee72fb3383b11af38a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802682 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697691}
-
Adam Ettenberger authored
This is CL [1/4] in a series of CLs to expose "display: none" elements to the browser process AXTree. 1. Add and improve tests for CSS display and visibility. 2. Introduce new command line flag and chrome://flags entry. 3. Update AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree and relevant logic for the feature to work, disabled using the feature flag. 4. Enable the feature in tests; update expectation files. --- In this change I added the following tests : * DumpAccessibilityTreeTest.AccessibilityCSSDisplayToNone * DumpAccessibilityTreeTest.AccessibilityCSSVisibilityToHidden * DumpAccessibilityTreeTest.AccessibilityCSSVisibilityToCollapsed * DumpAccessibilityTreeTest.AccessibilityCSSVisibilityToVisible I also updated the following html files : content/test/data/accessibility/css/display-to-block.html content/test/data/accessibility/css/display-to-inline.html The reason I updated these html files is so that... 1) Each related test file has comparable layout and WAIT-FOR behavior 2) Once the feature is enabled, the WAIT-FOR will flaky fail because exposing the node in the tree may trigger WAIT-FOR before the script has a chance to modify the accessibility tree. Bug: 651614 Change-Id: I501086047de409a8544f5ff8937d7ebd422fed13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809454 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697690}
-
Henrique Nakashima authored
Clank HOA Lite specifies features should be in chrome/browser rather than chrome/lib. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1801803 with the following changes: https://chromium-review.googlesource.com/c/chromium/src/+/1810767/1..2 This fixes a jni header include which should have been changed in the original CL to point to the new location. CQ bots missed this because the generated header persists across builds in the wrong location, even though it was now being generated in the new location. TBR=yfriedman@chromium.org,wylieb@chromium.org,wnwen@chromium.org Bug: 995916 Change-Id: I4915d2a52a7d877c35486b83fa5d31b840ba5d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810767Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697689}
-
Ian Struiksma authored
Following up after https://crrev.com/c/1787406 appears to have fixed idle paint issue by enabling 3 disabled tests: accesscorrections jetspizza star_city_games Bug: 993044 Change-Id: I005f0c722b9168a32579b2aafcb851e763105e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808425 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#697688}
-
danakj authored
Page zoom level is a page/view concept, but the code to manage it is currently in RenderFrameImpl, though only run when it is the root frame. This doesn't dramatically change ownership of responsibility but moves the code up into RenderViewImpl. RenderWidget still goes through RenderFrameImpl (though more explicitly) to set the zoom level on the RenderView. And RenderWidget takes responsibility for closing the page popup instead of having multiple "set page zoom" methods on RenderViewImpl. This uncovered some spooky action-at-a-distance and makes it more explicit and documented, though no less unfortunate. A local root LocalFrame does not initialize with the correct page zoom value because it has no parent to read it from. We (accidentally?) worked around that by setting the RenderView's page zoom to its current value when navigating a (new) LocalFrame, which would call into blink's WebView and walk through the entire frame tree setting the value on everything, eventually also on the new LocalFrame. Now on navigation, for a local root, we call RenderWidget's UpdateWebViewWithDeviceScaleFactor() which does the same thing by re-setting the WebView's page zoom factor. This was done when making a new main frame in multiple places (RenderView and RenderFrame both called it in the same CreateFrame() callstack). Now it is consolidated to a single place on navigation for the main frame and child frames giving them more consistent behaviour, and going explicitly through this method that should go away if things were well designed, rather than re-setting the RenderView to its own value. Remove calls to UpdateWebViewWithDeviceScaleFactor() scattered throughout RenderViewImpl and RenderFrameImpl. What we need is for 1) The Page to be updated with PreferCompositingToLCDText when the device scale factor changes. 2) The WebView to be updated when the device scale factor changes. 3) The LocalFrame of a local root needs its page zoom set by poking the WebViewImpl to walk through all frames and set it. R=erikchen@chromium.org Bug: 419087 Change-Id: I97c0e287be8f96a4ac632d63b981c190169dc1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799386Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#697687}
-
Dominic Battre authored
This experiment did not provide data indicating that we want to launch it, so let's make sure that it does no remain as an active experiemnt in fieldtrial_testing_config.json. Bug: 966406 Change-Id: I70a46f6234137fdfe696b738f3fa3b7b109b1a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807324 Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#697686}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8c80da317efc..7259f61fb600 git log 8c80da317efc..7259f61fb600 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 fmayer@google.com Merge "Use GetTestDataPath for tests." Created with: gclient setdep -r src/third_party/perfetto@7259f61fb600 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib56de7b4ab6fe4a53910c65e2d7078d6c6335425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809888Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697685}
-
Ken Rockot authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1769102 PS2 is the original CL rebased. Diff PS2->PS11 to see the one-line fix for bug 1000327. This is applied in addition to the base change in https://chromium-review.googlesource.com/c/chromium/src/+/1810036 to fix a more general race condition in render process host reuse. This moves the Resource Coordinator Service off of Service Manager APIs in favor of direct Mojo interface usage. A public browser API is exposed to give content clients access to the service connection. NOPRESUBMIT=true Bug: 977637, 1000327 Change-Id: Id3742584f25b3891386e62789db1b4121b0d3007 TBR: dcheng@chromium.org TBR: avi@chromium.org TBR: yucliu@chromium.org TBR: torne@chromium.org TBR: erikchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809098Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#697684}
-
Emircan Uysaler authored
Bug: 982922, fuchsia:24570 Change-Id: If9fb495249488c43f97e4451a14f0193911d600f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804527Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697683}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/83d2cae04c5f..122f4535b1be git log 83d2cae04c5f..122f4535b1be --date=short --no-merges --format='%ad %ae %s' 2019-09-18 vapier@chromium.org cros_test_lib: deprecate some unittest aliases 2019-09-18 vapier@chromium.org unittests: change self.assertEquals to self.assertEqual Created with: gclient setdep -r src/third_party/chromite@122f4535b1be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I16a4b8d2f37d894e4955d889007083e5b6def4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809889Reviewed-by:
-
Antonio Gomes authored
Now that socket_client.h can be moved out of the Blink exposed API layer, the extra copy step in P2PSocketClientImpl::SendWithPacketId can also be removed. This solution was added temporarily in [1], as part of Onion souping this file. [1] https://crrev.com/c/1805159/ In summary, this CL: - moves socket_client.h from blink/public/platform/modules/p2p/ to blink/renderer/platform/p2p/. - adapts the header being moved accordingly. - eliminates blink/public/platform/modules/p2p/ altogether. - P2PSocketClientImpl::SendWithPacketId to operate over WTF::Vector, instead of std::vector. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I1c8713cb6c96663cd0d7db8acbac1dfaa4809931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806979 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#697681}
-
Filip Gorski authored
TBR=antrim@chromium.org Bug: 997685 Change-Id: I22694fc565d49083e7fd937d7d97a7b9e64029e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809530Reviewed-by:
-
Owen Min authored
CloudReportingEnabled policy is using an extension to collect data and this extension is used as a signal by chrome://management page. The extension is going to be deprecated soon and its logic is moved into Chromium code base. Make sure that the chrome://management page still covers all data we collected. Without the extension, CloudReportingEnabled collects almost same data except the safe browsing ones. The safe browsing data reporting will be owned by other enterprise feature. Bug: 956237 Change-Id: Idb35ad27da50405898dfc499a37b7255f9bad735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808704Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697679}
-
Luke Z authored
This reverts commit 59860aa8. Reason for revert: Suspected breakage of WPT importer (crbug.com/1005222) Original change's description: > [blinkpy] Extend Mac macro to cover more versions > > Although we don't fully support 10.14 or 10.15 yet (we don't have > version-specific baselines for them), this should help to drastically > drive down the number of failures. > > Bug: 1001606 > Change-Id: I3cd93619c015cb154885a154660b169eb1bada58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790267 > Auto-Submit: Robert Ma <robertma@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694358} TBR=dpranke@chromium.org,robertma@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1001606 Change-Id: Ifd0fc72269bfbe56a5faeac8492b42adc9f5ce89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810761Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697678}
-
Brian White authored
This reverts commit 04e92329. Reason for revert: Likely candidate for linux-chromeos-rel builder failures: https://chromium-swarm.appspot.com/task?id=475cd90235116110 ../../chrome/browser/chromeos/login/test/oobe_screen_waiter.cc:53: Failure Expected equality of these values: target_screen_ Which is: demo-preferences GetOobeUI()->current_screen() Which is: network-selection Original change's description: > Chrome OS Oobe: Show Ash dialog only if required > > When starting a managed guest session (with no Terms of Service), a > blank Ash dialog is shown for a brief moment before the session starts. > This is caused by the Ash dialog for Oobe being shown even when all the > Oobe screens are skipped. > > This CL changes the behavior of the Ash dialog to only show when > required by using a OobeUI::Observer. The dialog is not shown by > default, and will be shown when a Oobe screen is shown. > > OobeScreenWaiter now checks that the native window is visible by > default. A small number of tests had to be changed to either show the > native window or ignore the visibility check. The reasoning for the > changes are in the comments for their respective tests. > > The WebUI behavior is unchanged. > > Bug: 1000164 > Change-Id: I9995f4beba85d7c5af7b13f81f1a654e2d52f372 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790450 > Commit-Queue: Jit Yao Yap <jityao@google.com> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697539} TBR=antrim@chromium.org,jityao@google.com Change-Id: I4b663f335ad6ef084a2583d54519452fa4a95d19 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1000164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808710Reviewed-by:
-
Peter Wen authored
Use new code introduced in: https://crrev.com/c/1758358 Bug: 1000751 Change-Id: Ib1f4d966530c2111e9b0c1fe14637caf4b32d9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810839 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697676}
-
Mandy Chen authored
Currently, if an unsupported JS feature is used, localization presubmit checks will fail with the raw error message from esprima, the JS parsing library. This CL wraps a try-catch block around the parsing call and outputs a nice error message that specifies the file location and the reason. Before: Error: Line 9: Unexpected token = After: Error: DevTools localization parser failed: third_party\blink\renderer\devtools\front_end\security\SecurityPanel.js: Line 9: Unexpected token = This error is likely due to unsupported JavaScript features. Such features are not supported by eslint either and will cause presubmit to fail. Please update the code and use official JavaScript features. Bug: 941561 Change-Id: If945563f84224232155a7de7cf597c5395a0cbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729729Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697675}
-
Nathan Zabriskie authored
This CL sends the sanitized PresentationFeedback to viz clients instead of the original feedback. Change-Id: Icaa567e1dcb5a7acad8d465671ada67cb874095e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810059 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#697674}
-
Chris Lu authored
There is no need for ViewportAdjustmentExperiment since the only experiment remaining is just the kSmoothScrollingDefault feature flag. GetActiveViewportExperiment() can just be a function that returns whether or not smooth scrolling is turned on. GetActiveViewportExperiment() and ViewportAdjustmentExperiment are still needed for downstream compatibility, and will be removed in a subsequent CL. Bug: 914042 Change-Id: I57bcd13dafaafb3b3a05ec65f23dacf2936e81e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799663Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#697673}
-
Sergey Ulanov authored
FuchsiaVideoDecoder wasn't handling the end-of-stream correctly. The DecodeCB for EOS buffer was called out of order when there are other pending Decode requests. Also DCHECKs were failing. Also updated unittests to detect this issue. Bug: 997853 Change-Id: Iae04250521e929d8ad220ead08d701f274a15979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810397 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697672}
-
Khushal authored
The class was used in the non-viz codepath which we don't support anymore. R=ericrk@chromium.org Change-Id: Iffc9b63d1c10e8696fb1f2c92acf6afdb138fa81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809810 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#697671}
-
Mandy Chen authored
Heap snapshot web worker currently calls localization functions directly, but this causes an issue as localizable resources are not available to the worker. To fix this, send serialized messages to the main thread and localize them there. Bug: 941561 Change-Id: Ic9f434e93fd3a2bb7b06aa669aaa85f905c72df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758732Reviewed-by:
-
Peter Boström authored
When the toolbar's display mode is not ::NORMAL the extensions container is never initialized. Not checking for this (or container availability) leads to crashes when the extension-uninstall dialog tries to find where to anchor to in the window. This intentionally checks the display mode instead of container availability as the containers should always be created in ::NORMAL. Bug: chromium:1005154 Change-Id: I5c51bf0f2a02c75896355ccee39077d6c55a0d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809974 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#697669}
-
dpapad authored
Specifically: - Remove dependencies to cr.ui.List, cr.ui.ListItem and list.css since these were (erroneously?) added at r508574, but were not used. - Hook up closure_compile target, since it was not referenced from anywhere. - Replace remaining HTML imports with regular <script> tags instead. Bug: 937747 Change-Id: Ib26d4a31ecb365e23205f28d21d18a79ce03aa52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809110Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#697668}
-
Mandy Chen authored
Since the current localization system uses a unique ID for each string that is calculated based on the the md5 hash of the string, each string in the grdp files needs to be unique. However, there are strings in the frontend that appear multiple times. When such strings are moved across folders, sometimes a seemingly random grdp file is changed by the autofix script. (See https://crrev.com/c/1683826 for an example) This CL introduces shared_strings.grdp, a file dedicated for strings that are shared across folders/grdp files. Instead of putting these strings in the grdp files that come first when sorted alphabetically, they live in shared_strings.grdp and have common descriptions among all instances of such strings. This way if shared strings need to be moved, it's more clear what's going on. Note that this CL contains a lot of changes that are generated automatically (e.g. shared strings are removed from their current locations), so here's the list of actual changes that need to be reviewed: * shared_strings.grdp file is added to front_end/langpacks and front_end/langpacks/ devtools_ui_strings.grd * path to shared_strings.grdp is added to scripts/localization_utils/localization_utils.js * in scripts/localization_utils/check_localized_strings.js, the parser marks strings that appear more than once as shared and set the target grdp file to be shared_strings.grdp * shared_strings.grdp file is checked by scripts/check_localizability.js for localizability violations * shared_strings.grdp messages have common descriptions added Bug: 941561 Change-Id: I00db23854656509f2f03988e70adc0109b6e09d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800918Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/873079f1d3a2..e34564bafe83 git log 873079f1d3a2..e34564bafe83 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 ynovikov@chromium.org Revert "Suppress crashing perftests on Win Intel Exp Rel" Created with: gclient setdep -r src/third_party/angle@e34564bafe83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:997674 Change-Id: Ifc271b11d3f170345dec722c4ba74afd19591061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810188Reviewed-by:
-
Bettina authored
Create experiment for SafeBrowsingPasswordProtectionForSignedInUsers. Bug: 914410 Change-Id: Iae3e6d2b74419048e1a78eb0479bed1d6446282e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809899Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#697665}
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 985386 Change-Id: If0074993b229e2a4da5fa0cf7f59e3fdce2c75a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809518Reviewed-by:
-
Adam Langley authored
This has been enabled by default since M76. Time to get rid of it. Change-Id: I7427d5f991b4c7eedd9bea6c2305683ef187f658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811198 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#697663}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd281eec08fe..795cab2777e2 Created with: gclient setdep -r src-internal@795cab2777e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib529fe8044fd4502d4128b694435f56eb71e879d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809986Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697662}
-
Yun Liu authored
Right now Java per-CL coverage instrument everything as full code base coverage. To only instrument class files related to affected files in a CL, we can: 1. Extract class files only related to affected source files in a jar. 2. Instrument these extracted class files. 3. Extract unaffected members from original jar. 4. Zip everything out to output path. Bug: 1001387 Change-Id: Iaf6a75c7f8005b5d64eee22bc604f25d0c2fcd8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797109Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#697661}
-
