- 31 May, 2019 40 commits
-
-
Lindsay Pasricha authored
We renamed the EG2 test targets in https://chromium-review.googlesource.com/c/chromium/src/+/1628171 but these files weren't updated. Bug: 866147 Change-Id: I59891bba8a0516fc9b5eca4867acb5e0fcde859a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637839Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#665199}
-
Felipe Cerqueira authored
Bug: 927957 Change-Id: I2353843752a270db375471e9faa62336fe50158d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635629 Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665198}
-
Pâris MEULEMAN authored
This CL aims to remove OAuth2TokenService.Oauth2TokenServiceObserver, which is unused except for tests. The tests depending on this API were modified to test the behavior using a different way in parent CLs: - Test that saveStoredAccounts was successfully executed; - Test the C++ Oauth2TokenServiceDelegateAndroid instead, which gives access to the C++ OAuth2TokenService::Observer. Bug: 960281 Change-Id: I152f5c582d7795c05162e0ab3fca219c0db10a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602715 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665197}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/887362fca7a7..8b079d6881fc git log 887362fca7a7..8b079d6881fc --date=short --no-merges --format='%ad %ae %s' 2019-05-31 mnissler@chromium.org Revert "Mark guado as experimental" Created with: gclient setdep -r src/third_party/chromite@8b079d6881fc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Iba1e13e9eb126f79bd3a10b957cbf7531e6eab0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638564Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665196}
-
Michael Thiessen authored
Restricting to NoTouchMode to lower riskiness/contentiousness of this change. Bug: 968573 Change-Id: I4b9247541179f8af0c0548d0d3bb6e6c05a0bba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637533Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#665195}
-
David Grogan authored
The FlexNG test failures shouldn't really have 591099 as their tracking bug, but that's a different CL. Bug: 963168 Change-Id: I96294fe71c2b20fcb8f50c00cf22603d69c386ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633533 Auto-Submit: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#665194}
-
Fritz Koenig authored
When the source is a WebGL canvas the rectangle must be adjusted for flipping with MESA_framebuffer_flip_y. BUG=964010 TEST=https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html?version=2.0.1 Change-Id: I20f5ac0a5049b23b3033a6d46f53606886f4e4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627555Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#665193}
-
Dale Curtis authored
BUG=879406,969079 TBR=liberato Change-Id: Icdc2bc65226bce07331f56311d244e6c2212c551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637593Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#665192}
-
Victor Costan authored
Bug: 937761 Change-Id: I33b207351d2e1da2daf31a4388ee0e0aab5f2b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638282Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#665191}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/94246cb21c8f..78f6819b0e70 git log 94246cb21c8f..78f6819b0e70 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 tsepez@chromium.org Reland "Split off CPDF_ModuleMgr:Create() from CPDF_ModuleMgr::Get()"" 2019-05-31 thestig@chromium.org Add CXFA_Node::GetXMLDocument() helper. 2019-05-31 thestig@chromium.org Update third_party/base/numerics/ code. 2019-05-31 thestig@chromium.org Update third_party/base/numerics/safe_conversions code. 2019-05-31 thestig@chromium.org Add a ReadArrayElementsToVector() helper function. 2019-05-31 thestig@chromium.org Break remaining dependency from fxge to fxcodec. 2019-05-31 thestig@chromium.org Fix some nits in SkiaState. 2019-05-31 tsepez@chromium.org Move PDF_{Adobe,Unicode}NameFrom{Unicode,Adobe}() to core/fxge. Created with: gclient setdep -r src/third_party/pdfium@78f6819b0e70 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Id4bce88022cecedbe1c59f24be8337a9c897d3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665190}
-
Peter Kasting authored
This is banned by the Chromium style guide. Bug: none Change-Id: I417bb80ec06616583f9f10bbf4f197d46d0f45b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637861Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#665189}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f0f5fb37d74..c8f285a7077e git log 2f0f5fb37d74..c8f285a7077e --date=short --no-merges --format='%ad %ae %s' 2019-05-31 jvanverth@google.com Fix DDL_Metal test configs 2019-05-31 jvanverth@google.com Reland "Added AutoreleasePool for managing pool memory in testing apps." 2019-05-31 halcanary@google.com SkShaderBase::isAPicture() 2019-05-31 bsalomon@google.com Color matrix effect rewritten as .fp 2019-05-31 jvanverth@google.com Use GrCFResource class to manage backend surface MtlTexture resources. 2019-05-31 robertphillips@google.com Clean update ETC1 data utilities (take 2) 2019-05-31 kjlubick@google.com Revert "Added AutoreleasePool for managing pool memory in testing apps." 2019-05-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 172e5d373fad..0a56f0e3d22d (6 commits) 2019-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 97d3c908..8e522297 (404 commits) 2019-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 37bc82ac64f5..c0d7ee45d45f (2 commits) 2019-05-30 bungeman@google.com Document SkShaper::RunHandler::Buffer 2019-05-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-30 herb@google.com Use strike spec for bitmap rendering 2019-05-30 ethannicholas@google.com added support for SkMatrix44 ctype 2019-05-30 jvanverth@google.com Added AutoreleasePool for managing pool memory in testing apps. 2019-05-30 reed@google.com share tiny bit of code for std language iter 2019-05-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-30 reed@google.com free formatctx when we're done 2019-05-30 robertphillips@google.com Revert "Clean update ETC1 data utilities" 2019-05-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-30 michaelludwig@google.com Remove old GrFillRectOp factories 2019-05-30 robertphillips@google.com Clean update ETC1 data utilities 2019-05-30 fmalita@chromium.org [skottie] Shaper: fission glyphs into separate fragments when needed 2019-05-30 robertphillips@google.com Use GrVkImage utilities in GrVkGpu::createTestingOnlyVkImage 2019-05-30 halcanary@google.com SkPDF: implement kDecal image shader TileMode 2019-05-30 halcanary@google.com SkPDF: MakeShader uses Color4f 2019-05-30 bungeman@google.com Correct shaper assert around iterator fonts. 2019-05-30 reed@google.com support assets for skottie2movie 2019-05-30 herb@google.com Collapse the SkTextInterceptsIter into base class 2019-05-30 brianosman@google.com Interpreter: Elide dup/pop around stores 2019-05-30 bungeman@google.com Add trivial implemenations of shaper run iterators. 2019-05-30 rmistry@google.com Add new G3 compile try bot 2019-05-30 rmistry@google.com Add recipe for triggering and waiting for G3 compile tasks 2019-05-30 rmistry@google.com Script to trigger and wait for G3 compile tasks 2019-05-30 reed@google.com Revert "Compare pixels for TypefaceWithNoPaths test" 2019-05-30 hcm@google.com Update Skia milestone to 77 Created with: gclient setdep -r src/third_party/skia@c8f285a7077e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967418,chromium:964498 TBR=kjlubick@google.com Change-Id: Iac3e939ce64552ceb0915f199c0a0fe779e8c5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638488Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665188}
-
Mandy Chen authored
audits2 was renamed to audits: https://chromium-review.googlesource.com/c/chromium/src/+/1614691 Rename grdp file and its entry. I'll improve the autofix script to catch this case in another PR. Change-Id: I0f2eaa3528ed925d32feccd22762399d603491be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637591Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#665187}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=tsepez@chromium.org Change-Id: I41fd9666b91aa705eaeb1bf2432b8dcd1947453d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636053 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665186}
-
Nate Chapin authored
Bug: 964768 Change-Id: I59c2384cda133f97730e88a266bba542aeaaa828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637864Reviewed-by:
Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#665185}
-
Natalie Chouinard authored
The Android Framework Preference classes are deprecated as of API level Q in favor of the v7 Preference Support Library. Add the required dependency so we can begin migrating. The net effect of this migration is expected to be a reduction in method count and binary size. Bug: 966073 Binary-Size: New support library import Change-Id: I6b1f2f762f131567db31a6d9c314c71142866cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605515 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#665184}
-
Suman Nelson Kancherla authored
A user-bounce metric is when the user clicks deny button on the consent dialog or otherwise closes the dialog by clicking outside of it, only to retry and click allow button this time. The metric is to count the number of times this happens. This cl has a no-op refactor. The ConsentFlowMetrics(Helper) classes in Java/C++ respectively are basically updating the same histogram. Metrics folks strongly discourage this. They would rather have one function update a metric and have all other functions call it. So, this cl replaces Java histogram calls with Jni ones. Bug: 965538,962755 Change-Id: Ie7e526caa7d18310b2c9580411d41df6ae618b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638098Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#665183}
-
Etienne Bergeron authored
The browser process is DPI aware. To be able to detect correctly the configuration on my win10 computer, I needed to add the code of this CL. To make the tests fails, I needed to change the system config to increase it to 125%, then I needed to sign-out and sign-in. see the output: ../../chrome/browser/ui/views/layout_provider_unittest.cc(70): error: Expected equality of these values: system_dpi_scale Which is: 1.25 1.0 Which is: 1 The test requires default display settings. The DPI of the display is not 100%. dpi_scale=1.25 Stack trace: Backtrace: base::debug::StackTrace::StackTrace [0x00007FFB86ADC648+40] (C:\src\chromium\src\base\debug\stack_trace.cc:203) StackTraceGetter::CurrentStackTrace [0x00007FF66C1DB986+86] (C:\src\chromium\src\third_party\googletest\custom\gtest\internal\custom\stack_trace_getter.cc:24) testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF66C1F172A+90] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:827) testing::internal::AssertHelper::operator= [0x00007FF66C1F11F7+87] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:404) LayoutProviderTest::SetUpTestSuite [0x00007FF66B9EA76D+1117] (C:\src\chromium\src\chrome\browser\ui\views\layout_provider_unittest.cc:70) R=tapted@chromium.org Bug: 963868 Change-Id: Ifcda84cbea88c42e9d3b2c5c81c024a1a9abc371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630978 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#665182}
-
Mike Wasserman authored
Replace the mojo interface with a pure virtual C++ interface. Add a static Create method; remove unused interface function. Update users. Bug: 958215 Test: Automated Change-Id: I1d697364fd090894cbc465400861e3fb7fcf5ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636677 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#665181}
-
Andrew Xu authored
A part of code to enable dragging AppList by mouse. To achieve this goal, three key functions are required: (1) Drag AppList by mouse from Peeking/Half state. (2) Drag AppList by mouse from Shelf. (3) Drag AppsGridView by mouse. This CL implements the first function: enable dragging AppList from Peeking/Half to FullscreenAllApps/FullscreenSearch Bug: 768484 Change-Id: I10b48afe111397f8cf962eec26304c853b868f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620783 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#665180}
-
Adithya Srinivasan authored
Portals can be activated in response to scroll events like overscroll and we want users to be able to continue scrolling after activation without tapping the screen again. This CL dispatches touch events targeted at the new ContentView after activation, which mirror where the pointers were before activation. Design doc: https://docs.google.com/document/d/12EsIEQIJAzh4-3aNQNhxoQ8Z7ayrSodmWbo06R9PbAQ/edit?usp=sharing Bug: 914376 Change-Id: I1ade7ac3da7451de14b38dd66056178cdcab7631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622906 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#665179}
-
Chris Harrelson authored
This avoids even more complicated code in GraphicsLayerUpdater. I don't think the performance will be a big problem in the short term, and longer-term CAP obsoletes this code. Bug: 968488 Change-Id: Id88ee31b47449ce752b004dd911b3918d035fc9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636858 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665178}
-
Suman Nelson Kancherla authored
Bug: 969024 Change-Id: I1af3edd08def4792c2162313eb5d98a55897a730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637655 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#665177}
-
Alex Chau authored
- message_id is already provided by IncomingMessage - sent_time is already provided by FCM, can be added to IncomingMessage Bug: 966028 Change-Id: Ia6247f262659f0748ffaa4c81d61757dbf84c54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636052 Auto-Submit: Alex Chau <alexchau@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#665176}
-
Leszek Swirski authored
When a ScriptResource receives a datapipe for the response body, it starts watching that datapipe for data. Previously, watching the data pipe meant calling ArmOrNotify on a mojo SimpleWatcher. If there is no data, then this arms the watcher to trigger a callback once data arrives; if there is data then it posts a task onto the loading task runner to trigger the callback "immediately". Unfortunately, script streaming can only be started in this callback. This means that if the data pipe already has enough data in its buffer to start streaming by the time the ScriptResource receives it (which appears to often be the case), we "waste" some time on task posting overheads, and potentially are blocked from starting streaming by other activity on the main thread. Locally I've seen latencies of >100ms between receiving a datapipe that has enough data to stream, and actually starting streaming it (with preload streaming enabled). So, when the data pipe is first received, if there is data in its buffer already we now immediately synchronously call its callback. Bug: 865098 Bug: 945321 Change-Id: I140975b92bf80febf59edaad3e19670b3bc5e529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631374Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#665175}
-
Elly Fong-Jones authored
Also bump the milestone to provide more time to discuss the path forward for this feature. TBR=omrilio@chromium.org Bug: None Change-Id: I59907936b8a36dc919a485566a208269d90d0b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638662Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#665174}
-
Sven Zheng authored
Add the pixel_browser_tests target to waterfall. This is an experimental target that do pixel testing. The test result relies on Skia Gold server so we want to isolate the target. The test can pass locally now and I need to see how it behaves on bots. Design doc(Internal): https://docs.google.com/document/d/1Mz72RHWyQKsT6jynrDNGbCaTKQIy_77qMjRM5gpsr_w/edit?usp=sharing Design doc(Public): https://docs.google.com/document/d/1uvXp0AKfemJ9e1TXM1nH3UTcVlDKISK2jFd_g2gstX0/edit?usp=sharing Bug: chromium:958242 Change-Id: Ifcef0e94e924ca7c98c4909a42f9e54d87041ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623226 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#665173}
-
Giovanni Panaro authored
Increased the left padding on the Status Bubble from 3 to 5 and the right padding from 1 to 5. This way the URL looks less cramped. Bug: 959890 Change-Id: I08eb80a057d0ea00096fb28c06f5a93654894f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598028Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#665172}
-
Evan Stade authored
TBR=tsepez@chromium.org Bug: 958206 Change-Id: I66b1924d9ab0d49047a7ee3fe8d1b696b74ed726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637865Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#665171}
-
Yusuke Sato authored
This fixes a problem introduced in CL:1592713. Without this fix, 'storage-android-running-changed' is sent to JS only when either of the following happens: - AllowJavascript() is called. - ARC is fully started. - ARC shuts down. However, storage-android-running-changed's listener on the JS side is registered only after AllowJavascript() is called. Because of this, if the Settings app is launched in the following way, |androidRunning_| variable in storage.js remains false and the 'Android storage' link never shows up. 1. Sign in. 2. ARC is fully started. 3. Settings app is launched. |androidRunning_| variable is false at this point. 4. AllowJavascript() is called. 5. 'storage-android-running-changed' is sent to JS, BUT there's no listener. 6. The user moves to Devices > Storage management. 7. storage-android-running-changed's listener is registered. 8. The JS sends 'updateStorageInfo' to the C++ side, but the C++ handler doesn't fire storage-android-running-changed. This CL changes the C++ handler code so that HandleUpdateStorageInfo() fires storage-android-running-changed with the up to date ARC status. The C++ handler used to do that, but CL:1592713 removed it by mistake. This CL restores the code. BUG=968580 Change-Id: If1d0a6d1597bffcb37b82c1e4c44746c4c201106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637038 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665170}
-
Ben Pastene authored
This reverts commit ad780388. Reason for revert: "No tests matched by pattern(s) ..." eg: https://chromium-swarm.appspot.com/task?id=4527b399d8f02d10 And it didn't fail the task >.< Original change's description: > Skip 'dep:chrome_internal' Tast tests if we're not building w/ is_chrome_branded. > > So that no dep:chrome_internal tests are ran if they don't have the > needed internal bits. > > Bug: 947531 > Change-Id: I060734d2fe05c878d16f2c6a63815bd0abbb554c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637644 > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665158} TBR=derat@chromium.org,dpranke@chromium.org,nya@chromium.org,bpastene@chromium.org Change-Id: I87ec89cfa30237e543f2f3e1830eb7f2b284bd83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638290Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#665169}
-
Xiaoqian Dai authored
When we requeste a tab's mobile version site, we overwrite the user agent's OS to Android OS so that the site can use its mobile version layout. In this CL, when overwriting the user agent - Update the Android version from Android 4.0.3 to Android 9 - Add "Chrome tablet" into its OS string - Change product name from "Chrome" to "Chrome Mobile" to increase the likelihood of sites adopting the user agent and displaying the mobile version sites. Bug: 953577 Change-Id: Ib72bd7abb1fa05dbcf9861b1d4d7ff8552c1f01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637649 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#665168}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f06b81d4. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I137979642321ae8c6e8374dcb22d118b92c5b816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638190Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665167}
-
Sam Maier authored
Bug: 855796 Change-Id: If28592206e8eb5f985600b9932b81885a3baa01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634802Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#665166}
-
Owen Min authored
Add code 413 Payload too large. This error is returned when the request is too large, usually caused by report uploading requests. Add this error so that we could publish metrics and setup retry logic based on it. Any exist error handling code treat the new error same as DM_STATUS_HTTP_STATUS_ERROR so there is no behavior change. Bug: 959398 Change-Id: Id4e1c1a82558bc56d870cc247f88e343ef38a9ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632533Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665165}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e90041ab4516..0817a0661743 Created with: gclient setdep -r src-internal@0817a0661743 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:790671,chromium:790669,chromium:790667,chromium:790665,chromium:790663,chromium:790662 TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Id932cd57a61a0b9c2289a568733041458d85adab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665164}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=tbansal@chromium.org Change-Id: Ie838d9dd2023eae0874ab0e79b2db1c682e07c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635515Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665163}
-
Elly Fong-Jones authored
Bug: None Change-Id: I849081ba93afa98227350759af1191e01bfc6246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637053 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#665162}
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: I9860fcc880bc1c8a4ceaf94c80dddef69ce383aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637665Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#665161}
-
Lan Wei authored
In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. Here we are changing some pointerevent input tests which have touch scroll actions. This is the seventh CL that changes part of the pointerevent input tests. Bug: 606367 Change-Id: If83fe7b4490e88fa113b06bdcc9e07af7f734149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622456Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#665160}
-