GitLab

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/293883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271544 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374973

Review URL: https://codereview.chromium.org/291043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271542 0039d316-1c4b-4281-b951-d872f2087c98

Currently, overscroll notifications are always sent as a separate IPC message,
regardless of the causal event.  Instead, bundle the overscroll metadata with
the event ack if the event caused the overscroll, saving an IPC message in the
most common overscroll case.

BUG=328503

Review URL: https://codereview.chromium.org/281723010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271541 0039d316-1c4b-4281-b951-d872f2087c98

* Display the connection id correctly
* Display the number of packets sent, lost, and received
* Display the set of active stream ids

Review URL: https://codereview.chromium.org/293763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271539 0039d316-1c4b-4281-b951-d872f2087c98

Currently, navigations within the child frame remain attached to the child
frame while it signals the parent to change path and title. This doesn't quite
work because location.replace and history.replaceState affect all back/forward
list entries which reference that frame's history entry, rather than just the
current one.

Chrome is currently inconsistent about which of the two behaviors it
implements. Fix the settings page to not rely on the bug so it is future-proof.
Instead, when embedded, all pushState and replaceState calls are proxied up to
the parent which manages history for the child. The child converts all
pushState calls to replaceState calls locally.

This adds uber.setTitle, uber.replaceState, and uber.pushState calls along with
a popState message to uber_utils.js. When running standalone, they call the
standard equivalents. When running within the uber page, they delegate to the
parent as appropriate.

In doing so, this fixes places where chrome://settings-frame and
chrome://settings do not set the same URL and title the same. Notably on the
search page and treating the default "settings" page as having a path of ""
rather than "settings".

BUG=317614
TEST=Go to chrome://settings. Open 'Manage search engines...'. Press back.
     Press refresh. Should stay on search page.

Review URL: https://codereview.chromium.org/298553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271538 0039d316-1c4b-4281-b951-d872f2087c98

In the case where there is no 'view in webstore' link, place the version number on the following line. In the case where there is no version _or_ 'view in webstore' link, allow the title to take up multiple lines.

BUG=373053

Review URL: https://codereview.chromium.org/274443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337096
TEST=bots

Review URL: https://codereview.chromium.org/293673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271536 0039d316-1c4b-4281-b951-d872f2087c98

What this CL do:
 If there is an item at the drag's starting position and
the item is not selected, select the item.

Why this handling is needed:
 If the drag operation is initiated by mouse, the
'mousedown' event eventually selects the pointed item,
but there is no such chance when the drag operation is 
initiated by touch.

BUG=373839
TEST=manually tested

Review URL: https://codereview.chromium.org/288883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271535 0039d316-1c4b-4281-b951-d872f2087c98

Unstalled pending streams now check that a slot is still available, after posting.
A unit-test is added to detect regressions.

BUG=373858

Review URL: https://codereview.chromium.org/295823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374176

Review URL: https://codereview.chromium.org/298523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271533 0039d316-1c4b-4281-b951-d872f2087c98

UserScriptSlave was responsible for too much, and the logic was getting
cluttered (which also made changes in, e.g.
https://codereview.chromium.org/288053002/ difficult to read, write, and
review). Refactor the logic to inject the scripts into a new class, so that
UserScriptSlave is pretty much just responsible for containing them.

BUG=373961

Review URL: https://codereview.chromium.org/284153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271532 0039d316-1c4b-4281-b951-d872f2087c98

I've updated gypi files to not use internal_pdf variable anymore, which was brought in from pdf repo's supplemental.gypi.

R=thestig@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/294793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271531 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=trybot, manual.
NOTRY=True

Review URL: https://codereview.chromium.org/282303013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348761
NOTRY=true

Review URL: https://codereview.chromium.org/296663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271529 0039d316-1c4b-4281-b951-d872f2087c98

Prevent extensions with <all_urls> from executing scripts using executeScript()
without user consent if the scripts-require-action switch is on.
Coming up next: Content scripts.

BUG=362353

Review URL: https://codereview.chromium.org/286003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271528 0039d316-1c4b-4281-b951-d872f2087c98

When we sync tilings, we always expect to sync the high res
tiling. However, in situations where our minimum contents scale
prevents us from syncing the high res tiling, we should instead
reset the raster contents scale, since those would be invalid
as well. This also ensures that we will create a new high res
tiling when we call ManageTilings.

BUG=374143
R=enne

Review URL: https://codereview.chromium.org/294463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271527 0039d316-1c4b-4281-b951-d872f2087c98

This only existed for pseudo locale testing of bidi.  I don't think anyone
is actively testing this config, so remove it.  If needed for manual testing,
we could probably come up with a way that doesn't involve a flag (e.g.,
special way to build the pak file).

BUG=None

Review URL: https://codereview.chromium.org/291913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271526 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271525 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/292053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271524 0039d316-1c4b-4281-b951-d872f2087c98

Checks for missing config.json and discovery.json.
Fixed string constants.

NOTRY=true

Review URL: https://codereview.chromium.org/293833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271521 0039d316-1c4b-4281-b951-d872f2087c98

Other types (e.g., int32) aren't keywords, so it's a bit anomalous that
the specialized handle types are. (Insisting that they be keywords makes
adding future handle types more difficult, since doing so could break
existing .mojom files.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/295773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271519 0039d316-1c4b-4281-b951-d872f2087c98

This broke the same android tests that failed 2 out of 3 times on your presubmit
try jobs.

> Decouple RVH creation from CrossProcessFrameConnector.
> 
> The RenderViewHost creation today takes a CrossProcessFrameConnector pointer, which it uses to decide whether to create a top-level or child frame view. Replace this with a boolean and associate the CrossProcessFrameConnector with the view at a later point in time.
> 
> BUG=357747
> 
> Review URL: https://codereview.chromium.org/270883003

TBR=nasko@chromium.org

Review URL: https://codereview.chromium.org/295833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271516 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/299493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271515 0039d316-1c4b-4281-b951-d872f2087c98

This line is required for app manifests, so it should be in the sample
manifest in the tutorial.

BUG=374672
NOTRY=true

Review URL: https://codereview.chromium.org/293523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271513 0039d316-1c4b-4281-b951-d872f2087c98

R=aurimas@chromium.org

Review URL: https://codereview.chromium.org/285293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271512 0039d316-1c4b-4281-b951-d872f2087c98

The revert broke Windows interactive_ui_tests. The world has probably
changed since this was first committed.

WidgetTestInteractive.CanActivateFlagIsHonored

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/29193/steps/interactive_ui_tests/logs/stdio

> Revert of [Refactor] Consolidate the logic for whether a widget can be activated. (https://codereview.chromium.org/286733002/)
> 
> Reason for revert:
> This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095
> 
> I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable
> 
> Original issue's description:
> > [Refactor] Consolidate the logic for whether a widget can be activated.
> >
> > This is a first step towards giving tooltips their own WindowTreeHosts on Linux.
> >
> > BUG=353533
> > TEST=None
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597
> 
> Review URL: https://codereview.chromium.org/297503003

TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/291013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373841

Review URL: https://codereview.chromium.org/289063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271508 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348761,94925
NOTRY=true

Review URL: https://codereview.chromium.org/291993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271506 0039d316-1c4b-4281-b951-d872f2087c98

1. Take OAuth client ID in JSON
2. Use protocol from devsite (still needs work)

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/294793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271505 0039d316-1c4b-4281-b951-d872f2087c98

This is currently causing a top crasher; tfarina@ rebuilt on a branch
without this patch and have confirmed that reverting it fixes the crash.

Reverting at the request of the TPMs.

> Fix WebURLLoaderImpl::Context leak if a pending request is canceled.
> 
> Now, ResourceDispatcher::CancelPendingRequest will send
> ResourceHostMsg_CancelRequest and trigger OnRequestComplete. However,
> the request is pending and thus OnRequestComplete will be queued.
> 
> There are at least two problems if OnRequestComplete is not called:
> 1. WebURLLoaderImpl::Context will never be released.
> 2. request_info->buffer leaks. The buffer holds shared memory handle
>    (file descriptor). fd leaking may lead to HW video decode failure on
>    ChromeOS (detail in chrome-os-partner:27911#63)
> 
> This issue is similar to issue 328092.
> 
> BUG=chrome-os-partner:27911,chromium:369221,chromium:369128
> R=jam@chromium.org, mmenke@chromium.org
> 
> Review URL: https://codereview.chromium.org/268423002

BUG=372342
TBR=kcwu@chromium.org

Review URL: https://codereview.chromium.org/293823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369409

Review URL: https://codereview.chromium.org/293693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271503 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures. (https://codereview.chromium.org/274193004/)

Reason for revert:
This patch was landed speculatively due to the suspicion that the removal of the ScopedAllowIO was to blame for http://crbug.com/372017. The cause of that issue was found to lie elsewhere.

Original issue's description:
> Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures.
> 
> BUG=61827
> NOTRY=true
> NOTREECHECKS=true
> R=asanka@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269405

TBR=mef@chromium.org
BUG=61827

Review URL: https://codereview.chromium.org/292803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271502 0039d316-1c4b-4281-b951-d872f2087c98

Add test for SimpleGeolocation.

BUG=245075
TEST=none

Review URL: https://codereview.chromium.org/289313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271499 0039d316-1c4b-4281-b951-d872f2087c98

Also log bypass during via header checking and restart browser for each page.

BUG=374413

Review URL: https://codereview.chromium.org/292453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346957

Review URL: https://codereview.chromium.org/290053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271496 0039d316-1c4b-4281-b951-d872f2087c98

Will try to resolve soon.

BUG=374943
NOTRY=true
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/294773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271495 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/290703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271493 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=wjia@chromium.org

Review URL: https://codereview.chromium.org/298433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271491 0039d316-1c4b-4281-b951-d872f2087c98

Design Doc and Proposal here:
https://docs.google.com/a/google.com/document/d/1QWIzDvf_-iZJW8CINvhxzIERwwKeg72302hNUw0ZrSM/edit

This CL depends on https://codereview.chromium.org/275543005/

BUG=371966

Review URL: https://codereview.chromium.org/280023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271490 0039d316-1c4b-4281-b951-d872f2087c98