- 24 Jan, 2018 40 commits
-
-
Charles Harrison authored
Bug: 804347 Change-Id: Ibf66a09132c328da35c006e3a29472c20144c56f Reviewed-on: https://chromium-review.googlesource.com/879329Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#531709}
-
Ted Choc authored
Accidentally broken by this refactoring: https://chromium-review.googlesource.com/582338 Added tests to ensure the metric does not regress in the future. BUG=800625 Change-Id: Iae1e29d11f62f177cea1200fa24befa64b77f559 Reviewed-on: https://chromium-review.googlesource.com/879433 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#531708}
-
Lei Zhang authored
On some official build bots, r531606 causes a -Wunused-result error. BUG=805615 Change-Id: I0f4f51a6eb07d67f3b4c552af7d5f115b5852095 Reviewed-on: https://chromium-review.googlesource.com/884505 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#531707}
-
Lei Tian authored
BrowserActionActivity could be shown even FRE is not finished but if FRE is not finished, predefined item would not shown. It only shows the custom item which looks like fallback dialog. Bug: 801264 Change-Id: I1d723e413fa06a7cd28d897620ed22f986887a5f Reviewed-on: https://chromium-review.googlesource.com/875190 Commit-Queue: Lei Tian <ltian@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#531706}
-
Troy Hildebrandt authored
NewApi warnings were suppressed accidentally and an AssertionError constructor that requires API 19 was used. The NewApi warnings are back, so this fix avoids using the AssertionError and throws the exceptions as they are. Bug: 805509,803484 Change-Id: I1f342d06cb7e4e24ea816803d0e97dbeab6f59d9 Reviewed-on: https://chromium-review.googlesource.com/884385 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#531705}
-
Chris Kuiper authored
This address issues pointed out in the previous change. Additionally it tweaks the low-pass filter coefficients slightly and adds an additional logic to ignore timestamps that are clearly incorrect due to them deviating from the reference time by a large amount. Bug: [internal] b/72341571 Test: Running multizone certification test cases on a mix of speakers. Change-Id: I52cfdd88f4d1f989823cab791986a2bce6dd810c Reviewed-on: https://chromium-review.googlesource.com/883406Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#531704}
-
Xiaocheng Hu authored
This patch introduces the two helper functions as a preparation for crrev.com/c/882292, where we need to check if an inline fragment is the logically first/last leaf in its line to resolve caret position around line wrap. Bug: 771398 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I905ddc8923417da7178f8962db9c01e6fdf24754 Reviewed-on: https://chromium-review.googlesource.com/884381Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531703}
-
Richard Coles authored
This reverts commit 29f4d37f. Reason for revert: New test ContextCacheControllerTest.CheckSkiaResourcePurgeAPI is flaky on multiple android builders. See crbug.com/805575 Original change's description: > Use new Skia resource purging API when we go idle > > This avoids clearing some longer-lived Skia caches, hopefully avoiding > an UMA latency regression we experienced when the idle clearing was > initially added. > > R=danakj > TBR=brettw@chromium.org for DEPS change relying on third_party/skia. Got review from third_party/skia owner, bsalomon@. > > Bug: 664181 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I801f63b7b3ff6386303b582b7ae1f503425e1bb0 > Reviewed-on: https://chromium-review.googlesource.com/741454 > Reviewed-by: Brian Salomon <bsalomon@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530949} TBR=bsalomon@chromium.org,danakj@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 664181 Change-Id: Ia811c891f91965caa6a702839b6cf65fd482f366 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/883664 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#531702}
-
Mostyn Bramley-Moore authored
Change-Id: I019c3736a585dd384a1ccb6e1e9cb1613162a69d Reviewed-on: https://chromium-review.googlesource.com/883623Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#531701}
-
Allen Bauer authored
Add vertical image centering/top alignment to LabelButton. This allows radio buttons (and checkboxes) to align the image with the first line if the label is wrapped. Bug: 652031 Change-Id: I6c6ac29540c83367936547788eda76d2c659af4c Reviewed-on: https://chromium-review.googlesource.com/857332 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#531700}
-
Maks Orlovich authored
These were disabled in about 2012 for reasons I can't accurately dig up besides "fail on bots", but appear to pass now. Bug: 533640 Change-Id: I1e38839a4291af5c14c32200128fb1245c1cfcc0 Reviewed-on: https://chromium-review.googlesource.com/884005Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#531699}
-
Luna Lu authored
1. Added tests for header policy. a. document.policy shows correctly parsed policy b. local / remote iframes without allow attribute correctly inherit document.policy c. dynamically update allow attribute updates the policy correctly. 2. Added tests for nested policies. Bug: 732003 Change-Id: I869449f6bba89fc58997355df27249f403d76808 Reviewed-on: https://chromium-review.googlesource.com/796952 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#531698}
-
Artur Khachatryan authored
Added a comma at the end of the test name Change-Id: I1e08dc70aaf154d9576c4dba2972e5892ebafbec Reviewed-on: https://chromium-review.googlesource.com/884231Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#531697}
-
Reilly Grant authored
This patch removes the IsTrustedSpdyProxy method from net::ProxyDelegate and instead stores this information in the net::ProxyServer instance itself. Only proxy configurations built by the Data Reduction Proxy service (or in test) are marked with this flag. Bug: 721403 Change-Id: Iaf15263c476cdf32316f52d92d1df0c09c73a5bc Reviewed-on: https://chromium-review.googlesource.com/882221 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#531696}
-
Reza.Zakerinasab authored
This change refactors createImageBitmap drawImage layout tests to use testharness.js. Bug: 805048 Change-Id: Ifefcccfc149542e0329c1127183ac77d67ebc855 Reviewed-on: https://chromium-review.googlesource.com/881265Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#531695}
-
Joe Downing authored
Over the last few days we've seen several cases of {viz_}content_browsertests failing even when all of the retires pass. The reason for the failure is that the swarming bot cannot clean up the directory due to child process(es) still running. The one thing all of the failures have in common is that the initial run of TerminateOnServiceQuit timed out. Perhaps there is some additional clean up the test framework needs to do in this case. TBR=rockot@chromium.org BUG=804937 Change-Id: I6937c038f91f7b254ab7ad2b8005c94ca064a4ee Reviewed-on: https://chromium-review.googlesource.com/884230Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#531694}
-
Frank Barchard authored
Switch types to C99 int8_t etc Types are defined in basic_types.h Also optimizes I420ToAR30 26% faster 92e22cf Lint cleanup after C99 change CL f1c5345 Define basic_types backward compatible layer 7e38988 Switch to C99 types 13771ff basic_types.h - remove unused macros a11ffa1 NV12 format documentation added. 8af6ea4 I420ToAR30 in 1 step SSSE3 assembly Bug: 797347, libyuv:774, libyuv:751 Test: try bots passed for local libyuv build Change-Id: If1060f71882886c237a46e1bb7791e3f5f419073 Reviewed-on: https://chromium-review.googlesource.com/881922Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#531693}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d36082af. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/10801 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Iff7061d24daa51ddda9169e960360d9c79c3dd2f Reviewed-on: https://chromium-review.googlesource.com/883422 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531692}
-
Milko Leporis authored
This change adds missing parts of mips64r2 support. Bug: 800754 Change-Id: If37183b7c996effe28b7f687ca86ec7f11d90514 Reviewed-on: https://chromium-review.googlesource.com/860058 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#531691}
-
Troy Hildebrandt authored
NewApi warnings were suppressed accidentally and an AssertionError constructor that requires API 19 was used. The NewApi warning are back, so this fix avoids using the AssertionError, and throws the exceptions as they are. R=tedchoc@chromium.org Bug: 805509,803484 Change-Id: I35723261c6d72bdac08d0236dbb8e46d752e0bfb Reviewed-on: https://chromium-review.googlesource.com/883566Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#531690}
-
Erik Luo authored
Clicking in DevTools can open more links than renderer can. This CL restricts DevTools from opening external URLs that are for browser-debugging, such as 'chrome://crash'. Bug: 798096 Change-Id: Idc969ddf6da1a24c6aca172565fe80485fa4cc9d Reviewed-on: https://chromium-review.googlesource.com/862384Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#531689}
-
Tao Bai authored
Not reset handler until new autofill session is needed, this will keep the autofill session alive among the navigation and handle PROBABLY_FORM_SUBMITTED corretly. Also popup the SubmissionSource to Java side. Bug: 804635 Change-Id: I246ca3e6a8d9dc48f60f3bc90f6d20dcd0bd7a2d Reviewed-on: https://chromium-review.googlesource.com/879271Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#531688}
-
Wei Li authored
Add interfaces and functions to allow passing in and compositing contents from multiple frames in pdf compositor service. Each frame is identified by its global unique id (rph id and rfh id). Content id is a unique id within its process. Each frame may have oop subframes. The pdf compositor service will keep track of all the frame contents and their relationship. When all subframes are painted, the service can composite the entire frame and convert it into PDF format. Please refer document goo.gl/ACV6VM for more explanations. BUG=455764 Change-Id: I3213d9ae0ca85d0ea695dd13acb00938499aa73b Reviewed-on: https://chromium-review.googlesource.com/767912Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#531687}
-
Francois Doray authored
Bug: 667892 Change-Id: I59ba41ab12c7a29a7011a7dc6bca16b0daa38895 Reviewed-on: https://chromium-review.googlesource.com/881582 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#531686}
-
Henrik Grunell authored
Use base::nullopt instead of std::string() for Optional parameter in WebrtcAudioPrivateGetAssociatedSinkFunction. DCHECK was hit because of incorrect usage; fixed with this change. Bug: 804836 Change-Id: Ia09f9a6bc563b6468236fd821ade49e1cb8f0fa7 Reviewed-on: https://chromium-review.googlesource.com/883343Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#531685}
-
Alex Newcomer authored
Incorrect histogram suffix was used in histograms.xml In code we use "*.FromApp" || "*.NotFromApp" In histograms.xml we had "*ForApp" || "*.NotForApp" Bug: 805063 Change-Id: Icad5459e2aaf2b641e4a45e98163e658131c64ac Reviewed-on: https://chromium-review.googlesource.com/882123Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#531684}
-
Liquan (Max) Gu authored
Before we introduce CustomUserTiming, we need to ensure the edge cases behave the same between the old and the new API while the feature flag of the new API is off. Hereby, we identify the following use cases. As the start/end marks are in String type, when passing the following args, they are converted to respective Strings: {} -> '[object Object]' null -> 'null' 51.15 -> '51.15' This CL introduces some test cases to cover these behaviors. Bug: 758385 Change-Id: I4ad60f907f3d794309bee1d8e3ce4268e2e5f49f Reviewed-on: https://chromium-review.googlesource.com/883943 Commit-Queue: Liquan Gu <maxlg@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#531683}
-
Peter Boström authored
The remaining static code in use moves to PendingView. References are updated to use ManagePasswordsBubbleDelegateViewBase directly. Also removes SINGLE_VIEW_COLUMN_SET in favor of using a FillLayout and cleans up unreferenced ColumnSet enums. Bug: chromium:654115 Change-Id: I54d6ed26132388bd33c3e93e504ce153146f43ec Reviewed-on: https://chromium-review.googlesource.com/882161 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#531682}
-
Koji Ishii authored
This patch fixes NGPaintFragment::VisualRect for inline fragments. Incorrect VisualRect causes parts of fragments not being painted. Inline boxes with 'position: relative' is still incorrect. This patch includes tests, but disabled for now. The fix involes other parts of the code that it will be in a separate patch. 22 failures turn to pass. Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib101051642f1c4b91d8b13df0822bf55e1481c1b Reviewed-on: https://chromium-review.googlesource.com/882789 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#531681}
-
Navid Zolghadr authored
Bug: 778289 Change-Id: I65a3710f7b5728c44d714d4a43405ad78720edb2 Reviewed-on: https://chromium-review.googlesource.com/862258Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#531680}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d8c2020e..bcd1365c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I35fcc00217d722656a64bceb39da4b6213394474 Reviewed-on: https://chromium-review.googlesource.com/883723Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#531679}
-
Mostyn Bramley-Moore authored
Also, move some existing include guards closer to the top of the file. Change-Id: I7dda7da99fce2a82354fd5db5ef62bee01444bec Reviewed-on: https://chromium-review.googlesource.com/882322 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531678}
-
Daniel Nicoara authored
This was a hack to allow Ozone DRM build to run using the Intel mesa gbm platform. This is no longer used (since we're using minigbm on all DRM platform). Bug: None Test: Ran updated chrome on samus and verified it starts up. Change-Id: I352d5e07051b08151773a9b0a4b259e8f3d21cd2 Reviewed-on: https://chromium-review.googlesource.com/883969Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#531677}
-
Meredith Lane authored
ComputedAccessibleNode will have access to a snapshot of the accessibility tree stored in content/renderer via the AomAXTreeProvider. This provider is exposed to the ComputedAccessibleNode via Platform. BUG=792783 Change-Id: I7a715bbdb7ad30d542c8d1848b3f1a39d77f5ccd Reviewed-on: https://chromium-review.googlesource.com/848575 Commit-Queue: Meredith Lane <meredithl@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#531676}
-
Sebastien Marchand authored
The current definition ("Tabs.MaxWindowsInADay: The maximum number of windows opened at the same time over the course of a day") is a little bit confusing because it's not clear if this is tracking open events,or how many windows are existing in general, this CL clarify this. Bug: 720131 Change-Id: Ie1cf08d7b98719a7e393b8fcd366f8ee0bea9ffb Reviewed-on: https://chromium-review.googlesource.com/884326Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#531675}
-
Kevin McNee authored
We change uses of Function.prototype.call to the safe builtin $Function.call throughout guest view code. Bug: 803668 Change-Id: I43ddeafe4e39d0d5092e366496da6757ad322855 Reviewed-on: https://chromium-review.googlesource.com/879245Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#531674}
-
Justin Carlson authored
This cl does several things. First, It removes the PrinterDetector::Observer::OnPrinterScanComplete API hook. That hook exists because we expected zeroconf printer detection to take a non-trivial amount of time and we wanted to be able to enable some UI indication that we were still looking for printers until the scan was complete. However, it turns out that mdns/dns-sd traffic is all cached anyways by the ServiceDiscovery, so we get initial printers back for zeroconf almost instantly, making this hook pointless. Second, the Observer API is changed so that it no longer guarantees an OnPrintersFound callback to the caller after registration; instead the client observing printer change events is responsible for calling PrinterDetector::GetPrinters() to do the initial population of the printer list. This removes a lot of weird hacks to get thread safety right. This change also removes CupsPrintersManager::Start() and PrinterDetector::StartObservers(), as these are no longer needed to make startup safe. These calls were added out of concerns that we would encounter something like: (in class Foo's constructor): my_detector_->AddObserver(this); ->OBSERVER CALLBACK HAPPENS BEFORE Foo::Foo() IS FINISHED<- ...rest of Foo's constructor... However, this isn't a real problem for the API AFAICT. Since the observer callbacks are on the same sequence as the constructor, they can't start until after the constructor finishes, meaning this is a non-issue. I think. I would appreciate reviewers taking a bit of time to think this through and see if they also believe this is now safe without the Start() calls, as concurrency is sometimes hard to reason about. This cl also removes some tests around StartObservers() that are no longer relevant with the API changes. Bug: 754834 Change-Id: Ia2e4c34b82ddf99a7551756c2bc037889f52df5b Reviewed-on: https://chromium-review.googlesource.com/871660 Commit-Queue: Justin Carlson <justincarlson@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#531673}
-
Mostyn Bramley-Moore authored
Change-Id: I067ad9a11dd0b852ce8d0a7eb78a287682a686c4 Reviewed-on: https://chromium-review.googlesource.com/882402Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#531672}
-
Shridhar Sundarraj authored
Content unittests crash when they call RenderWidgetHostImpl::SubmitCompositorFrame because it calls renderer_compositor_frame_sink_->DidReceiveCompositorFrameAck(resources) that tries to dereference a nullptr (|receiver_|). In my change, I stub out |renderer_compositor_frame_sink_| with a mock in each failing content unittest, by replacing CompositorFrameSinkClientPtr (|renderer_compositor_frame_sink_|) with a CompositorFrameSinkClientPtr bound to MockCompositorFrameSinkClient. Bug: 795397 Change-Id: Ibb820023332c7c6d2203b6e48549043ec0aa638f Reviewed-on: https://chromium-review.googlesource.com/875013Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Shridhar Sundarraj <sundarrajs@google.com> Cr-Commit-Position: refs/heads/master@{#531671}
-
Victor Costan authored
Bug: 721516 Change-Id: I80ef1e4b11cb44019f2136c60d3bb05431fa7916 Reviewed-on: https://chromium-review.googlesource.com/883979Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#531670}
-