GitLab

NOTRY=True

Review URL: https://codereview.chromium.org/468393002

Cr-Commit-Position: refs/heads/master@{#289534}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289534 0039d316-1c4b-4281-b951-d872f2087c98

R=dtu@chromium.org, satyanarayana@google.com
BUG=396317

Review URL: https://codereview.chromium.org/463353002

Cr-Commit-Position: refs/heads/master@{#289533}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289533 0039d316-1c4b-4281-b951-d872f2087c98

Whenever a new notification is created, route it to an
extension/app that has notification provider permission.
Currently, if there's an app with notificationProvider
permission, notifications will go to both message center
and that app. In the future, when additional sections in
Chrome Settings is implemented, this will send notifications
to only one party based on the user's selection.

BUG=

Review URL: https://codereview.chromium.org/441753002

Cr-Commit-Position: refs/heads/master@{#289532}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289532 0039d316-1c4b-4281-b951-d872f2087c98

* The actual destruction will typically happen on a different thread.
* We'd like to suppress warnings about the OS "pipe" being broken (which
  it often will, because we kill processes rather than shut them down).
* We'd like to know if we're still sending stuff on the channel even
  though it's about to go away.

R=yzshen@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/472603002

Cr-Commit-Position: refs/heads/master@{#289531}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289531 0039d316-1c4b-4281-b951-d872f2087c98

This private API exposes more information about connected USB devices
than the public chrome.usb API. It is designed for use by WEBUI
components that wish to display information about connected to devices
to the user such as the dialog box shown by the proposed
chrome.usb.getUserSelectedDevices API.

BUG=346953

Review URL: https://codereview.chromium.org/463493006

Cr-Commit-Position: refs/heads/master@{#289530}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289530 0039d316-1c4b-4281-b951-d872f2087c98

This patch was reverted because it leaked memory on every
window title set. This changes the patch around to use
UTF-8 XTextProperties and to free allocated memory
afterwards.

"""
After chromium stop using gtk+ for Linux/X11 all not ASCII
character in window title start looks like garbage. This
patch fixes this issue, by using algorithm similar to
gtk+/Qt's way of setting window titles.
"""

BUG=378096
First Review URL: https://codereview.chromium.org/414413002

Review URL: https://codereview.chromium.org/464173002

Cr-Commit-Position: refs/heads/master@{#289529}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289529 0039d316-1c4b-4281-b951-d872f2087c98

Adds the configured data reduction proxies if any to the proxy info
for a request, if the data reduction proxy is enabled, the data
reduction proxies are not bypassed, and the proxy server returned
by the proxy info if the request is direct.

This change makes it possible for the data reduction proxy to
coexist with managed proxy configurations, instead of being
overwritten by them. The data reduction proxy may be disabled
via managed prefs if this behavior is not desired.

BUG=339237,339258

Review URL: https://codereview.chromium.org/449973002

Cr-Commit-Position: refs/heads/master@{#289528}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289528 0039d316-1c4b-4281-b951-d872f2087c98

Removing backslash that would cause JavaScript error.

BUG=383630

Review URL: https://codereview.chromium.org/474493003

Cr-Commit-Position: refs/heads/master@{#289527}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289527 0039d316-1c4b-4281-b951-d872f2087c98

Sandbox::AllowMetadataForPath() currently allow all metadata access due to
https://codereview.chromium.org/10539009/ made the for loop comparison
in Sandbox::AllowMetadataForPath() always false, when we actually only
want to allow access to the path and all its parent path until root.

Turn the for loop to a do/while loop instead as it's a better fit, also
add a test case for Sandbox::AllowMetadataForPath().

It should only affect component builds on OS X 10.6 and utility process
as no other process is using this mechanism.

Review URL: https://codereview.chromium.org/472513002

Cr-Commit-Position: refs/heads/master@{#289526}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289526 0039d316-1c4b-4281-b951-d872f2087c98

The DCHECK from AppsGridView::UpdateDragFromItem() is changed
to an early return. This is a valid codepath, because drag events
can still arrive from the AppListItemView after a drag is cancelled,
e.g., via Sync.

AppsGridViewTest.MouseDragWithFolderDisabled is updated to
include coverage for this codepath.

A DCHECK was also hit in UpdateDragFromReparentItem(). This was not
a valid code path. The problem was that the root grid view tried
to cancel only its "part" of the drag, rather than forwarding the
cancel request to the folder managing the drag.

AppListMainViewTest.MouseDragItemOutOfFolderWithCancel is added to
include coverage for this codepath.

BUG=402784
TEST=app_list_unittests

Review URL: https://codereview.chromium.org/466693002

Cr-Commit-Position: refs/heads/master@{#289525}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289525 0039d316-1c4b-4281-b951-d872f2087c98

Repeated keypress events seem to be coming from the core keyboard device for the internal keyboard. Amazingly, they seem to come from the correct device (for my external keyboard at least) so this patch may be all we need.

BUG=402868
TEST=Flip open device past 180 to enter touchview. Hold a key on keyboard. Key is not typed. External keyboard still works while in touchview.

Review URL: https://codereview.chromium.org/460093003

Cr-Commit-Position: refs/heads/master@{#289524}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289524 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371406, 392108
R=sky@chromium.org

Review URL: https://codereview.chromium.org/467673002

Cr-Commit-Position: refs/heads/master@{#289523}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289523 0039d316-1c4b-4281-b951-d872f2087c98

We are planning on turning on --enable-new-avatar-menu by default in M38. In this
brave new world, the avatar button is always in the top right corner of the browser,
for all platforms. Previously, on Windows this button lived on the left side.

To make sure that the new world is the one that looks the best, we should always
use the correct orientation for the avatars. This does mean that for people
with the flag turned off, that are using the old style avatar menu on Windows,
they will see the avatars mirror.

BUG=380611
TEST=Start Chrome on Windows with --enable-new-avatar-menu. The avatar in the
avatar bubble should have the same orientation as in chrome://settings.

Review URL: https://codereview.chromium.org/464603002

Cr-Commit-Position: refs/heads/master@{#289522}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289522 0039d316-1c4b-4281-b951-d872f2087c98

These are currently data members, but they are always the same.

This simplifies upcoming app list refactoring.

BUG=403647

Review URL: https://codereview.chromium.org/466293002

Cr-Commit-Position: refs/heads/master@{#289520}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289520 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402732

Review URL: https://codereview.chromium.org/463393002

Cr-Commit-Position: refs/heads/master@{#289519}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289519 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394842

Review URL: https://codereview.chromium.org/468303003

Cr-Commit-Position: refs/heads/master@{#289518}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289518 0039d316-1c4b-4281-b951-d872f2087c98

This CL is a pure refactor of app list search result icon sizes which were
previously constants scattered about the codebase. This CL puts the icon
size as a static function in SearchResult so that there is only one place
the size needs to be changed.

BUG=391348

Review URL: https://codereview.chromium.org/458983004

Cr-Commit-Position: refs/heads/master@{#289517}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289517 0039d316-1c4b-4281-b951-d872f2087c98

accessibility/deleting-iframe-destroys-axcache.html started to fail after this CL.
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/20592

> Ensure there's no layout pending before accessing WebAXObject from TestRunner.
> 
> It's not safe to call WebAXObject functions when there's a layout pending.
> Chrome never does this, it only calls WebAXObject from
> renderer_accessibility_complete, and it makes sure to update layout before
> accessing the accessibility tree.
> 
> TestRunner didn't have the same protections, so this just explicitly updates
> the layout before any accessibility call.
> 
> BUG=393829
> 
> Review URL: https://codereview.chromium.org/469803003

TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/464403003

Cr-Commit-Position: refs/heads/master@{#289515}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289515 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a static FrameTree::GloballyFindByID that can be used by to find a FrameTreeNode given a frame tree node id.

BUG=376082

Review URL: https://codereview.chromium.org/429603002

Cr-Commit-Position: refs/heads/master@{#289513}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289513 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401098
TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/473683003

Cr-Commit-Position: refs/heads/master@{#289512}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289512 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400617

Review URL: https://codereview.chromium.org/469883002

Cr-Commit-Position: refs/heads/master@{#289511}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289511 0039d316-1c4b-4281-b951-d872f2087c98

This appears to have broken gfx_unittests on iOS:

http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/17689

> Update iOS deployment target to 7.0
> 
> iOS 6 will no longer be supported.
> 
> Replaces deprecated sizeWithFont: with sizeWithAttributes: (adding a
> ceilf since according to the internet, the former rounds up, and the
> latter does not) to fix compilation.
> 
> BUG=402921
> 
> Review URL: https://codereview.chromium.org/463333002

TBR=stuartmorgan@chromium.org

Review URL: https://codereview.chromium.org/473883002

Cr-Commit-Position: refs/heads/master@{#289510}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289510 0039d316-1c4b-4281-b951-d872f2087c98

NOTE: This is a revival/continuation of https://codereview.chromium.org/333723004, which was started by another developer.

The cc:CopyOutputRequest object assumes the src_subrect region is
in DIP space.  Thus, all calling code should provide the same.

Fixed tests in render_widget_host_view_browsertest.cc that were
completing successfully, even though the implementation was broken
for the high DPI scenarios.

In addition, I updated a number of interface comments to clarify the
difference between src_subrect being in DIP coordinates versus the
dest_size being in physical pixel coordinates.

Dependent on: https://codereview.chromium.org/311253004 (landed at r276139)

BUG=397708,399349

Review URL: https://codereview.chromium.org/462173002

Cr-Commit-Position: refs/heads/master@{#289509}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289509 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Disable WebNavigationApiTest.OpenTab on Windows. (patchset #1 of https://codereview.chromium.org/464243002/)

Reason for revert:
underlying issue should be fixed

Original issue's description:
> Disable WebNavigationApiTest.OpenTab on Windows.
> 
> BUG=402943
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289215

TBR=joaodasilva@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=402943

Review URL: https://codereview.chromium.org/469223002

Cr-Commit-Position: refs/heads/master@{#289508}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289508 0039d316-1c4b-4281-b951-d872f2087c98

This small patch is just some layer tree host test changes from
https://codereview.chromium.org/134623005/ split out.  These are
useful even without those changes, so can land separately.

R=danakj@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/475533004

Cr-Commit-Position: refs/heads/master@{#289507}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289507 0039d316-1c4b-4281-b951-d872f2087c98

UserImageSyncObserver obtained profile in a strange and wrong way. Now it uses
GetProfileByUser.

BUG=NONE
TEST=manually

Review URL: https://codereview.chromium.org/474603002

Cr-Commit-Position: refs/heads/master@{#289506}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289506 0039d316-1c4b-4281-b951-d872f2087c98

This will help to investigate cases of Chrome running out of renderer
services on Android.

BUG=396568
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/464403002

Cr-Commit-Position: refs/heads/master@{#289505}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289505 0039d316-1c4b-4281-b951-d872f2087c98

* show ID when "Developer Mode" is checked

BUG=393670

Review URL: https://codereview.chromium.org/462273003

Cr-Commit-Position: refs/heads/master@{#289504}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239656

Review URL: https://codereview.chromium.org/287153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271719 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/460133002

Cr-Commit-Position: refs/heads/master@{#289503}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289503 0039d316-1c4b-4281-b951-d872f2087c98

RenderTextHarfBuzz will be enabled by default in the future, when the relevant bugs are fixed.

BUG=321868
R=msw

Review URL: https://codereview.chromium.org/469083002

Cr-Commit-Position: refs/heads/master@{#289502}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289502 0039d316-1c4b-4281-b951-d872f2087c98

Certain Android devices, as well as stylus and mouse inputs, may report zero
for the touch size. These sizes are used when constructing the rect for touch
handle insersection tests.  However, gfx::RectBase will always report false when
performing the intersection test if either rect is empty.  Add an appropriate
epsilon minimum touch size when forming the touch bounding box rect.

BUG=402795

Review URL: https://codereview.chromium.org/462163002

Cr-Commit-Position: refs/heads/master@{#289501}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289501 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289500}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289500 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/473843002

Cr-Commit-Position: refs/heads/master@{#289499}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289499 0039d316-1c4b-4281-b951-d872f2087c98

Use X509_chain_up_ref, EVP_PKEY_dup, and newly-added X509_up_ref
instead. Also RAII OpenSSLClientKeyStore.

BUG=none

Review URL: https://codereview.chromium.org/474663002

Cr-Commit-Position: refs/heads/master@{#289498}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396157

Review URL: https://codereview.chromium.org/427673006

Cr-Commit-Position: refs/heads/master@{#289497}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289497 0039d316-1c4b-4281-b951-d872f2087c98

Make "Join other network dialog" and "Join mobile network dialog" opens properly on multiple signin screen

BUG=397100

Review URL: https://codereview.chromium.org/443673002

Cr-Commit-Position: refs/heads/master@{#289496}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289496 0039d316-1c4b-4281-b951-d872f2087c98

Nexus10 is currently timing out before rendering the first frame of
filter_terrain.svg. By extending the test from 5 to 10 seconds, we
should give it more of a chance to render. This should also reduce
noise on the other platforms.

R=dtu@chromium.org
BUG=402884

Review URL: https://codereview.chromium.org/462143002

Cr-Commit-Position: refs/heads/master@{#289495}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289495 0039d316-1c4b-4281-b951-d872f2087c98

BUG=235037

Review URL: https://codereview.chromium.org/465393002

Cr-Commit-Position: refs/heads/master@{#289494}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289494 0039d316-1c4b-4281-b951-d872f2087c98

This caused a compile failure on the Chrome OS bots:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/50095/steps/compile/logs/stdio

> Test that simulates touch exploration and checks speech on tabs and also the empty bookmark bar.
> 
> BUG=393768, 395895
> 
> Review URL: https://codereview.chromium.org/447893003

TBR=evy@chromium.org

Review URL: https://codereview.chromium.org/463373005

Cr-Commit-Position: refs/heads/master@{#289493}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289493 0039d316-1c4b-4281-b951-d872f2087c98

This caused failures on the Linux ASan bot:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/6417/steps/cc_unittests/logs/DelegatingRendererWithTileOOM

> Still produce quad when tile OOM and on demand raster is not allowed
> 
> When on demand raster is not allowed, when tiles are OOM, checkerboard
> or solid color quad should be produced rather than nothing.
> 
> Add a unittest for this exact same scenario.
> 
> BUG=402321
> 
> Review URL: https://codereview.chromium.org/468983002

TBR=weiliangc@chromium.org

Review URL: https://codereview.chromium.org/473813002

Cr-Commit-Position: refs/heads/master@{#289492}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289492 0039d316-1c4b-4281-b951-d872f2087c98