GitLab

BUG=428729

Review URL: https://codereview.chromium.org/966913003

Cr-Commit-Position: refs/heads/master@{#318705}

This CL adds two more Android instrumentation tests for Web Notifications,
which verify that the "tag" property on a notification will replace any
previous notification being shown, and a test verifying that activating
the notification will invoke the Service Worker, closing the notification.

BUG=462251

Review URL: https://codereview.chromium.org/958993002

Cr-Commit-Position: refs/heads/master@{#318704}

It was never really taken into use (it was meant to be used by external tools
but we never figured out how they should interact w/ Telemetry) and it's out of
date.

BUG=274456
R=skyostil@chromium.org

Review URL: https://codereview.chromium.org/962673002

Cr-Commit-Position: refs/heads/master@{#318703}

BUG=463111

Review URL: https://codereview.chromium.org/968973002

Cr-Commit-Position: refs/heads/master@{#318702}

Update the list of included unit tests on iOS to list all the components
that are built on iOS (based on the list in components/components.gyp).
Use an exclusion to remove all tests that depends on //content.

Sort the list of gypi files included by components.gyp.

BUG=462585

Review URL: https://codereview.chromium.org/963683003

Cr-Commit-Position: refs/heads/master@{#318701}

UmaSessionStats is primarily for tracking metrics pertaining to the
length of a user-session in chrome (from start/resume to pause) but
also tracks some usage during the session.

BUG=428903

Review URL: https://codereview.chromium.org/962293002

Cr-Commit-Position: refs/heads/master@{#318700}

BUG=460949
R=primiano@chromium.org

Review URL: https://codereview.chromium.org/972673002

Cr-Commit-Position: refs/heads/master@{#318699}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/db873d8..3da9181

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/971743002

Cr-Commit-Position: refs/heads/master@{#318698}

BUG=461282

Committed: https://crrev.com/c3a3f671f8e0c5777c6bc825f21d61c6bcafbec3
Cr-Commit-Position: refs/heads/master@{#318666}

Review URL: https://codereview.chromium.org/952853002

Cr-Commit-Position: refs/heads/master@{#318697}

This achieves a couple of goals:
1) Upstreams MemoryUma
2) Pulls it up from ChromeTabbedActivity (internal) to
AsyncInitializationActivity. This ensures that other activities (e.g.
DocumentActivity) also report memory warnings.
3) Instantiate MemoryUma!! This was broken in
https://chrome-internal-review.googlesource.com/161577 so low-memory
warnings haven't been reported since M35! :(

BUG=428903

Review URL: https://codereview.chromium.org/961323003

Cr-Commit-Position: refs/heads/master@{#318696}

HELLO_IMPLEMENTATION was a typo in the no-win condition.

The correct is to check if HELLO_SHARED_IMPLEMENTATION was defined,
as that is what is defined by //tools/gn/example:hello_shared target.

BUG=None
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/966333006

Cr-Commit-Position: refs/heads/master@{#318695}

This can be landed once the interface change has been made in WebRTC and rolled into Chromium (see here: https://webrtc-codereview.appspot.com/40139004/).

BUG=webrtc:2822

Review URL: https://codereview.chromium.org/875483002

Cr-Commit-Position: refs/heads/master@{#318694}

BUG=461854
TEST=manual

Review URL: https://codereview.chromium.org/971733002

Cr-Commit-Position: refs/heads/master@{#318693}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d06ecdb..2ea3d3a

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/963493003

Cr-Commit-Position: refs/heads/master@{#318692}

BUG=459678
R=noyau@chromium.org

Review URL: https://codereview.chromium.org/972683002

Cr-Commit-Position: refs/heads/master@{#318691}

When using multiple BrowserState (think saving and incognito), each one
has a different path to stored data on iOS. In order to avoid confusion
with chrome Profile change the name of the method returning the path of
a BrowserState to GetStatePath().

BUG=None

Review URL: https://codereview.chromium.org/964403002

Cr-Commit-Position: refs/heads/master@{#318690}

Cr-Commit-Position: refs/heads/master@{#318689}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/724429b..d06ecdb

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/964213006

Cr-Commit-Position: refs/heads/master@{#318688}

This CL adds GPU benchmarking API for drag function as next step in
adding synthetic drag feature for telemetry tests.

The part 1 of the CL can be found at crrev.com/929333002

BUG=457148

Review URL: https://codereview.chromium.org/942133002

Cr-Commit-Position: refs/heads/master@{#318687}

This CL adds support for navigating to data urls in browser-side navigation mode. This is a prerequisite to showing error pages when browser-side navigation is enabled.

BUG=459033

Review URL: https://codereview.chromium.org/906283003

Cr-Commit-Position: refs/heads/master@{#318686}

BUG=461624
TBR=jaekyun@chromium.org,sievers@chromium.org,wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/964383003

Cr-Commit-Position: refs/heads/master@{#318685}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f595d7d..724429b

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/968893002

Cr-Commit-Position: refs/heads/master@{#318684}

WebRTC 8543:8548
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/093c83b..1e5b7f7

Libjingle 8542:8550
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/fbd8fd2..bbfd399

TBR=

Review URL: https://codereview.chromium.org/972633002

Cr-Commit-Position: refs/heads/master@{#318683}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8b33fa60..c791d841

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/969743002

Cr-Commit-Position: refs/heads/master@{#318682}

BUG=463041
TBR=jaekyun@chromium.org

Review URL: https://codereview.chromium.org/966413002

Cr-Commit-Position: refs/heads/master@{#318681}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e9fa41a..f595d7d

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/965373002

Cr-Commit-Position: refs/heads/master@{#318680}

BUG=456016
TEST=manually tested; Edit some file in list view and see the thumbnail is updated with transition animation.

Review URL: https://codereview.chromium.org/954373003

Cr-Commit-Position: refs/heads/master@{#318679}

BUG=none

Review URL: https://codereview.chromium.org/953413003

Cr-Commit-Position: refs/heads/master@{#318678}

It looks it's no longer used in any production code.

BUG=n/a
TEST=compile

Review URL: https://codereview.chromium.org/964353002

Cr-Commit-Position: refs/heads/master@{#318677}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/627ffe9a..8b33fa60

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/965383002

Cr-Commit-Position: refs/heads/master@{#318676}

Previously FileSystemMetadata has multiple providers, and it switches the
providers depends on Entry state. e.g. If the entry is dirty, it uses
ContentProvider instead of ExternalProvider.

Previously each provider cached its result but they shared single
MetadataProviderCache instance. Thus if ExternalProvider returns values that are
out of sync, the values are cached and ContentProvider is never called.

The CL extracts the caching part of NewMetadataProvider as
CachedMetadataProvider wrapper class. And let it switch providers before
caching.

BUG=410766
TEST=FileManagerJsTest.*Metadata*

Review URL: https://codereview.chromium.org/971653003

Cr-Commit-Position: refs/heads/master@{#318675}

Revert of Remove dependency on //components/feedback on iOS (patchset #1 id:1 of https://codereview.chromium.org/954943004/)

Reason for revert:
This CL cause the test to run in another order, causing a hidden dependency on the ordering to be visible. Reverting as this cause test failures.

See http://crbug.com/462352

Original issue's description:
> Remove dependency on //components/feedback on iOS
>
> iOS does not use //components/feedback to report feedback so remove
> the unused dependencies.
>
> BUG=None
>
> Committed: https://crrev.com/3e96329f442c10d73174688a4786ab847a49a37f
> Cr-Commit-Position: refs/heads/master@{#318211}

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/968653004

Cr-Commit-Position: refs/heads/master@{#318674}

This patch actually fixes three different issues, as I could not separate the
updated tests in a meaningful way.

1. CheckDispatchVisitor needs to look for UnresolvedMemberExpr*, since inlined
tracing introduces unresolved member references.

This visitor looks at every function call within a trace dispatching method,
and returns whether there is a call delegating to the class in question. We
need to take care of UnresolvedMemberExpr* cases in addition to MemberExpr*.

2. RecordInfo::DetermineTracingMethods() should return traceImpl() instead of
trace() as trace_dispatch_method_.

The plugin inspects the definition of trace_dispatch_method_ in order to detect
missing or inappropriate delegation to subclasses. Therefore, the method should
be something that has actual delegation calls in its body (i.e. traceImpl())
instead of a trampoline stub (i.e. trace()).

3. A silly typo in Config::GetTraceMethodType(). Really silly. Not sure why
I did this way.

This patch comes with updated tests for traceAfterDispatchImpl(). Now the tests
are more closer to real cases, using traceImpl to implement trace dispatching.

BUG=462511
R=kouhei@chromium.org
CC=zerny@chromium.org, oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/968143002

Cr-Commit-Position: refs/heads/master@{#318673}

BUG=461476

Review URL: https://codereview.chromium.org/962213002

Cr-Commit-Position: refs/heads/master@{#318672}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ed228f8..e9fa41a

TBR=

Review URL: https://codereview.chromium.org/964273003

Cr-Commit-Position: refs/heads/master@{#318671}

Not registering them broke voice search for supervised users, because the corresponding extension comes from one of these providers.
It also resulted in inconsistent behavior for child accounts, where the providers would exist after the first sign-in, but not after the next browser restart.

BUG=458096,397951

Review URL: https://codereview.chromium.org/955683002

Cr-Commit-Position: refs/heads/master@{#318670}

Revert of Wallpaper manager now observing user child user status to update default wallpaper. (patchset #2 id:20001 of https://codereview.chromium.org/952853002/)

Reason for revert:
MultiUserNotificationBlockerChromeOSTest is failing after this CL (see issue 463049).

Original issue's description:
> Wallpaper manager now observing user child user status to update default wallpaper.
>
> BUG=461282
>
> Committed: https://crrev.com/c3a3f671f8e0c5777c6bc825f21d61c6bcafbec3
> Cr-Commit-Position: refs/heads/master@{#318666}

TBR=bshe@chromium.org,skuhne@chromium.org,merkulova@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=461282

Review URL: https://codereview.chromium.org/966333004

Cr-Commit-Position: refs/heads/master@{#318669}

BUG=

Review URL: https://codereview.chromium.org/959303002

Cr-Commit-Position: refs/heads/master@{#318668}

BUG=456779
TBR=keybuk@chromium.org

Review URL: https://codereview.chromium.org/913773002

Cr-Commit-Position: refs/heads/master@{#318667}

BUG=461282

Review URL: https://codereview.chromium.org/952853002

Cr-Commit-Position: refs/heads/master@{#318666}