GitLab

BUG=452643

Review URL: https://codereview.chromium.org/886583005

Cr-Commit-Position: refs/heads/master@{#314635}

UploadFileElementReader relies on checking the modified time of files
being uploaded to determine if a sliced file was modified during upload.
Clients of the net stack (in particular Blink) currently pass around the
expected modified time in a manner which cause the timestamp to lose
precision (E.g. converting to and from a double time_t).

As a result the expected timestamp and the current timestamp as returned
by GetFileInfo() will not match exactly. Current code attempted to
compensate for this by converting both timestamps to (integer) time_t.
However, since the conversion rounds down, this check would only succeed
if the loss of precision of the expected timestamp also caused it to
round down. This is not always the case. (E.g. (epoch + 10.999999) will
become 10 when converted to time_t, but the expected timestamp may have
rounded up to (epoch + 11.0) in the meantime.)

This patch compares the timestamps by checking if the magnitude of the
difference is less than one second.

BUG=426465
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg,mac_blink_rel,win_blink_rel
R=mmenke

Committed: https://crrev.com/b77c8ffae588001875fb50ead987a147ca882bdb
Cr-Commit-Position: refs/heads/master@{#314397}

Reverted: https://crrev.com/7ccf4fab5d4473e431f1a289056033eea0b3dd43
Cr-Commit-Position: refs/heads/master@{#314451}

Review URL: https://codereview.chromium.org/868253012

Cr-Commit-Position: refs/heads/master@{#314634}

This removes another source of raw process handles.

BUG=417532

Review URL: https://codereview.chromium.org/868543002

Cr-Commit-Position: refs/heads/master@{#314633}

Do not re-set the root layer for the ui::Compositor when suspending the
browser compositor view. Prior to moving the ui::Compositor to use the
scheduler, this would prevent frames from appearing. Now it causes blank
flashes.

There are still blue (debug) flashes when returning from fullscreen and
when the GPU process is killed. These still need to be fixed.

BUG=454682

Review URL: https://codereview.chromium.org/903543002

Cr-Commit-Position: refs/heads/master@{#314632}

Revert of Introduce HostID and de-couple Extensions from "script injection System" [browser side] (patchset #20 id:760001 of https://codereview.chromium.org/822453002/)

Reason for revert:
It might cause the crash https://code.google.com/p/chromium/issues/detail?id=454917.

Original issue's description:
> Introduce HostID and de-couple Extensions from "script injection System" [browser side]
>
> The major refactor includes:
> - Introduce HostID (a pair of |id, type|) to replace extension_id in browser
>   side.
> - Abstract UserScriptLoader to be a base class, and introduces
>   a derived class ExtensionUserScriptLoader which is
>   responsible for loading user scripts for extensions.
> - In DeclarativeUserScriptManager, a master is created per
>   extension/webUI.
> - DeclarativeUserScriptManager becomes an
>   ExtensionRegistryObserver and is responsible for clearing scripts
>   for master objects when receive OnExensionUnloaded event.
>
> BUG=437566
>
> Committed: https://crrev.com/b88fe3dc1072501bdd105fd95a8b3bc453fd2aa7
> Cr-Commit-Position: refs/heads/master@{#313402}

TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437566

Review URL: https://codereview.chromium.org/899983002

Cr-Commit-Position: refs/heads/master@{#314631}

Revert of Reland Ensure WebView notifies desktop automation on creation, destruction, and change (patchset #5 id:80001 of https://codereview.chromium.org/895623003/)

Reason for revert:
Seeing intermittent failures on vox tests after this patch

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/55807

BackgroundTest.InitialFeedback
BackgroundTest.ContinuousRead
BackgroundTest.CaretNavigation

Original issue's description:
> Reland Ensure WebView notifies desktop automation on creation, destruction, and change
>
> Original issue https://codereview.chromium.org/880063002
>
> TBR=dtseng@chromium.org
>
> Committed: https://crrev.com/4a61275d7b2708d4aca1e1c4975739424a379fc3
> Cr-Commit-Position: refs/heads/master@{#314378}

TBR=dtseng@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/897103002

Cr-Commit-Position: refs/heads/master@{#314630}

This matches other webui dialogs' (settings) behavior by setting initial
focus when a dialog is shown.

To fully match we need to also restore focus when the dialog is closed,
which we'll do when it's easier (i.e. when the page isn't totally
rebuilt all the time).

BUG=438301
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/900623003

Cr-Commit-Position: refs/heads/master@{#314629}

Review URL: https://codereview.chromium.org/892403003

Cr-Commit-Position: refs/heads/master@{#314628}

There is no callers for this anymore. Remove it and all the
unnecessary code.

BUG=

Review URL: https://codereview.chromium.org/898543002

Cr-Commit-Position: refs/heads/master@{#314627}

Now that fractional scroll offset can pass through cc main
thread and Blink, we can remove the scroll_delta flooring hack
and send the full fractional scroll_delta from impl to main.

Note that this will break the old pinch viewport code path (
which is to be removed soon) since it still only expects integer
scroll offset.

BUG=414283

Review URL: https://codereview.chromium.org/870363005

Cr-Commit-Position: refs/heads/master@{#314626}

This change adds the selectClientCertificates() and subtleCrypto() functions and is missing the getKeyPair() function.
It is also missing the certificate permissions per extension and any UI changes.

BUG=450167

Review URL: https://codereview.chromium.org/875373002

Cr-Commit-Position: refs/heads/master@{#314625}

da0df3f  Fix gyp failure on linux asan trybots.

BUG=428057
TBR=glider

Review URL: https://codereview.chromium.org/904473003

Cr-Commit-Position: refs/heads/master@{#314624}

The default is to support all toolchains. Do this
for several core libraries. This mostly affects
mac for which these libraries were previously not
being built.

This change allows for the addition of nacl-clang
or other toolchain without needing to change all
the core dsc files.

BUG=454962

Review URL: https://codereview.chromium.org/886583004

Cr-Commit-Position: refs/heads/master@{#314623}

Revert of Device Orientation API on Chrome OS (patchset #8 id:200001 of https://codereview.chromium.org/856123002/)

Reason for revert:
Compilation failure on CQ:

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20ChromeOS%20MSan%20Builder/builds/1666/steps/compile/logs/stdio

Original issue's description:
> Device Orientation API on Chrome OS
>
> Implement DataFetcherSharedMemory on Chrome OS to provide Device Orientation support. Create SensorManagerChromeOS to observe accelerometer events, and to generate updates to the Device Orientation API.
>
> This is a follow up to: https://codereview.chromium.org/680383007/
>
> With the accelerometer on Chrome OS now exposed to content/ from chromeos/accelerometer, no ash/ implementation is required. No public api in content/public/browser is needed either.
>
> TEST=SensorManagerTest.OrientationBuffer, SensorManagerTest.NeutralOrientation, SensorManagerTest.UpsideDown, SensorManagerTest.BeforeUpsideDownBoundary, SensorManagerTest.LeftEdge, SensorManagerTest.RightEdge, SensorManagerTest.BeforeRightEdgeBoundary
> BUG=342908
>
> Committed: https://crrev.com/e717460964dd27a7239abec31462441eb971edbe
> Cr-Commit-Position: refs/heads/master@{#314605}

TBR=timvolodine@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=342908

Review URL: https://codereview.chromium.org/899973002

Cr-Commit-Position: refs/heads/master@{#314622}

The CL adds support for print destinations managed by extensions (using
chrome.printerProvider API) to print preview.
These destinations are added to local printers list with the icon set to
the extension icon, but that will probably be changed before the API
goes to stable.

Also, this does not implement print requests for these destinations, so
the 'Print' button is disabled for them.

BUG=408772

Review URL: https://codereview.chromium.org/900503002

Cr-Commit-Position: refs/heads/master@{#314621}

Thank you for your contributions!

TBR=vrk@chromium.org,bemasc@chromium.org

Review URL: https://codereview.chromium.org/895143002

Cr-Commit-Position: refs/heads/master@{#314620}

BUG=455002

Review URL: https://codereview.chromium.org/897933002

Cr-Commit-Position: refs/heads/master@{#314619}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/884213005

Cr-Commit-Position: refs/heads/master@{#314618}

BUG=454978

Review URL: https://codereview.chromium.org/861043003

Cr-Commit-Position: refs/heads/master@{#314617}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1a481fe..f162012

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/874073003

Cr-Commit-Position: refs/heads/master@{#314616}

This CL makes "timezone auto update" feature available (but switched off by
default) to users. And adds flag to disable this feature.

BUG=416494
TEST=manual

Review URL: https://codereview.chromium.org/898503002

Cr-Commit-Position: refs/heads/master@{#314615}

Not all devices support GPU Tracing, but it is still useful to
be able run a trace test which tests whether or not traces are
properly plumbed all the way through the stack.

This CL separates out trace tests into 2 different tests, the
original "trace_test" only tests the CPU side and does not test
anything on the GPU. The "device_trace_test" will be used to test
whether or not GPU traces are working properly on devices which
support it.

Currently the device trace test is set to skip unconditionally.
Once we have the recipes set up to run the "device_trace_test" we
can enable this for devices that support it.

BUG=455324
TEST=trybots

Review URL: https://codereview.chromium.org/874023003

Cr-Commit-Position: refs/heads/master@{#314614}

Removes all image data associated with the bookmark, and sets the
user_removed_image flag so the server won't attempt to set a new image
for the bookmark.

BUG=434436

Review URL: https://codereview.chromium.org/891873002

Cr-Commit-Position: refs/heads/master@{#314613}

BUG=453844

Review URL: https://codereview.chromium.org/896303002

Cr-Commit-Position: refs/heads/master@{#314612}

A follow up CL will make use of this flag to enable the chrome://md-settings/ url for the new settings page.

BUG=454961

Review URL: https://codereview.chromium.org/895163002

Cr-Commit-Position: refs/heads/master@{#314611}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/884103004

Cr-Commit-Position: refs/heads/master@{#314610}

Reason for revert:
Android Webview AOSP Builder fail to compile after this patch.

invalid resource directory name: out/target/product/generic/obj/GYP/shared_intermediates/android_webview_jarjar_content_resources/jarjar_res OWNERS

Sample failing build:
http://build.chromium.org/p/chromium.linux/builders/Android%20Webview%20AOSP%20Builder/builds/17566

Original issue's description:
> Add more OWNERs to content/public/android
>
> BUG=None
> NOTRY=true

> Committed:
> https://crrev.com/680879373111af996eb06886910a58af5c7538ca
> Cr-Commit-Position: refs/heads/master@{#314598}

TBR=aurimas
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/896183004

Cr-Commit-Position: refs/heads/master@{#314609}

Revert of [OSX] Allow one zoom bubble to override another. (patchset #1 id:1 of https://codereview.chromium.org/886883002/)

Reason for revert:
Causes window flickering:
https://code.google.com/p/chromium/issues/detail?id=455184

Original issue's description:
> [OSX] Allow one zoom bubble to override another.
>
> At present, if a user changes zoom on OSX while the zoom bubble is
> already being shown, the new zoom bubble (with the most up to date
> information) is not shown. This CL changes this behaviour by allowing
> a new zoom bubble to be created, and replace the existing one.
>
> Example: load a PDF and repeatedly click the zoom +/- controls in the
> lower-right corner of the viewer.
>
> BUG=444995
>
> Committed: https://crrev.com/84567ceada9f89c8e962d18ab494b1d1bb5a3830
> Cr-Commit-Position: refs/heads/master@{#314147}

TBR=rohitrao@chromium.org,wjmaclean@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444995

Review URL: https://codereview.chromium.org/897923002

Cr-Commit-Position: refs/heads/master@{#314608}

We need to export everything that is used by the tests and fix the test
target to depend on //ui/ozone instead of directly on the platform
source_set. The latter builds a copy of the platform directly into the
test binary, creating unresolved references to other parts of
//ui/ozone.

BUG=445627
TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' &&
  ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes)

Review URL: https://codereview.chromium.org/886323004

Cr-Commit-Position: refs/heads/master@{#314607}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=torne@chromium.org

Review URL: https://codereview.chromium.org/882883007

Cr-Commit-Position: refs/heads/master@{#314606}

Implement DataFetcherSharedMemory on Chrome OS to provide Device Orientation support. Create SensorManagerChromeOS to observe accelerometer events, and to generate updates to the Device Orientation API.

This is a follow up to: https://codereview.chromium.org/680383007/

With the accelerometer on Chrome OS now exposed to content/ from chromeos/accelerometer, no ash/ implementation is required. No public api in content/public/browser is needed either.

TEST=SensorManagerTest.OrientationBuffer, SensorManagerTest.NeutralOrientation, SensorManagerTest.UpsideDown, SensorManagerTest.BeforeUpsideDownBoundary, SensorManagerTest.LeftEdge, SensorManagerTest.RightEdge, SensorManagerTest.BeforeRightEdgeBoundary
BUG=342908

Review URL: https://codereview.chromium.org/856123002

Cr-Commit-Position: refs/heads/master@{#314605}

BUG=393291

Review URL: https://codereview.chromium.org/896673005

Cr-Commit-Position: refs/heads/master@{#314604}

BUG=455070
TEST=manual, according to steps in bug.

Review URL: https://codereview.chromium.org/893383002

Cr-Commit-Position: refs/heads/master@{#314603}

Revert of Update geolocation permission tests for the permission bubble (patchset #18 id:340001 of https://codereview.chromium.org/787033004/)

Reason for revert:
Getting intermittent failures in GeolocationBrowserTest after this patch

Failing build:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/35949/steps/browser_tests

Output:
GeolocationBrowserTestWithParams/GeolocationBrowserTest.NoLeakFromOffTheRecord/1 (run #1):
[ RUN      ] GeolocationBrowserTestWithParams/GeolocationBrowserTest.NoLeakFromOffTheRecord/1
[3952:1032:0204/052930:WARNING:data_reduction_proxy_settings.cc(345)] SPDY proxy OFF at startup
[3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(156)] LegacyRenderWidgetHostHWND::OnGetObject message=61 w_param=0 l_param=-12 obj_id=4294967284 host_=00000000
[3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(129)] LegacyRenderWidgetHostHWND::Init hwnd=04CF00A6
[3952:1032:0204/052930:WARNING:geolocation_browsertest.cc(383)] before navigate
[3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(156)] LegacyRenderWidgetHostHWND::OnGetObject message=61 w_param=0 l_param=-12 obj_id=4294967284 host_=00000000
[3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(129)] LegacyRenderWidgetHostHWND::Init hwnd=08B500B0
[3952:1032:0204/052931:WARNING:geolocation_browsertest.cc(398)] after navigate
[3952:1032:0204/052931:WARNING:geolocation_browsertest.cc(234)] will add geolocation watch for bubble
[3952:1032:0204/052931:WARNING:geolocation_browsertest.cc(201)] javascript_response 1
[3952:3868:0204/052931:WARNING:embedded_test_server.cc(248)] Request not handled. Returning 404: /favicon.ico

Output not very helpful here, but perhaps it makes sense to a non-sheriff.

Original issue's description:
> Update geolocation permission tests for the permission bubble
>
> This makes the geolocation permission tests run for both infobars and
> permission bubbles. The tests now run as parameterized tests.
>
> Supercedes parts of:
> https://codereview.chromium.org/411503005/
> https://codereview.chromium.org/341833004/
>
> BUG=438758
>
> Committed: https://crrev.com/f57c61952870c6027dbf220eff8b2d703bfed3c8
> Cr-Commit-Position: refs/heads/master@{#314541}

TBR=mvanouwerkerk@chromium.org,timvolodine@google.com,markusheintz@chromium.org,felt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=438758

Review URL: https://codereview.chromium.org/902643003

Cr-Commit-Position: refs/heads/master@{#314602}

This file was deprecated by corresponding apptests and was deleted in
https://codereview.chromium.org/722943004 .

It was accidentally ressurected when moving the network service
source-of-truth to Chromium - we carried over modifications and new
files, but didn't carry over deletions of whole files.

BUG=450356

Review URL: https://codereview.chromium.org/894093003

Cr-Commit-Position: refs/heads/master@{#314601}

This simplifies the code some by eliminating google_profile_helper entirely, and
ensures that everyone who is trying to construct a "search URL" will correctly
respect things like the command-line Google base URL override switch.

This also moves some related code from URLRequestMockHTTPJob into its lone
caller and stops assuming that the search URL scheme is always HTTP.

BUG=364183
TEST=none

Review URL: https://codereview.chromium.org/896943002

Cr-Commit-Position: refs/heads/master@{#314600}

BUG=453844
R=kelvinp@chromium.org, mmoss@chromium.org

Review URL: https://codereview.chromium.org/902583003

Cr-Commit-Position: refs/heads/master@{#314599}

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/897803002

Cr-Commit-Position: refs/heads/master@{#314598}

Revert of Mojo+NaCl: Move generated code to mojo/nacl. (patchset #1 id:1 of https://codereview.chromium.org/896243003/)

Reason for revert:
Caused build failures on mac bots. Not sure why it failed there but not on the CQ.

Original issue's description:
> Mojo+NaCl: Move generated code to mojo/nacl.
>
> This change moves generated code for Mojo support in NaCl from mojo/monacl to
> mojo/nacl. This makes the target directory more consistent across GYP and GN
> builds.
>
> An upcoming change for IRT support will generate a header, which will need a
> consistent path (relative to include_dirs) across build systems.
>
> BUG=454466
>
> Committed: https://crrev.com/99cdffdb116cf608630600bbbf66a37fcf16695e
> Cr-Commit-Position: refs/heads/master@{#314591}

TBR=ncbray@chromium.org,jamesr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454466

Review URL: https://codereview.chromium.org/900983002

Cr-Commit-Position: refs/heads/master@{#314597}

Add Rappor metrics for Safe Browsing and SSL interstitials.  This reports the eTLD+1 of URL.  Later we'll add click-through and history state.

BUG=451646

Review URL: https://codereview.chromium.org/872813003

Cr-Commit-Position: refs/heads/master@{#314596}