- 27 Aug, 2019 40 commits
-
-
Jinsuk Kim authored
Makes the "Close [Chrome]" text blue when it appears on the last page navigation. Bug: 979498 Change-Id: I89f63e56b32ac4c6c3e157b5cbcab858081716b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768804Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#690919}
-
Andrew Xu authored
In this CL, ScrollArrowView inherits the ShelfButton. It improves the code readability and also makes Shelf code coherent: in current code base all of buttons in Shelf are ShelfButtons. Bug: 973481 Change-Id: I73aab558948b4ef32f79fa6e4ce243e9eba269a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772293Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690918}
-
Evan Stade authored
In these files, it was being used to clear notification registrations to fix http://crbug.com/125276 In NetworkStateInformer, it was doing nothing except removing its own registration. In SignInScreenController, the referenced UI object is owned, and therefore can't have been freed, so the precaution was no longer necessary. In ExistingUserController, we can replace with a check to IsSessionStarted before handling NOTIFICATION_AUTH_SUPPLIED. I don't understand why this code lives in ExistingUserController to begin with, and there's a TODO/bug to rework the bodge, but this should preserve behavior. Bug: 268984 Change-Id: I219b69997e4873ed60695442a757bd8d549dc00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771614 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Peter Kasting authored
See bug comments 16/17 or comments in the code for description. The algorithm here is O(n) in at most two passes over the input string, not counting the StripJavascripSchemas() call. Bug: 764512 Change-Id: I12123b40fc6c91f10d927fd34b368aa16c0310c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766890 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#690916}
-
Angel Alvarez authored
Adds logic to compute the contents digest of generated MHTML files, when requested via the generation input parameters. A new MHTML generation method is added to WebContents, but it will be merged into the existing one in a follow up CL. Also updates tests to verify the correctness of the digest computation. This is based off a change by mtlieuu@: https://crrev.com/c/1552118 Bug: 915966 Change-Id: I816940a307018255f31d1aea0a66a729cbec77ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754125 Commit-Queue: Angel Alvarez <angelii@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#690915}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/14a9be448e01..886698bc3fdd git log 14a9be448e01..886698bc3fdd --date=short --no-merges --format='%ad %ae %s' 2019-08-27 jmadill@chromium.org Vulkan: Style cleanups to TextureVk. 2019-08-27 jmadill@chromium.org Vulkan: Remove command buffer param from initImage. Created with: gclient setdep -r src/third_party/angle@886698bc3fdd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I3d5c608e3a5bbac740483225ee2ad181d6e3836e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772330Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690914}
-
Torne (Richard Coles) authored
Anywhere we call getSharedPreferences might be a disk write as the directory for prefs is created if it doesn't already exist; move the existing StrictModeContext in AwGeolocationPermissions up to the caller to also cover where the SharedPreferences object is retrieved, and add another missing one when the browser context is created. Bug: 994321 Change-Id: I2e18e156d378910751ee2a530d72180eab012696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773781Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#690913}
-
Steven Bennetts authored
"Start activate" in the internet settings UI simply opens a new dialog with the activation UI. This should not be part of the network config API. Bug: 853953 Change-Id: Ia4c72df1aad547991ab775ebf4c158827382da8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769633 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690912}
-
Mike Frysinger authored
The required behavior of argparse subparsers changed in Python 3. Add some code that works in Python 2 & Python 3 to retain the old behavior. Bug: 983071 Test: `./pak_util.py` doesn't crash under Python 3 Change-Id: I6820c65e365da662633a2eb4386e4077fedd3174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771983Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#690911}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/59099ed6ee31..217195ca2ce8 git log 59099ed6ee31..217195ca2ce8 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@217195ca2ce8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Icd61b738e1b1177962845b34429456f3e27145ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773716Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/db16ee85fb52..c9fdf2610a1d git log db16ee85fb52..c9fdf2610a1d --date=short --no-merges --format='%ad %ae %s' 2019-08-27 crouleau@chromium.org [Telemetry, typ] Add Rakib as OWNER. 2019-08-27 crouleau@chromium.org [tracing] Replace crouleau@ with perezju@ for owning TBMv2 and tracing tooling. Created with: gclient setdep -r src/third_party/catapult@c9fdf2610a1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:973936,chromium:997370 Change-Id: I122be6d5ed9c3f1b8aaecf7dc729cedd81343303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773329Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/51ed66b5cadd..cde5dea64717 git log 51ed66b5cadd..cde5dea64717 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 pprabhu@chromium.org cbuildbot: Do not set quota_account for moblab requests Created with: gclient setdep -r src/third_party/chromite@cde5dea64717 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic26516ff882b37dbb12145c36896519ec1ec5180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773328Reviewed-by:
-
David Black authored
Entry animation: Translate up from offscreen. Exit animation: Fade out. See bug for demo. Bug: b:139199754 Change-Id: Ib32f3bf0eaf19577cd1da2e9e28285a4d96bec53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769841Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#690907}
-
gogerald authored
Screenshot before: https://drive.google.com/file/d/12NZSwfUUEGC9dXSIEoSUB3mlMmjDmwtE/view?usp=sharing after: https://drive.google.com/file/d/1oHZ21pwrplRsKy8mzX0jDBKkmOaDPka8/view?usp=sharing Bug: 982018 Change-Id: Ib2cffd89fd1a8fc319e65e2cf70e32442fd9b072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769355 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690906}
-
Eric Willigers authored
Tests for scroll-padding-inline-start, scroll-padding-block-start, scroll-padding-inline-end, scroll-padding-block-end now appear together. Tests for scroll-margin-block-start, scroll-margin-inline-start, scroll-margin-block-end, scroll-margin-inline-end now appear together. Added tests that calc(auto) is rejected. Change-Id: I06759db50dd21e2654df494255a4e41233cdcae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771486 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#690905}
-
Haines Sy authored
Add a basic FakeComponentContext implementation of ConnectToAgentService to be used for Unit Testing. Bug: b/139953375 Change-Id: I68fa278c5fb287eda691ab30ca21fa6381b93717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770955 Commit-Queue: Haines Sy <hainesy@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#690904}
-
Bettina authored
Bug: 996380 Change-Id: I57e49cad315fb038ef4b9dfb71293f49f64c749f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769728 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#690903}
-
Scott Violet authored
Plumbs through the Profile/BrowserController and the start of NavigationController as discussed. The pattern is classes in weblayer/public/java/org/chromium/weblayer trivially calls through to classes in weblayer/browser/android/java/org/chromium/weblayer_private/ . Eventually the calls will be over AIDL. I also introduced a WebLayer java class for one time initialization. This isn't perfect, but a good start. BUG=none TEST=none Change-Id: Ie14cdb3d8a63624fb23c37dbc6187f100b5f20ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772443Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#690902}
-
Lei Zhang authored
Change it to return base::Optional<PP_PrivateAccessibilityTextRunInfo>, instead of returning the individual elements of PP_PrivateAccessibilityTextRunInfo as out parameters. Update the caller of GetTextRunInfo() to std::move() the text run into the vector that holds all the text runs, and simplify calculations for char indices in the caller. Change-Id: I719119935ea201f5aed7d1d41e706831a1696c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769220 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690901}
-
Chris Mumford authored
r472276 renamed two targets: 1) android_webview_apk ==> webview_instrumentation_apk. 2) android_webview_test_apk ==> webview_instrumentation_test_apk. However, there were two local targets which should have been renamed for consistency, but were not: 1) android_webview_apk_assets ==> webview_instrumentation_apk_assets. 2) android_webview_apk_resources ==> webview_instrumentation_apk_resources. Bug: 701938 Change-Id: I09b7f8109472e5ad0c9c2b5639dbb3e4e656cf74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772691Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#690900}
-
Rakina Zata Amni authored
Move the tests and change them to use the rendersubtree attribute. Note that the SVG test fails because the rendersubtree attribute is only defined on HTML elements. Bug: 991095 Change-Id: I4515d4db3786d7bcd1863e7b5407d88dbbf3c016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773017Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#690899}
-
Anastasia Helfinstein authored
Use the newly added FocusRingManager. Bug: None Change-Id: If0f98d40eec6a52a1eef5322d5ef05a15690a910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771046 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#690898}
-
Rune Lillesveen authored
We currently store a bool saying if the StyleColor represents currentcolor or not since currentcolor computes to itself and will inherit as currentcolor. If [1] is resolved, we need to do the same for system colors. Store a CSSValueID in preparation for that. This CL should not have any behavioral changes. [1] https://github.com/w3c/csswg-drafts/issues/3847 Bug: 939811 Change-Id: I5908a09b311c549c9d194bdf4180e24ba7baae5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771413Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#690897}
-
Rune Lillesveen authored
Make sure RuntimeEnabledFeatures are reset properly in tests. Change-Id: I13541aac18b6c5aa68753fdca560c8d8da0703a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771968Reviewed-by:
-
Jack Lynch authored
This CL adds an aria-label to the select box in the Performance panel Event Log pane that filters by duration in order to make its purpose clearer to screen reader users and meet WCAG 1.3.1. Screenshot of the select in question: https://gyazo.com/9ecb8d9699a05fbb83fcf6f0925f3c47 Bug: 963183 Change-Id: I887f6192b08dbff113d9ac61fa185ffa9ce195ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723804Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690895}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70768f4a8e10..2d5aec56fdf7 git log 70768f4a8e10..2d5aec56fdf7 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision abb1ee24..f706cf73 (690691:690793) Created with: gclient setdep -r src/third_party/webrtc@2d5aec56fdf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I453c8a10f82e8f0edc4384641ae7d7c845ed6a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773193Reviewed-by:
-
Becca Hughes authored
Enable the lock screen media controls by default since these are shipping in M78. BUG=965546 Change-Id: I159052753625fe4eb8bf3653bf2c7bdffe09615e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773325Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#690893}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c5a91bb269fc..8ba3dcbde46b git log c5a91bb269fc..8ba3dcbde46b --date=short --no-merges --format='%ad %ae %s' 2019-08-27 zoddicus@users.noreply.github.com Rolling 7 dependencies and updating known_failures (#791) Created with: gclient setdep -r src/third_party/shaderc/src@8ba3dcbde46b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ib15a774c6947beb8490cdc85db0d7496bbb0a098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773195Reviewed-by:
-
John Budorick authored
Requires crrev.com/i/1714264 Bug: 994432 Change-Id: I81052b2cddbd4866f70b43993749e570d2a4756e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773214Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#690891}
-
Will Harris authored
Previous to this CL, a caller could enable the MITIGATION_DYNAMIC_CODE_DISABLE_WITH_OPT_OUT policy expecting that it would work, but since Win8.1 and before Win10 RS1, ACG with no opt-out would be enabled by the sandbox instead. This would cause subsequent calls to opt a thread out to fail unexpectedly on these OS. This CL changes code to just ignore MITIGATION_DYNAMIC_CODE_DISABLE_WITH_OPT_OUT on unsupported OS as is sandbox convention. BUG=733739 Change-Id: If777ad461de3600c407c7175d283072ac42ab9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773520Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#690890}
-
Daniel Rubery authored
If the verdict from deep scanning is UWS or MALWARE, generate realtime reporting event for the dangerous download. Bug: 980777 Change-Id: I47524dd2eeb7b6a2f4178464390fb78479030b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771820Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#690889}
-
Ian Kilpatrick authored
Previously if we didn't match our "forced" BFC block-offset we'd layout that subtree. This patch adds logic for elements which have clearance past adjoining floats - (this is quite common on facebook.com). Fortunately we can re-use all of the logic if an element is "pushed by floats". However the following invariants must be true: 1. We have a "forced" BFC block-offset set for the old and new constraint spaces. 2. These "forced" BFC block-offset are equal to their respective clearance offsets. Change-Id: I4873bb477a5fa17768943d9dba07d8d65c20d780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773543 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#690888}
-
Vasiliy Telezhnikov authored
This CL add waiting for default icon image to be loaded in the BrowserActionApiTest.BrowserActionWithRectangularIcon tests. It adds TestIconImageObserver for this purpose (instead of local WaitForIconLoaded in MultiActionAPICanvasTest) Bug: 997820 Change-Id: I447d7563cd0bde20f8787f9eb412978addaecab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772128 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#690887}
-
Rakina Zata Amni authored
Move the tests & change them to use rendersubtree attribute. Removed some tests around containment, inline, timeout, duplicate from lock-after-append move etc. Note the acquire-clone.html tests failed, will file bug. Bug: 991095 Change-Id: Ia6606706bae235c07bbb78d34f4a6c91afda32ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772816Reviewed-by:
-
Gavin Williams authored
-New sort order is printers with automatic configuration sorted alphabetically first then printers that need manual configuration sorted alphabetically next -Added new test case to confirm nearby printers sorted correctly Bug: 993820 Change-Id: Idf730c8111bc6e835b659e899e3a478d719e04a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767604 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Owen Min authored
Plugin belongs to browser instance. We don't need browser context to get plugin lists. Hence move plugin from ChromeUserProfileInfo to BrwoserReport. 1) Remove Plugin related code from ProfileReportGenerator 2) Because of 1), ProfileReportGenerator does not need to be async. 3) ReportGenerator remains async as Plugin information will be get here. Getting plugin info in ReportGenerator will be added in the following CL. Bug: 956237 Change-Id: I04c5ac519bc5c03e5436e10e98eebcf9a27b11fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764278 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#690884}
-
Stephen Nusko authored
This reverts commit 94d22097. Reason for revert: Tests on the pixel 2 GPU are now fixed. See gpu-fyi-try-android-p-pixel-2-skv-32 trybot. Changes: 1) We now call OnDisconnect if we were already connected when calling SetNewSocketForTesting() this fixes gpu-fyi-try-android-p-pixel-2-skv-32 2) GetDefaultTraceConfig() is now in a unnamed namespace in the .cc file rather then a member function. This was needed for ubsan_vptr as described in crbug/997318 Original change's description: > Revert "Enable a new SYSTEM background tracing mode." > > This reverts commit 9c5df46a. > > Reason for revert: timing out tests > > Original change's description: > > Enable a new SYSTEM background tracing mode. > > > > This mode will allow us to set up a background scenario and deliver > > triggers to the system when something interesting is happening. Which > > will allow us to only upload traces that are of interest. > > > > Bug: 979583 > > Change-Id: Ic48ea08e3f9fafccaf045847cc0ddfa76d11611c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760736 > > Commit-Queue: Avi Drissman <avi@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: oysteine <oysteine@chromium.org> > > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689563} > > TBR=avi@chromium.org,oysteine@chromium.org,eseckler@chromium.org,nuskos@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 979583,997206 > Change-Id: I51889cecfdc1ac392fb199b1a190b14880801e6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768981 > Reviewed-by: enne <enne@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690047} TBR=avi@chromium.org,enne@chromium.org,oysteine@chromium.org,eseckler@chromium.org,nuskos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979583, 997206, 997318 Change-Id: Ib7052fbb7f2b67d85657494ab59d111a58213cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768768Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#690883}
-
Karen Qian authored
Bug: 922150 Change-Id: I6df27b4f41583f5231cca5a10277d6ce3bddaa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769347Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Karen Qian <karenqian@google.com> Cr-Commit-Position: refs/heads/master@{#690882}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73c58302fc9e..daddc3da9672 Created with: gclient setdep -r src-internal@daddc3da9672 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:913074 Change-Id: I01d4c30c9429bd9b844803c6cd7d8a8225b0aa10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773189Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690881}
-
Tao Bai authored
This patch moves chrome/common/page_load_metrics to components/page_load_metrics/common, and is mostly moving the file, no change to feature. README and OWNER file haven't been updated, will do when moving them to components. Bug: 995880 Change-Id: I5f8eb1cdbc9a631fea2fdd6158ea93b35da74271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761729Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#690880}
-
