- 24 Aug, 2020 40 commits
-
-
Anastasia Helfinstein authored
The virtual keyboard is not actionable via the automation API, so Switch Access simulates a mouse press on the keyboard to type a character. There was a bug causing this behavior to be bypassed when the screen contents changed. This CL fixes that bug, and refreshes the keyboard nodes appropriately. AX-Relnotes: n/a. Bug: 1110157 Change-Id: Ia4fd6af5b01aa3454e5e02ccf21a600667388936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368451Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#801186}
-
Rachel Carpenter authored
These need to be granted to each app individually while investigation into granting these to all SWAs is ongoing. Bug: b/163422374 Change-Id: I533aadc2f76674a20032c212e67abd03bdddda23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371385 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#801185}
-
Cathy Li authored
Bug: 1113427, b/161142289 Change-Id: I871b8012af71674d6e0e79a3a0b73dcbf03c686c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365393 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#801184}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /content/browser/site_per_process_browsertest.cc This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1110266 Change-Id: Ic527921e0dfa915b92e89ede01f3b8c507d68d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371290Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#801183}
-
gogerald authored
Extended start surface, grid, tab groups related flags and report-feed-user-actions as requested from M86 to M90. Change-Id: I125569a3afd9acbb94d73c10aa2961c597c8091c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373171Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#801182}
-
Leonid Baraz authored
It appears that crypto::EnsureOpenSSLInit needs to be called before any other OpenSSL function is called. This function is thread-safe, and OpenSSL will only ever be initialized once. Multiple sequential calls to EnsureOpenSSLInit are ignored by OpenSSL itself. Also, HKDF expansion added to produce a uniformly random symmetric key instead of using a shared secret directly. Bug: 1121075 Change-Id: I9b9be85f7082b0fc047da901ae54856d25b0bbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372898Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801181}
-
Evan Stade authored
This relands commit 8e6f7aa5. Difference to original: real WindowAndroid in PhotoPickerDialogTest It seems that L breaks when you use Mockito to mock a WindowAndroid in an instrumentation test (although not a junit test). Original change's description: > Move PhotoPicker to //components/browser_ui/photo_picker > > No behavior change is intended for Chrome. This simply relocates > code and assets and updates references. > > One fairly major change for WebLayer is that Base.Theme.Chromium > is folded into Theme.BrowserUI, which means that WebLayer may get > some slightly different theming in some places. This is necessary > because the photo picker uses Theme.Chromium.Fullscreen, which > builds on Base.Theme.Chromium. > > For now, DecoderService and the aidls live alongside the other > code, although they won't be usable by WebLayer as-is. They will > have to be shuffled around some more. > > Bug: 1110930 > Change-Id: I7a5c730b0dd67cb63f9323bcd6f98eb187745b57 > Skip-Translation-Screenshots-Check: True > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363639 > Reviewed-by: David Benjamin <davidben@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lijin Shen <lazzzis@google.com> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Auto-Submit: Evan Stade <estade@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800993} TBR=palmer@chromium.org,dcheng@chromium.org,davidben@chromium.org,finnur@chromium.org,estade@chromium.org,tedchoc@chromium.org,tsepez@chromium.org,wfh@chromium.org,lazzzis@google.com Skip-Translation-Screenshots-Check: True Change-Id: Id6d4e6db9d16d381aefd5acc90832b8570f27a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372917Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#801180}
-
Chris Cunningham authored
latencyHint should be settable at any point, especially early. This change removes the assumption that VRI algorithm_ is set prior to latencyHint. Bug: 1114748, 1100555 Change-Id: I69a0916674b1575547faab4fda371eb81bbea7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370653Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#801179}
-
zhaoyangli authored
The corresponding CI builder has been migrated and the json config under //ios has been deleted. This try builder is ready to use Chromium recipe. Bug: 912681 Change-Id: I8bfb0ef643345ec7b2696d326b58fd1c80a89426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373179Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#801178}
-
Matt Wolenetz authored
BUG=1119527,1120698 TBR=wychen@chromium.org,pmonette@chromium.org Change-Id: I715f93e12fa221529070db16d83641b6e5f36341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373266Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801177}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/149a3b758125..e95b5d6ad52b 2020-08-24 brucedawson@chromium.org Avoid ..\.. in packaged environment variables 2020-08-24 brucedawson@chromium.org Filter out Assessment and Deployment Kit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1120785 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I88e68044359022b63c992c8f5a84ae91a1dba350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801176}
-
Victor Costan authored
Bug: 488553 Change-Id: Id732ac4eb5e5afc26095a925e73797449369c492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371471 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#801175}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ib31af7a97eba281fd4a569ec930a9cdc5846a5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372921Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801174}
-
Gavin Williams authored
This change re-enables the device-discovery-notification switch while changing it to a single value type. When not enabled, Chrome will not show Privet notifications as part of Cloud Print's deprecation. Bug: 1115796 Change-Id: I17d3dd37148562feae08e673f5be8885cae4d84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354617 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801173}
-
Theresa Wellington authored
Test flakes frequently on M emulator. BUG=1120813 Change-Id: I481b39088f22e295e31ec5eed155f168e0fbad78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373284 Commit-Queue: Theresa <twellington@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#801172}
-
Eric Orth authored
*Take ownership of non-obsolete histograms owned by people no longer working on DNS code *Extend soon-to-be-expired histograms either by 6 months (for those I'm still getting good use out of and intend to keep using as we further roll out DoH) or by 3 months (for those I want to remove or rework a bit once I have more time) *Move one histogram that's not really DoH-specific from having doh-core@ as a secondary owner to the net OWNERS file (as is the typical secondary owner for most general DNS histograms) Change-Id: If1659f24f40c96a1df79607ecf5ab783e8d37123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372894 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#801171}
-
Kyle Horimoto authored
Bug: 1121139 Change-Id: Iee3b424b9626c1ddd1e5d1372dc66808c5a2a367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372870 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801170}
-
Theresa authored
This reverts commit 114425f8. Reason for revert: Failing on x86 bots Original change's description: > Add an undo closure snack bar in TabGridDialog > > This CL adds a snack bar to TabGridDialog that handles closure within > dialog. Note that this change doesn't prevent the original snack bar > from showing when closure happens, so there will be two snack bars > showing when a closure happens within dialog. This issue will be > addressed by later CLs. > > Bug: 1119899 > Change-Id: If0e5b010996a80c9a111c8bf2cb8af44feb63124 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368236 > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801037} TBR=wychen@chromium.org,yuezhanggg@chromium.org Change-Id: I1c2ccc03142c50c203ec08817d8817cfa614b519 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119899,1121363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373232Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#801169}
-
Allen Bauer authored
Bug: 938501 Change-Id: I400999e4ad1abc178f4004a443fc171f1995682b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352044 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#801168}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1c96e6739bbe..746445da75a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia3f29c93ce6d6e720dbfe9cf5b74f5370f3f441f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372915Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801167}
-
David Bertoni authored
This CL enables most of these tests. Two tests are flaky and are tracked by crbug.com/1115182. One test requires user gesture support, which is tracked by crbug.com/977629. Bug: 1093066 Change-Id: I01d73276cc11a50ae991ae36e7b1be58a94fb9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317759 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#801166}
-
Michael Bai authored
Record the number of files (and their unsent samples) from previous runs and make those values into stability metrics. The metrics precisely simulate the INTERNAL_PROFILE behavior and are only enabled for WebView. The patch also extends the metrics for used size to M87. Bug: 1076549 Change-Id: I0356899f13b8b89b9823c81d1eb748ef8ca3ee5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293321Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#801165}
-
evliu authored
This CL extends the Live Caption feature flag expiration from M86 to M90. Bug: 1121306 Change-Id: I4270151b8eeaf24eaab86d7502b984764dc42470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373172 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#801164}
-
Mugdha Lakhani authored
Removes all references to cellular network checks since they're no longer controlling access to preload/prerender features. Removes the enum value from NetworkPredictionStatus and FINAL_STATUS_CELLULAR_NETWORK from prerender final status. Change-Id: I18d55917579d02f596615743c2736b6173e559c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368361Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#801163}
-
Michael Crouse authored
Bug: 1082556 Change-Id: Ida303c739b31a9af6be2d394214ece28f3613b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373173 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801162}
-
Shimi Zhang authored
There is no actual usage of this abstract class anymore. Bug: 533069 Change-Id: I31ce5c99727a1ce11918b22a2252b3113c2c8878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371683Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#801161}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c86d8fb76ac3..746445da75a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idfb5b833d89b018e6720466ed374bc3474cba55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801160}
-
Chris Cunningham authored
Crash fixed by: https://chromium.googlesource.com/chromium/src.git/+/39bb8526f08be06a5d19791cc0fc98a5978dedd0 Bug: 1121015, 1120431 Change-Id: I957909c539d4c626dbeb238fd7e856bce4fcebb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373174Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#801159}
-
Robbie McElrath authored
This CL makes BrowserImpl save the UI state of BrowserViewController when destroying/creating it so we can save the controls location. It doesn't use onStoreInstanceState directly because the BrowserControlsContainerView lifecycle doesn't exactly match what Android expects (onStoreInstanceState gets called after BCCV is already destroyed). Bug: 1120209 Change-Id: Ibedf4f8ad1e01f29518b404d94961b0e97689b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368479Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#801158}
-
Ian Kilpatrick authored
Not sure what this one was doing. There should be no behaviour change. Change-Id: Id06d09013d54617e8928033c04e728cab9471a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369494Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#801157}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86e14dba..48246beb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I84306bb48f84a2f2038bb279c0bea0cb96a1190a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373142Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801156}
-
Peter Wen authored
Many of these lint warnings were turned off because it was difficult to fix all of them when they were introduced (usually via a lint update) and fix incoming new errors at the same time. Adding existing issues to the baseline and enabling for new code. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2369576 Fixed: - Regenerated baseline post-revert of a previous refactor that changed filepaths of errors that were in lint-baseline.xml. Bug: 1116130,807734,671170,831774,635567 Bug: 1069186,804427 Fixed: 807734,635567,804427 TBR=wnwen@chromium.org,twellington@chromium.org,agrieve@chromium.org Change-Id: I52fd71ed6678d35d5d31567be3038c53e544fa84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372928Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801155}
-
Olivier Yiptong authored
This is a reland of Ice3b2bd0589a8aff83a0f50f7bcd2d2ff6938989 Original change's description: > Revert "FontAccess: Replace web_tests with WPT tests" > > This reverts commit cfb42f4a. > > Reason for revert: The upstream CL of this CL (https://crrev.com/c/2364009) is likely the cause of build breakage for Win10 Tests x64 build starting from: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/48700 > > Original change's description: > > FontAccess: Replace web_tests with WPT tests > > > > Replaces web_tests with WPT tests to ensure cross-browser compatibility > > in the future. > > > > Bug: 535764 > > Change-Id: Ice3b2bd0589a8aff83a0f50f7bcd2d2ff6938989 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365332 > > Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> > > Reviewed-by: Joshua Bell <jsbell@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#800345} > > TBR=jsbell@chromium.org,oyiptong@chromium.org > > Change-Id: I6f85c0cb68f8c30ab29a618f3365d2473c9a8b99 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 535764 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367585 > Reviewed-by: Maggie Cai <mxcai@chromium.org> > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800478} TBR=jsbell@chromium.org,mxcai@chromium.org,oyiptong@chromium.org # Not skipping CQ checks because this is a reland. Bug: 535764 Change-Id: I360c6c2fba2ec5bb665430b670df77ed645aa794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368444 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#801154}
-
Yicheng Li authored
If fingerprint auth is supported, the in-session auth dialog needs to explicitly start fingerprint auth session (so that biometrics daemon can get prepared for the upcoming fingerprint scans), and explicitly end fingerprint auth session when no more retries are expected. Bug: b:156258540, b:144861739 Change-Id: I7534594a696bd42f6f29fdc85fe8548b5cf8caae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369336 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#801153}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d989a67c59d5..d32b1bc30216 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmonette@google.com,wolenetz@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085115,chromium:1119897,chromium:1120089,chromium:1120137 Tbr: pmonette@google.com,wolenetz@google.com Change-Id: Iacd18a171dbb47c1ad075b2dfd1368a97f56bc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372776Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801152}
-
David Bienvenu authored
Bug: 1010217 Change-Id: Id243885fd52d5d62d96d415037d54ab7bd8d05d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372913Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801151}
-
Jeffrey Young authored
BUG=b:162421778 Change-Id: I3e93cabe5791930f8ce793e569af0152193749d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367512Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#801150}
-
Shengfa Lin authored
DevTools event listener is passing a dereferenced pointer value to navigation. However, sometimes it's dereferencing a nullptr value (from an uninitialized unique_ptr) causing navigation tracker to crash when try to use the reference. See bug list 3578 for a case when that pointer is nullptr. When navigating to a blank page and an alert is triggered, ChromeDriver will not wait for the original navigation to finish and set the original Page.navigate response info state to ignore; when the response finally come back, ChromeDriver is not copying the result in the response causing the result uninitialized. Bug: chromedriver:3578,chromedriver:3488 Change-Id: I7fd6159d724036a7354a47844da9d14d76c70b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370091Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#801149}
-
Erik Chen authored
This reverts commit 3d77d782. Reason for revert: Fix landed: https://chromium-review.googlesource.com/c/chromium/src/+/2360816 Original change's description: > lacros: Temporarily revert back to Linux user-agent. > > The transition to Lacros is intended to be transparent to websites. As > such, Lacros needs to set the ChromeOS user-agent. However, in some > contexts (e.g. chrome://settings) Lacros must behave like the Linux > browser. The problem is that webUI makes the assumption that user-agent > uniquely identifies platform, and that there is only one browser per > platform. Thus, setting the ChromeOS user-agent triggers ChromeOS > settings behavior, which uses ChromeOS-only private extension APIs, > which crashes the renderer. > > The appropriate long-term fix to this is to correctly plumb additional > information into WebUI so that it can distinguish between Linux, > ChromeOS and Lacros browsers. This is currently not possible without > refactoring a substantial number of tests. This CL is a stopgap measure > to allow chrome://settings to be usable in Lacros. > > Bug: 1096590, 1111985 > Change-Id: Iabb8691e37ba6db4baba680e3d624248e8647321 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367473 > Reviewed-by: Darin Fisher <darin@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Auto-Submit: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800292} TBR=darin@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1096590 Bug: 1111985 Change-Id: I4e7bb004b4c64ee67e0bc08440e186988e14ff85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369501 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801148}
-
Ken MacKay authored
Merge-With: eureka-internal/441076 Merge-With: eureka-internal/441060 Bug: internal b/165807391 Test: cast_audio_backend_unittests Change-Id: I2ef33d20f5aa3b5cda8db238d575d318c02092d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369581Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#801147}
-