- 23 Jan, 2020 40 commits
-
-
Yoichi Osato authored
TBR=graphics-dev@chromium.org Bug: 1044841 Change-Id: I8b75e9a2939bdaf9f50e1f90d1fe56c64f9304ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015473Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#734373}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d7da3cc922f..a0e6361d160f Created with: gclient setdep -r src-internal@a0e6361d160f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1039943,chromium:1044743 Tbr: jbudorick@google.com Change-Id: I3c1d3f872993619a4f7a7caab0eef409596e591d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016462Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734372}
-
Yoichi Osato authored
This reverts commit 97dfeb90. Reason for revert: TabletModeControllerTest.VerticalHingeTest (CRASHED) on Linux ChromiumOS MSan Tests Fixed: 1044871 Original change's description: > Prepare shelf layout manager for shutdown earlier > > Starts shelf layout manager shutdown earlier at the beginning of shell > shutdown sequence (during OnShellDestroying call issued to shell > observers when the shell tear down starts). > > The main goal is to prevent shelf state updates that might happen during > shutdown. For example, tablet mode controller destruction, and overview > controller destruction might cause window stacking changes, that in > turn can cause shelf state updates - both of which happen before > Shell::CloseAllRootWindowChildWindows(), which is from where > ShelfLayoutManager::PrepareForShutdown is currently called (with some > indirection). > > NOTE: Calls to start shelf shutdown issued from > RootWindowController::CloseChildWindows() are kept around to handle root > window controller shutdowns that happen outside shell shutdown. > > BUG=1033343 > > Change-Id: I86211392b45bdafd5f095bd60c774fe88e8accce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015358 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734253} TBR=xiyuan@chromium.org,tbarzic@chromium.org Change-Id: I69855c62eedfc7698df237169fc1282868d2876b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015879Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6b345995a827..68125d909621 git log 6b345995a827..68125d909621 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 rmhasan@google.com [Typ] Add ability get string value of an Expectation instance 2020-01-23 dberris@chromium.org Find multiple points with E-Divisive Created with: gclient setdep -r src/third_party/catapult@68125d909621 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1041688,chromium:986447 Tbr: nuskos@google.com Change-Id: I030004cb0ab80301705f879dd20e9c26d2bc2384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016323Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734370}
-
Kent Tamura authored
LayoutMenuList is going to be removed after enabling LayoutNG for form controls. This CL is a preparation for the removal. Bug: 1040828 Change-Id: Ia399a7fed5ac9b35e1f04fdb870a4ea139fbd66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000253Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#734369}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I62e5ebb6237def06272f3890d42157831c98d287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014347 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#734368}
-
Julien Isorce authored
ERROR Unresolved dependencies. //media/gpu/vaapi:jpeg_decoder_unit_test(//build/toolchain/linux/unbundle:default) needs //media/gpu/test:local_gpu_memory_buffer_manager(//build/toolchain/linux/unbundle:default) //media/gpu/vaapi:webp_decoder_unit_test(//build/toolchain/linux/unbundle:default) needs //media/gpu/test:local_gpu_memory_buffer_manager(//build/toolchain/linux/unbundle:default) Also added a TODO(https://crbug.com/1043007) to remove the new is_chromeos guard around these tests. Indeed the file local_gpu_memory_buffer_manager.cc does not compile on Desktop Linux since https://chromium-review.googlesource.com/c/chromium/src/+/1970544 because this CL prevents to use minigbm on Desktop Linux. To handle the api differences between minigm and desktop system libgbm, a solution would be to use the existing wrapper in ui/gfx/linux/gbm_wrapper.cc. Bug: 1036647 Test: ninja -C out/Default capture_unittests vaapi_unittest Change-Id: I63d267bcc156916ddf85778c651e0b737d5e7cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006482Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#734367}
-
Simon Que authored
So that they can be used for ATS vs non-ATS comparison. R=tikuta@chromium.org, ukai@chromium.org, yekuang@google.com, yyanagisawa@chromium.org Bug: 1040754 Change-Id: Ica5fb60f396393ffcd68f30456835b2f7f1fcb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015918 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#734366}
-
Ahmed Mehfooz authored
This change adds kIconSystemMenu, kIconSystemMenuToggled types to the ash color provider. These colors are utilized in the tray with dark mode being default. Bug: 960118 Change-Id: I4cf9da17454aa25619a172aca8b038569a0a7849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013723 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#734365}
-
Eriko Kurimoto authored
The worker's name must be |''| in this test. According to the spec, the default value of WorkerOptions (which is the second argument of SharedWorker) is set as follows: dictionary WorkerOptions { WorkerType type = "classic"; RequestCredentials credentials = "same-origin"; DOMString name = ""; }; spec:https://html.spec.whatwg.org/multipage/workers.html#workeroptions Here, name property is set to an empty string. Therefore, the worker's name must be an empty string when the second argument is |undefined|. Bug: 907749 Change-Id: I5bc9c5afcf76beae1e3924661b2ea65fad5efe1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015911 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734364}
-
Makoto Shimazu authored
This CL is to add a new experiment ServiceWorkerTerminationOnNoControllee which is to terminate a service worker soon after all controllees are gone. The experiment introduces a small delay until the worker is actually stopped. If a new client results in being controlled by the service worker during the delay, the scheduled termination will be canceled. By default, this feature is disabled and the termination happens based on the existing 30-second idle timeout. Bug: 1043845 Change-Id: I132fc2da300ddef7aa6e111e0af2e587b72c8121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011589 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#734363}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0537aa80..b5c6594d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1de0ceb0499fa4dbd7fc605c426fe1f120890d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016382Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734362}
-
Yoichi Osato authored
TBR=layout-dev@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 626703 Change-Id: Ifda3ec2fd9307c57a8f9c3e3a6192d76c294a032 Fixed: 1044858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015914Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f324fe10ca65..c514ab001bb0 git log f324fe10ca65..c514ab001bb0 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 capn@google.com Evaluate interpolants at pixel center when multisampling disabled 2020-01-23 capn@google.com Use pixel centers for non-multisampled rasterization Created with: gclient setdep -r src/third_party/swiftshader@c514ab001bb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3913539aa6de2a9c529763476c138953e6514df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015627Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::GetLayoutBlockFlow()| to return valid block flow for inline-block for painting selection correctly for inline-block. This patch fixed following web_tests: * paint/selection/text-selection-inline-block-rtl.html * paint/selection/text-selection-inline-block.html Bug: 982194 Change-Id: Ic9ac0969159c893499fcbdba31a032318c91b4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011630 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734359}
-
Simon Que authored
If a builder config explicitly sets goma_enable_ats to either True or False, use that value. R=tikuta@chromium.org, ukai@chromium.org, yekuang@google.com, yyanagisawa@chromium.org Bug: 1040754 Change-Id: I4b0fca44f5bb526480c9f99caaba4d5e47231c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015917Reviewed-by:
-
Mitsuru Oshima authored
This is reland of crrev.com/c/1963234. See my comment for fix. Also added Added ArcNotificationContentViewTestCloseButtonInMessageCenterView to cover regression b/148028487 FPS on arm+hires is now ~60fps even with bg blur (w/o notifications) * Use layer clip during animation * Remove unnecessary background paint * Fine tune layer structures: Remove unnecessary texture layer, and use smaller layer, or change so that it require less repainting. Refactoring: * Consolidate the shield/blur/rounded code into TrayBubbleView. * Introduce layer type to buggle dialog delegate. Fix: * Looks like we were painting bg twice which made blur darker. It happens once in TrayBubbleView's layer. TBR=msw@chromium.org, tengs@hromiumorg Bug: 1033986, b/148028487 Test: no functional change. Added unittest for regresssion. Change-Id: I0d130d40f30cc3660a48a3c2b8979536fa24d85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015577 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#734357}
-
Kent Tamura authored
This CL merges duplicated code into LayoutBlock::EmptyLineBaseline(). This CL has no behavior changes. Bug: 1040828 Change-Id: Ibef264899797f5e443b2485a098d555fe93a949b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015870Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#734356}
-
Kent Tamura authored
The function is effective only if the box has non-"visible" overflow property, and the container element doesn't have it. This CL has no behavior changes. Bug: 1040828 Change-Id: Idf00ff9b8e9f650ddac199437a52e3423edbc223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015907Reviewed-by:
-
Hitoshi Yoshida authored
UnionBase is passed by value, so NativeValueTraits should handle it not as a pointer. Bug: 839389 Change-Id: I0a6ca6892bb8ec041376907bf3e5ccd92b797f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015867Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ba163361685f..fca88b650404 git log ba163361685f..fca88b650404 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 8c396a9cc4a8..135f8fcba837 (16 commits) 2020-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b766e5e7fbf4..f324fe10ca65 (6 commits) 2020-01-23 herb@google.com Specialize SkRectanzier to SkRectanizerSkyline 2020-01-23 egdaniel@google.com Pass readSwizzle into more proxy creation to not use config. 2020-01-23 egdaniel@google.com Remove GrPixelConfig from GrSurface and GrSurfaceProxy. Created with: gclient setdep -r src/third_party/skia@fca88b650404 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: I610a1260932db9600ce33eaf20c6d57a8d0f02c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015628Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8247ae787cc4..135f8fcba837 git log 8247ae787cc4..135f8fcba837 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 syoussefi@chromium.org Vulkan: Remove inactive uniforms in the translator 2020-01-23 spang@chromium.org Vulkan: Fix setupDraw when VK_EXT_transform_feedback is not enabled 2020-01-22 courtneygo@google.com Vulkan: Fix cast of float to unsigned int for ARM 2020-01-22 syoussefi@chromium.org Vulkan: Line raster emulation through specialization constant 2020-01-22 sugoi@google.com Enable GL_NV_fence with Vulkan backend Created with: gclient setdep -r src/third_party/angle@135f8fcba837 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: If618f15c881ed1138fd8e3bfdd906c07f820a031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016079Reviewed-by:
-
Alice Boxhall authored
Still to do (as a follow up): font size labels and omnibox button labels. Bug: 1041918 Change-Id: I99c1c814accd079e15dd8861246631a570443a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007797 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#734351}
-
Timothy Loh authored
Until the ebuild is actually updated to support DLC, the Plugin VM installer shouldn't be failing due to DLC errors. This CL partially reverts the behaviour of crrev.com/c/2001942 so we don't fail. We can revert this CL once the ebuild is updated. Bug: b:145814572 Change-Id: I2a9aadef45f5e72d1e7841f0ec3438d4d19f352c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015871Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#734350}
-
Jinsuk Kim authored
This CL makes sure the layout for gesture navigation is not initialized when the feature flag is turned off. For this, the place for initialization is delayted a little until the ChromeFeatureList is ready for use. Also extends the experiment to M82. Bug: 1043050 Change-Id: I6d5a4c7d50ebc9bf542d9ca43127664f6c60a860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007317 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#734349}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=aboxhall@chromium.org Bug: 1041419 Change-Id: I1e4d95d67075c6855b963f6ed419b352b1102705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997555 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Yoshisato Yanagisawa authored
To experiment ios_use_goma_rbe config behavior, let me enable this. Bug: 1044515 Change-Id: I2870eb540186f89b03b2faae07265ebcf5e090bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014480 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jason Clinton <jclinton@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#734347}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/04ccecc2d7b2..3df70e9c609d git log 04ccecc2d7b2..3df70e9c609d --date=short --first-parent --format='%ad %ae %s' 2020-01-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@3df70e9c609d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icdf0b454ed68b80935501e5fc016d35048f452a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016077Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/92a85446..0537aa80 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I59eb162b8dda5137e4eee5537c98476448bba069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016242Reviewed-by:
-
Yoichi Osato authored
This reverts commit c78cd05f. Fixed:1044826 Reason for revert: Fails Linux ChromiumOS MSan Tests Original change's description: > Parse PerAppTimeLimits policy > > Parse PerAppTimeLimits policy received from the server and store > app limits data in AppActivityRegistry. > This will be followed up by processing app limits. > > Bug: 1015654 > Test: AppTimeTest > Change-Id: I29691e0c801762a73f01cce217826423359957eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001411 > Reviewed-by: Yilkal Abe <yilkal@chromium.org> > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734123} TBR=agawronska@chromium.org,yilkal@chromium.org Change-Id: I3d66bf1a7630fb2476253b98e165e0f6c9b53aa8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015873Reviewed-by:
-
Yoichi Osato authored
This reverts commit 9939a33b. Reason for revert: PPAPINaClNewlibTest.NetworkProxy test failing on Mac ASan 64 Tests (1) Fixed: 1044845 Original change's description: > PPAPI: Add NetworkIsolationKeys to proxy lookup requests. > > This is needed to correctly isolate any DNS requests made by PPAPI in > the context of one page from those made in the context of other pages. > > Bug: 1021661 > Change-Id: Ibbca8db7df8c7e61cb9522630e70c8ccd365b5c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008050 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: Raymes Khoury <raymes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734094} TBR=raymes@chromium.org,mmenke@chromium.org Change-Id: Ia2c799af73dff4749b1af077b7d976f192d785aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015872Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I2000198ca283371d99a41a122015dc11988d16b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015422Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734342}
-
Eriko Kurimoto authored
This CL is for code cleanup. This doesn't change the behavior. Bug: n/a Change-Id: Iac4a44781fde183881cea62a97c8883932a670ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011593 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
-
Sophie Chang authored
Bug: 1036490 Change-Id: I03eeb9b6051a8b399ee2aca6522ef2c0ae5ae5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013745 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734340}
-
Leon Han authored
To indicate whether it's allowed to overwrite an NFC tag that already contains some records. We do not do any special checks for the case of overwrite = true, just write into the NFC tag in any cases. In case of overwrite = false, - Writing non-formatted tags that are NDEF-formatable --> format + write - Writing (formatted + empty) NDEF tags --> write - Writing (formatted and non-empty) NDEF tags --> not allowed The spec change: https://github.com/w3c/web-nfc/pull/373/commits/b71a81e33ba568f3a8e3cd3de8271bd45be789e8 https://github.com/w3c/web-nfc/pull/526 BUG=1023231,520391 Change-Id: Ibf271f88e6e395370f994864e966f55ef44f5d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003893 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#734339}
-
Ted Meyer authored
MediaError is meant to be a relatively small (sizeof(void*) bytes) object that can be returned as an error value from functions or passed to callbacks that want a report of status. MediaError allows attaching of arbitrary named data, other MediaErrors as causes, and stack frames, which can all be logged and reported throughout the media stack. The error code and message are immutable and can be used to give a stable numeric ID for any error generated by media code. There is also an OK state which can't hold any data and is only for successful returns. doc: go/media-error Bug: 1043289 Change-Id: I11a7c6d667f9810ba85264e41c8d7ce184858b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867991Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#734338}
-
tby authored
I made a typo when the in-code histogram name and the name in histograms.xml for the metric: Apps.AppList.DriveQuickAccessProvider.ResultPresence The incorrect name is in the code (it's missing a dot), but to avoid having to merge a fix this CL changes histograms.xml to be consistent with the code. Bug: 1022150 Change-Id: Ib61ef270141c1d77559631d9ef95af10dfe4fa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985831 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#734337}
-
Mandy Chen authored
This change modifies the shape of Page.getInstallabilityErrors [1] CDP event to include the error ids and arguments that are needed to generate the detail messages that are displayed in the Applications - Manifest tool. The design is proposed in Localizability of CDP [2]. The strings that are currently present in installable_logging.cc will be moved to the DevTools frontend. They'll remain in place so we are backwards compatible. Separate CLs will be made to process the new data in the DevTools frontend. [1]: https://chromedevtools.github.io/devtools-protocol/tot/Page#method-getInstallabilityErrors [2]: https://docs.google.com/document/d/1ZbCiXbVJZJaYqKZkQ_Y5RNpUqQd1JzO17PqFJZk2Ne8/edit?usp=sharing Bug: 946860 Change-Id: I8af923c1554396c6d79a4233bf342357b3386c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008430 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734336}
-
Alexei Svitkine authored
- Fixes common typos in email addresses. - For metrics where the first owner is not a @chromium.org or a @google.com and which have another owner with such an address, moves that owner to be the primary owner. This ensures there's a primary Google contact for any metrics we're collecting. This was done by looking through the following output and manually fixing problems: grep "<owner>" histograms.xml | grep -v google.com | grep -v chromium.org | grep -v OWNERS | grep -v "Add more owner tags" Bug: None Change-Id: I5c9288764008764cd6634726a27a3cb24ad1f9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013758 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734335}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ea20eae785f..ba163361685f git log 2ea20eae785f..ba163361685f --date=short --first-parent --format='%ad %ae %s' 2020-01-23 benjaminwagner@google.com Reduce binary size of GCC Debug builds 2020-01-22 robertphillips@google.com Add missing 'GrProtected' parameter to createCompressedTexture call chain 2020-01-22 michaelludwig@google.com Account for negative w in GrQuad::bounds Created with: gclient setdep -r src/third_party/skia@ba163361685f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:224618 Tbr: benjaminwagner@google.com Change-Id: Ic95395d63066e4473bfde6302e24790b96df6d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016068Reviewed-by:
-
