- 10 Jul, 2017 40 commits
-
-
rnephew authored
Benchmark was acidentally re-enable on android even though it is meant to be a desktop only benchmark. TBR=charliea@chromium.org Bug: 740581, 713222 Change-Id: I59548ffaa2a3a6c5528d2282f23bd16096b41f79 Reviewed-on: https://chromium-review.googlesource.com/565322Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#485329}
-
Yuwei Huang authored
For some reason this gesture makes two-finger pan not quite responsive, while the three-finger pan gesture itself often doesn't respond either. Maybe just disable it for now and see how things work. Change-Id: I015450735e6d0a4f4d671df30b97305798992af8 Reviewed-on: https://chromium-review.googlesource.com/564183Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#485328}
-
Benjamin Pastene authored
This includes: sql_unittests ui_touch_selection_unittests vr_common_unittests ui_android_unittests ipc_tests gpu_ipc_service_unittests gl_tests ui_base_unittests capture_unittests media_blink_unittests android_webview_unittests storage_unittests Bug: 670879 Change-Id: Ic6c975e608d440b611bdcb25b65ef038e432ebda Reviewed-on: https://chromium-review.googlesource.com/564139Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#485327}
-
Sadrul Habib Chowdhury authored
BUG=740527 Change-Id: Icd7be15d4b677770d5d4b4910490262d7aba7e9f Reviewed-on: https://chromium-review.googlesource.com/565540 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485326}
-
dimu authored
- modify chrome/VERSION owner file to stop VERSION updates spamming current owners Bug:739994 R=agable TBR=thakis Change-Id: Ia6474c2ae51c85d53cdc3917c7b4cb8ef8ecee3e Reviewed-on: https://chromium-review.googlesource.com/565739Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Di Mu <dimu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485325}
-
Peter Wen authored
This CL enables webp conversion for SystemWebview. For ChromeModern and Monochrome see: http://crrev.com/c/561578 ChromeModern, Monochrome, and SystemWebview apks all have min sdk version greater than 18. Thus webp is fully supported on those versions and since they are actually all API 21+, optimizations in L, M, and N will be applicable to all devices that receive those apks. This is enabled for all release builds so that if any issues crop up just a simple release build will trigger the conversion. On dev machines it is expected to add about 30 seconds to the overall build time, up to 1 minute if the machine is under load. Bug: 695482 Change-Id: Ifb27fc0d3e015da811a2635358cec336c423a41c Reviewed-on: https://chromium-review.googlesource.com/565542Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#485324}
-
Theresa Wellington authored
BUG=738798 Change-Id: Ic89d30a7ed94e110553712f84b5d02c283522604 Reviewed-on: https://chromium-review.googlesource.com/565341Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#485323}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. This means that any calls to "viewDidLoad" in this code will trigger an availability warning, because that function was added to the API in 10.10. To suppress the warning, rename the function to viewDidLoadImpl and introduce a wrapper function viewDidLoad that calls viewDidLoadImpl. Bug: 735328 Change-Id: Ifcea5787d095601dd621636380770a2c8d7acb59 Reviewed-on: https://chromium-review.googlesource.com/564095 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#485322}
-
Peter Wen authored
This CL enables webp conversion for ChromeModern and Monochrome. SystemWebview will be enabled in: http://crrev.com/c/565542 ChromeModern, Monochrome, and SystemWebview apks all have min sdk version greater than 18. Thus webp is fully supported on those versions and since they are actually all API 21+, optimizations in L, M, and N will be applicable to all devices that receive those apks. This is enabled for all release builds so that if any issues crop up just a simple release build will trigger the conversion. On dev machines it is expected to add about 30 seconds to the overall build time, up to 1 minute if the machine is under load. BUG=695482 Change-Id: Ic4377b9642e09eb1c886626f7750ad00951746e7 Reviewed-on: https://chromium-review.googlesource.com/561578 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#485321}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/72646aa580ee..30c9d9b85571 $ git log 72646aa58..30c9d9b85 --date=short --no-merges --format='%ad %ae %s' 2017-07-10 htwiggsmith Create story tag filter dom module and tests Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I40d4605a7d48e9a749c68b5996f0662299fa3560 Reviewed-on: https://chromium-review.googlesource.com/565326 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485320}
-
Robert Liao authored
On Windows, the background downloader uses the COM Global Interface Table, and Chromium requires these instances to have COM explictly initialized. Using a COM STA TaskRunner works for this case. BUG=739461 Change-Id: I28fdc54af5ec34034498d904bba648fc40c3c2f0 Reviewed-on: https://chromium-review.googlesource.com/562537Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#485319}
-
Steven Bennetts authored
If no ONC values is provided for OpenVPN.RemoteCertKU we need to set the Shill property to an empty string value. Bug: 738119 Change-Id: I3266e0c9f81fea42734e9da7d68df9e268487423 Reviewed-on: https://chromium-review.googlesource.com/558203 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Cr-Commit-Position: refs/heads/master@{#485318}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. This means that any calls to "viewDidLoad" in this code will trigger an availability warning, because that function was added to the API in 10.10. To suppress the warning, rename the function to viewDidLoadImpl and introduce a wrapper function viewDidLoad that calls viewDidLoadImpl. Bug: 735328 Change-Id: Ieb806578cc860b483fc75023fb39a7a4af171e14 Reviewed-on: https://chromium-review.googlesource.com/564209Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485317}
-
Theresa Wellington authored
Changes the location bar translation X when the location bar is RTL, and uses #getLeftPositionOfLocationBarBackground() directly rather than relying on a variable. Previously the variable was set when an #onDraw() called #getLeftPositionOfLocationBarBackground(); this resulted in #updateToolbarButtonVisibility() using a stale value. BUG=740058 Change-Id: I410dd20b7ddb0ff796935e854fd4fbd17b703d37 Reviewed-on: https://chromium-review.googlesource.com/565025Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#485316}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. The new way to suppress warnings is to either annotate the caller with an availability attribute or enclose the function reference in an "if (@available)" block. This patch uses @available to protect references to NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification, instead of comparing its address to zero. Bug: 735328 Change-Id: If6f428da62c1486c1d608f0afe5637f9fb2f4e07 Reviewed-on: https://chromium-review.googlesource.com/564151Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485315}
-
Eric Roman authored
This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: I89a3c36617c1328f0e64409b341e6483815910f7 Reviewed-on: https://chromium-review.googlesource.com/564341Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485314}
-
Qiang Xu authored
Changes: GestureRecognizerTest has no parameterized tests instantiated. We should remove ::testing::WithParamInterface<bool> inheritence. Bug: none TEST: covered by tests Change-Id: Ibc5701f59d474be1feb336e4ecafcaebf99bf05c Reviewed-on: https://chromium-review.googlesource.com/564094Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#485313}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. The new way to suppress warnings is to either annotate the caller with an availability attribute or enclose the function reference in an "if (@available)" block. Because the type NSVisualEffectView is marked as only available in 10.10 onwards, so must the visualEffectView property in TabWindowController and all other references to NSVisualEffectView. Any code that uses functions on NSVisualEffectView must be protected with @available. Bug: 735328 Change-Id: Ibe1bb965ae93bd0becc24fb90356462b1a26ab86 Reviewed-on: https://chromium-review.googlesource.com/564289Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485312}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/8fe24272fa6d..5449aade6227 $ git log 8fe24272f..5449aade6 --date=short --no-merges --format='%ad %ae %s' 2017-07-10 fmalita [Reland] More SkColorSpaceXformer caching 2017-07-10 reed don't compose with (forced) opaque colors 2017-07-10 ethannicholas Revert "Make TessellatingPathOp be a non-legacy GrMeshDrawOp" 2017-07-07 iannucci Remove dependency on recipe_engine/shutil. 2017-07-10 ethannicholas Revert "converted GrCircleBlurFragmentProcessor to sksl" 2017-07-07 bsalomon Make TessellatingPathOp be a non-legacy GrMeshDrawOp 2017-07-10 borenet Remove Rietveld stuff from cq.cfg 2017-07-07 csmartdalton Add missing checks for geometry shader stages in GrVkUtil.cpp 2017-07-09 fmalita Revert "More SkColorSpaceXformer caching" 2017-07-07 fmalita More SkColorSpaceXformer caching Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I9b64986d628dee4cb27de0a7e8e58bf4ff411fd6 Reviewed-on: https://chromium-review.googlesource.com/565107Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485311}
-
Anita Woodruff authored
- Previously was using GMock to mock the bridge class that forwards jni calls when creating/deleting/checking site notification channels. - Now there is a very simple fake implementation using an in-memory map from channel origin to NotificationChannel. - This enables more readable tests and will make it easier to write tests in future as the implementation develops. Bug: 700377 Change-Id: I958758c653ca3d83df3e95ad721f66c990fe03ea Reviewed-on: https://chromium-review.googlesource.com/565513 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#485310}
-
Friedrich Horschig authored
This cl complements https://chromium-review.googlesource.com/c/564614/ in that it reenables the baked-in popular sites for iOS. The reason for not reverting the old CL is the includes that were needed to make the presubmit happy. Bug: 737607 Change-Id: I24020f6949aff679bc80a918f61610d32056ceda Reviewed-on: https://chromium-review.googlesource.com/565565Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#485309}
-
kylechar authored
This CL adds a viz_unittests target for testing parts of viz. Remove the tests from components_unittests. Add the viz_unittests to trybots for CrOS, Linux, Windows, Mac and Android. The tests in //components/viz/common:unit_tests are not included on Android because they fail with the test GL implementation. Bug: 722935 Change-Id: Icd1595b745aef1cf87ab6ddbeeb3d16c0c8ec9d0 Reviewed-on: https://chromium-review.googlesource.com/538293 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#485308}
-
mmenke authored
It has two "are"s in a row. BUG=none Review-Url: https://codereview.chromium.org/2976523002 Cr-Commit-Position: refs/heads/master@{#485307}
-
Anthony Berent authored
It is a frequent pattern in tests to start an EmbeddedTestServer before starting a test, and to stop it when the test completes. Simplify this pattern by creating a Junit4 rule for running an EmbeddedTestServer. Change-Id: Ibfdf4c032a0d223c674f09bf847998e62200a6f5 Reviewed-on: https://chromium-review.googlesource.com/548057Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Anthony Berent <aberent@chromium.org> Cr-Commit-Position: refs/heads/master@{#485306}
-
John Abd-El-Malek authored
Change-Id: I9abfb441a9c0de36bc91975b39a5b48568c356a1 Reviewed-on: https://chromium-review.googlesource.com/565543Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#485305}
-
Nicolas Dossou-gbete authored
The repo contains a currently unused preferences screen for the suggestions, that is the only caller of the remote suggestion status methods. This CL marks them as appropriately unreached. The status of the remote suggestions will be used soon to update the UI state, so AreRemoteSuggestionsEnabled is updated in this patch to reflect the accurate status. Bug: 721407,740115 Change-Id: Ia92d85798f96064acc77c9366dafc3daee4ce025 Reviewed-on: https://chromium-review.googlesource.com/563617 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#485304}
-
Ingemar Ådahl authored
Merge all resource dependency manifests using the manifest merger from the Android SDK, providing the functionality described in https://developer.android.com/studio/build/manifest-merge.html. Removing the nontrivial manifest guard in the android_aar_prebuilt() template will be done in a follow-up change, as well as removing pre-merged manifest tags, such as "com.google.android.gms.version" meta-data. Bug: 643967 Change-Id: Ifdf9f3f76f5c80f1a2326dcd47045d032556936f Reviewed-on: https://chromium-review.googlesource.com/558296Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ingemar Ådahl <ingemara@opera.com> Cr-Commit-Position: refs/heads/master@{#485303}
-
helenlyang authored
This CL adds TextBadgeView to iOS Showcase. This involves adding a text_badge_view folder to showcase, creating a glue view controller, and modifying the Showcase configuration file and BUILD.gn files as necessary. Since TextBadgeView is currently a stub implementation, Showcase displays a blank white screen. BUG=740133. Review-Url: https://codereview.chromium.org/2967113003 Cr-Commit-Position: refs/heads/master@{#485302}
-
joedow authored
BUG=704216 Review-Url: https://codereview.chromium.org/2936673003 Cr-Commit-Position: refs/heads/master@{#485301}
-
Lucas Furukawa Gadani authored
Bug: 739816 Change-Id: I73ac3e7b68f5918a3f4749896d0ed7cf26d739df Reviewed-on: https://chromium-review.googlesource.com/562856 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#485300}
-
Friedrich Horschig authored
After discovering that the unused |SetDefaultResourceForSite| breaks the current Beta build, this CL redoes https://crrev.com/2959193002/ and disables the baked-in popular sites for iOS. Bug: 737607 Change-Id: I6ba17e95a2a81d9ec9e06580ab1248b2fc24faac Reviewed-on: https://chromium-review.googlesource.com/564614Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#485299}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4183f201c515..217644c0d65a $ git log 4183f201c..217644c0d --date=short --no-merges --format='%ad %ae %s' 2017-07-06 npm Force unicodes into valid ranges Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ifbb39630f7ef720133eae54ca9336b680bdbd900 Reviewed-on: https://chromium-review.googlesource.com/565044 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485298}
-
Geoff Lang authored
Use templates to determine the size of each element and the elements per unit allowing ComputeDataSize to only use a single inlined CheckedNumeric multiply with a compile-time constant. The data size validation of glUniform calls was up to 12% of the GPU process' CPU time on some WebGL applications, this lowers it to be less than 0.1%. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic6e5f975087308da9473918a9ef081c0b591fbb4 Reviewed-on: https://chromium-review.googlesource.com/559104Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#485297}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74cef601..2588b89c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I5a3aa9aefd1bfe7a3c3ca5afd882376123bef2fa Reviewed-on: https://chromium-review.googlesource.com/565459Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485296}
-
lizeb authored
When an intent is received in Custom Tabs, extract a redirect endpoint from an extra. If it exists, the URL to load is first party with respect to the calling app, preconnect to the redirect endpoint. This is part of Leapfrog, see the bug. Also, only disables preconnection with the data reduction proxy for HTTP URLs, as HTTPS URLs don't go through the proxy. BUG=739165 Review-Url: https://codereview.chromium.org/2970003003 Cr-Commit-Position: refs/heads/master@{#485295}
-
Daniele Castagna authored
crrev.com/2858693002 introduced a wait on an egl fence before pageflipping buffers. After that CL we noticed big performance regressions on Intel: crbug.com/721463 Removing the coarse egl lock that seemed to be the issue helped but didn't solve the performance regression completely: https://crrev.com/f3d9d4d0c7a4520e2e0117222ff6e8d4a4ce595f This CL adds a workaround for Intel to restore the previous behavior where synchronization relies completely on the Intel drivers. Bug: 721463 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ice34e03edb3f4cd81152ae917ceb08a23626b2d0 Reviewed-on: https://chromium-review.googlesource.com/562178Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#485294}
-
Bernhard Bauer authored
When the bottom sheet is closed, set its adapter to null, which clears the view (and recycles all the view holders inside it), to reduce the memory overhead of the views (which potentially hold large bitmaps) while the sheet is closed. The adapter itself is still around and holds on to the model, so it can be reattached when the sheet is opened again. The model caches bitmaps only via discardable references, which it will drop under memory pressure. Bug: 718925 Change-Id: I58510bc831a35f15d831915ba9fc47f929253978 Reviewed-on: https://chromium-review.googlesource.com/562136 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#485293}
-
creis authored
This flag takes precedence over --site-per-process and other site isolation modes. BUG=688617 TEST=Cross-site subframes work with --single-process --site-per-process CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2964033002 Cr-Commit-Position: refs/heads/master@{#485292}
-
mef authored
Filter out build/secondary/third_party dependencies to work around __main__.LicenseError: missing README.chromium or licenses.py SPECIAL_CASES entry in build/secondary/third_party/android_tools BUG=606859 BUG=710801 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2959303002 Cr-Commit-Position: refs/heads/master@{#485291}
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/27a6063..70c95fa BUG=chromium:739448,chromium:731324,:angleproject:1644,chromium:682815 TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9ed559801bfbb7cada2fef863096047f33437703 Reviewed-on: https://chromium-review.googlesource.com/565051Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#485290}
-