GitLab

The work around is to be more aggressive about sending
multipart data before we have a response header.  We used
to buffer a response until we had the full frame.

This avoids a crash in webcore by behaving more like
CFNetwork.  It also makes us behave more like Gecko,
which is probably good for compat.

The original patch (r47599) broke plugins on Windows because
it was depending on the assumption that we would send data
as one big chunk.  Now that we send data as multiple chunks,
we need to update the data offset being sent to the plugin.

BUG=30880

Review URL: http://codereview.chromium.org/2787002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49355 0039d316-1c4b-4281-b951-d872f2087c98

Preparation CL for adding crash metrics UMA counters to ChromeFrame. Basically this would mean that metrics reporting would be done directly
by ChromeFrame. Currently ChromeFrame uses Chrome to upload this data. 

Refactored the chrome metrics service and metrics logging functionality into base classes defined in chrome\common\metrics_helpers.cc/.h. While
this refactoring is by no means complete it is a first step to avoid needless code duplication between chrome and chrome frame.

Bug=46057

Review URL: http://codereview.chromium.org/2744003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49354 0039d316-1c4b-4281-b951-d872f2087c98

(Note: This was a TODO for akalin).

BUG=None
TEST=trybots, and manually

Review URL: http://codereview.chromium.org/2704002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=37129,38334
TEST=install sxs, check about box, about:version, start menu shortcut name

Review URL: http://codereview.chromium.org/2753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49352 0039d316-1c4b-4281-b951-d872f2087c98

This change also changes the CapturerGdi to output 32bit instead of 24bit.

Review URL: http://codereview.chromium.org/2771007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49351 0039d316-1c4b-4281-b951-d872f2087c98

This also makes GTK and Mac reset the location bar in the correct cases with various types of clicks on back/forward.

BUG=none
TEST=Middle-click reload.  It should reload the page in a new background tab.
Review URL: http://codereview.chromium.org/2779011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49350 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=unittests on Windows

Review URL: http://codereview.chromium.org/2772002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=38572
TEST=uitest, also "chrome/Debug/chrome.exe & chrome/Debug/chrome.exe"

Review URL: http://codereview.chromium.org/2664004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49348 0039d316-1c4b-4281-b951-d872f2087c98

Build chromoting_x11_client only on posix systems.

Review URL: http://codereview.chromium.org/2766004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49347 0039d316-1c4b-4281-b951-d872f2087c98

Fix problem whereby the "-full" magic value is removed from the "ap" value when a differential update for CF fails (it should remain unless the update succeeds).

Also, fix problem with installer return codes being squashed. This was a regression introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=41322.

BUG=46051,40607
TEST=Cause a differential update to fail, observe that the "ap" value contains a "-full".


Review URL: http://codereview.chromium.org/2773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49346 0039d316-1c4b-4281-b951-d872f2087c98

BUG=46217
TEST=greener tree
TBR=jcivelli
Review URL: http://codereview.chromium.org/2751004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49345 0039d316-1c4b-4281-b951-d872f2087c98

It was unjustly reverted due to flaky unit-test failure.
Original review:

http://codereview.chromium.org/2358003

TBR=ctguil@chromium.org

Review URL: http://codereview.chromium.org/2720003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49344 0039d316-1c4b-4281-b951-d872f2087c98

It seems to be breaking the ExtensionAPIClientTest.CreateWindowW unit-test.

BUG=25564
TEST=none

Review URL: http://codereview.chromium.org/2358003

TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/2782003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49343 0039d316-1c4b-4281-b951-d872f2087c98

the system callbacks about screen changes. Also clean up some comments.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2790002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49342 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2784001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49341 0039d316-1c4b-4281-b951-d872f2087c98

allow linking to succeed when WebCore is built with ACCELERATED_COMPOSITING on
BUG=46116 
Review URL: http://codereview.chromium.org/2714004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49340 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25564
TEST=none

Review URL: http://codereview.chromium.org/2358003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49339 0039d316-1c4b-4281-b951-d872f2087c98

BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2733007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=35198,13044
TEST=FileUtilTest.NormalizeFilePathBasic,FileUtilTest. NormalizeFilePathReparsePoints,FileUtilTest.NormalizeFilePathSymlinks

Review URL: http://codereview.chromium.org/2088006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49337 0039d316-1c4b-4281-b951-d872f2087c98

BUG=18775
TEST=import passwords from Firefox on OS X.
Review URL: http://codereview.chromium.org/2725005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=45734
TEST=none

Review URL: http://codereview.chromium.org/2742003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49335 0039d316-1c4b-4281-b951-d872f2087c98

the outer application's Info.plist.

This ensures that the framework and other contents of the versioned directory
can be bit-for-bit identical for a given version, regardless of configured
Keystone channel. This will enable binary diff updates, because they will not
need knowledge of the channel a user is upgrading from.

BUG=45017
TEST=Keystone still functions properly, channel still shows up in the about
     window and about:version of official builds
Review URL: http://codereview.chromium.org/2791001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49334 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/2562002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49333 0039d316-1c4b-4281-b951-d872f2087c98

Python script to generate code to dynamically bind to GL functions (native GL, OSMesa, EGL or mock GL for unit tests). This replaces GLEW because GLEW doesn't bind to the GLES dialect of GL.
Moved the mock GL code into app/gfx/gl.
Updated the GPU code and AcceleratedSurface to use the new GL bindings.


TEST=trybots
BUG=none

Review URL: http://codereview.chromium.org/2134006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49332 0039d316-1c4b-4281-b951-d872f2087c98

- Add a sound mute icon and swap between sound high and mute icon based on
  volume change;
- Change sound button click to toggle volume mute;
- Show volume control when mouse over sound button and hide it when mouse
  leaves;
- Call volumeChange after we setupPlaybackControls so that volume slider's
  value syncs with media element's volume;
- Removed "controlbutton" class from "volume" element because it is really
  a control button and "controlbutton" style sets its hight to 30px;

BUG=chromium-os:3148
TEST=Verify click on sound button mute/unmute audio and volume slider shows up when mouse over sound button.

Review URL: http://codereview.chromium.org/2722006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49331 0039d316-1c4b-4281-b951-d872f2087c98

as flaky on Windows

BUG=46198
TEST=XP/Vista bots do not turn red due to this test.
TBR=jcivelli
Review URL: http://codereview.chromium.org/2739005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49330 0039d316-1c4b-4281-b951-d872f2087c98

Using XRender to render the chromoting client. This patch has done several things:
1. Rename chromotocol_pb to remoting
2. Defined ChromotingView as the display area of the remote view
3. Implemented X11Client as the client that uses X11 for display
4. Implemented X11View that uses XRender for drawing
5. Fixed several problems in host capturer and encoder

Review URL: http://codereview.chromium.org/2745006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49329 0039d316-1c4b-4281-b951-d872f2087c98

Properly escape user input for notifications, since URL-encoded characters are leaking through as HTML in non-HTML notifications.

BUG=45859
TEST=see bug

Review URL: http://codereview.chromium.org/2743007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49328 0039d316-1c4b-4281-b951-d872f2087c98

Allow creating HTML notifications with the data: scheme.  I've confirmed this doesn't open up the same extra privileges as javascript: scheme, which is still disallowed.

BUG=32470
TEST=create HTML notifications using data: 

Review URL: http://codereview.chromium.org/2779005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49298

Review URL: http://codereview.chromium.org/2749004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49326 0039d316-1c4b-4281-b951-d872f2087c98

a 'minimal' set of rectangles that covers the changed region.

BUG=none
TEST=new unittests added

Review URL: http://codereview.chromium.org/2714007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49325 0039d316-1c4b-4281-b951-d872f2087c98

Calling NaClAppDtor() is unnecessary because the process is about to
exit anyway, and it happens only in the error path because
NaClAppDtor() is not able to shut down running NaCl threads safely.
There is a TODO for its removal in the NaCl tree.

This is related to http://codereview.chromium.org/2659002.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=560
TEST=nacl_ui_test

Review URL: http://codereview.chromium.org/2753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49324 0039d316-1c4b-4281-b951-d872f2087c98

Also added paths to DirectX SDK to common.gypi because ANGLE requires headers and libraries not part of the Windows Platform SDK.

TEST=trybots
BUG=none

Review URL: http://codereview.chromium.org/2685002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49323 0039d316-1c4b-4281-b951-d872f2087c98

Removed redundent version from update string.
Added a line break to the ChromeOS version on test builds to improve appearence
(select and drag to see complete version).
Added margins to multiline edit fields without borders to make them match
single line edit fields in positioning.
Fixed an issue with setting the initial focus for GTK based windows. This
fixes the problem of the cursor showing up in the version field.

BUG=chromium-os:3571 1589 2967
TEST=none

Review URL: http://codereview.chromium.org/2620003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49322 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Build succeeds using 10.6 SDK

Review URL: http://codereview.chromium.org/2790005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49321 0039d316-1c4b-4281-b951-d872f2087c98

It was reverted due to breaking a valgrind test which has since been disabled.

Review URL: http://codereview.chromium.org/2763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49320 0039d316-1c4b-4281-b951-d872f2087c98

I got it to a point where we show HTML content from the extension within an infobar, but there are a few things missing.

Missing pieces:
- Infobar does not size based on the height of its content (between 36px and 72px).
- Infobar content always has a fixed width, but needs to fill out into the available infobar area.
- I've put in code to asynchronously fetch the image for the Infobar, but it needs to be shown and hooked up to the ExtensionAction context menu (same context menu we use for the browser action container icons).
- The background for HTML content should have a gradient, but is just solid blue at the moment.

BUG=39916
TEST=Infobars should show up on GTK.

Review URL: http://codereview.chromium.org/2753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49319 0039d316-1c4b-4281-b951-d872f2087c98

it crashes randomly.
BUG=none
TEST=dev platform

Review URL: http://codereview.chromium.org/2765005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49318 0039d316-1c4b-4281-b951-d872f2087c98

Modify bsdiff 4.3 to create goobsdiff, which is appropriate for use as the Mac
binary differ/patcher.

BUG=45017
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49317 0039d316-1c4b-4281-b951-d872f2087c98

binary differ/patcher.

BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2716005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49316 0039d316-1c4b-4281-b951-d872f2087c98