- 19 Feb, 2020 40 commits
-
-
Emre Kanlikilicer authored
Bug: 1052578: Add verbose logging to GCPW and move most messages under verbose. Change-Id: I2bd51f2c59c0ca2487b5337abec81186784728be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058257Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Emre Kanlikilicer <emreknlk@google.com> Cr-Commit-Position: refs/heads/master@{#742638}
-
Aya ElAttar authored
Bug: None Change-Id: Ie67b4d30b3158e90d403219cbe5913021d09655c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062352 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#742637}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fa9eff37c38a..90c9f66cc4cc git log fa9eff37c38a..90c9f66cc4cc --date=short --first-parent --format='%ad %ae %s' 2020-02-19 cwallez@chromium.org Revert "Provide default implementation of rx::DisplayEGL" Created with: gclient setdep -r src/third_party/angle@90c9f66cc4cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I9ceee50bfc3a9fcb47efa572fb7d07711940b295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063962Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742636}
-
Sergey Poromov authored
This reverts commit 4e60310e. Reason for revert: [sheriff] The tests are still flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=ServiceProcessStateTest.ReadyState https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=ServiceProcessStateTest.ForceShutdown https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests Original change's description: > core: re-enable service process tests > > Two of these were disabled as flaky several years ago. > They have not flaked on my workstation in a few dozen runs, > so let's speculatively re-enable them. > > Bug: None > Change-Id: Iea9a6953d71c5935a4b36f99d75bf81ae83eb464 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057286 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741546} TBR=ellyjones@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I0c7c550223562e6ce61a797ed51a3e6081fc5981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064249Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742635}
-
Ella Ge authored
TBR=kyleju@chromium.org No-Try: true Bug: 856601 Change-Id: Ifb3b7137617e785e66af0c3864f082958205e2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064175Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#742634}
-
Sergey Poromov authored
[sheriff] Disable LoginShelfViewTest.ClickShutdownButtonOnLockScreenWithVerticalInSessionShelf test as flaky Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ash_unittests&tests=ClickShutdownButtonOnLockScreenWithVerticalInSessionShelf Sample run: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3322 TBR=manucornet@chromium.org Bug: 1053980 Change-Id: If67ea27a99c1940d122d2cceebf1389afc7e82de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062281Reviewed-by:
-
Stephan Hartmann authored
GCC throws an error if noexcept is specified on declaration and definition. Specifing on declaration is enough. Bug: 819294 Change-Id: I89f03cf3ee73e63b3f711082315a67f93ccc9dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059999Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742632}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ice5662baf9d84fc2940df8a391df8a9b744d2d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063661Reviewed-by:
-
Robert Sesek authored
Chromium now requires 10.10+, so weak-linking a framework that is always available is not necessary. Bug: 840435 Change-Id: I88bed9c971450441b79b961e3d08443acadc9644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062928Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742630}
-
Robert Sesek authored
Bug: 778317 Change-Id: I4e61655092747c02a18faae294d836876e6015a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063211Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742629}
-
Robert Sesek authored
Bug: 710376 Change-Id: I27b03d27dec71f0f755be83c0de9d72167383fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063531Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742628}
-
Friedrich Horschig authored
(This CL should not have any user-visible impact.) Currently, ShowSuggestionPopup can fail and not show the popup. Additionally, it also requires FillingData to show a popup which is not necessarily correct for popups with the main purpose to display a button to unlock account-stored credentials. This CL ensures that ShowSuggestionPopup always shows the popup when called by moving the failure conditions up. By handling focused username elements early, it simplifies some cases. Bug: 1052783 Change-Id: Ibe4ac9b8d23277325291e144f3db242a6c7774ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061254Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#742627}
-
Finnur Thorarinsson authored
Removing an image decode from the queue should not also delete info about which decode is currently in progress, since that causes the queuing mechanism to think new requests should be sent for decoding. This adversely affects flinging, because requests that had been queued up (but are about to be deleted because the user has already flung past them) would be sent for decoding when new entries are added. This change also removes the Map of current requests, which may give off the impression that we're switching from parallel to serial decoding. However, that is not the case since it was serial to begin with -- we currently only fire off one request at a time, so a Map is not required to track what is in progress. Bug: 1051925, 895776, 656015 Change-Id: Ieaef6d905148eb67d813de397d1582ca151aca79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054249Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#742626}
-
Greg Thompson authored
BUG=none R=zmin@chromium.org Change-Id: Ifa45fb938240b0b4d277ce3bd32c19151140673c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063012 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742625}
-
Nico Weber authored
Bug: 1053958 Change-Id: I07aeae7ebbd5259e030dfad7f1792b44a49b8fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063905Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742624}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<GestureEvent> and DynamicTo<GestureEvent> as new downcast helper 2. Use IsA<GestureEvent>(element) in place of IsGestureEvent(element) Bug: 891908 Change-Id: Ie84f3f844be8687b57bba1a27083e08648f5f491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064163Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#742623}
-
Rushan Suleymanov authored
In case when there are duplicate bookmark nodes and one of them was created locally (and removed shortly) the removed node was trying to access. Also some unit tests were added by the way. Bug: 1050716 Change-Id: I6dc910f9002822cef45dfc4b4cb669eb472199ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057303 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742622}
-
Armando Miraglia authored
This reverts commit 0fce13aa. Reason for revert: It broke the chromium.webrtc bot (example: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Android%20Tests%20(dbg)%20(K%20Nexus5)/5712) Original change's description: > Update and enable CanSetupH264VideoCallOnSupportedDevice. > > - Ensure that call actually uses H264 by checking codec type in > video track stats. > > - Enable CanSetupH264VideoCallOnSupportedDevice test. > > Bug: webrtc:11244, 1047994 > Change-Id: I5ba241828500de9e465d5200e651640394d2ce6a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033511 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Sergey Silkin <ssilkin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742572} TBR=hta@chromium.org,mcasas@chromium.org,guidou@chromium.org,ssilkin@chromium.org Change-Id: I4ea3badad7ed564801a458263eb6366991f2924c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:11244, 1047994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063135Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#742621}
-
Hirokazu Honda authored
RtcVideoEncoderFactory: Create VideoEncoder if it's unknown whether the configured profile is supported crrev.com/c/2035481 delays filling VEA supported profiles in GpuVideoAcceleratorFactoriesImpl because it queries GPU process the supported profiles, instead of referring cached info of GpuInfo instance. Therefore, it can be unknown whether the configured profile on CreateVideoEncoder is supported. We create VideoEncoder in the case, relying that the software encoder fallback happens later if no hw encoder is capable of the profile. Bug: 2035481 Test: webrtc.RTCPeerConnection.* on soraka and kukui Change-Id: I04334073769914005b6ec1a82170457d340f4a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035486 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#742620}
-
Hirokazu Honda authored
crrev.com/c/2035481 delays filling VEA supported profiles in GpuVideoAcceleratorFactoriesImpl because it queries GPU process the supported profiles, instead of referring cached info of GpuInfo instance. If getVEASupportedProfiles() is called in flight, the function reports as if the HW encoders support no profile. The issue due to this timing problem happens in fact on some CrOS devices. This CL mitigates the timing issue by setting the initialized VEA supported profiles to ones based on cached info of GpuInfo instance. Besides, this clarifies a caller of getVEASupportedProfiles() that the function returns nullopt if the factory hasn't got the results from GPU process. Bug: b:147404923 Test: webrtc.RTCPeerConnection.* on soraka and kukui Change-Id: Ie6867cb6f79934f66cf8550e2d41ec54671a5487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035461 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Monica Basta authored
Bug: 1053875 Change-Id: Ic3bcb4886d1d9033809853a784029de683863f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062417 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#742618}
-
Rune Lillesveen authored
Bug: 1053965 Change-Id: I610aecce124cbda287eb05030955415f66b84676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062977 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#742617}
-
David Van Cleve authored
This change adds an interface for performing the Trust Tokens protocol operations of issuance, redemption, and request signing. It is a common parent CL of three changes, each of which adds the implementation of a single protocol operation. The plan is for URLLoader to be provided a request helper on requests suitable for executing Trust Tokens operations (and no helper otherwise). Bug: 1042962 Change-Id: I8861ca08047da6b55bf90e67dca1b4f458598615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052468 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#742616}
-
Nico Weber authored
Bug: 804884,1053958 Change-Id: I7182072d3530ab3459373c6b45cca2cf753b6edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063904 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Peng Huang authored
The problem is because the swapbuffers ack callbacks could be called with any gl context. So we need call MakeCurrent before calling BeginWrite(). Bug: 1052745 Change-Id: I03f5e8b6f3ca1e53b9d407789f3f131a10f49356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062906Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742614}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f25db531203d..1b1227d53e69 Created with: gclient setdep -r src-internal@1b1227d53e69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifd10bfbe5b1d69006c75d070eca2b198477d75e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063819Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742613}
-
Michael Lippautz authored
MSVC is unsupported, see https://groups.google.com/a/chromium.org/g/chromium-dev/c/fuVUxe1q6EA/m/is1EpDqwBQAJ Bug: 1053958 Change-Id: Ibd8872d1b3be7509c2eec17f4e7d83cbb7398406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063131Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742612}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0aa86a7ae831..21e5074dcdb8 git log 0aa86a7ae831..21e5074dcdb8 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 cwallez@chromium.org Revert "Create VulkanImageWrappingTests for dma-buf images" 2020-02-18 hob@chromium.org Create VulkanImageWrappingTests for dma-buf images Created with: gclient setdep -r src/third_party/dawn@21e5074dcdb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:996470 Tbr: cwallez@google.com Change-Id: Ib8de94143b3924e0741434f14f482324be60c421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063821Reviewed-by:
-
Fredrik Söderquist authored
This means that patterns that are in error are cached rather than being attempted to be rebuilt. This is consistent with how gradients are handled. Bug: 109212 Change-Id: I72d418c78cc3314021d21977a53e93b3f7686757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062971 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#742610}
-
Francois Doray authored
This reverts commit 47b6798d ("https://chromium-review.googlesource.com/c/chromium/src/+/1976500). This commit is suspected to have affected the 95th percentile of SessionRestore.ForegroundTabFirstPaint4 on Mac. Reverting it temporarily to verify that hypothesis. TBR=sky@chromium.org Bug: 1035419, 1020549, 1022492 Change-Id: Ide1787a64b28c9f731ee1cb4f8bf0c451bb072e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062692Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#742609}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e22500101fbd..e68978417ac4 git log e22500101fbd..e68978417ac4 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-19 janscheffler@chromium.org Inform developers about the ServerTiming API 2020-02-19 jacktfranklin@chromium.org Revert "Fix TS + Ninja integration" 2020-02-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-02-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-18 tross@microsoft.com Fix focusing stop button after timeline profiler initialization 2020-02-18 jalyn@microsoft.com Fix watch expression deletion bug 2020-02-18 eirage@chromium.org Add save&load to input panel 2020-02-18 jonathan.garbee@chromium.org DevTools: scroll console scopes if more exist than can be seen 2020-02-18 tvanderlippe@chromium.org Remove typedefs from {resources,sdk,search,security}-legacy.js 2020-02-18 tvanderlippe@chromium.org Remove typedefs from {source_frame,sources,text_editor,text_utils}-legacy.js 2020-02-18 tvanderlippe@chromium.org Fix screenshot image_diff for Linux 2020-02-18 tvanderlippe@chromium.org Remove typedefs from timeline{_model}-legacy.js 2020-02-18 tvanderlippe@chromium.org Remove typedefs from web_audio-legacy.js 2020-02-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-18 tvanderlippe@chromium.org Revert "Extract `toBase64` into `StringUtilities`" 2020-02-18 wolfi@chromium.org Revert "Reland "Use 1000 not 1024 for kB and MB calculations"" 2020-02-18 jacktfranklin@chromium.org Fix TS build checking for bridge files 2020-02-18 jacktfranklin@chromium.org Extract `toBase64` into `StringUtilities` 2020-02-18 tvanderlippe@chromium.org Fix TS + Ninja integration 2020-02-18 wolfi@chromium.org Fix layout issue in add-location-table 2020-02-18 kimanh@chromium.org [devtools] Make wasm source url clickable 2020-02-18 wolfi@chromium.org Reland "Use 1000 not 1024 for kB and MB calculations" Created with: gclient setdep -r src/third_party/devtools-frontend/src@e68978417ac4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1011811,chromium:1035309,chromium:1038461,chromium:1050423,chromium:1050549,chromium:1051458,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib131cc87d0ca0aed94c09de6e339e5471444e09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063820Reviewed-by:
-
Sergey Poromov authored
This reverts commit ef364481. Reason for revert: [sheriff]: Consistent failures on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome First failed run: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3315 Original change's description: > Allow mixed-security content in promoted PWA windows > > Prior to this CL, mixed-security content was blocked entirely in > standalone PWA windows with scopes. This CL allows those PWAs to display > mixed-security content, but when this happens, the window will show the > CustomTabBarView with the URL and a "Not Secure" indicator to indicate > the presence of mixed content. > > Screenshot: > https://bugs.chromium.org/p/chromium/issues/attachment?aid=432401&signed_aid=JeW6cXlVCQ3bSebdZ-FoJg==&inline=1 > > This removes a behavioural difference between promoted PWAs and "create > shortcut" apps without manifest scopes. > > > Bug: 910016 > Change-Id: Ic9b3bbdba14218bb1ad8fd4f2ca8cf47cd4e3a37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041380 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742515} TBR=alancutter@chromium.org,estade@chromium.org,pbos@chromium.org,dominickn@chromium.org,glenrob@chromium.org Change-Id: I677c642411685d840b793fc2f0d507188e0dbae7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063173 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8962e435..ac15544d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5064e3d44b50e6ad1eb2f877e78c55160e0894b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063752Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742606}
-
Anton Bikineev authored
This adds counterparts of gc metrics for minor GCs. Bug: 1029379 Change-Id: I32726cb374af73d80094639248d3b467d77aedb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061251 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742605}
-
Sergey Poromov authored
This reverts commit d81e22c1. Reason for revert: [sheriff]: Depends on a CL https://crrev.com/c/2041380 that: Consistent failures on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome First failed run: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3315 Original change's description: > desktop-pwas: Do not prefer apps with scopes over those that don't > > This CL updates AppRegistrar::FindAppWithUrlInScope() to ignore the > IsShortcutApp() status of a web app and just use the default scope the > same as a specified scope. > > This makes web apps with default scopes will be treated the same > as web apps with scopes specified in their manifest reducing the > behavioural differences between promoted installs and "create shortcut" > installs. > > Bug: 910016 > Change-Id: Ifa2c94132fa806a013a6d210dff0d7505df4c3f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051464 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742533} TBR=alancutter@chromium.org,glenrob@chromium.org Change-Id: Ia8a3cc96521c77ce26a0b4268862d6751d4c94b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063017Reviewed-by:
-
Antonio Gomes authored
This CL allows us to remove content/common/frame_message_structs.cc|h as well as to clean up references to FrameMsg_ViewChanged_Params in content/common/content_param_traits.cc|h. BUG=1051135 R=dtapuska@chromium.org, haraken@chromium.org, kinuko@chromium.org Change-Id: I175b6412452b09ffc15083be305dee31a69584f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062091 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#742603}
-
Viktor Semeniuk authored
This change allows to copy password into clipboard by clicking corresponding button in menu item. Button was implemented in previous CL. Bug: 917337 Change-Id: I28ceb294b2f4e7cb0f783154b4307c4888a477ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054094 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Robbie Gibson authored
This separate protocol is in preparation for moving the text zoom coordinator usage code from BVC to BrowserCoordinator. Once there's a separate protocol, the BrowserCoordinator can implement it instead of the BVC. Bug: 1052818 Change-Id: I5215864219a8419e4bb170bff3a89b31f3a80c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062997 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#742601}
-
Torne (Richard Coles) authored
It's possible for there to be a pending Java exception for the current thread when the Android version of MessagePumpForUI is called, because the ALooper we use to schedule our message pump iterations can also have other callbacks running on it and ALooper doesn't check for exceptions between callbacks. One example of this is render thread exceptions on P and earlier, which are thrown by sending a message to the UI thread in native - if we get unlucky and our MessagePumpForUI runs afterward in the same ALooper polling cycle, we will crash the first time we make a JNI call, resulting in a confusing stack trace. Avoid this by just skipping our callback execution if there is a pending exception set at the start of the callback. If the exception ends up not being fatal (caught by something higher up the stack) then our callback will be run again in the next iteration, as the fd has not been reset. Bug: 1052830 Change-Id: Ie13ceab6c2c1b988189791546fa12a5529ef17b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062434Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#742600}
-
Wez authored
This reverts commit eddd5af6. Reason for revert: Appears to have caused ARM64 and Debug bots to fail on waterfall, due to MISSING files. Original change's description: > [fuchsia] Migrate to use Fuchsia SDK Vulkan package rules. > > Bug: 1050703, fuchsia:46115 > Change-Id: I3e8c795e616bc803513efd33cff64ca95a625875 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058968 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742595} TBR=wez@chromium.org,sergeyu@chromium.org Change-Id: If4eedd955b95391da6fc45454876a93411ecb986 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050703, fuchsia:46115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063018Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#742599}
-
