- 16 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abd178f66131..b37886f4e33a Created with: gclient setdep -r src-internal@b37886f4e33a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If4b9a7a77fc2e99090403f8f11562eb857344480 Reviewed-on: https://chromium-review.googlesource.com/c/1338950Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608654}
-
Kentaro Hara authored
This reverts commit 56f3274d. Reason for revert: This broke VideoFrameSubmitterTest on Linux ChromiumOS MSan Tests. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9636 Original change's description: > Reland "Fix video quad rect and surface output rect" > > This is a reland of 1dfd4418 > > Original change's description: > > Fix video quad rect and surface output rect > > > > Video surface output rect didn't take rotation into account so when > > SurfaceAggregator would stretch content to fill bounds, it would end up > > with the wrong scaling factors (squash in one dimension and expand in > > another) since the surface quad's bounds (in the embedder) were rotated. > > > > To work around this (or by accident), VideoFrameResourceProvider was > > passing the rotated size as the quad's rect which doesn't make sense > > intuitively. This also worked by accident with DirectComposition > > overlays because of applying another scaling which would fix the aspect > > ratio again. > > > > This change makes it possible to use the |quad_to_target_transform| as > > is, without having to apply an aspect ratio correcting scaling, and to > > assume that the quad's rect is in the pre-transform space. > > > > Bug: 904035 > > Change-Id: Ia55e44f1f2b49b8d368a97af54f3ce9d90a81234 > > Reviewed-on: https://chromium-review.googlesource.com/c/1334971 > > Reviewed-by: enne <enne@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Reviewed-by: Frank Liberato <liberato@chromium.org> > > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#608495} > > TBR=enne@chromium.org,kbr@chromium.org,liberato@chromium.org > > Bug: 904035 > Change-Id: I278a0ea2c5507f01ea13b31d2090b5f99537c7c3 > Reviewed-on: https://chromium-review.googlesource.com/c/1338418 > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608596} TBR=kbr@chromium.org,enne@chromium.org,sunnyps@chromium.org,liberato@chromium.org Change-Id: I55b589ea5325317bc271928d9d2b388bec344174 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904035 Reviewed-on: https://chromium-review.googlesource.com/c/1338586Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#608653}
-
Ben Pastene authored
In preparation for their move from chromium.fyi to chromium.fuzz. Bug: 903591 Change-Id: Ia749e03db24092063592e3c26ab09c997eb3d974 Reviewed-on: https://chromium-review.googlesource.com/c/1338565 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#608652}
-
Peter Kasting authored
Bug: none Change-Id: I18dab792fec5856e8511fd9d98e3b7234e1edb60 Reviewed-on: https://chromium-review.googlesource.com/c/1338661 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#608651}
-
Yutaka Hirano authored
It's no longer failing. Bug: 870173 Change-Id: Iad2a11e4d91f93fc13b52c0d93de01a84af12b61 Reviewed-on: https://chromium-review.googlesource.com/c/1337222Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#608650}
-
David Benjamin authored
This is a reland of https://chromium-review.googlesource.com/c/1324878, but with the suppression added for macOS layout tests too. TLS 1.0 and 1.1 are deprecated. See: https://security.googleblog.com/2018/10/modernizing-transport-security.html https://groups.google.com/a/chromium.org/d/msg/blink-dev/EHSnAn2rucg/oiu0DoQ0CAAJ As part of that deprecation, show a console warning in DevTools and also add a Blink-level UseCounter. (We typically measure things at the connection or request level for network features, but since we're plumbing this in anyway, go ahead and add one.) I mirrored the plumbing and UseCounters for Symantec certificates. TBR=carlosil@chromium.org,kinuko@chromium.org,pfeldman@chromium.org Bug: 896013 Change-Id: I06c93e3ac82f9b07c92193ca75e4c2d8d711d34d Reviewed-on: https://chromium-review.googlesource.com/c/1338559 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#608649}
-
Steve Anton authored
Bug: 874296 Change-Id: I694325a0cc85ad520c18762e34ba05e2204e2c74 Reviewed-on: https://chromium-review.googlesource.com/c/1286902 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#608648}
-
Takashi Toyoshima authored
This is mechanical, but a large change set. As we discussed at a code review in the past, let's rename all CORS related names. Bug: 875759 Change-Id: I1d626f229ac3ddc7a1d83e921449db0d1472af1c Tbr: sky@chromium.org, mkwst@chromium.org, rdevlin.cronin@chromium.org, dalecurtis@chromium.org, mmenke@chromium.org, kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1333018 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#608647}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e69406dde9dd..5dd873597e78 git log e69406dde9dd..5dd873597e78 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 benjhayden@chromium.org Add chromeperf-app for v2spa Created with: gclient setdep -r src/third_party/catapult@5dd873597e78 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I05a0693089ba32cce42ca144e49ecd72e69a4554 Reviewed-on: https://chromium-review.googlesource.com/c/1338157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608646}
-
Eric Karl authored
Currently, CommandBufferHelper implements MemoryDumpProvider. This interface is never used, as the relevant function is directly called from classes which hold CommandBufferHelpers. In fact, calling OnMemoryDump generically via the MemoryDumpProvider interface is risky, as there are locking concerns. Removing this interface. Bug: 529678 Change-Id: Ic60c4afaf697d07881a8b12343ca3f2a1d9a7608 Reviewed-on: https://chromium-review.googlesource.com/c/1336512Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#608645}
-
Shawn Gallea authored
Move wl_shell interface out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: Ic9b4a8d0cb68c30c0836af103c326aee70f66811 Reviewed-on: https://chromium-review.googlesource.com/c/1323969 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#608644}
-
Peter Kasting authored
The majority of callsites already did this, but not every caller. This will enable some future changes that DCHECK or otherwise rely on this root window. Bug: none Change-Id: I8ff51012d180be7e21df8f5c1aa4539cff7c7102 Reviewed-on: https://chromium-review.googlesource.com/c/1338466Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#608643}
-
Roberto Carrillo authored
R=stgao,liaoyuke,jbudorick Change-Id: Ie573c6d137743c69f5fa869edd47adf86edb4265 Reviewed-on: https://chromium-review.googlesource.com/c/1338110Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Reviewed-by:
-
Mikel Astiz authored
These unit tests are the last examples of tests depending on implementation details of SESSIONS sync, where overriding a feature toggle was necessary. Instead, let's embrace the new USS implementation. Longer term, it may make sense to remove this dependency altogether and migrate these unit tests to a test-specific OpenTabsUIDelegate. For anything fancier, we should use proper sync integration tests. This intermediate step makes it more obvious that there aren't behavioral changes between the two sync implementations. Bug: 895455 Change-Id: I1c3f26ec3037d71908cbf090644bf0580d8fd41b Reviewed-on: https://chromium-review.googlesource.com/c/1301435 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#608641}
-
Melissa Galonsky authored
Fixes crbug/875224, by preventing users from creating content_settings that can never take effect. Bug: 875224 Change-Id: I1d7f0c7b504cd26ce929490de345e3591f0e2861 Reviewed-on: https://chromium-review.googlesource.com/c/1277925Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Melissa Galonsky <mgalonsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#608640}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/59f7623f1c0b..09299cdfd973 git log 59f7623f1c0b..09299cdfd973 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 thestig@chromium.org Add IFX_StreamWithSize with just a GetSize() method. 2018-11-15 tsepez@chromium.org Cover some more orphaning in cpdfsdk_baannot.cpp. 2018-11-15 thestig@chromium.org Make IFX_WriteStream not retainable. 2018-11-15 thestig@chromium.org Remove IFX_ReadStream. 2018-11-15 thestig@chromium.org Remove more IFX_SeekableStream pure virtual overrides. Created with: gclient setdep -r src/third_party/pdfium@09299cdfd973 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:901654 TBR=dsinclair@chromium.org Change-Id: I050e750b37a8b3e1f63fbb02709b29fd208cd56e Reviewed-on: https://chromium-review.googlesource.com/c/1338398Reviewed-by:
-
Steven Bennetts authored
This includes: * keyboard_end_to_end_browsertest.cc * keyboard_controller_browsertest.cc Note: This renames the tests in keyboard_controller_browsertest from VirtualKeyboard* to KeyboardController* to better match the file name and the specific area of test focus. This also contains some minor cleanup to keyboard::KeyboardController that primarily impacts the in-progress SingleProcessMash implementation, but should not affect the classic Ash implementation (except to clean it up some). It is useful to isolate these changes from the larger CL introducing AshKeyboardUI. Bug: 876138 Change-Id: I8aa7e5da1f04f0d8b17a58e9582608e6159bee29 Reviewed-on: https://chromium-review.googlesource.com/c/1336250 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#608638}
-
Ria Jiang authored
The OOPIF bug on cros was fixed https://bugs.chromium.org/p/chromium/issues/detail?id=877762, re-enabling VizHitTestDrawQuad by default for cros platforms. Bug: 804888 Change-Id: I93cd237bc0631b6e1f77ae59232937697ce45ef2 Reviewed-on: https://chromium-review.googlesource.com/c/1337644Reviewed-by:
-
Ria Jiang authored
HitTestDataProviderAura is no longer in use; all previous use cases were updated to use HitTestDataProviderDrawQuad. Clean up HitTestDataProviderAura related code. Bug: none Change-Id: I2e67411c1c145cf5e5fe527c79ec2bfbd00c6570 Reviewed-on: https://chromium-review.googlesource.com/c/1338327Reviewed-by:
-
Amos Lim authored
register('data://blah') should throw a TypeError instead of SecurityError. If scopeURL’s scheme is not one of "http" and "https", reject promise with a TypeError and abort these steps.[1] [1]: https://w3c.github.io/ServiceWorker/#start-register-algorithm Bug: 877138 Change-Id: Ic1e8cae52ec9393152044aa37da389eb499165bb Reviewed-on: https://chromium-review.googlesource.com/c/1189688 Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Reviewed-by: -
Ken Rockot authored
Changes Identity so that none of its fields are optional. All Identity objects are now either empty and invalid, or fully populated and refer to a specific, concrete service instance that did, does, or may exist at some point. Bug: 902590,904240 Change-Id: I5b35909afb39b2588f0841d5b1713a6f7c06c800 Reviewed-on: https://chromium-review.googlesource.com/c/1333126Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#608634}
-
Reilly Grant authored
This change adds an additional note to the comment for this method highlighting the fact that the RenderFrameHost may change during navigation and that this method only returns the final host. To observe the change WebContentsObserver::RenderFrameHostChanged() should be used. Bug: 898645 Change-Id: I716923758fae621c596b599c754e998d86324d20 Reviewed-on: https://chromium-review.googlesource.com/c/1330757 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#608633}
-
Lukasz Anforowicz authored
This CL modifies WebViewPlugin::WebViewHelper::CreateURLLoaderFactory method so that it delegates creation of URLLoaderFactory to the frame that hosts the plugin. Bug: 891872 Change-Id: I002503730f98adbced92d61c7d74eb53f4865e98 Reviewed-on: https://chromium-review.googlesource.com/c/1259824Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#608632}
-
Martin Kreichgauer authored
This adds an AuthenticatorAttachment field to CtapMakeCredentialRequest. The field is initialized by MakeCredentialRequestHandler from the equivalent field on its AuthenticatorSelectionCriteria parameter, and is consumed by WinNativeApiAuthenticator to initialize the equivalent parameter passed to the Windows WebAuthn API. Also moves the AuthenticatorAttachment enum out of AuthenticatorSelectionCriteria and into fido_constants.h, and fixes a common misspelling of attachment throughout the code. Also migrates the allowList and excludeList parameters of the Windows WebAuthn API to an updated version that respects the PublicKeyCredentialDescriptor's transports field. Bug: 898718 Change-Id: I4dbc80929fcb6c4ff534822acd4b80410c14ae7f Reviewed-on: https://chromium-review.googlesource.com/c/1335785 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#608631}
-
Tom Tan authored
This change makes the code compile for Widnows ARM64. Also AMD GPU could not be available on every device, so assume that it could be ignored to load. Bug: 893460 Change-Id: Idae2a64fa9ad8f9e3ad9843abc128e48b85a82c5 Reviewed-on: https://chromium-review.googlesource.com/c/1335281Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#608630}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/859e6809332f..abd178f66131 Created with: gclient setdep -r src-internal@abd178f66131 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id5a325a48ff187956e1f85c5f3f5345a7ce8aa8b Reviewed-on: https://chromium-review.googlesource.com/c/1338700Reviewed-by:
-
Joel Hockey authored
Bug: 878324 Change-Id: I2f1448019648c70329d991485b31b7e0ccc4bde1 Reviewed-on: https://chromium-review.googlesource.com/c/1337147Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#608628}
-
Zhenyao Mo authored
BUG=902684 TEST=bots R=piman@chromium.org Change-Id: I0c7267b6c23313e9613d38ecdf399707cbd8b11c Reviewed-on: https://chromium-review.googlesource.com/c/1338494 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608627}
-
Shawn Gallea authored
Move gaming input interface out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: I9202fc459a4f1095d20f83e7d1b64822beca9028 Reviewed-on: https://chromium-review.googlesource.com/c/1323693 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
-
Ryan Meier authored
Change-Id: I708c29a84a5751d4fa2ddae3490e49ef76d80a2f Reviewed-on: https://chromium-review.googlesource.com/c/1336468 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Kenneth Russell authored
This reverts commit 953f1c19. Reason for revert: Collided with https://chromium-review.googlesource.com/1338619 Original change's description: > Suppress flaky canvas-teximage-after-multiple-drawimages.html test > > The canvas-teximage-after-multiple-drawimages.html webgl test is flaky > on MacOS and Android qualcomm. Add test suppression. > > BUG=905682 > TBR=kbr@chromium.org > > Change-Id: Id8fdb70f6dae6383c6d734916a3a724adbe00ea3 > Reviewed-on: https://chromium-review.googlesource.com/c/1338560 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608605} TBR=rjkroege@chromium.org,kbr@chromium.org Change-Id: I863bac3201092184e47fbcd08acba8d1d83a2ffb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905682 Reviewed-on: https://chromium-review.googlesource.com/c/1338864Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608624}
-
Fredrik Söderquist authored
We were always serializing as the completed (all keywords present) form, which is not the shortest canonical form. https://svgwg.org/svg2-draft/painting.html#PaintOrder Fold the ComputedStyleUtils helper into the PaintOrder CSSProperty class, since this is very specific to this property. Matches WebKit and almost Gecko (which seems to handle some "two keyword" cases differently.) Bug: 904898 Change-Id: Ib796a111e601485e339fdf2739a587fb5f893b8a Reviewed-on: https://chromium-review.googlesource.com/c/1335579 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#608623}
-
Stephen Martinis authored
The bot has been running into test timeouts, so increase the number of shards used to run tests. Might adjust the exact number of shards after. Bug: 905842 Change-Id: Icf0ab65e70a0b48b7b97e95318ecabdac31d63aa Reviewed-on: https://chromium-review.googlesource.com/c/1338569Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I865d0bca89708d85854c907580384c5d2698b693 Reviewed-on: https://chromium-review.googlesource.com/c/1337649Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#608621}
-
Wenzhao Zang authored
It's unnecessary after the system tray button UI is added. Also the locale list in Settings is not customized for Demo Mode. Bug: 877749 Change-Id: I17c0ab8cab457a5a47416797677ce3b17d9b4b1b Reviewed-on: https://chromium-review.googlesource.com/c/1334333 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#608620}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/59127a5d3941..8ada4d523eb4 git log 59127a5d3941..8ada4d523eb4 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 iannucci@chromium.org [cipd] Roll cipd to allow long paths on Windows Created with: gclient setdep -r src/third_party/depot_tools@8ada4d523eb4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id745e3d750b7f4893aafa1c8320c926320f0f4ea Reviewed-on: https://chromium-review.googlesource.com/c/1338158Reviewed-by:
-
Steven Bennetts authored
This CL updates the remaining ChromeVirtualKeyboardDelegate calls to use ChromeKeyboardControllerClient instead of direct calls to keyboard::KeyboardController. This also adds OnKeyboardEnableFlagsChanged to ensure that the enable flags are cached accurately on the chrome side. Bug: 876138 Change-Id: I3022fa78df7c589c22579b4b4e3b2a3279622f81 Reviewed-on: https://chromium-review.googlesource.com/c/1330894Reviewed-by:
-
Evan Stade authored
ui::Cursor now holds the data necessary for custom cursors, although for simplicity this patch still converts to CursorData for serializing over mojo. CursorFactoryOzone goes back to being a true singleton, which shouldn't be used from client code in Mash (in Oop Mash, it's actually null; in single process Mash it is avoided by checking the feature switch). This patch also makes some tweaks to how custom web cursors are stored as ui::Cursors, which shouldn't impact other platforms but brings the ui::Cursor representation into alignment with the PlatformCursor representation for ozone. As a future cleanup we should be able to get rid of CursorData and serialize ui::Cursor directly. Bug: 904039, 734668 Change-Id: I4168c0266899bd276c60a0ac6a286b3a79df572f Reviewed-on: https://chromium-review.googlesource.com/c/1334968 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#608617}
-
Josh Horwich authored
Add a checkbox in the ARC opt-in dialog presented during new-user setup that will allow the user to review the relevant settings after the new-user flow. Bug: 901184 Test: New-user opt-in with setting checked/unchecked Change-Id: I061f6c139298323a32b262b7a1463c70c9a640e7 Reviewed-on: https://chromium-review.googlesource.com/c/1334096Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Josh Horwich <jhorwich@chromium.org> Cr-Commit-Position: refs/heads/master@{#608616}
-
Xianzhu Wang authored
This disables DCHECK(new_display_item_list_.IsEmpty()) for transient paint controllers in the destructor. We could require the client of a transient controller to always commit and finish cycle, but allowing to abort seems simpler and harmless. Bug: 904971 Change-Id: If1bd15b55cbad0e1871eaed4a8d30b78e8a54d86 Reviewed-on: https://chromium-review.googlesource.com/c/1336953Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608615}
-
