GitLab

Wilco emits action key codes directly from kernel instead of
function-key codes. This CL adds new Dom codes or fixes existing Dom
codes accordingly. They are:

key code             Dom code
-----------------------------------------------------
KEY_SCALE            SHOW_ALL_WINDOWS (new)
KEY_SWITCHVIDEOMODE  DISPLAY_TOGGLE_INT_EXT (new)
KEY_ZOOM             ZOOM_TOGGLE (fix evdev/xkb value)
KEY_ASSISTANT        LAUNCH_ASSISTANT (fix HID value)

Also removed invalid dom-code values for ZOOM_TOGGLE and
LAUNCH_ASSISTANT.

Bug: 949730, 950099
Change-Id: I3028cdcab82a4f806fc3a84f5b5bd64ffea053ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549725Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Georges Winkenbach <gwink@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648388}

This makes it possible to store the WorkspaceController as a property
of desks containers instead of tracking each in the RootWindowController

BUG=866622
TEST=ash_unittests pass.

Change-Id: I7f47c3c9adecbfb03a4b374bc36f57d2ec3dbc1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553715Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648387}

When we are able to support VP9 profile 2 (10 bit color), we need to
change some parameters in the decoder creation to use P010 vs NV12.
Similarly, when creating textures we also need to use a different
pixel and DGXI format.

Bug: 764779
Change-Id: I5d5e8176be9759b101ea6952ecf7fe3f31b80cfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548815
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648386}

Change CrContainerShadowBehavior to support optionally adding a bottom
shadow/border, which defaults to the mirror image of the top shadow.

Use the behavior in CrDialog, to apply top and bottom scrolling borders.

This will also allow Print Preview's sidebar, which implements this
behavior, to add a bottom shadow in a followup CL.

Bug: 945619
Change-Id: I4dd441f90bb9d157170e0c30d915f961d7758f0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552131
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648385}

This patch adds three use counters:
- kHTMLImportsOnReverseOriginTrials
- kElementCreateShadowRootOnReverseOriginTrials
- kDocumentRegisterElementOnReverseOriginTrials
to count the APIs usage on a trial token for measuring
removing circumstance.

TEST=(virtual/origin-trials-runtimeflags-disabled/)http/tests/origin_trials/webexposed/

Bug: 946876
Change-Id: I5db5969f7f1c21fd60f4a867396a336bff2c99a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547474Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648384}

RenderWidgetHostView.

Bug: 908139
Change-Id: Ie9254f2688e01ba20ec55f665d276bf90ce9fe65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464648Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648383}

BUG=782120

Change-Id: Ie1fb67157fee61768c3f34421892c7d4c54c5107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554211
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648382}

*Initially this CL was reverted since it wasn't cleaning up properly
and following tests would fail.

- Also makes some small changes to InfobarCoordinator to support non
animated banner presentation.

Bug: 911864
Change-Id: Ie2097786e887e88e31a042ce558d4f012f035da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554839Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648381}

This CL:
  - ensures perf fyi builder configurations are handled the same
    way as perf non-fyi builder configurations.
  - merges the handling of builders & testers to allow for future
    execution of isolated script tests on builders.
  - removes the now-vestigial OBBS fyi config.
  - removes the now-vestigial telemetry_perf_tests_without_chrome
    gn target.

Bug: 807273
Change-Id: I5ee7f4181da6084bf46e581d5cd583fea6faaad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1387689
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648380}

https://swiftshader.googlesource.com/SwiftShader.git/+log/484e08e0fae6..60da1580366f


git log 484e08e0fae6..60da1580366f --date=short --no-merges --format='%ad %ae %s'
2019-04-05 sugoi@google.com Support pNext chain entries in vkCreateImageView
2019-04-05 sugoi@google.com Sample location properly marked as unsupported
2019-04-05 sugoi@google.com Input aspect support in vkCreateRenderPass
2019-04-05 bclayton@google.com SpirvShader: Implement descriptor set arrays


Created with:
  gclient setdep -r src/third_party/swiftshader@60da1580366f

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/126330097
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: Ia4e34fb27813a29c52a6b10d41a68aaba9742bcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554598Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#648379}

Small cleanup now that all Skia representaitons have a
SharedContextState - no need to pass in GrContext.

Change-Id: I05aafe172d05bceeb36247ee5005ac8cfdf00b80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554297
Commit-Queue: Eric Karl <ericrk@chromium.org>
Auto-Submit: Eric Karl <ericrk@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648378}

Chrome OS OOBE Welcome screen was incorrectly shown after restart to Gaia
screen.

This Cl fixes the issue.

Bug: 949768
Change-Id: I3399b2bf8e5700dbb3a0228fe4a6bc8b961b9c90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555045
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648377}

The function and its two callers are defined but not used. Hence, this
patch removes them. This also makes it easier to change
PreviousLinePosition to a hit test based approach (*)

(*) http://bit.ly/2WB70oR

Bug: 947179
Change-Id: I3c5cc306c973cfd61b75269b666be1dc871870b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554134Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648376}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I1b2803a254e06187d2693fc6d71b405e8cdc2e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553919Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#648375}

Bug: 941488
Change-Id: I16a2db2e2dfdf2bd0ec8ec448038d8eb701740c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552408Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648374}

Fix a crash in PluginManager::UnregisterNaClModule which happens since
OnExtensionUnloaded can be called twice in succession for an extension (which is
itself a bug). Also, remove an incorrect DCHECK in
PluginManager::RegisterNaClModule (Extension manifests are free to add duplicate
module paths). Add a regression test.

BUG=460699, 708230

Change-Id: Ie89b73d57cf3d02c4b300cc082f22a928c780f6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549852
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648373}

This reverts commit 2806da1a.

Reason for revert: Reverting as suspect for https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux%20(dbg) breakage.

Original change's description:
> [traffic_annotation] use {link,proto}_deps instead of deps
> 
> I will deprecate deps in proto_library for improved build throughput.
> 
> Instead,
> * use proto_deps for proto file generating task dependency
> * use link_deps for link/compile time dependency
> 
> Bug: 938011
> Change-Id: Ieb1281a9653fdfdd1add3594b2b19a138aff37ff
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503275
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#637670}

TBR=thakis@chromium.org,tikuta@chromium.org,rhalavati@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 938011
Change-Id: I6b3725b8e1b68fbc280a8b8be87b4825b526e4c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555334Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648372}

This CL consolidates the bitmasks in the QueryContentProtectionTask
response, and factors out the mapping of connection type to content
protection method for reuse in ApplyContentProtectionTask.

Bug: 929449
Test: display_unittests
Change-Id: I14fa63e8cdb0dc70df3745cd5324b8c54643eb40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553582
Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648371}

https://skia.googlesource.com/skia.git/+log/c7755d947084..7340124746df


git log c7755d947084..7340124746df --date=short --no-merges --format='%ad %ae %s'
2019-04-05 halcanary@google.com SkString: simplify impl
2019-04-05 khushalsagar@chromium.org remote fonts: Validate format on deserialized glyph.
2019-04-05 jvanverth@google.com Fix WritePixels and ReadPixels for MacOS Metal
2019-04-05 michaelludwig@google.com Support clip masks for SaveLayerRec and drawSpecial in Ganesh
2019-04-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-05 halcanary@google.com SkPDF: Add regression benchmark for multiple path clips
2019-04-05 nifong@google.com Add helper for loading files, use let


Created with:
  gclient setdep -r src/third_party/skia@7340124746df

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:949000,chromium:947381
TBR=jlavrova@chromium.org

Change-Id: Ic3dd3b5f8c277896587fcaa73770d0c19340a98d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554594Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#648370}

BUG=937880

Change-Id: I165c6de88f4d63080287704a066728757c2a5c26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531561
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648369}

https://chromium.googlesource.com/angle/angle.git/+log/b9a71427efd2..5f388c245293


git log b9a71427efd2..5f388c245293 --date=short --no-merges --format='%ad %ae %s'
2019-04-05 timvp@google.com Vulkan: dEQP-EGL.functional.image.modify.*


Created with:
  gclient setdep -r src/third_party/angle@5f388c245293

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Change-Id: Ic09a0ec00333fd843e818693990c50594650d739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554596Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#648368}

This is the same as the container builder's layout object, so use that
instead.

Also moves where we set the margins to the "post-layout" site along
with other copy-back calls.

There should be no behaviour change.

Change-Id: I198dc1548592ccb26553438cab6a2488d395b144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554792Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648367}

Now that mdns resolutions is supported in CUPS, we don't need to hold
the resolved uri in the printer object anymore.

BUG=758018,936251
TEST=Able to configure and print using mdns resolution in CUPS

Change-Id: I2f149e6558be4689e7b13122a5853feba7ea6b8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551683
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648366}

This is from current origin/stable label.
commit 2cacdff921fb067d93cf476a10f7decb1a9fb766 (tag: v81.0.0, origin/stable)

Bug: 947496
Change-Id: I50b84317caf2fdb9ef8e68d56d6cc6c691986880
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554133Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648365}

The //fuchsia/engine:test_support target was depended upon by multiple
targets while it was only actually used by the
//fuchsia/engine:web_engine_unittests target.

Bug: 922635
Change-Id: I5b943e30629c934c7bdfdb8db0894933d66c7d50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555373Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648364}

The cause is TabModel#setIndex() event is fired when undoing the first
tab, before the tab actually undo in TabGroupModelFilter.

This CL is a band-aid fix for M74. We cache the selected tab that is not
exist in the TabGroupFilterModel. And try to select that tab on the
next addTab()/undo call. This will fix the current crash and will not
causing any side effects on TabGroupModelFilter normal usage.

Bug: 948518
Change-Id: Ic65e521baebe65c54b1033f6be35dd2dbdd1a676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552281Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648363}

Web Share now rejects share attempts if a file with a
non-approved MIME type is being shared.

Design doc:
https://docs.google.com/document/d/1wfcy-hVjEbSuxlBjj_2azqmov8s9ECG1Fm7XoS_XUus/edit?usp=sharing

Also, ensure temporary files are created with "." before the extension.

Bug: 903010
Change-Id: I318e9c908bd9816df35d1d2d64679c984f6bdff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554465Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648362}

Revert https://crrev.com/c/1504434 since it is not an app list
only problem. Fix it in MoveWindowToEnsureCaretNotInRect so that
it does not move a window beyond work area top.

Bug: 936381
Test: Additionally test with a browser window using the repo steps.
Change-Id: I4be2ee7173748af10acefb7ed880514424644ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555245
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648361}

Bug: 899386
Change-Id: I5e9157be89a2965bb5261898ed03d843bfbf189b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536685Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648360}

Bug: 781257
Change-Id: I4fbebdd57a03ca5329d7020dcaf47150fd3ec928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551728
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648359}

Removed the use of std::map and checked all Blink accessibility code for any usage of std containers.
R=dmazzoni@chromium.org

Change-Id: I9a285b1aa018d973b3d75d738ab6f2b492a3df2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554144
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648358}

This is a reland of 402ea29b

Original change was reverted due to msan failures. Indeed it
didn't take care of the case of window destruction during
move. This CL includes its fix.

Original change's description:
> Process touch events during the tab-dragging window move
>
> When the touch events move very quickly on detaching, some
> touch events are already queued, those queued touch events
> aren't processed properly.
>
> - Detach() aren't releasing the capture on the source widget.
>   This means those queued touch events are targeted to the
>   source widget instead of the moving widget, but the touch
>   history is already transferred to the moving widget, which
>   makes troubles on gesture recognition. We can release the
>   capture on the detach on this specific situation.
> - the recognized gestures are sent to the root window of
>   the moving widget and nobody can handle. The new class
>   RemainingGestureEventHandler handles them.
> - RemainingGestureEventHandler should not handle events
>   originated from ET_TOUCH_CANCELLED -- some test cases
>   actually fail if so. ET_TOUCH_CANCELLED can happen internally
>   within the browser (like Window::CleanupGestureState()),
>   but that's not the intention of this class.
>
> Bug: 943316
> Test: the new test case in interactive_ui_tests
> Change-Id: I679562d7707342874960dd7ff4d70d749f1ad437
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545113
> Reviewed-by: Jun Mukai <mukai@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Jun Mukai <mukai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#647789}

Bug: 943316
Change-Id: Ice077b4e53309a2a59b254581da7e6dd0f3b409c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553171
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648357}

Bug: 877147
Change-Id: I9bd31a9f9731e3cd50f43e246f9d0565f107bd9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546058Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648356}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dbc721d65f0d..9198ef8ede66


git log dbc721d65f0d..9198ef8ede66 --date=short --no-merges --format='%ad %ae %s'
2019-04-05 nodir@google.com [bot_update] Default to refs/heads/master
2019-04-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@9198ef8ede66

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:940214
TBR=agable@chromium.org

Change-Id: I30e05bb762b0cbb9c78c4cf47c5aecfd16ad45bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553455Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#648355}

Currently, the test pages only check once (on page load) if the specific
session type is supported. If a device is disconnected while a user is
on the page, the "Enter VR" button does not update with that change.
This change enables support within the button to listen to device change
events and update it's state based on whether the specified session
types are supported, and changes all of the pages to consume this new
option.

Given the nature of xr-barebones, it implements this directly as well
rather than relying on the button.

Bug: 873409
Change-Id: I4be8a50f88f796b2e4d7d9f0834d4d77cda7d586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554643Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648354}

This slipped through the cracks earlier. Our approved
strings include a string to use when no description is
available. We decided to use the same string if the
result was empty, and if there was a server failure.

Bug: 905419

Change-Id: I7c8692f550999428ba2f08ecbc14e3fed6b05a14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552444Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648353}

Bug: 950081
Change-Id: I6a2fb232edaa4f04f761d64e5d223f5fc0471176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555044
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648352}

This mostly entailed running clang-format -i * followed by git cl
format. I also manually edited some if statements to reduce nesting.

Change-Id: Ibfd24d1d763435e590a93a7fc5d05572e7fa35d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548068Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#648351}

This experiment has been defaulted to true for a while now.
Simplified the code.

Bug: 884724
Change-Id: I47fb608b703f292ad8edfe8a91ab9a446fe4d6ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554295Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648350}

The padding should alwas be the height of the tab strip, as set in XML.

BUG=946991

Change-Id: Ifd701988a90ec4289979df4632b2999ae4f14d70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553827Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648349}