- 03 Jan, 2019 40 commits
-
-
Mike Reed authored
Change-Id: Ib6f73ceed8efec413ae657e5f3a69bb7c9d0c5fa Reviewed-on: https://chromium-review.googlesource.com/c/1394009Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#619696}
-
Steven Bennetts authored
For trivial file moves in policy browser tests: TBR=emaxx@chromium.org Bug: 918682 Change-Id: Ie46d17b4d1fb5ff6f106f7662a192eb580888d84 Reviewed-on: https://chromium-review.googlesource.com/c/1392605 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#619695}
-
Fabrice de Gans-Riberi authored
Fuchsia integration tests have been flaking on the waterfall. Disable them until the underlying issue is fixed. This also separates castrunner unit tests and integration tests in two different test suites. Bug: 917192, 918586 Change-Id: Idd3ad424559b7d68679d16d6a2e56929c33e029a Reviewed-on: https://chromium-review.googlesource.com/c/1393887Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#619694}
-
François Beaufort authored
This CL removes window.IsActive() DCHECK in PiP window controller as this result is no longer always true anymore in Chrome OS due to https://chromium-review.googlesource.com/c/chromium/src/+/1357819. Bug: 916370 Change-Id: I1b1ff742baa76a4147f162aa620cfc5657fb8783 Reviewed-on: https://chromium-review.googlesource.com/c/1392344Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#619693}
-
Takumi Fujimoto authored
Re-enable the following tests using test UI API / Views Cast dialog: MediaRouterIntegrationBrowserTest.OpenLocalMediaFileInCurrentTab MediaRouterIntegrationBrowserTest.OpenLocalMediaFileInNewTab MediaRouterIntegrationBrowserTest.OpenLocalMediaFileCastFailNoFullscreen DISABLED_OpenLocalMediaFileFailsAndShowsIssue cannot be enabled yet because the Views dialog doesn't support showing an issue not associated with a sink. DISABLED_OpenLocalMediaFileFullscreen cannot be enabled yet due to a known flake in which the local media doesn't go fullscreen on its own. Bug: 900248 Change-Id: I0e95df58d3e2f92394e5f4b3e25a942a2b514eb9 Reviewed-on: https://chromium-review.googlesource.com/c/1351896 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#619692}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2b9d702c09f1..74ec15010f8a git log 2b9d702c09f1..74ec15010f8a --date=short --no-merges --format='%ad %ae %s' 2019-01-03 yunchao.he@intel.com Assigning nullptr to descriptor's nextInChain in C++ is unneeded Created with: gclient setdep -r src/third_party/dawn@74ec15010f8a The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2b192885a4b5d54aed96278aa502473f06c3e808 Reviewed-on: https://chromium-review.googlesource.com/c/1394201Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619691}
-
Thomas Guilbert authored
RemoteMediaPlayer.seek() is broken in some versions of GMS Core. This CL works around the issue by sending a manual seek message. This CL also updates getApproximateCurrentTime() to return the seek time when there is a seek in flight. This prevents a regression with MediaTime never being updated when seeking backwards. Bug: 914072 Change-Id: I35943b1201fa2e4f32efe440f4def689c955d9ec Reviewed-on: https://chromium-review.googlesource.com/c/1393666Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#619690}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/59345cdef38c..26c5b54fb09f $ git log 59345cdef..26c5b54fb --date=short --no-merges --format='%ad %ae %s' 2018-12-31 cclauss CircleCI: Test for Python 3 syntax errors and undefined names (#1522) 2018-12-30 behdad Fix automake warnings 2018-12-30 cclauss print() is a function in Python 3 (#1520) 2018-12-30 cclauss Python 3 fixes to gen-os2-unicode-ranges.py (#1521) 2018-12-30 ebrahim [cmake] Enable C++11 on CMake (#1519) 2018-12-30 behdad Ouch! Fix build on C++<11 2018-12-30 behdad Fix ubsan with passing nullptr to qsort() 2018-12-27 behdad Fix build on C++ < 11 2018-12-27 behdad [vector] Fix warning 2018-12-27 behdad [aat] Minor 2018-12-27 behdad [vector] Remove use of arrayZ() by using casts 2018-12-27 behdad [vector] Remove static_array 2018-12-27 behdad [vector] Use allocated = -1 to signify failure 2018-12-27 ariza fix lealk with cff2::accelerator_templ_t::topDict (#1517) 2018-12-24 behdad [vector] Change pre-alloced count from 8 to 2 2018-12-23 behdad Fix a few warnings 2018-12-22 behdad [iter] Fix warning 2018-12-22 behdad [set] Add iter_t as alias to const_iter_t 2018-12-22 behdad [set] Change to const_iter 2018-12-22 behdad [set] Cache length in iterator 2018-12-22 ebrahim Minor, remove redundant inline 2018-12-22 ebrahim Minor, tweak spaces 2018-12-22 ariza CFF renaming (#1507) 2018-12-21 behdad [set] Actually derive iterator from hb_sorted_iter_t<> 2018-12-21 behdad [set] Implement unified iterator 2018-12-21 behdad [set] Mark some internals protected 2018-12-21 behdad [iter] Add hb_sorted_iter_t<> 2018-12-21 behdad [iter] Change operator[] operand to be signed 2018-12-21 behdad [array] Port to hb_iter_t<> 2018-12-21 behdad [iter] Change __more__ to fallback to __len__ 2018-12-21 behdad [array/vector] Rename len to length 2018-12-21 behdad [iter] Split hb_iter_t<> into hb_iter_t<> and hb_iter_mixin_t<> 2018-12-21 behdad Adjust internal header dependencies 2018-12-21 behdad [Makefile.am] Minor 2018-12-21 behdad [iter] Include from hb.hh 2018-12-21 behdad [iter] Move hb_fill() and hb_copy() to hb-iter.hh 2018-12-21 behdad [iter] Disallow copy-construction or assignment of hb_iter_t<> 2018-12-21 behdad [iter] Fix hb_copy() return value 2018-12-21 behdad [iter] Add const_iter_t / const_iter() 2018-12-21 behdad [iter] Make hb_fill() take collection type, not iter 2018-12-21 behdad [array] Add more hb_array() / hb_sorted_array() variants 2018-12-21 behdad [serialize] Use component_list by reference, as a supplier 2018-12-21 behdad [iter] Add .random_access() 2018-12-21 behdad [iter] Fix __end__() 2018-12-21 behdad [array] Remove copy constructor 2018-12-21 behdad Fix bot 2018-12-21 behdad Minor 2018-12-21 behdad [iter] Fix test again 2018-12-21 behdad Minor 2018-12-21 behdad [iter] More prototyping 2018-12-21 behdad [iter] Make hb_fill() and hb_copy() take iterators 2018-12-21 behdad [iter] Add hb_fill() 2018-12-21 behdad [iter] Start prototyping hb_copy() 2018-12-21 behdad [iter] Showcase implicit casts 2018-12-21 behdad Rename 2018-12-21 behdad [iter] Rename 2018-12-21 behdad [iter] First sample use 2018-12-21 behdad [iter] Add bidirectionality 2018-12-21 behdad [iter] Sketch new iterator design 2018-12-21 behdad [iter] Add empty test 2018-12-21 behdad Revert "Remove unused hb-iter.hh" 2018-12-20 behdad [vector] Add operator bool 2018-12-20 behdad Rename 2018-12-20 behdad Remove unused typedef 2018-12-20 behdad 2.3.0 2018-12-20 behdad [serializer] Add operator << 2018-12-20 behdad Add hb_assign(obj, value) 2018-12-20 behdad [serialize] Adjust ClassDef 2018-12-20 behdad Fix code on big-endian gcc / clang 2018-12-19 behdad Minor [skip ci] 2018-12-19 behdad [saitnize] Minor 2018-12-20 fanc999 Fix build on older Visual Studio versions (#1499) 2018-12-19 behdad [sanitize] Use hb_static_size instead of ::static_size 2018-12-19 ebrahim [test] Fix test-name-table.cc leak issue 2018-12-18 behdad [arrays] Add hb_ubytes_t for unsigned char 2018-12-18 behdad [arrays] Remove hb_supplier_t<> 2018-12-18 behdad [serialize] Propagate error from hb-face 2018-12-18 behdad [serialize] Streamline error propagation 2018-12-17 behdad Remove unused hb-iter.hh 2018-12-17 behdad [arrays] Minor tweaks to hb_supplier_t 2018-12-17 behdad [arrays] Rename Supplier to hb_supplier_t 2018-12-17 behdad Hide hb_addressof() 2018-12-17 behdad Enable __builtin_* on clang 2018-12-17 behdad Add hb_addressof() and use it to fix bug after hb_bytes_t merge 2018-12-17 behdad Enable system extensions in hb.hh 2018-12-17 philip.race Fix Solaris use after free (#1495) 2018-12-17 behdad Remove define GNU_SOURCE 2018-12-17 behdad Fix more warnings 2018-12-17 philip.race Fix Solaris Trailing comma in enum warnings (#1490) 2018-12-17 ebrahim Lower coretext_aat shaper priority (#1488) 2018-12-17 ebrahim Remove redundant void from C++ sources (#1486) 2018-12-17 ebrahim Minor, fix two more ArrayOf incorrect operator logic 2018-12-17 behdad [arrays] Minor fix 2018-12-17 behdad [array] Add cast operator to add const to Type 2018-12-17 behdad [array] Remove problematic constructor 2018-12-17 behdad [array] Add arithmetic operators 2018-12-17 behdad [array] Return Crap instead of Null if Type is not const 2018-12-17 behdad [array] Add operator * 2018-12-17 behdad [array] Add constructor from fixed-size array 2018-12-16 behdad [array] Organize (...) Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,behdad@google.com,drott@chromium.org,eae@chromium.org,jshin@chromium.org Change-Id: I5c849e836fdb002678ac0ce5bd9016d5169e26e4 Reviewed-on: https://chromium-review.googlesource.com/c/1394312 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#619689}
-
edchin authored
SnapshotCallback has an image parameter that was being passed by value. This CL converts it to pass by reference to be more efficient. Change-Id: I020192a7d6886e81ce317f3789516adff69dba03 Reviewed-on: https://chromium-review.googlesource.com/c/1394008Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619688}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5efb17b5..eb333167 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I81c2fcdae6f32df8fc38956c280cb8700894b024 Reviewed-on: https://chromium-review.googlesource.com/c/1394388Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619687}
-
Nico Weber authored
Remove a redundant entry, and add a dedicated bug line for nacl_helper_bootstrap now that I understand what's going on there. Bug: 918882 Change-Id: Id5c12c9096783dda98b9c80c4de0a9db860d1aa7 Reviewed-on: https://chromium-review.googlesource.com/c/1394707Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#619686}
-
Michael Lippautz authored
Setting a property to undefined that has not been set before can lead to V8 transitioning that wrapper object. This can lead to allocation which in turn can trigger garbage collection. Bug: 916022 Change-Id: I01bfb4af4514138c81a507acbb462b024dc89025 Reviewed-on: https://chromium-review.googlesource.com/c/1394587 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#619685}
-
Tibor Goldschwendt authored
This toast is shown if the VR module is not installed yet when launching Chrome on standalone VR headsets. Bug: 914498 Change-Id: Iaac05f06e20a40d62dca52916bb158914edb4320 Reviewed-on: https://chromium-review.googlesource.com/c/1393556Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#619684}
-
Joshua Pawlicki authored
Split from https://chromium-review.googlesource.com/c/chromium/src/+/1344880 Bug: 907219 Change-Id: Ia855b6ad41bf1a4465233cfd857fae3c1a759c54 Reviewed-on: https://chromium-review.googlesource.com/c/1393403 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#619683}
-
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 Change-Id: I85c15d42228d0e1c88f366af263d86dca15ba44e Reviewed-on: https://chromium-review.googlesource.com/c/1390424Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#619682}
-
Evan Stade authored
Test is SwitchAccessPredicateTest.IsActionableFocusableElements TBR=jamescook@chromium.org Bug: 918876 Change-Id: I8f3de7f4f089d1d9fc9e67a7012baa6c1dfca9f1 Reviewed-on: https://chromium-review.googlesource.com/c/1394396Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#619681}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d9f036200e10..35caab8b839f git log d9f036200e10..35caab8b839f --date=short --no-merges --format='%ad %ae %s' 2019-01-03 perezju@chromium.org [cli services] Fix encoding issue on non-json error responses Created with: gclient setdep -r src/third_party/catapult@35caab8b839f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:917376 TBR=sullivan@chromium.org Change-Id: I1ff55149492fb34eda4d3607ad2e1ede731b07d1 Reviewed-on: https://chromium-review.googlesource.com/c/1394202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619680}
-
Pavel Golikov authored
Introduced ozone_extra_path build argument. It points to additional platforms file to include while building ozone platforms. It points to //ui/ozone/ozone_extra.gni by default for backward compatibility. Bug: 918118 Change-Id: If6db25b3693f319955fdec54d9f91d47422a6e38 Reviewed-on: https://chromium-review.googlesource.com/c/1391687Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#619679}
-
Jonathan Metzman authored
Document how to do Linux-x86-ASAN and Linux-x86-ASAN-debug builds. Mention that x86 can be used with UBSan, but probably not with other configurations. Also document "libs" variable for "fuzzer_test" gn template. Change-Id: I70ff71a5ea192b10c7bc495cc657fde34c0653b1 Bug: 917000, 852428 Reviewed-on: https://chromium-review.googlesource.com/c/1394386Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619678}
-
Evan Stade authored
There are still some failing, so instead of filtering many individual tests, filter them all. TBR=jamescook@chromium.org BUG=831826 Change-Id: I42236102982a270917c96c6a9c030b6bd029543f Reviewed-on: https://chromium-review.googlesource.com/c/1394392Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#619677}
-
Peter Kasting authored
Bug: 918742 Change-Id: Ib1f99893a80ec033e2c986f93d6f7cf00722569b TBR: rsesek Reviewed-on: https://chromium-review.googlesource.com/c/1394024Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#619676}
-
Steven Bennetts authored
This is just: ./tools/git/move_source_file.py chromeos/chromeos_switches.* chromeos/constants/ ./tools/git/move_source_file.py chromeos/chromeos_pref_names.* chromeos/constants/ ./tools/git/move_source_file.py chromeos/chromeos_paths.* chromeos/constants/ ./tools/git/move_source_file.py chromeos/chromeos_features.* chromeos/constants/ And some minor associated DEPS changes. This will allow more strict DEPS checking for components depending on //chromoes:chromeos_constants (but not //chromeos). It also moves most of the remaining src files from src/chromeos/. For mechanical file moves: TBR=sky@chromium.org Bug: 918682 Change-Id: Ie1cd23b0b69d719cc48d9e60a27eb3c60dbd771d Reviewed-on: https://chromium-review.googlesource.com/c/1393559Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#619675}
-
Jonathan Metzman authored
1. Remove disclaimer about LPM not having a track record. 2. More consistent line length. 3. Change `targeted_code` to `targeted_function` 4. Improve example for multiple inputs. 5. Fix link. 6. Improve wording. Change-Id: I8486c544773bbbd17dd12591ed1c602213275d98 Bug: 769578 Reviewed-on: https://chromium-review.googlesource.com/c/1394310Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619674}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/031b028c78a9..943e9fdb7885 Created with: gclient setdep -r src-internal@943e9fdb7885 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib071133c08c1ef664fd37604ee7f9a775b3f8477 Reviewed-on: https://chromium-review.googlesource.com/c/1394684Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619673}
-
Tommy Steimel authored
This reverts commit bae1ec12. Reason for revert: Causing failures on Linux Tests bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/74581 Original change's description: > Fix RTCPeerConnection-track-stats.https.html expectations. > > The tests started failing in an earlier WPT import, see > https://crbug.com/832501. > > TBR=hta@chromium.org > > Bug: 832501 > Change-Id: If53c927e03dabb60158c61befc5a29d1c45bba1f > Reviewed-on: https://chromium-review.googlesource.com/c/1394307 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619631} TBR=hbos@chromium.org Change-Id: I6b02e4b99e003b1ee1e686eea1bf3b36aadb4b39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832501 Reviewed-on: https://chromium-review.googlesource.com/c/1394705Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619672}
-
Nico Weber authored
Bug: none Change-Id: Ib2ceb021eee6edee3fe7fabd1e022063d6e1432b Reviewed-on: https://chromium-review.googlesource.com/c/1394703Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#619671}
-
Dan Harrington authored
We need to track the state of the auto-fetch notification that's associated with a SavePageRequest. This change adds a new field to SavePageRequest for this purpose, updates the database schema for storing the field, and adds access methods for setting the value through RequestCoordinator. Bug: 883486 Change-Id: I6baa6d240efdedc210d6917870047812cba02381 Reviewed-on: https://chromium-review.googlesource.com/c/1374114 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#619670}
-
Vladimir Levin authored
This patch adds a test that does an acquire and update, then before the update finishes it removes the element from the DOM and does a commit. This fails the update promise. This test is meant to be paired with another one already checked in where we don't call a commit and also expect the update to fail. R=chrishtr@chromium.org Bug: 882663 Change-Id: Idbe58b5162d4189da05379ed2044a0e620ce5dd9 Reviewed-on: https://chromium-review.googlesource.com/c/1393451Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619669}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8966b55644c2..31c4bcb210bd git log 8966b55644c2..31c4bcb210bd --date=short --no-merges --format='%ad %ae %s' 2019-01-03 reed@google.com rm unneeded encoding param Created with: gclient setdep -r src/third_party/skia@31c4bcb210bd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Iee40d8351cc572579bf4daa1d818ba6a79a58df4 Reviewed-on: https://chromium-review.googlesource.com/c/1394683Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619668}
-
Christian Fremerey authored
As per new report on crbug.com/849636, this device seems to be another instance of drivers reporting the device as available in MediaFoundation but not actually working with it. Bug: 849636 Change-Id: I21764713826e4f86cf600e6e30b75a3d9c3fb087 Reviewed-on: https://chromium-review.googlesource.com/c/1393804Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#619667}
-
Tommy Steimel authored
This reverts commit 70ffd447. Reason for revert: Causing failures on Mac 10.13 bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/8478 Original change's description: > [ChromeDriver] Handle pauses in Perform Actions > > W3C spec allows the app to specify pauses within Perform Actions command > (https://w3c.github.io/webdriver/#dfn-dispatch-actions). Updating > ChromeDriver to handle these pauses. > > Bug: chromedriver:1897 > Change-Id: I533179f4a9f2216bfacf0f4fdb539c8f898bed07 > Reviewed-on: https://chromium-review.googlesource.com/c/1392281 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619506} TBR=lanwei@chromium.org,crouleau@chromium.org,johnchen@chromium.org Change-Id: Ia03b2b463e5baa93ec1e96c773f38eb9c82f2808 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:1897 Reviewed-on: https://chromium-review.googlesource.com/c/1394664Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619666}
-
Rohit Rao authored
Fixes a call to an NS_UNAVAILABLE inititalizer. BUG=917351 Change-Id: I3c1471f3fe0764c8e03d026b28bf7b90e44fe9f5 Reviewed-on: https://chromium-review.googlesource.com/c/1394390 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619665}
-
Tommy Steimel authored
Test is flaky on ci bots: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/30508 Change-Id: I3b2658193ac62f53eed1db9d470c67b28987fc38 Reviewed-on: https://chromium-review.googlesource.com/c/1393664Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619664}
-
Jeremy Roman authored
ListHashSet is deprecated. Bug: 614112 Change-Id: I7b726aed29a92e8e61499b7a2455de0855735267 Reviewed-on: https://chromium-review.googlesource.com/c/1392273Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619663}
-
Dan Harrington authored
It is possible to reach this function in incognito mode, in which case offline_page_model will be null. Added code to handle this condition instead of crash. Bug: 918119 Change-Id: Iddad53677e168c565a20dfc888d1ccb213a54fe7 Reviewed-on: https://chromium-review.googlesource.com/c/1393465Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#619662}
-
Kevin Ellis authored
Update interpolation of transform lists to reflect recent changes to the spec (https://drafts.csswg.org/css-transforms/#interpolation-of-transforms). * If the transform lists are of different lengths, but the transformations are pairwise compatible to the end of the shorter list, extend the shorter list with corresponding identity transforms. * If the transform lists are incompatible, perform pairwise transforms for compatible entities at the start of the list and fallback to matrix interpolation for the remaining transformations. * Fix discrete fallback. Bug: 860391, 267348, 918643 Change-Id: I8b2d770e354f3d77dad00e088a2eafe6c1ad655a Reviewed-on: https://chromium-review.googlesource.com/c/1372025 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#619661}
-
Mike Reed authored
Change-Id: Ia01ee627f15389ca8fc79d87b93227d434719ecf Reviewed-on: https://chromium-review.googlesource.com/c/1394011Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#619660}
-
Brandon Mayer authored
Enabled edge embedding computation in subgraphs via feature flag. Additionally, the named_template_arguments allows graph template arguments to be modified at runtime via legacy javascript API until IPC refactor work is complete. This cl looks to support m72 and should be deprecated either at the end of beta m72 or early m73. Bug: 914959, b/120986539 Change-Id: I2b42c0989800afa9339ae8176a1a833c85ddcbdd Reviewed-on: https://chromium-review.googlesource.com/c/1376812Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Brandon Mayer <bmayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#619659}
-
cathiechen authored
If the zero-height marker container is triggered in the previous layout pass, and in this layout pass, marker become inside or marker container has other child, we need recover from zero-height, the height of marker container should be restored to auto not the height of li. This test passes in Firefox, WebKit as well as LayoutNG. Bug: 918488 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3c65a2d27f1b8dfef13c41bfe804cd1f9aab89c5 Reviewed-on: https://chromium-review.googlesource.com/c/1393129 Commit-Queue: cathie chen <cathiechen@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#619658}
-
Mason Freed authored
This should have been cleared, but wasn't. Likely the cause of https://crbug.com/917589. Bug: 917589 Change-Id: I68c54ea84dba60c67fea5566a057055c6349f36e Reviewed-on: https://chromium-review.googlesource.com/c/1394085Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#619657}
-