GitLab

I find these function names confusing. I have to stop and read the code each
time I try to use them to figure out what they're going to do.

Part of the confusion is that ClampToMin sets the components to the _maximum_
of the two sizes/vectors. It's also not clear from the function name which of
the two objects is acting as the 'Min'. This is mitigated by the parameter names
and local variables passed to the function, but it would be nice if the name
of the function itself made this clear.

a.ClampToLowerBound(b) makes it clear both that b is acting as the lower bound
and how and when a is going to be altered.

Other names I've considered (for ClampToMin -- the suggestions for ClampToMax
are analagous):
  ClampIfSmallerThan(other)
  SetComponentsToMax(other)
  Union(other) (for sizes)

R=danakj,sky
BUG=None

Review URL: https://chromiumcodereview.appspot.com/14367021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203017 0039d316-1c4b-4281-b951-d872f2087c98

The following issues have been fixed:
1) If one or more panels in the stack are collapsed, the live preview is not shown correctly.
2) If the whole stack is minimized by the system, the live preview is not shown correctly.

BUG=177743
TEST=Manual tests by collapsing a panel or system-minimzing a stack and then hover over the taskbar icon

Review URL: https://chromiumcodereview.appspot.com/16035007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203016 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rogerta@chromium.org
BUG=228833

Review URL: https://chromiumcodereview.appspot.com/15977002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203015 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242540

Review URL: https://chromiumcodereview.appspot.com/15675011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203013 0039d316-1c4b-4281-b951-d872f2087c98

Removal of this Flush is correlated with an increase in file
corruption on ChromeOS, so we're going to try and put it
back and see if our file corruption problems get better.

TBR=sky@chromium.org
BUG=chromium:236093
TEST=ran unit tests, ran on device.

Review URL: https://codereview.chromium.org/15937015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203012 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203010 0039d316-1c4b-4281-b951-d872f2087c98

per match pattern, by disallowing wildcard hosts and wildcard subdomains
of TLDs (com) and effective TLDs (appspot.com).

R=yoz@chromium.org
BUG=55316

Review URL: https://chromiumcodereview.appspot.com/15862011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203009 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151350:151373&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/16171013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203008 0039d316-1c4b-4281-b951-d872f2087c98

verify-translations.py script is not longer necessary because
grit is now used to generate message.js files.

R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/15650018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203007 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77656

Review URL: https://chromiumcodereview.appspot.com/16019015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203006 0039d316-1c4b-4281-b951-d872f2087c98

This code does to things to make sure that immersive mode gestures operate
correctly regardless of the screen orientation. The first is to move the
registration of the filter to the root window, which guarantees that all of the
events will be seen by the filter.

The second change is to extend the bounds the filter is watching above by the
maximum bezel side. This makes sure that under rotation swipes that start on the
bezel are still handled.

BUG=241545, 244269
TEST=Rotated screen through all rotations and confirmed that swipe in/out works
     as expected in immersive mode.

Review URL: https://chromiumcodereview.appspot.com/15734011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203005 0039d316-1c4b-4281-b951-d872f2087c98

Also fixed a bug in ExtensionBrowserTest::InstallOrUpdateExtension
where it would silently fail to upgrade a non-idle extension.

BUG=178542

Review URL: https://chromiumcodereview.appspot.com/16138003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203004 0039d316-1c4b-4281-b951-d872f2087c98

Unfortunately, we can't keep this function in webkit/glue because not everyone
who links in Blink depends on webkit/glue. For example, cc uses WebString but
doesn't depend on webkit/glue.

IMHO, the best solution to all these constraints is to put this function in
base. It's concerned with concepts that make sense in base (strings and
character sets). The only thing odd about the function is that it accepts
Latin-1 or UTF-16, which is because of the underlying string representation in
Blink.

Review URL: https://chromiumcodereview.appspot.com/15732022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203003 0039d316-1c4b-4281-b951-d872f2087c98

Splitting from the original patch here, crrev.com/14942008
to only include 'webkit' specific changes

BUG=102853

Review URL: https://chromiumcodereview.appspot.com/14680012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203002 0039d316-1c4b-4281-b951-d872f2087c98

This function returns an object whose keys are the notification
IDs of all notifications created by that extension.

BUG=240924

TBR=miket@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15715008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203001 0039d316-1c4b-4281-b951-d872f2087c98

The return status of apt-cache show doesn't actually indicate whether a package has any candidates, so we now call grep on apt-cache pkgnames to determine this.

BUG=244473

Review URL: https://chromiumcodereview.appspot.com/15741015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203000 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202999 0039d316-1c4b-4281-b951-d872f2087c98

Build both v1 and v2 apps on the bots. Change #1: building both V1 and V2 apps at the same time. V1 app goes to remoting/remoting.webapp and V1 app goes to remoting/remoting.webapp.V2.

BUG= 239941

Review URL: https://chromiumcodereview.appspot.com/16031003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=236029
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/15774005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202997 0039d316-1c4b-4281-b951-d872f2087c98

Created class UserAddingScreen controlling new mode.
Type of login UI explicitly set in hashtag after URL.

BUG=239209

Review URL: https://chromiumcodereview.appspot.com/16002004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202996 0039d316-1c4b-4281-b951-d872f2087c98

Add a flag to make IME capitalize the first letter of each new sentence.

Also adding EditorInfo.IME_FLAG_NO_EXTRACT_UI flag that goes together with
EditorInfo.IME_FLAG_NO_FULLSCREEN but somehow was never included before.

BUG=232426
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16141003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202995 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig@chromium.org
BUG=none
TEST=less memcheck issues

Review URL: https://chromiumcodereview.appspot.com/16094012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202994 0039d316-1c4b-4281-b951-d872f2087c98

The new scheduling approach consists of both changes to how frames are scheduled
and when input events are processed.  This patch renames a switch for the former
and adds a switch for the latter, to be used for ongoing development.

BUG=240945

Review URL: https://chromiumcodereview.appspot.com/16043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202993 0039d316-1c4b-4281-b951-d872f2087c98

This changes the semantics of ProduceTexture to not replacing the current texture by a dud, but instead keeping the existing one, that it also puts into the mailbox. It changes the semantics of ConsumeTexture to deleting the current texture, and replacing it by the mailbox contents (without taking it out of the mailbox). The texture becomes shared. The mailbox is now effectively a weak pointer onto the texture.

BUG=230137

Review URL: https://chromiumcodereview.appspot.com/14188053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202992 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=demo for SDK
R=binji@chromium.org, noelallen@chromium.org

Review URL: https://codereview.chromium.org/15732012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202991 0039d316-1c4b-4281-b951-d872f2087c98

These headers have moved from Source/Platform/chromium/public to
public/platform. This CL updates CC's references to the old location to point
to the new location. After this CL lands, I'll remove the forwarding headers
that are letting these references still work.

TBR=jamesr@chromium.org
BUG=239545

Review URL: https://chromiumcodereview.appspot.com/16085003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202990 0039d316-1c4b-4281-b951-d872f2087c98

Reorder the NativeViews attached to a view via the kViewHostKey according to the position of the view in the view hierarchy.
 
BUG=237650
Test=NativeWidgetAuraTest.*

Review URL: https://chromiumcodereview.appspot.com/15114002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202987 0039d316-1c4b-4281-b951-d872f2087c98

I missed a device scale place in my previous patch.

BUG=242976
TEST=tools/perf/run_measurement --browser=android-content-shell smoothness_measurement tools/perf/page_sets/top_25.json --page-filter=hl=e

Review URL: https://chromiumcodereview.appspot.com/16057003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202986 0039d316-1c4b-4281-b951-d872f2087c98

so that we can copy texture as is.
- store gfx::Display object for mirrored display instead of
  just id because we need one for mirror root window.
- use host window's coordinate for mirror cursor window.

BUG=239776
TEST=covered by unit tests

Review URL: https://chromiumcodereview.appspot.com/15730006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202985 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202983 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244597
TBR=ben

Review URL: https://chromiumcodereview.appspot.com/15649011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=238224
R=joi@chromium.org, joth@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/16073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202981 0039d316-1c4b-4281-b951-d872f2087c98

R=jochen@chromium.org
TBR=jamesr@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/15952012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202980 0039d316-1c4b-4281-b951-d872f2087c98

much identical.

BUG=226965
R=jln@chromium.org

Review URL: https://codereview.chromium.org/16019017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202979 0039d316-1c4b-4281-b951-d872f2087c98

* Name/comment animation constants for clarity.  Make constants used in multiple
  places in the class be private static members to scope them to the class (not
  really a big deal as there are no other classes in the .cc file).
* Inline the calculations from GetTextAnimationSize() into GetPreferredSize()
  and nuke |visible_text_size_| as a result.
* To enable the above change, add a background_showing() method to tell us when
  the background painter is being painted.  This is basically equivalent to "are
  we animating", but also includes the "paused animation" state (during which
  the actual animation is technically reset).  Then use this everywhere
  appropriate.  This results in one functional change: if the content setting
  model changes our type while we're paused, we now just silently ignore it.
  This seems more correct, and I doubt this case can happen anyway.
* Eliminate pointless arg to OnClick().
* Make |background_painter_| a pointer, which will be necessary when it switches
  to being an image grid painter.
* Eliminate unnecessary #includes and a using directive.
* Other changes to braces, newlines, variable names, code order, comments, etc.
  with the aim of clarity, brevity, and stylistic consistency.

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/16209002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202978 0039d316-1c4b-4281-b951-d872f2087c98

BUG=235099

Review URL: https://chromiumcodereview.appspot.com/16075004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202977 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 1675fd68.
It causes DCHECK failure on an Android bot.

BUG=235188
TBR=vollick

Review URL: https://codereview.chromium.org/16018011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202975 0039d316-1c4b-4281-b951-d872f2087c98

Follow up on: https://codereview.chromium.org/14358005/

BUG=234733

Review URL: https://chromiumcodereview.appspot.com/15003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202974 0039d316-1c4b-4281-b951-d872f2087c98

The GetTotalNodesCount() function is called sufficiently often that it
makes sense to spend some effort optimizing its implementation.

The current implementation uses some traversal functions that are fairly
slow, especially since GetSuccessorId() was made more expensive by the
implementation of UniquePositions.

This change moves the implementation into the syncable::Directory.  This
allows it to take advantage of the Directory's internal data structures
and avoid unnecessary lookups. 

BUG=248143,238621

Review URL: https://chromiumcodereview.appspot.com/15322003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141788
TEST=Updated media_unittests.
R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/15660002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202971 0039d316-1c4b-4281-b951-d872f2087c98