GitLab

This CL is to fix the regressions caused by r785154. r785154 has been
causing two regressions. One is the context menu is opened at the wrong place
once right click is used inside emulation window. The other one is
a crash happens when performing a right click on 'Color selector'
overlay in emulation view.

The first regression caused by r785154 missed clearing
|host_context_menu_location_| unlike the original behavior. So, it
made RenderFrameImpl::ShowContextMenu() calculate the position of
the context menu with |host_context_menu_location| instead of the
current window position unlike the original behavior.

And, the second regresion was caused by RenderWidgetHostImpl::ShowContextMenuAtPoint
calls ShowContextMenu() through the Mojo message without checking if
|blink_frame_widget_| is bound.

This CL fixes those regressions.

Bug: 1093960, 1113088, 1115440
Change-Id: I94c3c385caeacda5561d30e6fd7ced6e86d69201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354128Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#798639}

https://skia.googlesource.com/skia.git/+log/c4245f475be7..866d2894ebd1

2020-08-17 djsollen@google.com Add android:exported values to all SkQP activities.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: stani@google.com
Test: Test: successful install on device with AOSP build
Change-Id: If67de613d99804be7f30f622b145844b07759b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358408Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798638}

Bug: 1087263
Change-Id: I2125c7072fcc9295749ff04f514e1b13d8754143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355905Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798637}

This is a re-land with sanity-checks of the kill() outcome removed, so
we can address the effects of process leaks separately from introducing
leak-checking.

Under Windows and Fuchsia the TestLauncher runs test batch processes in
their own jobs, allowing any leaked sub-processes leaked by tests to be
cleaned up.

Under POSIX platforms each batch is run in its own process group, but
the group was only being kill()ed if the test batch failed or crashed.

TestLauncher now proactively kill()s each test batch's process group.

Note that this will still miss processes launched into new process
groups by tests.

Bug: 1094369
Change-Id: I0880f08bd120fc5dd057a54efc3db63173feeca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359136
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798636}

With this CL, the edit fragment retrieves the compromised credential
from the start argument and fills them into the form. It also ensures
that temporary destruction of the fragment keeps the password and the
credential data.

Screenshot in the bug.

Bug: 1114720, 1092444
Change-Id: I8a0fe9a47f56b0af38465babd29c93afd8f669b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352901
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798635}

This CL removes ChromeGuard.


Bug: 1063824
Change-Id: Iad1224482534ff7a0f04116852dbebcabf27adce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346806
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798634}

Explicitly remove the copy constructor and assignment operator with
the delete keyword.

R=atotic@chromium.org, svillar@chromium.org

Bug: 1010217
Change-Id: I12a768919d9b5d5e4e9884a527296b2f7ad44b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358711Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#798633}

Bug: 1018157
Change-Id: I223619ed17fccf52313810177e79761569ba8459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353169
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798632}

Using wpt-import in Chromium 4bddba41.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
rego@igalia.com:
  external/wpt/css/css-grid

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: I88dfc7319d5256c7c2f373c23ad005e9786e1e75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358582Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798631}

This CL adds a way for ClientDiscardableSharedMemoryManager to discard
unlocked discardable memory locally. To achieve this, it keeps track
of all locked and unlocked, unpurged instances. These are then purged
all at once when ReleaseFreeMemory() is called.

This is guarded by a new feature which is disabled by default, and as
such there is no behaviour change by default.

Bug: 1109209
Change-Id: I7755d714ff354e831557627fda401751384392b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321400
Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798630}

This patch adds the capability to deliver notification synchronously
in the post-layout stage. It uses this for the 'auto' content visibility
case. During the notification, if this is the first time we have a
notification, then it is done synchronously. Furthermore, if the
notification causes a locked-ness change, then we request that the
layout stage is re-run (to ensure that visible things are immediately
visible.

R=szager@chromium.org, chrishtr@chromium.org

Change-Id: I59c94590a5dd0ec2398a06f3f03212a80b581fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348415Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798629}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bff6472b..0c2650ad

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I624177f3c764aa2b2075ba4a698b9b5a9cd33f62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358583Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798628}

Previously when passing nil to secondaryAttributedString  while
initiating a PopoverLabelViewController, the popover will show a large
blank area under the primary message. That's because a blank secondary
TextView has occupied the space. Fixed the issue by only create
secondary TextView when secondaryAttributedString has a value.

Bug: 1115925
Change-Id: Ic01ae94037aaae14b76194aca439b3677682b921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354519
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798627}

* Inline temps
* Combine conditions
* Use min/max more
* VideoPlaybackRoughnessReporter::kDesiredWindowDuration isn't needed

Bug: none
Change-Id: Ifbe23075f035df50e6bec4299802b6832c15d96b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359000
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798626}

When setting a new DiscoverFeedVC calling reloadData would sometimes
not actually reload the Feed. Taking a look at a similar method
I realized that there's a bug and workaround for that, which I added to
our DiscoverFeedVC setter

Here's where the workaround is also being used:
https://source.chromium.org/chromium/chromium/src/+/master:ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm;l=504

Bug: 1085419
Change-Id: I9cf39edfe9da9006dc0b26bf1b27bb0f8c41d255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355439Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798625}

Remove "if defined(OS_CHROMEOS)" when setting default token_value in
SetRefreshTokenForAccount in identity_test_utils.

UserPolicySigninServiceTest was calling IssueOAuthToken with
"refresh_token_for_" + gaia_id value because they expect the refresh
token to have this value by default. Fix this test by calling
SetRefreshTokenForAccount with custom token value and using the same
token to issue OAuth token.

Bug: 1115075
Change-Id: I92ca73b25b87131b9fb02dbae8bbea8a5707adb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353333Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Anastasiia N <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798624}

This is a reland of d7f6a170. The only
change since the reland was to disable some tests on android as they test
code paths that won't be hit on android.

Original change's description:
> Portals: Make breakpoints inside portalactivate event handlers work
>
> Currently, we reset the DevTools session before portal activation and
> create a new session with the activated portal's WebContents. We dispatch
> the portalactivate event and run any event handlers in the interim while
> there are no agents active, and as a result, existing breakpoints do not
> work.
>
> This CL waits for DevTools to point at the portal WebContents before
> actually swapping the WebContents, thus making sure that the
> portalactivate is dispatched after the main target has been reattached.
>
> Bug: 1025761
> Change-Id: I930d5f7ec361cd594c60bcece0bd9450a94994e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295080
> Reviewed-by: Peter Boström <pbos@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Lucas Gadani <lfg@chromium.org>
> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797727}

Bug: 1025761
Change-Id: I16edcfe85f83fee5aee31624cbdc2c8a0a150a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355552
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798623}

This patch adds a browser test for ignoring non-TWA payment apps when
running inside of a TWA that provides app store payment capability to
Chrome. The test is for Chrome OS only, which is using the
cross-platform Android payment app factory. When this factory is ported
to Android, then the same test will work on Android as well.

Bug: 1061503
Change-Id: I8f366c0feca7604000e8efc5e47d57047ab68a37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347400
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798622}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2137e8afdcc7..c2bd4cfa7063

2020-08-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-08-17 jobay@google.com [e2e] Fix flaky test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1112692
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I50404da2db7ea1733628510caf87101afa9a6d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358402Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798621}

Bug: 1034915
Change-Id: I6fec4c0b51df3e3fc7e62c2ce1c5ac277584919d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359138Reviewed-by: Rushan Suleymanov <rushans@google.com>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798620}

kUsePreferred likes to ignore text wrapping, making this view
really long because of the long text present. along with this,
the text was re-aligned to be even with the checkbox.

Bug: 1071831
Change-Id: I40de122e40149de878794ea0c0a7409a1f858078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359732Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798619}

Bug: 1102025,1092444
Change-Id: Ic703c3b3cb730d7ce1d27507f9d1fb2232a9e60e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353257
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798618}

Atm, this class is X11 only. We need to make that work with
Ozone/X11/Wayland in the future.

Bug: 1085700
Change-Id: I69d7d7128c3fb4b18cbfd8890dc4a1c8e85b1ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352928
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798617}

Roll Chrome Mac PGO profile from chrome-mac-master-1597574780-11032f77f0853e1d71f33728c0242d630bf5af1f.profdata to chrome-mac-master-1597665194-0d53ac1a851921d9b7ac1e88ae497b998bf9af0d.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ifb344b72f63b727ea74c562127fc08590eaab83f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358404Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798616}

Change-Id: I021f64713a2b19b9e40f5ddab7258a3fc97fd88a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357454Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798615}

Change the fileManagerPrivate API to use FileEntry, like all other API
in that API group. Move the Blob handling code lower down into the

  file_manager_private_custom_bindings.js

code. Since Blob reading could fail, use an errorUUID to represent the
invalid blob and make the C++ generate a chrome.runtime.lastError when
the errorUUID is seen. Attach the actual DOMError to that lastError in
the return code in the custom bindings JS (to aid debugging).

Update the apitest JS to use FileEntry instead of Blob. Update apitest
C++ to copy more testing files to the "testing" volume.

Add new files_manager test resource "empty.txt", which has no content,
to apitest the "empty Blob" case.

Bug: 1114622
Change-Id: Ie69c012ec23fac847ea19bbfcc09ad9b23c13c4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359872Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798614}

This CL adds adjustment to /build/config/compiler/BUILD.gn, to exclude
  ldflags += [ "-Wl,--no-call-graph-profile-sort" ]
for WASM. The flag usage was added in http://crrev.com/c/2332591, but
it's not yet supported by wasm-ld.

Change-Id: I04b1e81569e23f6a0b6f44b5e5544e30a3b0433d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359401
Auto-Submit: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798613}

Change-Id: Idb5111fb165d139be00cb26aab5f53154d5f3151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356186
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798612}

This change should not affect any behavior.

This CL moves the change password code out of the coordinator. This
keeps the coordinator clean from any logic and helper code so that it
remains focused on assembling the component and forwarding events.

Bug: 1092444
Change-Id: I2e380cf06403cfe91c39e02e9a65cc3352a44aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352920
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798611}

Adds ReauthenticationEvent for tracking reauth events.
Logs ManualFallback reauth events.

Bug: 1113120
Change-Id: Ia96dfabdbca40610a11f8467746b617f7c67e387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346437
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798610}

This Cl moves the implementation of the RecentTabsMenuProvider protocol
in a separate helper.
This helper is used to create context menu from the recent tabs and the
tab grid coordinator.

Bug: 1093302
Change-Id: I7c78adc6eded30f749b9a2dec8d159306452588a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351974Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798609}

This allows users to:
  - focus file-type filter buttons by TAB key.
  - toggle state of focused buttons by ENTER or SPACE keys.

To do this, we use <button> element instead of default <div> and style
them per the design, with html{.pointer-active,.focus-outline-visible}
style to control <button> state activations and keyboard focus rings.

And since <button> has in-built ARIA support, that comes for free too.

Bug: 1114721
Test: Manual test with flag #files-filters-in-recents.
Change-Id: Ib709f79d24ab8c3a41aabdae2be4cb237c1fad5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358947
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798608}

Adds a caution of auto-generated files.

Bug: 839389
Change-Id: I212dd2eb8153669f964f7b1a1de3d7ad4c9f8bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358931Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798607}

The data type might stop with clearing all data on any server-side error
(even transient). This might happen because the data type will be backed
off on any server-side error. In some cases it's not desired behaviour,
e.g. if there is a transient AUTH_ERROR which is transient and the next
commit request most probably will succeed.

Originally it was introduced to detect internet connection problems or
other error during commit. However there is already a mechanism to
detect if there is no internet connection. Additionally, there are more
cases when the client gets a transient error and it would be better to
try to send the message again.

Bug: 1097054
Change-Id: Ibfe4fe2d5d2614965a8c105017bb943447316ba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360076Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#798606}

Update existing PageInfo test and add another one to verify the
container UrlBarView shows Page Info when clicked by default.

Bug: 1116056
Change-Id: I26719b3d47184a5fcf8132c00f9fce32c7a7874d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359075
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798605}

This reverts commit 944fde32.

Reason for revert: strongly suspecting this breaks All/DeclarativeNetRequestResourceTypeBrowserTest
See https://crbug.com/1116995

Original change's description:
> Reland "Change HeapObserverList to HeapObserverSet"
> 
> This is a reland of f29d2ae1
> 
> ExecutionContext::NotifyContextDestroyed() has relied on the
> deterministic iteration order of ObserverList, so landing the original
> CL caused a problem. It is fixed in another CL:
> https://crrev.com/c/2352588
> 
> Original change's description:
> > Change HeapObserverList to HeapObserverSet
> >
> > The previous CL for HeapObserverList https://crrev.com/c/2060348
> > addressed two things: changing HeapObserverList to HeapObserverSet and
> > allowing removal while iteration, and was reverted for performance
> > reasons. This CL only does the former and avoids performance
> > implications of the latter.
> >
> > This CL is for migration of NewLinkedHashSet.
> > See: https://crrev.com/c/2134039
> >
> > Bug: 1100257
> > Change-Id: I2426d14d77a68f200bf1398b16638e1605dd4ff1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319087
> > Commit-Queue: Yuki Yamada <yukiy@chromium.org>
> > Reviewed-by: Keishi Hattori <keishi@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#797115}
> 
> Bug: 1100257, 1115411
> Change-Id: Id8e1b9a4141777de89bbc471f6ac8c6508a0adff
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352292
> Commit-Queue: Yuki Yamada <yukiy@chromium.org>
> Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
> Reviewed-by: Keishi Hattori <keishi@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798576}

TBR=haraken@chromium.org,keishi@chromium.org,yukiy@chromium.org,bartekn@chromium.org

Change-Id: I8c3d3a159efb802cda84fe3cbb1779abbbe2670d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1100257
Bug: 1115411
Bug: 1116995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359036Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798604}

https://chromium.googlesource.com/angle/angle.git/+log/d852ad24adc0..29271d0eece4

2020-08-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 1980311465cf to c1db3b8e7960 (1 revision)
2020-08-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from b4c4da3e7606 to b8de4f57e983 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I7fc274e7f5e2dbb7708f276b3098bc26f15f2779
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358394Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798603}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/81e695c66040..2137e8afdcc7

2020-08-17 jacktfranklin@chromium.org Support HTML element types in component bridges
2020-08-17 sigurds@chromium.org Propose wolfi@ as an owner for front_end/resources
2020-08-17 jacktfranklin@chromium.org Add support for Map to component bridges

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ia7e0eb3c48f0a396f300739d2debead5149d5fda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358396Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798602}

This change adds delay before revealing password check result. Delay is
added only if it took less than 3 seconds to finish the check.

Bug: 1075494
Change-Id: Ibc1031e870e178a98b1f74f4122c9519a8e15d28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351975Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/master@{#798601}

Before this patch, all TWA payment apps on Chrome OS were available for
payment, even if they implemented an IS_READY_TO_PAY service that
replied "false" to the query (when
chrome://flags/#enable-web-payments-experimental-features flag was
enabled).

This patch queries the IS_READY_TO_PAY service of the TWA payment app on
Chrome OS and enables payments only if the service is absent or returns
"true".

After this patch, the TWA payment app can control at runtime whether
it's able to handle payments.

Bug: 1061503
Change-Id: Idb267c0bbe2d8bb9173bcfde1b9a25e47a7fc505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269744
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798600}