GitLab

Change-Id: Iaeddffa11bdf0079b4c027356d3bc8d47f366bf1
Bug: 827575
Reviewed-on: https://chromium-review.googlesource.com/982633
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548176}

//tools/binary_size/supersize now does a better job of analyzing these.

Change-Id: I8fdf607c6985388dbb174f45bbfe8321046a5cf6
Reviewed-on: https://chromium-review.googlesource.com/995953Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548175}

-max_len=N doesn't guarantee that libfuzzer won't ever try feeding a
larger input into the target. So a check is added to the code to enforce
the size limit.

Bug: 828359
Change-Id: I2aa1404e618350896636de42a0ecc426946c8401
Reviewed-on: https://chromium-review.googlesource.com/996403
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548174}

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I10071ce60082dc66a4b63c57fe7ad53f51ccdac3
Bug: 812268
Reviewed-on: https://chromium-review.googlesource.com/985056Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548173}

* This patch updates the bridge to use contextual suggestions object
  directly
* It also wires peek_text to the bridge.

Bug: 824182, 827656
Change-Id: Iae3f3cca90bf2d0fe97953d906e270438e1f203c
Reviewed-on: https://chromium-review.googlesource.com/994456Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548172}

https://pdfium.googlesource.com/pdfium.git/+log/28bb2f2ffe75..dc566b0a76f9

$ git log 28bb2f2ff..dc566b0a7 --date=short --no-merges --format='%ad %ae %s'
2018-04-04 hnakashima Fix XFA caret blinking only while mouse moves.
2018-04-04 thestig Parse "yy" correctly for AFDate_FormatEx().
2018-04-04 dsinclair Decrease XML parser buffer size
2018-04-04 dsinclair [fwl] Restrict setting cursor outside text bounds

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:828561,chromium:436572,chromium:813195


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I2515beeac588ea2d53d3caa6d92bae0165da4824
Reviewed-on: https://chromium-review.googlesource.com/996232Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548171}

This prevents a DCHECK failure when running infobar browser tests and manually
closing the window with the infobar in it.

BUG=none
TEST=none

Change-Id: Iad50464a5a538d9d6e167f7a2c1a22905902770d
Reviewed-on: https://chromium-review.googlesource.com/991468Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548170}

Change-Id: I427e544c6ebb732bb4873c1d2b1f8936d31d6c5e
Reviewed-on: https://chromium-review.googlesource.com/996212Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: Douglas Creager <dcreager@google.com>
Cr-Commit-Position: refs/heads/master@{#548169}

|is_posix| will be switched to false for Fuchsia, this is a preliminary change.

Bug: 812974
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I25c9a760ea6176935cb5bf946a9c5b499d93e640
Reviewed-on: https://chromium-review.googlesource.com/988793Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548168}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/36ee60c3..68c9ef31

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I7c06a860ed13ae165dede96a3cd502003c9d3853
Reviewed-on: https://chromium-review.googlesource.com/995914Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548167}

This hooks up support for the MSAA put_accValue interface.
Also refactors BrowserAccessibility::AccessibilityPerformAction
to use a switch instead of a bunch of if statements.

Bug: 828946
Change-Id: Ia9169a3156428ae371953f9cbad9c2c72311bd8f
Reviewed-on: https://chromium-review.googlesource.com/996178Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548166}

This change implements Remount on SmbProviderClient which calls Remount
on the SmbProvider Daemon via D-Bus.

Bug: 757625
Change-Id: I11b419863996e6bba685f14136e54d65db007d0a
Reviewed-on: https://chromium-review.googlesource.com/987199
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548165}

This reverts commit cc52503a.

Relands two tests, ACCESSIBILITY and TTS_SUBPAGE. Does not include
the flaky test, which I will try to re-add separately with
adjustments to make it not flake any more.

TBR=hcarmona@chromium.org,zmin@chromium.org

Bug: 823359
Change-Id: If81e79fb8ea9a4870eb3886198c41ca166e38fda
Reviewed-on: https://chromium-review.googlesource.com/996016Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548164}

Instead it now always has a MessageLoop* and is allowed to use APIs
which will soon no longer be exposed on MessageLoop::current().

This is a precusor cleanup extracted from
https://chromium-review.googlesource.com/c/chromium/src/+/957760/7
in the broader effort to restrict usage of MessageLoop::current().

R=haraken@chromium.org

Bug: 825327
Change-Id: I580fe360ff9630a5ffb40b89921c6889d449e67a
Reviewed-on: https://chromium-review.googlesource.com/986813
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548163}

|is_posix| will be switched to false for Fuchsia, this is a preliminary change.

Bug: 812974
Change-Id: I13429e796618d3773df720259d672ae26d2390b8
Reviewed-on: https://chromium-review.googlesource.com/988810Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548162}

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/browser/renderer_host/media

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Includes should have been stripped if the was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=xhwang@chromium.org

Bug: 781352
Change-Id: Iae32d4a5cbb177de34391d8cf99e423e4d465cdb
Reviewed-on: https://chromium-review.googlesource.com/995921Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548161}

Modifies the acknowledged fudge factor for more pleasant scrolling.
Also adds subdirectory OWNERS for facilitating future fudging.

Bug: b/77490018
Test: on device
Change-Id: Id60ad0d1326dfb7c3e42be22b99cc20021a32c28
Reviewed-on: https://chromium-review.googlesource.com/996132Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548160}

R=amineer@chromium.org

Change-Id: Iba200ecc17108b7fe265173449e505d31bed01c2
Reviewed-on: https://chromium-review.googlesource.com/996410Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548159}

The idea with virtual/layout_ng_experimental/ is for it to
test LayoutNG features that aren't enabled by "default". The
existing virtual/layout_ng/ testsuite, on the other hand, should
only enable the NG feature set that we intend to ship next.

This CL includes some directories relevant to block
fragmentation testing, and enables the runtime feature
LayoutNGBlockFragmentation on those. In the future we may want
to do the same for e.g. flexbox or tables.

The expected results and expectation files here are based on the
LayoutNG expectations prior to CL:976223 (which disabled NG block
fragmentation in the "default" NG feature set), plus some
additional rebaselining, because running a virtual test requires
render tree dumps in more cases, for some reason.

Bug: 824918
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ife651b3366631cb674d99695f4628a3f6fac926a
Reviewed-on: https://chromium-review.googlesource.com/981138
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548158}

Focus ring on an inline element encloses continuations, thus the inline
element needs to update visual rect and check for invalidation when any
continuation's geometry changes.

Previously this was done in LayoutObject::SetNeedsPaintOffsetAndVisualRectUpdate()
called for a continuation block to set invalidation flag on the head of
the inline continuation. This is problematic during PrePaint because the
head of inline continuation has already finished its paint invalidation
and cleared its paint flags.

Now force subtree visual rect update and invalidation checking for a
block contianing inline with outline and continuation to ensure correct
visual rect update and invalidation.

Bug: 826582
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0bac20a8fafb64ea7121b3e25b7c75ebf7fb984f
Reviewed-on: https://chromium-review.googlesource.com/993707
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548157}

Per spec, we should exclude effects that do not target an element in
the called document:

https://drafts.csswg.org/web-animations-1/#dom-document-getanimations

Bug: 828424
Change-Id: I41405d82184b17c1185931e34735a5f946573844
Reviewed-on: https://chromium-review.googlesource.com/992812
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548156}

This is the second reland attempt. Previous attempt is here:
https://chromium-review.googlesource.com/c/chromium/src/+/981156.

Reason for reland: fixed the arm64/arm discrepancy for 64/32 bit.

TBR: yfriedman@chromium.org, thestig@chromium.org
Bug: 820591
Change-Id: If85d0a0566e663058608f497aad66208b2b6f710
Reviewed-on: https://chromium-review.googlesource.com/992813
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548155}

...mostly by de-indenting it by reversing the visibility-check. Also
reuse ComputedStyle locals and switch to using a ComputedStyle&.
In LayoutSVGShape::NodeAtFloatPointInternal, the large-ish condition is
split into three slightly smaller.

Change-Id: I275081391a3b399f9887215f4fe3075884de103c
Reviewed-on: https://chromium-review.googlesource.com/995674Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#548154}

This CL adds AccountPickerDialogFragment that is shown from
SigninFragmentBase and asks the user to select an account from the list.

Bug: 814728
Change-Id: Id82189694c5bf2b9c88ae3434e7a706539a493bc
Reviewed-on: https://chromium-review.googlesource.com/986262
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548153}

|is_posix| will be switched to false for Fuchsia, this is a preliminary change.

Bug: 812974
Change-Id: I930c1866c1ee1121fc08720e94b3075b084ee250
Reviewed-on: https://chromium-review.googlesource.com/988795Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548152}

Bug: None
Change-Id: Ic1d11908700ad0460df817cc368204e9de2d4f12
Reviewed-on: https://chromium-review.googlesource.com/995616
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548151}

Adding in a UMA that logs what triggered the entry into Chrome in VR.

Bug: 808589
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6bc9e9501fd86428e37db53853fc638fa00c1e73
Reviewed-on: https://chromium-review.googlesource.com/989055Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548150}

Implements the RTCPeerConnection.getStats(MediaStreamTrack) version[1]
of the stats selection algorithm behind flag. This is the equivalent of
doing RTCRtpSender.getStats() or RTCRtpReceiver.getStats() for the
track's sender or receiver. This is tested in external/wpt/.

Due to limitations of the generated V8 bindings it is not possible to
express all versions of RTCPeerConnection.getStats() at the same time
in IDL. Thus this CL introduces a version of getStats() taking
"optional any callbacksOrSelector" as argument, with custom binding
logic performed in RTCPeerConnection.cpp. A fast/peerconnection/
LayoutTest is added to test all combinations.

[1] https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-getstats

Bug: 680172
Change-Id: I8c64fc64c708d266c926dfa3eb3587c4cbb31210
Reviewed-on: https://chromium-review.googlesource.com/978128
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548149}

+ test header state on multiple tabs
+ test header state with other sections
+ parameterized context menu actions
+ render test on toggling header

Bug: 824900
Change-Id: Id82742a8d27e263bf0db9563473f9a320ed33875
Reviewed-on: https://chromium-review.googlesource.com/984377
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548148}

Add the missing check for actually being in kiosk mode, but keep the
autotest bail to simplify testing of the feature.

BUG=chromium:826568
TEST=Ran autotest, verified that extension can't access edid.

Change-Id: I8f93e29d8d977b0977b3eb597ce2aae263b4e9b9
Reviewed-on: https://chromium-review.googlesource.com/982619Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Felix Ekblom <felixe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548147}

The spec says that they have to, but we weren't checking it from what I
can see.

Bug: 827574
Change-Id: I96f1a7b5078cfc4c5e88647f47e3a60821901848
Reviewed-on: https://chromium-review.googlesource.com/982632
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548146}

Update StoreKitLauncher protocol to support product parameters and
also update the iTunesLinksHandler to extract product parameters
from iTunes URLs and provide them to StoreKitLauncher.

Bug: 828067
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0c48aa60e39d3c26843f164915c35863f14f3cac
Reviewed-on: https://chromium-review.googlesource.com/991607
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548145}

Add linux_chromium_compile_rel_ng_patch_on_gclient as an experimental builder
at 5% to test that patching on GClient instead of bot_update works as intended.

Bug: 643346
Change-Id: I2e1cc2961db6720bbb4b6c84d8764fb0bc5f1473
Reviewed-on: https://chromium-review.googlesource.com/991163Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548144}

Handling of 'oblique' values were missing in
ComputedStyleUtils::ValueForFontStyle - serialize as 'oblique <angle>'.
Because of this the return value needs to be widened to CSSValue.

Expectations for css/css-fonts/variations/font-shorthand.html updated.

TBR=drott@chromium.org

Bug: 809935, 809938
Change-Id: I753324776ba080820bc5c4a14e8aff6237ee5d12
Reviewed-on: https://chromium-review.googlesource.com/995793Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#548143}

Bug: 827690
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I509088a542dfc775262ae9807114db205ae6ac08
Reviewed-on: https://chromium-review.googlesource.com/988848Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548142}

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Includes should have been stripped if the was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=thakis@chromium.org

Bug: 781352
Change-Id: I0cb8cd0bbe6161bc706a5fc81d73c1d41ddcc775
Reviewed-on: https://chromium-review.googlesource.com/995974
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548141}

Chrome/VoiceOver didn't narrates `aria-expanded` state in latest code.
We fix from AriaRoleAttribute() to RoleValue() in SupportsARIAExpanded.

Bug: 824465
Change-Id: Ib9ded5bbf84ad59f96cd2eb06cdd18eb537d8224
Reviewed-on: https://chromium-review.googlesource.com/989633
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548140}

When we get a color tag that doesn't actually
specify the value range, we should not default
to full range values. Instead let's default to
INVALID (which later on defaults to limited range)

Bug: 827893
Change-Id: I137391651fea6b1bff05da20199ebbd8b6cc41e4
Reviewed-on: https://chromium-review.googlesource.com/990778
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548139}

Some EDID-provided chromaticity coordinates for the blue colour are
too far from the expected ones, causing blue to be rendered as purple
(or cyan, in some cases). This is due to broken primaries, as all the
standard colorspaces' blues are clustered nearby.

This CL adds a sanity check for the blue coordinates (need to be to
the left and below of a given point) and adds a unit test for it. If
the condition doesn't verify, we just ignore this ColorSpace -- which
means we'll treat the monitor as sRGB.

Bug: 809909, 771345
Change-Id: I4555625928f883825a3b315abdaaa379eb26a415
Reviewed-on: https://chromium-review.googlesource.com/993513
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548138}

Re-enables this test with the Network Service enabled.

This test did some things which the Network Service does not support and
does not need to support, or which otherwise made testing with the
Network Service more complex than necessary. The following changes have
been made:

  * We no longer attempt to load a network resource from a WebUI
    renderer. This will not be supported with Network Service and is no
    longer desirable to have working in production anyway. There should
    no longer be any WebUI pages making network requests.

  * Use http instead of https for the clients1.google.com requests. This
    allows such requests to be handled by the EmbeddedTestServer which
    already exists in BrowserTestBase, which is itself not configured to
    handle HTTPS requests. Since these requests are filtered by
    hostname, the scheme doesn't matter.

  * Switch the test to use a SimpleURLLoader instead of a
    FakeURLFetcher. This allows the test code to exercise the same
    behavior with or without the Network Service enabled.

Bug: 721414
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iad1f2deaec2e218b9cb168acbe71c90591dc6acf
Reviewed-on: https://chromium-review.googlesource.com/972425
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548137}