- 12 Dec, 2018 40 commits
-
-
Tony de Luna authored
Notifications for displaying data promotions are no longer supported. Class is now in charge of displaying mobile data warnings and prompts user to install data saver extension. BUG=910767 Change-Id: I74c45001158194788fb335be83e040b95e3271be Reviewed-on: https://chromium-review.googlesource.com/c/1362211 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#616076}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3338f216..da1d51ff Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If0afa97e6f35a64409c6d6310c9180d5f6467e10 Reviewed-on: https://chromium-review.googlesource.com/c/1374455Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616075}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/572100bbdaa1..6f13ebdc542b git log 572100bbdaa1..6f13ebdc542b --date=short --no-merges --format='%ad %ae %s' 2018-12-12 xixuan@google.com chromeos_config: Mark nyan_blaze-release back to important. Created with: gclient setdep -r src/third_party/chromite@6f13ebdc542b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I402d7b29853f53b68636daaea9d4a95a2de2c670 Reviewed-on: https://chromium-review.googlesource.com/c/1374141Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616074}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/64f62f4a179f..b08457df2325 git log 64f62f4a179f..b08457df2325 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 syoussefi@chromium.org Vulkan: Make flushAfterVertexConversion workaround Nexus5X-specific Created with: gclient setdep -r src/third_party/angle@b08457df2325 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I4b41a0ddaef3f92321ceda5f26db89e7c155aa03 Reviewed-on: https://chromium-review.googlesource.com/c/1374529Reviewed-by:
-
Troy Hildebrandt authored
Introduces the concept of pending client initializations so that we don't fail in odd ways if multiple initializations are in flight. Also fixes some of the initialization PostTasks to ensure we're always dereferencing our WeakPtrs on the same task runnerand ensuring that we actually post our callbacks on the calling task runner. Removes the WeakPtrFactory from ProtoLevelDBWrapper as well, which involves a substantial refactoring to get DB init status back. A new InitStatusCallback has been created so the 2 param Init and InitWithDatabase calls give me an InitStatus. IsCorrupt was removed, since setting the corruption state was the only thing that required using a WeakPtr in the first place. This gives us the freedom to make calls to the wrapper from any sequence regardless of what it was created on, and not have the WeakPtrFactory cause problems when it's destructed. Bug: 912117,870813 Change-Id: Ic7931a543b4d3d09714184dfb335311130bc7667 Reviewed-on: https://chromium-review.googlesource.com/c/1364074 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#616072}
-
W. James MacLean authored
This CL makes TouchEventAckQueue responsible for calling ProcessAckedTouchEvents() on the root view. Several main changes: 1) The TEAQ now stores the full TouchEvent, not just the event's touch ID. This is required by ProcessAckedTouchEvents(). 2) With the assumed invariant that now all touch events are acked, and in-order, we don't need to explicitly mark emulated touch events as such, since we can use the TouchEmulator to keep track for us. 3) The TEAQ now holds a pointer to its owning RWHIER, since it needs access to both (i) the TouchEmulator, and (ii) the function IsViewInMap(). The latter means having to make IsViewInMap() a public function on RWHIER. Bug: 848050 Change-Id: I822424ff1d04b8ba0c67a88956b1517c38a877ec Reviewed-on: https://chromium-review.googlesource.com/c/1355243 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#616071}
-
Daniel Murphy authored
This patch * extracts ScopeLockRange and ScopeLock classes into separate files, * implements a multi-level lock acquisition algorithm to acquire a collection of locks together * clarifies the invariants of DisjointRangeLockManager Bug: 862456 Change-Id: I2702237dfa7e5213e7cd395d3c8fcfeeaf86898e Reviewed-on: https://chromium-review.googlesource.com/c/1258218 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#616070}
-
sebsg authored
Bug: 913973 Change-Id: I3081b3392135774f54745c7da60089328e64393b Reviewed-on: https://chromium-review.googlesource.com/c/1371929 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#616069}
-
Sky Malice authored
This reverts commit 6205ad09. Reason for revert: Not needed now that https://chromium-review.googlesource.com/c/1371244 landed. Original change's description: > [Feed] Stop obfuscation of FeedRefreshTask class name. > > Bug: 913696 > Change-Id: I29fe62f4022c464330385c9e6e4d3253f2f3273c > Reviewed-on: https://chromium-review.googlesource.com/c/1370555 > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Commit-Queue: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615356} TBR=fgorski@chromium.org,skym@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 913696 Change-Id: I99720fe10cc3f292e44e0da72387585f685326bd Reviewed-on: https://chromium-review.googlesource.com/c/1374451Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#616068}
-
Daniel Bratell authored
srt_chrome_prompt_impl.cc is code that is only used in Windows but was compiled for all operating systems. Since it uses constants that only exist in Windows it's kind of lucky that it doesn't cause any problems, except in some jumbo build experiments where there was linker errors. (TBR for name change in BUILD.gn) TBR=nparker@chromium.org Bug: 904958 Change-Id: If1e3f76c7bc913d4041d0cb38b4891d898d24506 Reviewed-on: https://chromium-review.googlesource.com/c/1350870Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#616067}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b59d04f79ee3..8d08d23a6642 git log b59d04f79ee3..8d08d23a6642 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 cwallez@chromium.org README.md: Add a link to the mailing list. Created with: gclient setdep -r src/third_party/dawn@8d08d23a6642 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I7f8d4b75e4de7f62a8fd59b8250da8eda40d8d86 Reviewed-on: https://chromium-review.googlesource.com/c/1374530Reviewed-by:
-
Eric Aleshire authored
ios-wpr-simulator is currently timing out due to a lack of filtering. Each site tested by autofill automation is reported as its own suite, i.e. ios_costco.test.AutofillAutomationTestCase/testActions ios_ebay.test.AutofillAutomationTestCase/testActions ios_westelm.test.AutofillAutomationTestCase/testActions And the test_runner will automatically rerun any suite that fails, filtering for just that suite. However, filters were not implemented for WprProxySimulatorTestRunner, meaning that if ios_ebay failed, every site would be retested, resulting in an polynomial amount of test rerunning and a time out. This change implements filtering properly as well as tests for filtering, which should reduce the bot runtime to a reasonable level. Change-Id: Ib614a5902be3ffd9d41720173bdf51d140705f83 Reviewed-on: https://chromium-review.googlesource.com/c/1374453Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#616065}
-
David Tseng authored
Rather than including a fake alert object within the client accessibility tree, make the views tree include it with an explicit aura::Window. TBR=servolk@chromium.org Bug: 888152 Change-Id: I9e190a8e437a78c7e27ebfaab70ec20980dff32d Reviewed-on: https://chromium-review.googlesource.com/c/1368828 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#616064}
-
Xing Liu authored
Android's MediaCodec API uses various low level video decoder API. On Nexus5 tablet on Android Kitkat, the MediaCodec may not generate valid result and doesn't have any response. This CL adds a timeout to mitigate this issue. Bug: 907577 Change-Id: If616cae1e784fbbadd07752f5ff898662be1875e Reviewed-on: https://chromium-review.googlesource.com/c/1368279 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#616063}
-
Sandra Sun authored
This patch implements snapping after pressing PgUp/PgDn and Home/End keys. The logic is implemented in ScrollManager::LogicalScroll(). These keys are different from arrow keys. Pressing the arrow key is considered as scrolling with intended direction only. Pressing the PgUp/PgDn is considered as scrolling with intended direction and end position. Pressing the Home/End key is considered as scrolling with intended end position only. So we need to use different strategies to snap for these keys. Bug: 821928 Change-Id: If4d04ff58214a3304d09838f321e65c6e68f7d1d Reviewed-on: https://chromium-review.googlesource.com/c/1361648Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#616062}
-
Steven Bennetts authored
This CL tracks SystemWebDialogDelegate instances so that derived classes can check for an existing instance and focus that instead of opening a new instance. Bug: 855344 Change-Id: I688f2e09bd280a511d4ab53463beccfdd10f5371 Reviewed-on: https://chromium-review.googlesource.com/c/1366793Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#616061}
-
A Olsen authored
And also to manage c/b/ui/webui/policy* Change-Id: I1e54608ea4fafe5efc1d1ec6a7b2719cabaaeeec Reviewed-on: https://chromium-review.googlesource.com/c/1373787Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616060}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/88f396963bc7..e79ad68b2984 git log 88f396963bc7..e79ad68b2984 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 tsepez@chromium.org Combine ElementTable, parent array, and names. 2018-12-12 tsepez@chromium.org Remove ELEM_HIDDEN____() macro. Created with: gclient setdep -r src/third_party/pdfium@e79ad68b2984 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib680cdb5bfdaece2878ecb507093a5ca458baf46 Reviewed-on: https://chromium-review.googlesource.com/c/1374048Reviewed-by:
-
Robert Flack authored
When https://chromium-review.googlesource.com/c/chromium/src/+/1347784 landed we changed non-BGPT to also use all animation reasons as compositing reasons for each of transform, filter and opacity but this is only needed for BGPT. The additional time to compute animation compositing reasons caused a regression of about 7.5% on thread_total_all_cpu_time_per_frame which should be resolved with this change. A followup will be landed to fix it for BGPT. Bug: 909054 Change-Id: I7d7a23e758bdb3fcb93ab1ca265d53b658d8218f Reviewed-on: https://chromium-review.googlesource.com/c/1374055 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#616058}
-
Sunny Sachanandani authored
A recent Skia roll made changes to rectangle anti-aliasing. Rebaselining per Skia owners recommendation. Will reenable test in followup CL. TBR=kbr@chromium.org Bug: 914206 Change-Id: I22d1982b6a73c79a3f198370c2f25b47e11ed2bc Reviewed-on: https://chromium-review.googlesource.com/c/1374512 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#616057}
-
Kyle Horimoto authored
This is part of the ongoing effort to clean up the directory structure of multi-device code. The files moved are only relevant to the DeviceSync service, so they belong within the service implementation. See go/multidevice-directory-structure-cleanup for details. Bug: 912743 Change-Id: Icce398a4aa93110fbd790c364bba29bf461a83e4 Reviewed-on: https://chromium-review.googlesource.com/c/1372648Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#616056}
-
Lindsay Pasricha authored
Bug: 906201 Change-Id: I3a75ee136390ce0f3d5ff0840cbb8eee005d5bd9 Reviewed-on: https://chromium-review.googlesource.com/c/1372716 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616055}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d80da25f9a45..17b5749fc223 Created with: gclient setdep -r src-internal@17b5749fc223 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie06d8b6a54bf07369190a2c19559380d9b9c8cdf Reviewed-on: https://chromium-review.googlesource.com/c/1374142Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616054}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 59d0480b. With Chromium commits locally applied on WPT: a7cca762 "Revert "Fix SVG-As-Background sizing"" 6e2a70e4 "Reland "Fix SVG-As-Background sizing"" 8bb5e943 "Add WPT to verify that 1XX responses are used to provide responseStart timing" 618e62b5 "Align resource timing buffer full processing to spec PR 168 (take 3)" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ib40c87b63f698b075708070a7c00e8195c6780e1 Reviewed-on: https://chromium-review.googlesource.com/c/1373879Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616053}
-
Sergey Ulanov authored
Previuously net-test-server-config was written to /data/shared, which is then mapped to /test-shared in the test launcher. The problem was that this approach breaks when test launcher is not used (i.e. with --single-process-tests flag). Updated runner scripts to copy the file to /tmp. This approach is more consistent with other platforms and doesn't require any special logic in the test launcher. Change-Id: I5377eda57a0524b02e7ce419a5930ff16087a2e6 Reviewed-on: https://chromium-review.googlesource.com/c/1374456Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#616052}
-
Henrique Nakashima authored
This metric measures completion rate of background downloads when started through DownloadBroadcastManager. The events are: - Started - Completed - Cancelled - Failed A trend of process killed rate can be inferred from the formula: 1 - ((Completed + Cancel + Failed) / Started) Bug: 864625 Change-Id: If9fc28f25a72a9010055b995f8ab53b11c1b2563 Reviewed-on: https://chromium-review.googlesource.com/c/1363679Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#616051}
-
Andres Calderon Jaramillo authored
This CL creates a story which consists of a JS animation in which a group of red squares rotates in the background while three semi-transparent foregrounds move on top (with some rotation, translation, and resizing going on). The foregrounds apply a blur filter. The motivation is that in Chrome OS, we were having problems with the launcher animation having a low frame rate. As the launcher is swiped upwards, it applies a blur on the background. dcastagna@ landed a fix to improve this significantly (see https://crbug.com/900046). The code used by the launcher to do the blurring is not unique to Chrome OS, so the new story should be able to measure regressions in that animation. For due credit: the story is based on tbuckley@'s example which reproduced the issue on the web (see https://codepen.io/anon/pen/MPXYMQ). Chromebook after reverting bf7c3813 (dcastagna@'s fix) from 96c5b055. Test: percentage_smooth goes from 90.805% to 36.158% on an eve Bug: 682082 Change-Id: Ifc4a725a2ba430e7698fccde703d2de4a12db687 Reviewed-on: https://chromium-review.googlesource.com/c/1324240 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#616050}
-
Marcin Wiacek authored
@IntDef annotations are preferred way for declaring set of int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing InternalState enum in common @IntDef form: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface Change-Id: I8ca8f808060f31e60c07cfc9bcdc6f3b2a8dc8a4 Reviewed-on: https://chromium-review.googlesource.com/c/1135539Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#616049}
-
Michael Ludwig authored
The rebaseline diffs are a little trickier to follow because many specific expectations have been moved into a more generic family, either from Mac and Windows versions to just Mac/Windows generic, or all the way to a platform independent expectation image. Bug: 913948 Change-Id: Ifa1cfa5191587a0ece36c2ce06dc111db5f699fa Reviewed-on: https://chromium-review.googlesource.com/c/1372221 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#616048}
-
chrome://flashJulian Pastarmov authored
All information on this page is duplicate of information from other sources. The Flash plugin version and path can be found on chrome://version. GPU information is present of chrome://gpu and crashes on chrome://crashes. BUG=615739 Change-Id: Ic0dce75db63099715145a63cac82316494a87b12 Reviewed-on: https://chromium-review.googlesource.com/c/1373841Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#616047}
-
Greg Kerr authored
The V2 sandbox is now default for all but the network and GPU processes on macOS. This CL deletes the feature flag. A new experiment will be introduced for the GPU process. The default case for the sandbox profile switch is removed, because previous CHECK() failures were confusing to diagnose. All profiles must now be handled explicitly, so Chrome won't build if a new profile type isn't handled. Bug: 749839 Tbr: asvitkine@chromium.org Change-Id: I3924a27efcc34091258e9c6076d062c35abef186 Reviewed-on: https://chromium-review.googlesource.com/c/1371024 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#616046}
-
Mounir Lamouri authored
HTMLMediaElementRemotePlayback (whith is HTMLMediaElement.remote) is currently the supplement. Making RemotePlayback the supplement will allow core/ to get the object and use it via an interface. Bug: 913668 Change-Id: I8f2c1fb0039098d829d11b166191f6d4745eb96b Reviewed-on: https://chromium-review.googlesource.com/c/1371215Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#616045}
-
Regan Hsu authored
Histograms which records if the user attempted to unlock and signin their device via SL (tapped their user photo) or other auth method (e.g., password, PIN, or fingerprint tba). Bug: 905438 Change-Id: I1cd840c67ad717102b4008be7e92aafcad5f95c6 Reviewed-on: https://chromium-review.googlesource.com/c/1355846 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Sami Kyostila authored
This patch makes ThreadControllerWithMessagePumpImpl continue processing tasks even after the enclosing RunLoop has been quit. This is needed for MessageLoop compatibility in the following scenario: 1. A RunLoop is entered. 2. A native OS-level runloop is started, e.g., by opening a popup menu on Mac. Chrome tasks are allowed to executing in this nested loop. 3. A task is posted terminate the nested loop. 4. Before the above task has a chance to execute, a native callback calls RunLoop::Quit(). Because from Chrome's point of view there is no runloop nesting happening in the above scenario, RunLoop decides that it is the innermost one and tells ThreadControllerWithMessagePumpImpl to quit. However this doesn't terminate the OS-level loop and we get a live-lock. As Quit() is only supposed to affect RunLoop behavior instead of preventing tasks from getting executed, this patch changes ThreadControllerWithMessagePumpImpl to match the behavior of MessageLoop, i.e., allowing tasks to run after Quit(). Bug: 891670 Change-Id: I64fd335c122a0a6709f0c7222cfa1d3140a702e6 Reviewed-on: https://chromium-review.googlesource.com/c/1367660Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#616043}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f6b10fbe4ad7..f7f13e0742a9 git log f6b10fbe4ad7..f7f13e0742a9 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 kron@webrtc.org Add end-to-end test for ColorSpace information 2018-12-12 phensman@webrtc.org Switch to literals in playout delay tests 2018-12-12 kron@webrtc.org Add chroma siting to color space RTP extension 2018-12-12 henrikg@webrtc.org Revert "Reland "Default to dlopening the PipeWire."" 2018-12-12 nisse@webrtc.org Delete VideoCodec::targetBitrate 2018-12-12 mbonadei@webrtc.org Using fully qualified names for using declarations. 2018-12-12 phensman@webrtc.org Reintroduce division by two for audio playout delay 2018-12-12 mbonadei@webrtc.org Stop using 'using namespace'. 2018-12-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7f93585b..23962c38 (615733:615838) 2018-12-12 srte@webrtc.org Signals start rate when registering to TargetTransferRateObserver. 2018-12-12 nisse@webrtc.org Convert NetEq Cng-related test to not use RegisterExternalDecoder 2018-12-12 tomas.popela@gmail.com Reland "Default to dlopening the PipeWire." Created with: gclient setdep -r src/third_party/webrtc@f7f13e0742a9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122,chromium:None,chromium:None,chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icf6f6fc19cf09dfc783ca117f3ae0206218f5731 Reviewed-on: https://chromium-review.googlesource.com/c/1374136Reviewed-by:
-
Mohsen Izadi authored
Viz process that can be run using service manager is only used when mash is run in multi-process mode with out-of-process viz (i.e. when both Mash and MashOopViz features or on). Currently, service manager uses aura::Env mode (MUS vs LOCAL) to allow this which is wrong. Also, a recent change (r611340) causes service manager to run before aura::Env is created which breaks things further. This CL checks Mash and MashOopViz features to allow out-of-process viz. BUG=912218 Change-Id: Ib828acefd07abcb9ab134c9ed866fc3d4792de40 Reviewed-on: https://chromium-review.googlesource.com/c/1373883Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616041}
-
Marcin Wiacek authored
Patch is aligning PromiseState to other @IntDef: 1. with @IntDef element first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface Change-Id: Ia94bbd12a0e4cac0e4a0d504dbd3c24a2a8b10f7 Reviewed-on: https://chromium-review.googlesource.com/c/1370950Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#616040}
-
Nicolas Ouellet-payeur authored
This policy behaves a lot like BrowserSwitcherUseIeSitelist, except it can point to a different URL than the one IE uses. Bug: 846316 Change-Id: I52f91019aabcdd9b20163198195770fb52183e98 Reviewed-on: https://chromium-review.googlesource.com/c/1361327 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#616039}
-
Sky Malice authored
+66,360 bytes main lib size +483,380 bytes main dex size +780,271 bytes normalized apk size +299,669 bytes APK size +865,224 bytes Estimated installed size (Android Go) +2,252,524 bytes Estimated installed size InstallBreakdown (+2,251,998 bytes): +2,778 bytes unwind_cfi (dev and canary only) size +2,673 bytes Non-compiled Android resources size +66,360 bytes Native code size +589 bytes Package metadata size +2,163,890 bytes Java code size +15,708 bytes Compiled Android resources size +2,466 entries fields +3,489 entries methods +794 entries types +1,732 entries strings Specifics: InstallSize: Dex: Change-Id: I75d601109fcd2ed725ed70bbd907da9a1da3bd6f Reviewed-on: https://chromium-review.googlesource.com/c/1374165Reviewed-by: -
Nasko Oskov authored
Since PlzNavigate is the only way navigation works currently, this comment is no longer valid. Change-Id: I0a922d096a9bfd574e904ef6ee0fa5b79793e6ec Reviewed-on: https://chromium-review.googlesource.com/c/1373018Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#616037}
-
