GitLab

R=ben@chromium.org
BUG=295499

Review URL: https://codereview.chromium.org/25589002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226387 0039d316-1c4b-4281-b951-d872f2087c98

R=jar@chromium.org

Review URL: https://codereview.chromium.org/25578002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226386 0039d316-1c4b-4281-b951-d872f2087c98

Broke the mac build: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%282%29&number=42927

> [rAC, OSX] saveInChrome status now persistent.
> 
> The AutofillDialogController already persisted the state of the
> "Save in Chrome" checkbox. This CL ensures that the OSX dialog reflects
> that persisted state and is properly updated when the state changes.
> 
> NOTRY=true
> BUG=282101
> R=avi@chromium.org
> 
> Review URL: https://codereview.chromium.org/25405003

TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/25673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226385 0039d316-1c4b-4281-b951-d872f2087c98

Seems to have broken win and mac:
http://build.chromium.org/p/chromium/builders/Win/builds/17341
http://build.chromium.org/p/chromium/builders/Mac/builds/22281

> Fix code style and gyp files in cast to build cast_unittest
> 
> *.gypi should not be used for dependency directly. Renaming those files
> to *.gyp. Also style fixes to make compilers happy.
> 
> This change is reland of r226264.
> 
> TBR=acolwell
> 
> Review URL: https://codereview.chromium.org/25544003

TBR=hclam@chromium.org

Review URL: https://codereview.chromium.org/25662002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226381 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=302869

Review URL: https://codereview.chromium.org/25526005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226379 0039d316-1c4b-4281-b951-d872f2087c98

Both use a relative time, and it's important that this relative time is consistent with the wall clock when the system time gets adjusted (e.g. NTP, tlsdate, etc.). The monotonic clock, when available, has that property. Unfortunately, by default, pthread_cond_timedwait takes the system time which doesn't have that property.

On Linux/Chrome OS, we use pthread_condattr_setclock which lets us use the monotonic clock. On Android, we use the non-portable pthread_cond_timedwait_monotonic_np which has the same effect.
Unfortunately, neither is supported by NaCl.
Mac can use the non-portable pthread_cond_timedwait_relative_np which uses a relative time.

BUG=293736
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/24158005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226378 0039d316-1c4b-4281-b951-d872f2087c98

> Fixes use after free caused by delete in RootWindowController
> 
> RootWindowController::CloseChildWindows() was explicitly deleting
> windows. It should only do that for windows that are owned by the
> parent, otherwise the window should be removed.
> 
> BUG=297028
> TEST=covered by test now.
> R=oshima@chromium.org
> 
> Review URL: https://codereview.chromium.org/25374002

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/25659002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226377 0039d316-1c4b-4281-b951-d872f2087c98

The AutofillDialogController already persisted the state of the
"Save in Chrome" checkbox. This CL ensures that the OSX dialog reflects
that persisted state and is properly updated when the state changes.

NOTRY=true
BUG=282101
R=avi@chromium.org

Review URL: https://codereview.chromium.org/25405003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226376 0039d316-1c4b-4281-b951-d872f2087c98

Stop visual dialog flicker when switching a section's input source from
manual to suggestions or vice versa.

1) Coalesce "requestRelayout" messages, so they are only called once
   the current RunLoop iteration is done. Previously, they were
   executed immediately on each individual data change - multiple times
   while the controller was updating.

2) Change visibility of suggestions/inputs _after_ the views have been
   laid out. Prevents briefly observable layout flow.

NOTRY=true
BUG=286530

Review URL: https://codereview.chromium.org/25358002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226375 0039d316-1c4b-4281-b951-d872f2087c98

This will us (in future CLs) to not pass in ContextState into FramebufferManager,
but just the FramebufferState.

Review URL: https://codereview.chromium.org/25277005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226374 0039d316-1c4b-4281-b951-d872f2087c98

These functions don't have to be in CryptohomeLibrary. If you need to
avoid real D-Bus method calls (ex. in tests), you can use
FakeCryptohomeClient.

BUG=141016
TEST=none
R=hashimoto@chromium.org, pneubeck@chromium.org

Review URL: https://codereview.chromium.org/24869003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226373 0039d316-1c4b-4281-b951-d872f2087c98

the filename, don't try to parse the whole JSON/IDL file unless absolutely
necessary. Halves the time it takes to run a cron (it recently regressed).

R=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/25627002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226372 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes the default low res scale factor be 0.25 * high res
scale factor. The reasoning is that 0.125 looks too blurry. With low
quality low res tiles in play, 0.25 should still incur a performance
penalty, but it shouldn't be too bad, and look a bit better.

BUG=268203

Review URL: https://codereview.chromium.org/22144008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226371 0039d316-1c4b-4281-b951-d872f2087c98

TBR=acolwell

Review URL: https://codereview.chromium.org/25605003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226370 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226367 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=158633:158648&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/25587002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226366 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sail@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225992

Review URL: https://codereview.chromium.org/24707002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226365 0039d316-1c4b-4281-b951-d872f2087c98

Mark decimal constant as unsigned explicitly to appease Linux compilers.

R=acolwell@chromium.org
TBR=acolwell

Review URL: https://codereview.chromium.org/25348003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226364 0039d316-1c4b-4281-b951-d872f2087c98

Styx provides thumbnails using a persistent urls, in contrast to the previous urls which used to get stale with time. This patch moves to the persisten urls, to there is no need to handle stale urls anymore.

TEST=browser_tests
BUG=254025

Review URL: https://codereview.chromium.org/25458002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226362 0039d316-1c4b-4281-b951-d872f2087c98

BUG=b/10911057

Early out before calling native getNavigatonHistory as it may be
deleted before.

Review URL: https://codereview.chromium.org/25505005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298198

Review URL: https://codereview.chromium.org/25084003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226360 0039d316-1c4b-4281-b951-d872f2087c98

This will be useful when you need to compute a bounding box for a collection of
3D points.

R=ajuma@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/25518002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226359 0039d316-1c4b-4281-b951-d872f2087c98

A bug causing extension bindings not to be initialized was fixed in
revision 155947. This patch adds a workaround for older Chrome versions.

BUG=251913
TEST=manual
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217384

Review URL: https://codereview.chromium.org/19774009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226358 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226357 0039d316-1c4b-4281-b951-d872f2087c98

R=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/25618002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226356 0039d316-1c4b-4281-b951-d872f2087c98

This test fails when run with the rest of unit_tests unless
ProfileLoaderUnittest.* also runs.

BUG=302156
TBR=sky

Review URL: https://codereview.chromium.org/25457003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226355 0039d316-1c4b-4281-b951-d872f2087c98

Remove a guard which prevents destruction of the GLES2 implementation in cases
where an error causes only partial construction. Otherwise, the CommandBufferHelper
destructor will access the CommandBuffer after it has been destroyed.

BUG=285578

Review URL: https://codereview.chromium.org/25590002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226354 0039d316-1c4b-4281-b951-d872f2087c98

This can be used to generate partial trees of documents where not all documents
exist yet so links won't be stale. The option is off by default and has to
be passed to sphinx-build explicitly with -D kill_internal_links=1

BUG=None
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/25641002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226350 0039d316-1c4b-4281-b951-d872f2087c98

My last change to fix cq compilation error introduced a bug in code.
Fixed in this change.

R=pwestin@google.com
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/25637003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226348 0039d316-1c4b-4281-b951-d872f2087c98

RootWindowController::CloseChildWindows() was explicitly deleting
windows. It should only do that for windows that are owned by the
parent, otherwise the window should be removed.

BUG=297028
TEST=covered by test now.
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/25374002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226347 0039d316-1c4b-4281-b951-d872f2087c98

BUG=272583
TEST=none

Review URL: https://codereview.chromium.org/24940002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226346 0039d316-1c4b-4281-b951-d872f2087c98

- Symmetric to best_rasterize_time.
- In preparation for moving rasterize_and_record benchmark to tracing
  based architecture.

R=nduca@chromium.org
BUG=280638

Review URL: https://codereview.chromium.org/25284005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226345 0039d316-1c4b-4281-b951-d872f2087c98

Compilation errors due to int type casting.

TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/25643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=294699

Review URL: https://codereview.chromium.org/23604064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=mirandac@chromium.org

Review URL: https://codereview.chromium.org/25612003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226342 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fsamuel@chromium.org
BUG=299507

Review URL: https://codereview.chromium.org/25639002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=292397
TBR=sergeygs@chromium.org

Review URL: https://codereview.chromium.org/25604004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226340 0039d316-1c4b-4281-b951-d872f2087c98

The remote side will not get the real audio because webrtc will replace the frames with silence.


BUG=299007

Review URL: https://codereview.chromium.org/24742007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226339 0039d316-1c4b-4281-b951-d872f2087c98

IndexedDB writes the "wire format version" for serialized
data into the database metadata to detect the case where
a user reverts to an older version of the browser and
data "from the future" will not be understood. Detecting
this early lets us fail the open, rather than later
mysterious inconsistency errors. When the back-end was in
Blink the value could be grabbed directly from the
SerializedScriptValue class. Now it is exposed via headers.

BUG=299125

Review URL: https://codereview.chromium.org/24904002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226338 0039d316-1c4b-4281-b951-d872f2087c98

These get removed from the interface in
https://codereview.chromium.org/25450002/ as they are not used.

BUG=181120

Review URL: https://codereview.chromium.org/25455002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226336 0039d316-1c4b-4281-b951-d872f2087c98