- 16 Nov, 2018 40 commits
-
-
Egor Pasko authored
We found that encountering unknown offsets from profile information may indicate that the data is seriously offset (pun intended). It does not happen now on the orderfile bot, and we would like to know when it happens next. Converting this situation to error. Bug: 893981 Change-Id: Ibabe4b39886afa4e3a228f9e3910df5d0bcf91cf Reviewed-on: https://chromium-review.googlesource.com/c/1340328Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#608810}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 420f97c4. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ie8c05d96805cfd0f6f62877cba8a7d9aceb93724 Reviewed-on: https://chromium-review.googlesource.com/c/1340359 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608809}
-
danakj authored
is swapped out => is frozen for oopif => for child local root frame "Swapped out" was used in RenderWidget as the term comes from RenderViewHost, and RenderFrame. The main frame can be swapped out - meaning hosted in another process. RenderWidget is a separate layer of the code however and we would like to delete them but we can't, so they must enter this state of "inactivity". Thus, frozen. Then we can more clearly separate frozen RenderWidgets from swapped out frames and freeze/thaw RenderWidgets more appropriately. "For oopif" is confusing as it seems to mean the RenderWidget is not in the same frame tree as the main frame. However it can be when there is an oopif in between the frame in question and the main frame. Rename it to be more clear about when it is true. R=ajwong@chromium.org, piman@chromium.org Change-Id: I52e31acfbf098bfb993d1aea69b699b7bcbb8cbf Bug: 905191, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1336218 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608808}
-
Sidney San Martín authored
Bug: 900293 Change-Id: Ibdb90ce9d2777311a1f67cd992f3ae326a9e1f01 Reviewed-on: https://chromium-review.googlesource.com/c/1338463Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#608807}
-
Joe Mason authored
Also includes a .clang_format file in the pup_data dir that was missed, which caused dummy_signatures.cc to be reformatted. R=csharp@chromium.org Bug: 830892 Change-Id: I720c083ee6f8ee2b6f1805392419f43c91d43026 Reviewed-on: https://chromium-review.googlesource.com/c/1338205Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#608806}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/384d0eaf1930af1ebc47eda751f0c78dfcba1c03..e6eef1ca16a022e476bbaedffef044597cfc8f4b Bug: none Change-Id: I5bab6b11ebe76cf162d8b8ed6eeccd0f10d6c818 Reviewed-on: https://chromium-review.googlesource.com/c/1336209 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#608805}
-
Tien Mai authored
- Prevent Google Credential Provider for Windows from starting another instances of Chrome on winlogon screen if one is already running - Fix DCHECK failure that would crash the GCPW if the user cancels out of the sign in or selects a different credential to sign into. Bug: 900966 Change-Id: Ib30b4eff282cb55fa3fe6777dca56ff2051e275c Reviewed-on: https://chromium-review.googlesource.com/c/1334293 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#608804}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9e63a8137860..417ac91cdb06 git log 9e63a8137860..417ac91cdb06 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 jmadill@chromium.org Fix typo in perf_test_runner.py. Created with: gclient setdep -r src/third_party/angle@417ac91cdb06 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Id6b5921477756274f26f6e458eab00f1faed8125 Reviewed-on: https://chromium-review.googlesource.com/c/1340381Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608803}
-
Igor Eremeev authored
This is a rather small change that will not affect behavior until next variations limit bump is needed. Code seems to be a little inconsistent here, either string truncating or returning is redundant. R=asvitkine@chromium.org, isherman@chromium.org Change-Id: Idd4c10198026ac81165d921460c07834030b257a Reviewed-on: https://chromium-review.googlesource.com/c/1339739Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#608802}
-
Elly Fong-Jones authored
Everyone will be editing this file and I don't want to destroy the c/b OWNERS' review queue. Setting the OWNERS to myself and avi@ (aka "flags-team"). Bug: 897809 Change-Id: Ifc0afe1cea365f7398cfb14f5f4556f9bdeb818e Reviewed-on: https://chromium-review.googlesource.com/c/1340519Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c37388f1addd..6a7b164f0c0e git log c37388f1addd..6a7b164f0c0e --date=short --no-merges --format='%ad %ae %s' 2018-11-16 33432579+alan-baker@users.noreply.github.com Add shaderc smoketest configuration (#2057) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@6a7b164f0c0e The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I197714c2ff88116f4259e224bf484b3b703ad6f1 Reviewed-on: https://chromium-review.googlesource.com/c/1340379Reviewed-by:
-
danakj authored
The field is true when there is no routing id for the main frame (ie there is a proxy main frame), and false otherwise. So we can just use that. In the browser side it is actually a separate state, is_active_ on the RenderViewHostImpl. However it is always set to true/false when the main frame routing id is set as well. So we remove it and have is_active() report if the main frame routing id is present instead. R=alexmos@chromium.org TBR=dcheng Change-Id: I87c89f9d06ec99e769528e164e0ea0ed3d6fc6bc Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1336210 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#608799}
-
Ella Ge authored
TBR=nasko@chromium.org Bug: 874782 Change-Id: I0ce30b5216b8ea7105f085e71bbb3e7dd1ab663a Reviewed-on: https://chromium-review.googlesource.com/c/1340362Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608798}
-
Carlos IL authored
Bug: 807399 Change-Id: I7ec3529451a8cd1690a210411ae7120e7223bf9e Reviewed-on: https://chromium-review.googlesource.com/c/1338234Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#608797}
-
Alex Newcomer authored
|back_and_app_list_background_| is interfering with event targeting and causing the app list button to be unresponsive, specifically in the right side of the button. NOTE: This only repros on device, not on the emulator. Prevent |back_and_app_list_background_| from recieving events to prevent this. Bug: 900632 Change-Id: Ib2cd8e51cb560d84307904c86ae46ecc388e2424 Reviewed-on: https://chromium-review.googlesource.com/c/1338723Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#608796}
-
edchin authored
This CL moves CommandDispatcher ownership out of BVC and up into BrowserCoordinator. This CL migrates these coordinators: - formInputAccessoryCoordinator - snackbarCoordinator The goal is to migrate all coordinators from BVC to BrowserCoordinator. Bug: 905524 Change-Id: If7fe78cabbda32a19b2c5420ede55a8e48930563 Reviewed-on: https://chromium-review.googlesource.com/c/1336560 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608795}
-
Joe Mason authored
Includes a fix to ComputeSHA256DigestOfPath required by the unit test R=csharp@chromium.org Bug: 830892 Change-Id: I72e6c1a4fcf21565357e5e6043ee93b480931a4f Reviewed-on: https://chromium-review.googlesource.com/c/1338659Reviewed-by:
-
Shawn Gallea authored
Set params.bounds for widget within FullscreenShellSurface Bug: 896710 Test: FullscreenShellSurfaceTest.Bounds Change-Id: I250e99c177a2fd4ad15fab64d5a7929195441cb6 Reviewed-on: https://chromium-review.googlesource.com/c/1336000 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#608793}
-
Vladimir Levin authored
The locked element attribute is useful on the context since it creates an easy access point to add elements into. R=chrishtr@chromium.org Bug: https://github.com/chrishtr/display-locking/issues/30 Change-Id: I726a1db72373bdde261a808b38ccb17424a21348 Reviewed-on: https://chromium-review.googlesource.com/c/1336507Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608792}
-
Nico Weber authored
And fix luci-milo.cfg to pass the check: - Add jumbo-rel bots that were on the subwaterfalls to the main waterfall - Add two Webkit builder bots to main waterfall - Add Deterministic Linux (dbg) to chromium.linux subwaterfall - Make sure each bot has a single name project_pb2.py was created by grabbing the current version of https://chromium.googlesource.com/infra/luci/luci-go/+/master/milo/api/config/project.proto (9a3aea9951f) and running out/gn/protoc --python_out=. project.proto I also want to check that the category names are consistent across main and subwaterfalls, but this CL is already large enough, so let's do that in a separate change. Bug: none Change-Id: I0088621e3b7e7fb9698dd3f0853460105bb8ccd0 Reviewed-on: https://chromium-review.googlesource.com/c/1301795 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#608791}
-
Ella Ge authored
This reverts commit 04f43afb. Reason for revert: Looks like causing compile failure on Android CFI https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3645 Original change's description: > [Autofill Assistant] Displays the difference in Details if there is any. > > If there is a difference between current and new details it's > highlighted and two chips are displayed; to allow move forward or > go back (which closes CCT). > > Screenshot: https://screenshot.googleplex.com/kOoC3B1frUp > > Bug: 806868 > Change-Id: I95ff09c379398d5a5858aa3947d4c578f39b14c9 > Reviewed-on: https://chromium-review.googlesource.com/c/1335941 > Commit-Queue: Lukasz Suder <lsuder@chromium.org> > Reviewed-by: Stephane Zermatten <szermatt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608759} TBR=mcarlen@chromium.org,szermatt@chromium.org,lsuder@chromium.org Change-Id: I1a08ce61aedff0b51c7f71c27cd238e8359c0640 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 806868 Reviewed-on: https://chromium-review.googlesource.com/c/1340368Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Adds every current flag to flag-metadata.json 2) Enables AboutFlagsTest.EveryFlagHasMetadata to ensure that no future flags without metadata are added Note that every flag has been set to expire in M76 per <https://sites.google.com/a/chromium.org/dev/flag-ownership>. Bug: 897809 Change-Id: I67ab00e0462a50bb1a1484154f225c6e82d46097 Reviewed-on: https://chromium-review.googlesource.com/c/1335867 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Sergio Villar Senin authored
This is a first step in the migration of the different iOS' authentication_service_* classes to the IdentityManager API. The migration cannot be completed at this point as several APIs are not available yet. This CL is basically passing the IdentityManager to the different classes and using its API whenever appropiate instead of directly calling SinginManager and TokenService. Bug: 890817, 890818, 890819, 890820, 890820 Change-Id: I6df4466cc7f8ff1524e9736cb54376c0ee166070 Reviewed-on: https://chromium-review.googlesource.com/c/1335567Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#608788}
-
Dan Harrington authored
When an SQL statement has leading or trailing whitespace, the stored statement doesn't match when performing the DCHECK. Fixed by trimming whitespace before comparing the statements. Bug: 894884 Change-Id: If49b06103ed4fa3d49e623f62ce43247b2a27cf3 Reviewed-on: https://chromium-review.googlesource.com/c/1338177Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#608787}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e486cec6a10..5bf5a64fe7a9 git log 6e486cec6a10..5bf5a64fe7a9 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 scroggo@google.com Add SafetNet Logging for JCS_RGB jpegs Created with: gclient setdep -r src/third_party/skia@5bf5a64fe7a9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:b/118372692 TBR=rmistry@chromium.org Change-Id: I5188e00346761f3bcbdd72cb530a94035298e410 Reviewed-on: https://chromium-review.googlesource.com/c/1340149Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d6eacbfadd07..b2c3373106d2 git log d6eacbfadd07..b2c3373106d2 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 metzman@chromium.org cros_fuzz: Improve handling of UBSAN, reproduce and cleanup 2018-11-16 derat@chromium.org scripts: Improve status logging in cros_run_vm_test.py. 2018-11-16 shapiroc@chromium.org cbuildbot: Delete config.dtb support 2018-11-16 achuith@chromium.org cros_chrome_sdk_unittests: Seabios symlinks test. 2018-11-16 dgarrett@google.com workspace_stages: Create dual sync stage. 2018-11-16 dgarrett@google.com workspace_builders: Refactor inheritance. 2018-11-16 dgarrett@google.com generic_stage.GetRepoRepository: Make arguments flexible. 2018-11-16 dgarrett@google.com CleanUpStage: Cleanup Workspaces. Created with: gclient setdep -r src/third_party/chromite@b2c3373106d2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie82f53b56e166b2c9a98d1803e1fafbbcd4755f3 Reviewed-on: https://chromium-review.googlesource.com/c/1340148Reviewed-by:
-
Mythri Alle authored
IsolatedCodeCache feature has been on finch trial since 71 and the results are as expected. No measurable regressions on the top-level loading metrics and an expected regression of ~7-10% on the time spent compiling Javascript. The regression is expected because we do not share the compiled code across different origins. Bug: chromium:812168 Change-Id: Ib0aec9def0be83ae59298adc8516979b7587ae27 Reviewed-on: https://chromium-review.googlesource.com/c/1337625 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#608784}
-
https://chromium-review.googlesource.com/c/1312234Nico Weber authored
Bug: 875037 Change-Id: Ia4a6393237602b88bb0130d9f916972e930d95b3 Reviewed-on: https://chromium-review.googlesource.com/c/1339339Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#608783}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6ad86b66386..4d4ac41560ad git log c6ad86b66386..4d4ac41560ad --date=short --no-merges --format='%ad %ae %s' 2018-11-16 fmayer@google.com Merge "profiling: Don't use default memory order in client." Created with: gclient setdep -r src/third_party/perfetto@4d4ac41560ad The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5c3ef638d14b6a61037831e7ea439a5a87366316 Reviewed-on: https://chromium-review.googlesource.com/c/1340150Reviewed-by:
-
Olivier Robin authored
These are metrics of the old Today extension. Change-Id: Icd0d7c832dacd725cfb33554fc0cf026344dd7ea Reviewed-on: https://chromium-review.googlesource.com/c/1339839Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608781}
-
gogerald authored
Make the default switch preference in settings is true as we used in AutofillAssistantFacade.isConfigured. This CL also refactors the code to clear class scope and dependency. Bug: 806868 Change-Id: I85326c7075d1f353b301934f20a3e2aef127ecc5 Reviewed-on: https://chromium-review.googlesource.com/c/1338470 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608780}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=asanka@chromium.org Bug: 903957 Change-Id: I7ae73e710d70fb3872942b50b7c26285cad73571 Reviewed-on: https://chromium-review.googlesource.com/c/1338124Reviewed-by:Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#608779}
-
Benoît Lizé authored
This has two benefits: - Not touching the whole data (as most of it is not written to except for the initial memset() in vector's constructor.) - Allowing to recover from allocation failures. Bug: 905777 Change-Id: I748ec518af8cfc272a8342fdd567d957dbe1fbcc Reviewed-on: https://chromium-review.googlesource.com/c/1339872 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Yi Su authored
SettingsSwitchCell. SettingsSwitchCell should not have a UITableViewCellSelection animation, so set selectionStyle to UITableViewCellSelectionStyleNone when configuring SettingsSwitchCell. Bug: 894791 Change-Id: I21da349f8b888f16af2466d72c1957f17adfe200 Reviewed-on: https://chromium-review.googlesource.com/c/1340260Reviewed-by:
-
Hans Wennborg authored
This picks up package.py changes #607265 and #608413. It does not change the version of clang. It also includes a crazy workaround for msys binaries (in our case find.exe and mv.exe, used by lit tests) crashing during some unknown chrome infra problem (see last bug). Bug: 870331, 905289 Change-Id: Ic1d9fa64d6fcd4b590139c9343bed5bbe4d3faa3 Reviewed-on: https://chromium-review.googlesource.com/c/1337614 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/302134240b5d..7dbb7c311f00 git log 302134240b5d..7dbb7c311f00 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 mbonadei@webrtc.org Adding missing build target for audio_device_default. 2018-11-16 srte@webrtc.org Removes templating from CompositeMediaEngine. 2018-11-16 srte@webrtc.org Adds interfaces for audio and video engines. 2018-11-16 nisse@webrtc.org Tweak ChannelSend interface, to make it closer to ChannelSendProxy 2018-11-16 nisse@webrtc.org Delete class ChannelReceiveProxy. 2018-11-15 artit@webrtc.org Android: ignore LintError for absent class files Created with: gclient setdep -r src/third_party/webrtc@7dbb7c311f00 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:856189 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idb96613892a627f2dea77c1e306d193bf29cc53c Reviewed-on: https://chromium-review.googlesource.com/c/1340145Reviewed-by:
-
Marc Treib authored
Sync-the-feature requires a primary account, so this is more accurate. Bug: 871221 Change-Id: Iadd226c28d0d82cc86640a3c210f95505a219465 Reviewed-on: https://chromium-review.googlesource.com/c/1339939 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608774}
-
Clemens Hammacher authored
This makes use of the new fuzzer-specific asan_options, msan_options and ubsan_options. Wasm fuzzers need to be able to install custom segfault handlers, and v8-generated code sometimes uses SIGTRAP in internal code assertions. We might need to allow segfault handlers for more fuzzers (if it's not the default anyway), but this CL is conservative here and only adds it to selected fuzzers. We can still add more later. R=ahaas@chromium.org, mmoroz@chromium.org Bug: chromium:863799 Change-Id: I3fa24b60851501b9c194f7b0cf131cb19325972e Reviewed-on: https://chromium-review.googlesource.com/c/1335572 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This is a prereq for https://chromium-review.googlesource.com/c/chromium/src/+/1338221 without this change, the MTA assertions fail in unit tests even though they are correct in prod. This change matches the browser process' params @ content/browser/startup_helper.cc It has the adverse side-effect however of enabling the MTA in renderer unit tests but the downside there is not as bad as it just means some COM asserts may pass in unit tests where they wouldn't in integration tests or prod. I think that's okay because unit tests are already generally very loose on allowing I/O, waits, etc. Misuse will still be caught, but that's just not unit tests' main role. R=fdoray@chromium.org Bug: 708584, 707362 Change-Id: I68c5e41c24396885af43427d09c11e1e84ecea43 Reviewed-on: https://chromium-review.googlesource.com/c/1338305 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#608772}
-
Michael Lippautz authored
The GCObservation handle is always set and empty state implies that the observed object was garbage collection. Use phantom reference which avoids clearing out the reference manually. Bug: 903586, 843903 Change-Id: I77e6e9d9ef4625d4bb91b3907b0d1b69c17f2208 Reviewed-on: https://chromium-review.googlesource.com/c/1340320Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608771}
-
