- 03 Aug, 2018 29 commits
-
-
Renee Wright authored
Bug: 862609 Change-Id: I27594afaa4b128ff0ae8e6009ff5c88eb22c69f3 Reviewed-on: https://chromium-review.googlesource.com/1160123Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#580410}
-
Fady Samuel authored
Compositing.CompositorFrameSinkSupport.SubmitResult will never be hit with OOP-D. This CL fixes that. Bug: 865179 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id123904da50aa02fb3997ecaeac7078654fca4fd Reviewed-on: https://chromium-review.googlesource.com/1161481Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580409}
-
Ryan Tseng authored
"HOME" doesn't always exist as a envvar https://stackoverflow.com/questions/4028904/how-to-get-the-home-directory-in-python Bug: 869249 TBR: jbudorick Change-Id: I13f381d12ac75f3ec45b9736b980b30e32e602af Reviewed-on: https://chromium-review.googlesource.com/1157648Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#580408}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Id2b4a3db66c2f98d166740e424a5ae9783c49dbf Reviewed-on: https://chromium-review.googlesource.com/1161563 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580407}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cdda2f0c..f6db395a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie94e593280d5cb99cf1c373b42710d761c23ab96 Reviewed-on: https://chromium-review.googlesource.com/1161294Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580406}
-
Alan Cutter authored
This CL adds a null check to RenderViewContextMenu::AppendLinkItems() ensuring we have an associated Browser before attempting to use it. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1158110 without using TestWebContents (which results in a bad downcast). Bug: 869280 Change-Id: I6799f0c746c0cdca941e1235ac476f4e1d8a1f0e Reviewed-on: https://chromium-review.googlesource.com/1160121Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580405}
-
Jinsuk Kim authored
UserDataFactory in WebContents interface ended up not being used by embedder but all within contents layer. This CL hides the interface by moving it to WebContentsImpl. Change-Id: I8ee92891c71cca6892a83757b0ed22c7d53a707d Reviewed-on: https://chromium-review.googlesource.com/1159559Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#580404}
-
Trent Apted authored
The ExifParser constructor was missing a comment causing the compiler to ignore all the other annotations. Closure didn't complain about the constructor itself missing a comment because it's never invoked as a constructor by name. It's passed as a factory to registerParserClass(). Bug: 860355 Change-Id: I12bf8bf1c0b3ac9c5b4825e22a58558121258fa9 Reviewed-on: https://chromium-review.googlesource.com/1160061Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#580403}
-
Pawel Osciak authored
This reverts commit 7528f618. Reason for revert: disable the feature by default while related issues are being investigated (b/111781384). Original change's description: > Enable VA-API-based HW VP8 encoding by default. > > Flip the VaapiVP8Encoder flag to enable VA-API based HW VP8 encoder by > default. > > BUG=794608 > TEST=veatest, apprtc > > Change-Id: If99f825788786dc4cc2be8c4f7a3908d04023368 > Reviewed-on: https://chromium-review.googlesource.com/1080436 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Pawel Osciak <posciak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564004} TBR=posciak@chromium.org,xhwang@chromium.org,sandersd@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 794608,b:111781384 Change-Id: I35232863ca5b96285994cb03553548b0b72ff169 Reviewed-on: https://chromium-review.googlesource.com/1160181Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#580402}
-
Andrew Moylan authored
We are collapsing the ModelProvider interface into the top-level MachineLearningService interface. ModelProvider's sole method LoadModel becomes a method of MachineLearningService. This reflects the corresponding Chromium OS change: crrev.com/c/1158091. (The changes are safe to perform simultaneously as no clients call this interface yet.) Bug: 836095 Change-Id: Ia30be3ff176a72f2873c589ad1bc8e5c53248031 Reviewed-on: https://chromium-review.googlesource.com/1160138Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580401}
-
Kunihiko Sakamoto authored
Mark virtual/new-remote-playback-pipeline/media/controls/text-track-menu-pointer-selection.html as slow Tbr: mlamouri@chromium.org No-Try: true Bug: 865262,869906 Change-Id: Ib28e65954d6b9d0e0d24f3598d6b4da7dc274153 Reviewed-on: https://chromium-review.googlesource.com/1160832Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580400}
-
Eric Stevenson authored
Also fix incorrect usage of json.dump(). Change-Id: I5b02f9fead661f84d68eec8126101cc26c6110af Reviewed-on: https://chromium-review.googlesource.com/1159929 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580399}
-
Tim Song authored
Change-Id: Ic3aef8ab7e798680c0c572131f569dc93c9b4bdf Reviewed-on: https://chromium-review.googlesource.com/1161100Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#580398}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I048cf0c93b510568630e112087069d30ba76d5cd Reviewed-on: https://chromium-review.googlesource.com/1161564Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#580397}
-
Robert Ma authored
No-Try because tests haven't been imported. TBR=foolip No-Try: True Bug: 870526, 870528 Change-Id: I72df4669a5f22d7676ac289eb0c208633b6b019c Reviewed-on: https://chromium-review.googlesource.com/1161559Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#580396}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie85682a9a0898dbb64d109daa65f2f61d36bb738 Reviewed-on: https://chromium-review.googlesource.com/1161380 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580395}
-
Darren Shen authored
In a previous CL [1], we made changes to the shelf layout manager to use occluded and displaced bounds. However, we introduced a bug where the work area would not reset when we hide the accessibility keyboard, leaving a large gap in the screen. The code now makes more sense: we should be changing the work area whenever the displaced bounds change. We add a test for this. We also removed some calls to |LayoutShelf| in existing tests; |LayoutShelf| doesn't get called in real situations. Calling |LayoutShelf| manually will always change the work area, which is not what happens in practice. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1146530 TBR=jamescook@chromium.org Bug: 870503 Change-Id: I80a6aa90f1bce8e59e6c7cde2e3f181c31fc6907 Reviewed-on: https://chromium-review.googlesource.com/1160827Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#580394}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8ed949d3dcdc..95340100f95f git log 8ed949d3dcdc..95340100f95f --date=short --no-merges --format='%ad %ae %s' 2018-08-02 tsepez@chromium.org Tidy JBig2_Image.cpp 2018-08-02 thestig@chromium.org Handle inline font dicts in CBA_FontMap::AddFontToAnnotDict(). 2018-08-02 art-snake@yandex-team.ru Rework of CPDF_DataAvail::CheckHintTables. 2018-08-02 thestig@chromium.org Remove -Wno-pointer-to-int-cast from fxcodec target. 2018-08-02 tsepez@chromium.org Introduce JBIG2_PUTDWORD() macro in CJBIG2_Image.h Created with: gclient setdep -r src/third_party/pdfium@95340100f95f The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:869171 TBR=dsinclair@chromium.org Change-Id: I3aa3c1f6538a4a6e238352c313d36a74fc4625d7 Reviewed-on: https://chromium-review.googlesource.com/1161144Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580393}
-
tzik authored
XRDevice passes an XRSessionCreationOptions instance to WTF::Bind, and its |output_context_| is a garbage collected object. As we have no chance to call XRSessionCreationOptions::Trace while it's held in the callback, |output_context_| may be collected incorrectly by GC. This CL expands XRSessionCreationOptions members to the parameters of XRDevice::OnRequestSessionReturned to fix the object graph. Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iae4750dbec20d99f838f45d69fc3b782ed71cee2 Reviewed-on: https://chromium-review.googlesource.com/1160741Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#580392}
-
Matt Menke authored
This method was previously unused, but with the network service moving out of process, the speech recognition code will now need to use it. Bug: 841445 Change-Id: I886b10dbe6a4687ddb6e72e5296398f01534f221 Reviewed-on: https://chromium-review.googlesource.com/1145709 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#580391}
-
kylechar authored
This reverts commit 2b20bcdd. Reason for revert: Relanding after reverting https://crrev.com/c/1156998. Original change's description: > Revert "Add in-process VizCompositorThread for software compositing." > > This reverts commit 7d8b7c2d. > > Reason for revert: Need to revert https://crrev.com/c/1156998 > > Original change's description: > > Add in-process VizCompositorThread for software compositing. > > > > We are having issues where starting a GPU process consistently fails on > > some systems. Currently OOP-D runs the display compositor in the GPU > > process always. This includes when both hardware acceleration and > > SwiftShader are disabled. If we can't start the GPU process, we can't > > run the display compositor and Chrome crashes. > > > > This CL changes where the VizCompositorThread runs if the GPU access is > > disabled on Windows. We start the thread after giving up on the GPU > > process and create FrameSinkManagerImpl + dependencies on it. > > > > Also fix chrome://gpu page so that OOP-D and surface sync features are > > still correct if |gpu_access_blocked| is true. > > > > There is a lot of peripheral cleanup and code reuse possible as a follow > > up to this CL. It's not attempted here to make this easier to merge back > > to M69. > > > > Bug: 849639 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > > Change-Id: Ica6a3ec5b0e7951cb6807b135df4b4cfe410e394 > > Reviewed-on: https://chromium-review.googlesource.com/1158723 > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Commit-Queue: kylechar <kylechar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580241} > > TBR=sadrul@chromium.org,kylechar@chromium.org,piman@chromium.org > > Change-Id: I00fc978561630ef292436e2d44012a0931551d0f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 849639 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/1161121 > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580264} TBR=piman@chromium.org Change-Id: I6beb00a3551800cae159e503e5dcb5be9a45116e Bug: 849639 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1161122 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#580390}
-
Findit authored
This reverts commit 3859a1e7. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 580315 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzM4NTlhMWU3MTBmYjJmYjJjZTY2MjBmZDkyZTMxOWRmZjg1OTY2ZGEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28482 Sample Failed Step: ash_unittests Original change's description: > cros: Ensure that the login bubbles are fully visible. > > This CL moves LoginUserMenuView::EnsureWidgetInWorkArea to > LoginBubble::EnsureBubbleInWorkArea and adds handling for the case where the > bubble extends past the right side of the screen. > > Bug: 827599 > Change-Id: I29de2ac035e2a641250a047283cf0b5aa66a55ea > Reviewed-on: https://chromium-review.googlesource.com/1160933 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580315} Change-Id: I034e2a709f29957ade62343655756d164ef6ea5e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827599 Reviewed-on: https://chromium-review.googlesource.com/1161025 Cr-Commit-Position: refs/heads/master@{#580389}
-
kylechar authored
This reverts commit f72374c3. Reason for revert: The root issue was something different, this change isn't needed. Original change's description: > Android OOP-D: Disable VizDisplayCompositor on x86 Jellybean > > We're seeing large numbers of crashes on this platform, which is a very > small percentage of overall population. Disable this for now, while we > debug the issue. > > TBRs for uninteresting/mechanical changes > TBR=thestig > TBR=piman > > Bug: 867453 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I11829fd91ec303dbc1b413af0797ea0a96839338 > Reviewed-on: https://chromium-review.googlesource.com/1156998 > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579538} TBR=boliu@chromium.org,fsamuel@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR: ericrk@chromium.org Bug: 867453 Change-Id: I23fcb3fc0c3d68bd4087849c1704aefa229013ff Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1161141Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Added a comment in EmptyTabObserver against the future attempt to replace EmptyTabObserver with TabObserver + default interface methods as it has a side effect of increasing the number of generated methods. Bug: 781359 Change-Id: Iea3a345c7cf522f69e9626245605a0f967af3bb4 Reviewed-on: https://chromium-review.googlesource.com/1155284 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#580387}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3481542a423d..29b7b99e5d9f git log 3481542a423d..29b7b99e5d9f --date=short --no-merges --format='%ad %ae %s' 2018-08-02 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@29b7b99e5d9f The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ibe29a3696c527876ffb8f7f41aadff9f65cd58e4 Reviewed-on: https://chromium-review.googlesource.com/1161143Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580386}
-
Xu Xing authored
Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I19023be3ae96aec29dcf337addf8fb02a79f9ed6 Reviewed-on: https://chromium-review.googlesource.com/1159850Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#580385}
-
Dan Sanders authored
At stub destruction, CommandBufferHelper forgets all of its textures, which leads to crashes on Mac. The fix is to stop doing that, now that AbstractTextures remove the need to do so. Additionally, the behavior of calling BindImage(nullptr) was changed in the conversion to AbstractTexture; this change restores the original behavior. Bug: 869186 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I27fb81408ac90d28752a6bb6cfbb5e3c56975c70 Reviewed-on: https://chromium-review.googlesource.com/1155812Reviewed-by:
-
Renee Wright authored
Change-Id: I3404f7d9d99b3e2636ab3e5cc3e0c5850975bf39 Reviewed-on: https://chromium-review.googlesource.com/1159935Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
Eric Roman authored
This matches the behavior for other platforms, and helps reduce differences in testing. Bug: 870359 Change-Id: I6c0bd06497d1577a034ee3f52bdf7d144061d28d Reviewed-on: https://chromium-review.googlesource.com/1159603 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#580382}
-
- 02 Aug, 2018 11 commits
-
-
Carlos Knippschild authored
To make it easier to track the reason why tests are disabled one should add links from the disabled test to the issue in crbug that explains why they were disabled. This adds missing links from a few offline pages tests. TBR=dimich@chromium.org Bug: 830282, 870295 Change-Id: I1de64bfaf41211fd4585ec9733e6c80c338d4526 Reviewed-on: https://chromium-review.googlesource.com/1161441Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#580381}
-
liberato@chromium.org authored
Occasionally, MojoAndroidOverlay will receive more than one failure message from the server. Ignore all but the first. Bug: 861719 Change-Id: I38a98108bad29cacdce61863c0a8cd42eb8feb2e Reviewed-on: https://chromium-review.googlesource.com/1161219Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#580380}
-
Alex Newcomer authored
Three changes: - Add the icons for desktop context menu options. - Make the "Autohide Shelf" option a regular menu option. - This is because touchable menu items do not use the "check" type and was OKed by UX. - Remove the "Autohide" and "Shelf position" items in tablet mode. - This is requested by UX. Bug: 850134 Change-Id: I4bc7912687fbd8f1c3543301be511ac02277a859 Reviewed-on: https://chromium-review.googlesource.com/1159735 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580379}
-
John Abd-El-Malek authored
Bug: 800212 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5d200862e81809af793d28b7751729a1824be76c Reviewed-on: https://chromium-review.googlesource.com/1156566 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580378}
-
Yue Li authored
This reverts commit 8a49de16. Reason for revert: <INSERT REASONING HERE> Original change's description: > assistant: add DSP support > > Bug: b/77916222 > Change-Id: Ic2efb6e21d243bf5c19554dbdd35773ef082e12b > Reviewed-on: https://chromium-review.googlesource.com/1132624 > Commit-Queue: Muyuan Li <muyuanli@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580006} TBR=xiaohuic@chromium.org,muyuanli@chromium.org Change-Id: I7df21aba5ee2d05efab163d291bbce943f52e5c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/77916222 Reviewed-on: https://chromium-review.googlesource.com/1161228Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#580377}
-
Eric Roman authored
Specifically this adds the --impls switch as a way of specifying the order to run verifiers. To run the platform verifier and then the builtin verifier you would use: --impls=platform,builtin To run just the builtin verifier: --impls=builtin This is relevant when testing because there can be global sideffects for running the platform verifier that affect the subsequent runs (notably NSS's temporary cache of intermediates). Change-Id: I1cb47fff745f3ade03a4885803f9fdab2240f2e5 Reviewed-on: https://chromium-review.googlesource.com/1161394Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/20ee171b98bd..578ef2847b72 git log 20ee171b98bd..578ef2847b72 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 cc73f241145d..cb4ae446080b (1 commits) 2018-08-02 herb@google.com Hoist path check 2018-08-02 brianosman@google.com For filled arcs, merge coverage by simply adding 2018-08-02 timliang@google.com implemented GrMtlBuffer for Metal gpu backend 2018-08-02 ethannicholas@google.com switched SkSL from std::map to std::unordered_map 2018-08-02 egdaniel@google.com Support using vulkan 1.1. 2018-08-02 kjlubick@google.com Make flutter roll happy 2018-08-02 egdaniel@google.com Have GrVkBackendContext take a VkPhysicalDeviceFeatures struct. Created with: gclient setdep -r src/third_party/skia@578ef2847b72 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ie082dacd968d0033e1399fedf6531a3674fa33a9 Reviewed-on: https://chromium-review.googlesource.com/1160945Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580375}
-
Florin Malita authored
Making Skottie available for future CrOS UI work. Change-Id: I41946a4f0d09099e15bf4d08a64bb566080ff393 Reviewed-on: https://chromium-review.googlesource.com/1160772Reviewed-by:
Mike Reed <reed@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#580374}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/0a6e2d0dcbc5..77e8a21d75e2 git log 0a6e2d0dcbc5..77e8a21d75e2 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 hinoka@chromium.org Revert "Whitespace change to kick off luci jobs" Created with: gclient setdep -r src/native_client@77e8a21d75e2 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: Ifed76d0886be51e96645f4dc2ee70d70fe5ddeb7 Reviewed-on: https://chromium-review.googlesource.com/1161221Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580373}
-
tzik authored
WorkletOptions is marked as DISALLOW_NEW_EXCEPT_PLACEMENT_NEW(), and that required to be allocated on stack or on stack heap container. WTF::Bind() will start rejecting pass-by-value object that has Trace() method such as WorkletOptions as it's error prone. So, as a preparation for that, this CL expands necessary bit of WorkletOptions to the parameters of Worklet::FetchAndInvokeScript to avoid passing WorkletOptions directly. Change-Id: I4cbcb8e1163327c1d4ffd8aa17f3f3d719e2f523 Reviewed-on: https://chromium-review.googlesource.com/1160682 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#580372}
-
Yue Li authored
Bug: None Test: Manual Test Change-Id: I0e1ef57b9c148d0c5db182ff1c44564893be5973 Reviewed-on: https://chromium-review.googlesource.com/1161292Reviewed-by:
-
