- 22 Jun, 2018 40 commits
-
-
Chong Zhang authored
This CL: 1. Allows chrome to add policy headers for navigations and redirects via content API. 2. Removes the old |PolicyHeaderIOHelper| codepath and moves policy header tests to a new location. 3. Adds a move constructor/assignment for |net::HttpRequestHeaders|. Bug: 832749,845683 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I713ed30da33ba5feb5f437f8927b173c2f84d91a Reviewed-on: https://chromium-review.googlesource.com/1100393 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569503}
-
David Tseng authored
Change-Id: If274eda790046a53dffb0f4d3724aaaa1904699f Reviewed-on: https://chromium-review.googlesource.com/1096422 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569502}
-
Jeremy Roman authored
Change-Id: Ic5dde187984e827fde4dba21b1df3ef399c6a56f Reviewed-on: https://chromium-review.googlesource.com/1110941Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569501}
-
Matt Falkenhagen authored
These are only flaky on OOPIF (site-per-process), and there are existing flaky expectations for the non-OOR-CORS tests. I'm not sure why the OOR-CORS tests regressed recently, but since it's an experimental feature and the non-OOR-CORS tests are also flaky I'll leave it for OOR-CORS or OOPIF team to look. Bug: 854630, 834185 Change-Id: I93db44e01e96adb0d0f715061b66f0f7ec3f2862 TBR: dgrogan NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1111479Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#569500}
-
Tetsui Ohkubo authored
Changing focus of a view may cause UnifiedSystemTrayBubble to destruct. (See stack trace of https://crbug.com/853434#c6) At the point UnifiedSystemTrayBubble is deleted, the widget is still not deleted, so we should explicitly check if the widget is closing. TEST=manual BUG=853434 Change-Id: I2d4a146393ad6d0a39d5c8b78ea3c3623d04b91e Reviewed-on: https://chromium-review.googlesource.com/1107036Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#569499}
-
Ned Nguyen authored
Add --exact-test-filter flag to telemetry unittest script when --isolated-script-test-filter is passed to trampoline script Bug: chromium:533481 Change-Id: Ib2716c4f7fa62df15b4b53b29bb11dc4d55e984b Reviewed-on: https://chromium-review.googlesource.com/1110598Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#569498}
-
Sunny authored
According to HTML document parsing spec[1], there is no special procedure for <template> tag when in "in frameset" insertion mode. Besides, in "in template" insertion mode, the parser should not process <frameset> tag by changing insertion mode to "in frameset" mode. Around 18 failed tests should be passed after this change. For standalone html5lib tests in LayoutTests/html5lib, template.dat is updated to match the correct behavior. [1] https://html.spec.whatwg.org/multipage/parsing.html BUG=829668 Change-Id: Id25e6ab9ce47042a8e86a30aa2827f529f24f463 Reviewed-on: https://chromium-review.googlesource.com/1108191Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#569497}
-
Aidan Wolter authored
In order to bind to interfaces, the MultizoneAudioDecoder needs the service_manager::connector from the parent service. Bug: 110480251 Test: Build, run multizone Change-Id: Ibd11f2ef05f6712d10a13748349e24fa13e8a63e Reviewed-on: https://chromium-review.googlesource.com/1110657Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#569496}
-
Tetsui Ohkubo authored
The tooltip text for UserAvatarButon was set but not visible, because can_process_event_within_subtree for its child view was true. TEST=manual BUG=853710 Change-Id: I081a96628b1ab77e4ca57ef7d5900777a864b297 Reviewed-on: https://chromium-review.googlesource.com/1107432Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#569495}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0d22d3fa3ae1..694c8ff073d5 git log 0d22d3fa3ae1..694c8ff073d5 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 metzman@chromium.org [fuzzing] Make env more realistic 2018-06-21 dgarrett@google.com cros_tryjob: Use "default_debug" email template for --debug. 2018-06-21 ayatane@chromium.org Revert "chromeos-infra-go: Disable tests" 2018-06-21 dgarrett@google.com cbuildbot_launch: Tiny tweak to _MaybeCleanDistfiles. 2018-06-21 dgarrett@google.com cbuildbot: Remove .trybot marker concept. 2018-06-21 dgarrett@google.com config_lib: Remove config_lib.UseBuildbucketScheduler. 2018-06-21 dgarrett@google.com buildbucket_lib: Remove config_lib.UseBuildbucketScheduler. Created with: gclient setdep -r src/third_party/chromite@694c8ff073d5 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:648042,chromium:854734,chromium:852633,chromium:None,chromium:None,chromium:853025,chromium:853025 TBR=chrome-os-gardeners@chromium.org Change-Id: Ifce3485cd2e96d41803591c9a039daf716555a68 Reviewed-on: https://chromium-review.googlesource.com/1111158Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569494}
-
jonross authored
Except on Android, surface sync (--enable-surface-synchronization) is on by default. So keeping tests of it around are actually redundant. This removes them from all configs except for 'viz_fyi_android_gtests' where we want coverage to find bugs until we are ready to ship on Android. TEST=surface_sync_browser_tests, surface_sync_content_browsertests Bug: 843511 Change-Id: Icabccb7427c62844b9e56df1628e13f04d4b759a Reviewed-on: https://chromium-review.googlesource.com/1111098Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569493}
-
Matt Wolenetz authored
Adds ability for ChunkDemuxer and SourceBufferState to indicate whether a changeType request's type can be satisfied (using successful construction of an associated StreamParser as the condition), and to effect changeType by resetting the SourceBufferState's StreamParser. SourceBufferState's state machine is expanded to allow for enforcing at-most-one invocation of it's |init_cb_|, while continuing to require that a newly constructed StreamParser first successfully handle an initialization segment. Since this CL does not relax the existing codec-strictness of StreamParserFactory (and, by extension, MediaSource.addSourceBuffer), it uses the same strictness for CanChangeType. Any relaxation can be done in later CLs. Also, since such codec strictness is still in place, SourceBufferStream codec changes (more than just existing support for same-codec config changes) are allowed only when handling the first initialization segment following a changeType request, and only if the SourceBuffer had previously handled an initialization segment. Later CLs will include changeType pipeline integration tests, Blink API experimental support for changeType, and changeType web-platform-tests. BUG=605134 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I57e6ef175c9e06ca59db03f8c07ebd6070504af4 Reviewed-on: https://chromium-review.googlesource.com/1110483 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#569492}
-
Dave Tapuska authored
Attempt an alternate for https://chromium-review.googlesource.com/c/chromium/src/+/1096133 by defining uint64_t based constructors and keeping the strlen intrinsic. BUG=588506 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7edecb3a9c9ca111584dbe0454bf818cad1b2382 Reviewed-on: https://chromium-review.googlesource.com/1105187 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#569491}
-
Khushal authored
If we have a valid transfer cache entry but it doesn't exist in the cache, we proceed with using an empty image. Since any referenced entries must be serialized and locked with each command, it should be considered an error. R=ericrk@chromium.org Bug: 853491 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I328d441163aa290693efd4870aeb3717c1586163 Reviewed-on: https://chromium-review.googlesource.com/1108556Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#569490}
-
Lukasz Anforowicz authored
r567099 introduced a bug, where the loop in SpellcheckService::OnCustomDictionaryChanged could spin forever without calling RenderProcessHost::iterator::Advance. This CL fixes this. Bug: 854540 Change-Id: I6a1829a3595a1414ceb75b125b54a4576b3c02a6 Reviewed-on: https://chromium-review.googlesource.com/1108540Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#569489}
-
Darren Shen authored
Timeouts on mac_chromium_rel_ng TBR=smcgruer@chromium.org Bug: 855055 Change-Id: Ifb98ee39067afac3d82e8655d784224d27dc57eb Reviewed-on: https://chromium-review.googlesource.com/1111178 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#569488}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/61582510eeb8..9457546761a4 git log 61582510eeb8..9457546761a4 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 bsalomon@google.com Alternative fix for stale MIP maps on texture export/import. 2018-06-21 bungeman@google.com Revert "SkRefCnt, SkTypes: fix includes for clients" 2018-06-21 herb@google.com Revert "Add SkGlyphRunList" 2018-06-21 herb@google.com Use local strike caches to avoid flaky test behavior 2018-06-21 herb@google.com Make SkStrikeCache::Validate call non global version 2018-06-21 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 78ef7c5c81fb..97bcdb1d73a1 (1 commits) 2018-06-21 herb@google.com Add SkGlyphRunList 2018-06-21 benjaminwagner@google.com Revert "[infra] Enable retries for Windows compiles" 2018-06-21 egdaniel@google.com Fix vulkan copy resolve. 2018-06-21 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 20eea3cd3b2d..050ef946947a (1 commits) 2018-06-21 caryclark@skia.org make includes available for flutter 2018-06-21 benjaminwagner@google.com Add Perf NoGPUThreads jobs. 2018-06-21 herb@google.com Expand ExclusiveStrikePtr with StrikeCache 2018-06-21 ruiqimao@google.com fixed NIMA deformed vertices rendering 2018-06-21 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms eb7de4255855..78ef7c5c81fb (1 commits) 2018-06-21 borenet@google.com [recipes] Housekeeper-PerCommit-BundleRecipes needs vpython 2018-06-21 fmalita@chromium.org [skottie] Simplify AttachMask 2018-06-21 allanmac@google.com OpenGL interop is simplified when the cl_context is not created by SKC. 2018-06-21 robertphillips@google.com Switch to swap in moveOpListsToDDL for SkTArray 2018-06-21 reed@google.com use double to compute root to avoid overflow 2018-06-21 robertphillips@google.com Move taskgroup initialization closer to where it is used 2018-06-21 caryclark@skia.org abort really big path fuzzing 2018-06-21 reed@google.com add test for wacky conic edges (disabled for now) 2018-06-21 halcanary@google.com Mark all deleted methods private 2018-06-21 brucewang@google.com Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_AndroidSystem. 2018-06-21 herb@google.com Allow access to global glyph cache 2018-06-21 bsalomon@google.com Blacklist ReimportImageTextureWithMipLevels on AndroidOne 2018-06-21 stephana@google.com [infra] Remove PixelC bot Created with: gclient setdep -r src/third_party/skia@9457546761a4 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:850617,chromium:850350,chromium:850350 TBR=kjlubick@chromium.org Change-Id: I1e29242736d9855813ae91a481d5564ce97adc76 Reviewed-on: https://chromium-review.googlesource.com/1111157Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569487}
-
Takuto Ikuta authored
This is follow up of https://chromium.googlesource.com/chromium/src/+/f7d47b7e8c03400343d4b6753ff79ade9d09ca68 This CL specifies libpath explicitly for LIB directories. Bug: 854849, 787903 Change-Id: I9b65b0c0980af1f7eb4ece2ffbb31d8bde44e7ce Reviewed-on: https://chromium-review.googlesource.com/1109452 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569486}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c0dbb3da. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19949 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB timvolodine@chromium.org, reillyg@chromium.org: external/wpt/orientation-event TBR=robertma No-Export: true Change-Id: I3746b7fc790017c4daac1875fc885d9aeaface00 Reviewed-on: https://chromium-review.googlesource.com/1111008 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569485}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6f440ed5b51f..5f5819f8ed8a git log 6f440ed5b51f..5f5819f8ed8a --date=short --no-merges --format='%ad %ae %s' 2018-06-21 buildbot@webrtc.org Roll chromium_revision 105c0431..cb8b61b4 (569260:569376) 2018-06-21 mhoro@webrtc.org Fix for VP9 K-SVC video freeze frame when send bandwidth is restricted. 2018-06-21 sergio.garcia.murillo@gmail.com Generalize SimulcastEncoderAdapter, use for H264 & VP8. 2018-06-21 phoglund@webrtc.org Convert video quality test from a TEST_F to a TEST fixture. 2018-06-21 buildbot@webrtc.org Roll chromium_revision e1ef7d4b..105c0431 (568794:569260) 2018-06-21 minyue@webrtc.org Aligning time in audio jitter buffer plot to other plots in rtc event log visualizer. 2018-06-21 phensman@webrtc.org Reland "Reland "Injectable logging"" Created with: gclient setdep -r src/third_party/webrtc@5f5819f8ed8a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I386ba5c2adbdb646319c88312422e86ff9f96470 Reviewed-on: https://chromium-review.googlesource.com/1111058Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569484}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3d8131535e6b..c3cc2ab66d3d git log 3d8131535e6b..c3cc2ab66d3d --date=short --no-merges --format='%ad %ae %s' 2018-06-21 rharrison@chromium.org Clean up constant values for JS alert and beep 2018-06-21 hnakashima@chromium.org Use enum for stages of CPDF_Creator. 2018-06-21 hnakashima@chromium.org Do not save content stream if all page objects were removed from it. 2018-06-21 rharrison@chromium.org Use the length of calculated string instead of source Created with: gclient setdep -r src/third_party/pdfium@c3cc2ab66d3d The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:854623 TBR=dsinclair@chromium.org Change-Id: I033b1457e15085df69d794da8d42dfcc3e015713 Reviewed-on: https://chromium-review.googlesource.com/1111057Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569483}
-
Peter Boström authored
Adds MATERIAL_REFRESH and MATERIAL_TOUCH_REFRESH to MD modes used in ToolbarActionsBarUnitTest and fixes the test to account for the separator area used in Refresh modes. Bug: chromium:846410 Change-Id: Ib6d45d26fc3ba273e3cc3c3613dae07c31af0c2b Reviewed-on: https://chromium-review.googlesource.com/1111269Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#569482}
-
Caleb Rouleau authored
This test isn't really necessary. The case is handled slightly differently on windows and mac, but it is not important to the product. This test was just added in https://chromium-review.googlesource.com/c/chromium/src/+/1106769 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/22045 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/78366 Bug: chromedriver:2474 Change-Id: I3a339886e479182ec28914292c43d8dbe62d5e84 Reviewed-on: https://chromium-review.googlesource.com/1111323Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#569481}
-
Kenneth Russell authored
It's passing on the new Intel HD 630 bots. Bug: 635528 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3c6b1f88f7f26ec71ac716f4fd135517dc07b158 Tbr: zmo@chromium.org Tbr: jdarpinian@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1111019Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569480}
-
dpapad authored
Also unify the new "Sign out" string with a previously existing "Sign Out" string. Bug: 852000 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia48cb413d9b63e6f841db7a695095ef0750aacaa Reviewed-on: https://chromium-review.googlesource.com/1108929 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569479}
-
spqchan authored
Refactor ObserveGestureEventAndResult() in InputScrollElasticityController by moving the logic into separate methods. This is to decouple the momentum update logic from the event type i.e. so that elasticity can be updated by a ui::ScrollEvent as well as a blink::WebGestureEvent. As a result, the methods are public so that they can be called to handle ui::ScrollEvents. This refactor is a part of elastic scrolling: https://chromium-review.googlesource.com/c/chromium/src/+/1094097 Bug: 615948 Change-Id: I15dc619bee0577c1323b1e88a3c8924d7f31b47a Reviewed-on: https://chromium-review.googlesource.com/1103841 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#569478}
-
rbpotter authored
Copy the existing UI behavior of focusing the print button when a new destination is ready, including on initialization. Bug: 854566 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I517340b31e4d7e4550b894788ae7339599b292e6 Reviewed-on: https://chromium-review.googlesource.com/1108755Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#569477}
-
Steve Kobes authored
Bug: 823365 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic7d1091222850e65d5442b7a339c6925d5c51dac Reviewed-on: https://chromium-review.googlesource.com/1110882Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569476}
-
Jeremy Roman authored
Currently the allocations look like: [StringBuffer (usually on stack)] -> [Buffer8/Buffer16] -> [vector backing store] This removes the middle allocation, which makes all operations except swap simpler and more local. Change-Id: Ic9536dfb4f5fc905d99477f088d6ba8e0945b573 Reviewed-on: https://chromium-review.googlesource.com/1110257Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569475}
-
Stephen Martinis authored
This reverts commit 9b237478. Reason for revert: Seems to have broken the test suite, see https://crbug.com/855290 Original change's description: > Chromedriver: Make test runner emit proper test results > > The chrome test result format needs failed tests to be marked as > unexpected to be recognized as true failures. Otherwise they're thought > to be acceptable failures, and don't show up as actual failures when > parsed. > > Bug: 533481 > Change-Id: Ica94a18a4503a5553ef5602627643ae526155e1a > Reviewed-on: https://chromium-review.googlesource.com/1109269 > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569341} TBR=martiniss@chromium.org,crouleau@chromium.org,johnchen@chromium.org Change-Id: Iac8dfd494895bfa0e5c786bda43d43036f494f73 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 533481 Reviewed-on: https://chromium-review.googlesource.com/1111357Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#569474}
-
Alexei Filippov authored
This makes the layout more compact. Change-Id: I26731a590a1df0a946d29ed39a6254b9122bccae Reviewed-on: https://chromium-review.googlesource.com/1109438Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#569473}
-
Mike Wasserman authored
This should avoid WindowService and RenderProcessHost ids colliding. (RenderProcessHost uses incrementing process ids as Viz FrameSinkIds) (we can remove this once the WS assigns renderer's ids in Mash/OopAsh) Bug: 854368 Test: No DCHECKs or crashes launching KSV app on CrOS (Ctrl-Alt-/) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ibac8817c1cfc9205e4bf40fa73735a6ec2aa5976 Reviewed-on: https://chromium-review.googlesource.com/1109262 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569472}
-
tzik authored
This CL replaces MockTimer with MockOneShotTimer or MockRepeatingTimer as a preparation of OnceCallback support of base::Timer. Bug: 850247 Change-Id: I573c944fede451d72469c6f4404e39c848ad6a34 Reviewed-on: https://chromium-review.googlesource.com/1109673Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#569471}
-
Alexei Filippov authored
Yellow meant object is reachable from window. Red meant a DOM object is detached from the tree. BUG=851195 Change-Id: I4439f70fcbc00de7432673264405d4feb12124ba Reviewed-on: https://chromium-review.googlesource.com/1109274Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#569470}
-
Yuly Novikov authored
Bug: 851751 No-try: true Change-Id: I186a7110b69a478801de057b9e33b1ac3fefde19 Reviewed-on: https://chromium-review.googlesource.com/1110660 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569469}
-
Bruce Dawson authored
The static_initializers tool should support being passed either the name of a PE file or the name of a PDB file. This support was started (the extension was extracted) but not completed. This change finishes the job. This is important because I can't get static_initializers.exe to load symbols when I pass it the path to a PE file, even when the .pdb file has been downloaded to my local symbol-server cache. I had to copy the .pdb file to the PE file's directory which I would like to avoid. I also updated the PE file error message to suggest fixes. Bug: 341941 Change-Id: Ibb046a395ec3f808eceb4b5d92abe4a952fa428c Reviewed-on: https://chromium-review.googlesource.com/1110616Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569468}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8d31c73edc4a..6e6a25be184c git log 8d31c73edc4a..6e6a25be184c --date=short --no-merges --format='%ad %ae %s' 2018-06-21 lalitm@google.com trace_processor: significantly cleanup sched slice table class Created with: gclient setdep -r src/third_party/perfetto@6e6a25be184c The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: Ib71f83b297fe25f999086ff44ae22af8ffb227d6 Reviewed-on: https://chromium-review.googlesource.com/1110677 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569467}
-
Dirk Pranke authored
This brings the test results more into compliance with the current test result standard in bit.ly/chromium-json-test-results-format. Notable changes: - If a test is run multiple times, we explicitly return every `actual` result. Previously, if the test produced the same result every time, we'd only return a single value for `actual` - If a test is skipped unexpectedly, that will be considered a regression and an unexpected result. - The test results will contain `is_unexpected`, `is_flaky`, and `is_regression` fields for the matching conditions. Bug: 837047, 822078 Change-Id: I4896e61469d3b576ea9e7dbbe16fac709f74b6b9 Reviewed-on: https://chromium-review.googlesource.com/1103611 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#569466}
-
David Black authored
Previously, an interaction was started and this triggered UI to show. Now, the UI is shown/hidden as desired and, depending on the entry point, this will start an interaction as necessary. This is important because we have the need to launch Assistant UI without an interaction. This will occur when linking into Assistant Settings, Reminders, etc. Unit tests to follow in b/77656544. Bug: b:80542452 Change-Id: I6de066b3a9ed86590b1fc467b4baa36f02833c66 Reviewed-on: https://chromium-review.googlesource.com/1106597Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#569465}
-
John Budorick authored
Bug: 638318 Change-Id: I1c3b1fbf83d70faa7c11f41de547e4ae82fbb211 Reviewed-on: https://chromium-review.googlesource.com/1103589 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#569464}
-