GitLab

The DCHCECK that server side redirect should not be added as a new item
is invalid in the following scenario:

(1) Navigate to an AMP (Accelerate Mobile Page) -- I do this from
    news.google.fr
(2) Shutdown Chrome on iOS (i.e. switch to another app, then kill the
    app)
(3) Relaunch Chrome on iOS

When Chrome is relaunched, there will be no pending items and somehow a
server side redirect is fired, so a server side redirect item is added
to the chain.

This CL removes the DCHECK.

BUG=710385

Review-Url: https://codereview.chromium.org/2808353007
Cr-Commit-Position: refs/heads/master@{#464310}

This CL adds and changes some files in ui/file_manager to build ZIP archiver.
We are going to add ZIP archiver to the list of component extensions
in another CL, so ZIP archiver still won't show up in the context
menu with this patch.

BUG=607078
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2808993003
Cr-Commit-Position: refs/heads/master@{#464309}

Revert of Enable crashpad for Mac (patchset #4 id:60001 of https://codereview.chromium.org/2816593006/ )

Reason for revert:
mac_chromium10.10_rel_ng buildbot failing in browsertests

Original issue's description:
> Enable crashpad for Mac.
>
> This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.
>
> For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.
>
> BUG=687407
>
> Review-Url: https://codereview.chromium.org/2816593006
> Cr-Commit-Position: refs/heads/master@{#464289}
> Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a

TBR=skyostil@chromium.org,jzfeng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=687407

Review-Url: https://codereview.chromium.org/2819503002
Cr-Commit-Position: refs/heads/master@{#464308}

This patch filters out shorthands from the input of
make_computed_style_base. This is to explictly prevent shorthands being
treated like CSS properties in ComputedStyle.

Currently there are no shorthands being generated as properties, so this
patch does not affect behaviour.

BUG=628043

Review-Url: https://codereview.chromium.org/2809053002
Cr-Commit-Position: refs/heads/master@{#464307}

ChromeBox for Meetings devices want a way to toggle spoken feedback when
the user holds down two fingers. Use existing code that detects this gesture,
but instead of toggling directly, fire private events on accessibilityPrivate
that they can intercept and then trigger with their own UI and timing.

BUG=662501

Review-Url: https://codereview.chromium.org/2808053004
Cr-Commit-Position: refs/heads/master@{#464306}

- Enum of extraction status
- Histogram of extraction time
  (those w/ JSON parsing results are counted separately)

BUG=693633

Review-Url: https://codereview.chromium.org/2815693004
Cr-Commit-Position: refs/heads/master@{#464305}

Once the context's frame is detached from the DOM, we shouldn't hold
a strong reference to v8::Context.  This CL makes WindowProxy::global_proxy_
a weak reference once the frame is detached.

This CL is a preparation of https://crrev.com/2713623002 .

BUG=

Review-Url: https://codereview.chromium.org/2811943003
Cr-Commit-Position: refs/heads/master@{#464304}

We currently generate mappings between CSSValueID and platform enums
inside the ComputedStyleBase generator. However, because such mappings
do not exist for nonproperty fields, it no longer makes sense for us
to generate these mappings inside make_computed_style_base.py.

This patch moves the generator for CSSValueIDMappingsGenerated to
its own file, so that it is not affected by nonproperty fields.

BUG=628043

Review-Url: https://codereview.chromium.org/2794853002
Cr-Original-Commit-Position: refs/heads/master@{#463955}
Committed: https://chromium.googlesource.com/chromium/src/+/dea75f9603af994dd10370ddd25a0dc6af7b93cd
Review-Url: https://codereview.chromium.org/2794853002
Cr-Commit-Position: refs/heads/master@{#464303}

Header files in components/google/core/browser include files from these targets, therefore they should be public_deps.

Example error:
In file included from ../../chrome/browser/rlz/chrome_rlz_tracker_delegate.cc:24:
In file included from ../../components/search_engines/template_url_service.h:23:
In file included from ../../components/google/core/browser/google_url_tracker.h:17:
In file included from ../../net/url_request/url_fetcher.h:19:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found

BUG=none

Review-Url: https://codereview.chromium.org/2812403003
Cr-Commit-Position: refs/heads/master@{#464302}

Example errors:
In file included from ../../remoting/host/setup/start_host_main.cc:18:
In file included from ../../net/url_request/url_fetcher.h:19:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found

In file included from ../../remoting/host/setup/me2me_native_messaging_host_main.cc:22:
In file included from ../../net/url_request/url_fetcher.h:19:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found

BUG=none

Review-Url: https://codereview.chromium.org/2813393002
Cr-Commit-Position: refs/heads/master@{#464301}

Add the ability to highlight menu items through the AppMenuButtonHelper.
This will allow components to draw attention to the menu button and,
once the menu is open, a particular menu entry.

BUG=705687

Review-Url: https://codereview.chromium.org/2779543005
Cr-Commit-Position: refs/heads/master@{#464300}

Headless is enable in Mac and Linux, and will soon be enabled in Windows.
This patch adds headless resources (1.7 Kb) to all those versions
Launch bug: http://crbug.com/705916

BUG=709836

Review-Url: https://codereview.chromium.org/2811633002
Cr-Commit-Position: refs/heads/master@{#464299}

in conjunction with checking that the alt-service is actually broken.

This is doable now that https://codereview.chromium.org/2805043004/
has landed.

Review-Url: https://codereview.chromium.org/2810323003
Cr-Commit-Position: refs/heads/master@{#464298}

There was a race condition with the lazy initialization logic
from before, where the media_resource_tracker() lazy-getter
could be called by something on the media thread before the
call to media_resource_tracker()->InitializeMediaLib() in
cast_browser_main_parts. This would make the media resource
tracker think that the media thread was the UI thread, which
would cause the InitializeMediaLib() call to fail, thinking
it was on the wrong thread.

BUG=NONE
TEST=build cast_shell_apk with gn arg
     is_cast_audio_only=true, install on Android emulator
     and verify that crash does not happen on browser process
     startup.

Review-Url: https://codereview.chromium.org/2811293003
Cr-Commit-Position: refs/heads/master@{#464297}

Small refactoring of WizardController::OnNetworkConnected() to merge the
flows of official and unofficial builds as much as possible to properly
trigger FRE on a Linux build.  This is done by calling OnEulaAccepted()
on unofficial builds.

BUG=703658

Review-Url: https://codereview.chromium.org/2816763002
Cr-Commit-Position: refs/heads/master@{#464296}

Currently make_computed_style_base.py ignores any overrides to the
setter and initial method names in CSSProperties.json5. This patch
ensures that the generator uses the overridden names (which are already
handled in its parent class, StyleBuilderWriter, and stored in
property_['setter'] and property_['initial']).

This patch does not change any generated code.

BUG=710496

Review-Url: https://codereview.chromium.org/2811183004
Cr-Commit-Position: refs/heads/master@{#464295}

https://skia.googlesource.com/skia.git/+log/9fa740365215..96d5b9a273a5

$ git log 9fa740365..96d5b9a27 --date=short --no-merges --format='%ad %ae %s'
2017-04-12 reed remove unused fURI from pixelref

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: I7ed66455f31508f9ef750bbb34721e663d048534
Reviewed-on: https://chromium-review.googlesource.com/476096Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464294}

R=stevenjb@chromium.org
BUG=603620,626882
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2810003003
Cr-Commit-Position: refs/heads/master@{#464293}

R=dpapad@chromium.org,hcarmona@chromium.org
BUG=709579
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2816883002
Cr-Commit-Position: refs/heads/master@{#464292}

BUG=709148
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817803002
Cr-Commit-Position: refs/heads/master@{#464291}

To keep dependencies clean, this CL creates a new target
//storage/browser:test_support. As storage tests are moved next to the
files they cover, the test doubles that they use will be moved to the
new test_support target.

BUG=653751
TBR=rdevlin.cronin

Review-Url: https://codereview.chromium.org/2815743002
Cr-Commit-Position: refs/heads/master@{#464290}

This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.

For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.

BUG=687407

Review-Url: https://codereview.chromium.org/2816593006
Cr-Commit-Position: refs/heads/master@{#464289}

I also fixed some comments and fixed pylint line length errors.

This was a bug introduced in crrev/346923003.
Originally we would start playing the video and wait until it got to 1
second, and then we would seek around in it. After crrev/346923003 we
would instead play the entire video and then seek around in it.

sandersd@'s crrev/1962563005 noticed this bug and commented on it, but
we haven't gotten around to fixing it until now.

This change should reduce load on Speed infra machines by reducing the benchmark duration for tough_video_cases_extra from ~5 minutes to ~3 minutes. we get to skip the initial playback for 14 of the pages in tough_video_cases_extra. the video length of test content is around 10 seconds on average, and this change will make us play only 1 second of the video instead of the whole video before we start seeking. So 14*(10-1) = 126 seconds.

Also, I noticed that two of the pages in tough_video_cases are also seeking pages, not time_to_play pages, so this will reduce the runtime for those as well.

In addition to reducing the load, this change will also make seek times become the measurement that they were originally supposed to be. Seek time cold currently doesn't actually measure cold seek time because that part of the video that was seeked to was already played once.

BUG=711125

Review-Url: https://codereview.chromium.org/2813383002
Cr-Commit-Position: refs/heads/master@{#464288}

Remove GpuProcessHostUIShim::DestroyAll(), and related comments which no
longer is accurate. Also, allow the instance(s) to leak during tear down.

BUG=none

Review-Url: https://codereview.chromium.org/2817503005
Cr-Commit-Position: refs/heads/master@{#464287}

This was added to the PermissionRequestType enum for the HTML By Default
project but histograms.xml wasn't updated to match.

BUG=None

Review-Url: https://codereview.chromium.org/2813893005
Cr-Commit-Position: refs/heads/master@{#464286}

This change will enable to choose a file and close a context menu
simultaneously by a single click in the file list of the Files app.

Before this change, only the mousedown event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
I think Issue 507681 was resolved by the change to apps_page.js, and
487194 was done by that of title_page.js in the original change.
I confirmed that the both issues doesn't reappear by this change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2800383002
Cr-Commit-Position: refs/heads/master@{#464285}

This does the following;

 * Makes --write-full-results-to and --isolated-script-test-output
   aliases for --json-test-results.

 * Adds --json-failing-test-results in case anyone depends on only
   getting failing results.

 * Moves us towards removing needing
   testing/scripts/run_isolated_script_test.py to run layout tests on
   swarming (one less wrapper script layer, yay!).

 * This fixes the output counts on BuildBot for Layout Tests (when not
   run on swarming).

---------------------------------------
 Total tests: 2160
  * Passed: 1172 (1172 expected, 0 unexpected)
* Failed: 956 (956 expected, 0 unexpected)
* Flaky: 32 (32 expected, 0 unexpected)
---------------------------------------

   Changes to;
---------------------------------------
Total tests: 61245
* Passed: 51187 (51156 expected, 31 unexpected)
* Failed: 10020 (10020 expected, 0 unexpected)
* Flaky: 38 (38 expected, 0 unexpected)
---------------------------------------

BUG=524758,704394

Review-Url: https://codereview.chromium.org/2813173002
Cr-Commit-Position: refs/heads/master@{#464284}

When Data Saver stats are reset via the settings page, all DRP related
statistics should be erased.

BUG=710651

Review-Url: https://codereview.chromium.org/2815123003
Cr-Commit-Position: refs/heads/master@{#464283}

BUG=646711

Review-Url: https://codereview.chromium.org/2806823002
Cr-Commit-Position: refs/heads/master@{#464282}

BUG=710418

Review-Url: https://codereview.chromium.org/2815983002
Cr-Commit-Position: refs/heads/master@{#464281}

Most of ToV8 can be moved to platform/bindings, except for a few core-specific overloads. ScriptValue uses ToV8 and defines ScriptValue::From inside ToV8.h because of a cyclic dependency. So moving ToV8.h to platform also allows ScriptValue to be moved.

All the core specific overloads are moved to ToV8ForCore.h/cpp and the rest are kept in ToV8.h (which will be moved to platform/bindings later).

BUG=682322

Review-Url: https://codereview.chromium.org/2809243002
Cr-Commit-Position: refs/heads/master@{#464280}

These aren't STL-like methods, so they shouldn't have STL-like naming.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jochen@chromium.org

Bug: 710611
Change-Id: I85167fed8b260eebaacf6c4d7c4a7c0d17979bef
Reviewed-on: https://chromium-review.googlesource.com/476021Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464279}

Start() can be called on both resumption and fresh new download
This CL records only the parallel downloads that are new

BUG=644352

Review-Url: https://codereview.chromium.org/2810133003
Cr-Commit-Position: refs/heads/master@{#464278}

extensions/browser/api/networking_private requires generated
net_features.h, but does not depend on that file. This makes
build flaky depending on whether the file has been generated
by some other target before or not.

TEST=Several times simple Chrome flow with -j 24
BUG=711050

Review-Url: https://codereview.chromium.org/2808763006
Cr-Commit-Position: refs/heads/master@{#464277}

Intent to experiment:
 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0-6bmy1cOnw
Intent to ship:
 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d8KxOilsS2g
OWP launch tracking bug:
 https://bugs.chromium.org/p/chromium/issues/detail?id=661071
Feature dashboard:
 https://www.chromestatus.com/feature/5734842339688448

BUG=661071

Review-Url: https://codereview.chromium.org/2811063002
Cr-Commit-Position: refs/heads/master@{#464276}

Intent to Implement and ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/HZ_ZHEE9oDo/jXunplrqBAAJ

BUG=525660

Review-Url: https://codereview.chromium.org/2812853003
Cr-Commit-Position: refs/heads/master@{#464275}

Currently we set the mode to static before changing any properties.
This may result in an invalid configuration that will be rejected,
reverting back to automatic.

This CL:
* Only sets the IPConfig mode to static when a property is changed.
* Fixes a case where IP config state was incorrectly sent on page load when networkProperties is incomplete.
* Cleans up some functions in internet_detail_page.js to avoid potential dom-if pitfalls when using |this.foo| instead of |foo| inside a bound getter. (Also to improve consistency within the file).

BUG=704631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817613002
Cr-Commit-Position: refs/heads/master@{#464274}

Add test to check all current accelerators having keyboard overlay.
BUG=706462
TEST=KeyboradOverlayUIBrowserTest.ShouldHaveKeyboardOverlay
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814003002
Cr-Commit-Position: refs/heads/master@{#464273}

If windows isn't using overlays then it's more efficient to use a
B8G8R8A8 swapchain instead of YUY2, as then windows won't have to do its
own colorspace conversion.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2809473003
Cr-Commit-Position: refs/heads/master@{#464272}

Adds --apk-file flag to archive action. When passed, section sizes are
taken from the .so within the .apk rather than from the one in
lib.unstripped.

Also removes "symbols" from console.py, which was missed in
previous rename commit. The reason to not expose this top-level
is that it in the future, we don't want to also expose java_symbols,
pak_symbols, etc.

BUG=681694

Review-Url: https://codereview.chromium.org/2807343005
Cr-Commit-Position: refs/heads/master@{#464271}