Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 26 Oct, 2019 37 commits
  3. 25 Oct, 2019 3 commits
    • Olivier Yiptong's avatar
      [Native File System] Set user activation when file picker succeeds · 04c3c4c8
      Olivier Yiptong authored 
      Sets a new user gesture when the user successfully picks a file or
directory.

This allows developers to request write permissions immediately
following the user making a choice.

Will not activate if the user canceled.

Bug: 1014171
Change-Id: Ie7847b67316244348bf1021bac0ca058a8521dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872776
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: default avatarMustaq Ahmed <mustaq@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709704}
      04c3c4c8
    • Matthew Mourgos's avatar
      CrOS Shelf: Correctly set drag handle size · 306c1720
      Matthew Mourgos authored 
      Correctly set the drag handle size after the delegate_view_'s
layout manager is removed and set to nullptr.

Bug: 1009731
Change-Id: I68a0f137e9f065a67631d0a8df81d641d1be1f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880267Reviewed-by: default avatarManu Cornet <manucornet@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709703}
      306c1720
    • Daniel Murphy's avatar
      [IndexedDB] Fixed invalid max_object_store_id after database deletion · d437812d
      Daniel Murphy authored 
      The connection request system keeps around the LevelDBDatabase object
when a delete happens to allow subsequent open on that same database.
To do this, it resets the IndexedDBMetadata back to a default state.

During a recent refactor, this state reset wasn't done properly, and we
don't have any tests to catch that error. This change fixes that
incorrect state reset.

A test isn't included here because:
1. It passes the third party test provided to us,
2. The current unittesting framework isn't great and needs to be
   replaced (don't want to create negative work)
3. It is pretty obvious this fixes the problem, and there are no other
   'incorrectly' or 'not' re-initialized state here,
4. Current layout tests should have caught this, and it is unclear why.
   Bug to create this test: https://crbug.com/1018444
5. IndexedDB work is currently on the backburner while Storage Service
   is pursued, and won't be re-prioritized until next year-ish. I don't
   want to spend time on this now when it's needed for Storage Service
   work.

If more P0 bugs crop up in IndexedDB over the next week, then we may
have to re-think this policy and divert engineering effort towards
making IndexedDB more stable. This is present in m78, which was just
promoted to stable. If there are any more issues, we expect them to
show up in the next week or so.

TESTED=Manually tested using example test case from field.
R=cmp@chromium.org

Bug: 1018406
Change-Id: I36e42777e07ef91bf8cf11b9a633a9171ca3755e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880320
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: default avatarChase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709702}
      d437812d