- 04 Aug, 2020 40 commits
-
-
mark a. foltz authored
Replace with more inclusive terms per Chromium Style Guide. Bug: 1106011 Change-Id: I6b88cb9bfa1e1b7fa004c6e40b2ea6712cd29083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335486Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794593}
-
Piotr Bialecki authored
Bug: 1112333 Change-Id: I6be773adf04a41639865521a2eec02b66bd4989d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335895Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#794592}
-
mark a. foltz authored
Replace with more inclusive terms per Chromium style guide. Bug: 1106011 Change-Id: I42537596567d42959e737aeffba16bce34f0cda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335387Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794591}
-
Saurabh Nijhara authored
As per product requirement, restrictions such as force sign out, notifications and EOL (End of Life or Auto Update Expiration) Settings banner are not applicable to unmanaged users by default. However, the admin can enable these for unmanaged users by setting the unmanaged_user_restricted flag in the policy MinimumDeviceVersion. This CL is to show the banner on Chrome OS Settings page and management page (chrome://management) for users only if 1) Update is required as per policy 2) Device has reached EOL 3) User is managed or unmanaged_user_restricted is true in policy. This policy is only applicable to ChromeOS. Bug: 1112371 Change-Id: I8e099529b898f1c63ecf7675457f7e1dcf9e80c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335433 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794590}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/965b1ffc561e..504a6f1944fe 2020-08-04 jobay@google.com Let `$` return null when no element is found 2020-08-04 jacktfranklin@chromium.org Bridges: fix complex type finding across imports 2020-08-04 jobay@google.com Use custom query handlers to implement $ and $$ in test/shared/helper.ts 2020-08-04 patrick.brosset@microsoft.com Grid: Handle separate row/col color and dash and highlight on grid-template hover If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5bd9a51c25a1a9e2de84a10b3e953374bb028bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794589}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb3f2812. With Chromium commits locally applied on WPT: dfdc7fe9 "[WPT] Errors caught/reported for importScripts()" a1917485 "Add WPT for CSP frame-ancestors violation reporting with report-uri" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ib34e4b4485db87f845bc48b661139a6a1ddfc5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334585Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794588}
-
Sigurd Schneider authored
This helper function will be used in upcoming CLs in a few places. Bug: chromium:1069378 Change-Id: If5646fa116c1d15c38f7e5ff43d5374cebdeb151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332820Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#794587}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f3bd05074570..46b0d8780f66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib0b3dbe1c1a7c48ab122378fe90106f5e8860dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336507Reviewed-by:
-
Chris Hamilton authored
A variant container for hosting instances of util::TokenType. Allows strong typing when a token can be one of many types. BUG=1096617 Change-Id: Iec386f9760d4b093931ecdc6c477c202ae00bdc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327644 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#794585}
-
Alexander Cooper authored
Both the Plane and Anchor Manager currently maintain a map and a uint to generate Ids based on the address of their corresponding type. This logic will soon be similiarily expanded for HitTest and potentially AugmentedFaces. To avoid duplicating this logic, it is extracted into a helper class. Change-Id: I51f4475d37fe84ca687b82761d21a07b5b93d948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333674Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#794584}
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 1111134 Change-Id: I71da5c606925ead07c7469569825d000d2bd0da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331178 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#794583}
-
Bruce Dawson authored
The webui_closure_compile instructions refer to closure_compile but the correct gn arg name (as of crrev.com/c/2248564) is enable_js_type_check. Change-Id: I7bd947e0a277fe6e0f4972cd69ac2fc1c0b9b8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335557 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#794582}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/963bc42f8719..93bb4f5a94f3 2020-08-04 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-04 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-04 uekawa@google.com cros_mark_android_as_stable: print out json metadata. 2020-08-04 lamontjones@chromium.org api: freshen python bindings. 2020-08-04 erikchen@chromium.org Fix a parallel_unittest bug. 2020-08-03 vapier@chromium.org licensing: ban no-source-code license 2020-08-03 engeg@google.com chromeos_config: Sync R86 (ToT) boards criticality If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ibc2de041c387c8a4c71eadde38f9e7d3801f0d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336769Reviewed-by:
-
Jongmok Kim authored
Uses explicit deletion instead, removes use of base/macros.h. Bug: 1010217 Change-Id: Id7efbf60060e975843f53dc363763f369195f488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326515 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#794580}
-
Mikel Astiz authored
This includes: 1. Trivial removal of an unused argument |no_db|. 2. Removal of argument |delete_file|, which should be unnecessary because none of the tests seem to rely on it (is only relevant for tests that instantiate HistoryService multiple times). 3. Removal of other keyed services besides HistoryService, which tests don't seem to rely on. MediaEngagementServiceTest is one of the few examples that does advance destroying and recreation of HistoryService, and requires logic like BlockUntilHistoryBackendDestroyed(). Because it's unique to this test and not something other tests should follow, the code gets moved there. The end result is that TestingProfile::CreateHistoryService() is a convenience function to set up a testing factory. It continues to be deprecated and tests should migrate over to using TestingProfile::Builder directly. Change-Id: I8b3d0378df23e383cae42687af31a034fc921fa1 Bug: 1106699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332576 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#794579}
-
Scott Little authored
Before this CL, translate_ui_delegate.cc sorts the list of supported translate languages using insertion sort. This CL changes it to use std::sort. Bug: 1109032 Change-Id: I6687ad1ba6c4da6dbb263446ed86d416ac9637b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333996 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Auto-Submit: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#794578}
-
Joshua Pawlicki authored
CSIP was using an UpdateServiceOutOfProcess in practice. Bug: 1107586 Change-Id: I3915818a8e828fe296cdbd5f3268351f82309a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336954 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794577}
-
Marijn Kruisselbrink authored
And migrate old settings to the new names. Bug: 1110509 Change-Id: I56f12e15e767bc13f0167652fab2be71ba5ac03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324669Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#794576}
-
Kateryna Prokopenko authored
Doc: https://docs.google.com/document/d/1hmC2R-f2_024I3urdEpKm34V5tSWeIk8MuRts7rggso/edit# Bug: chromium:1082628 Change-Id: I5ddc4e3cd9fc509b46442c0e506553527d1dc4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289841 Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#794575}
-
Nektarios Paisios authored
When an object on Mac is focusable but has no value or name, we compute its accessible description from its inner text. Unfortunately, we were adding a space between the concatenation of each piece of text coming from each child object which creates a mismatch between the text offsets returned by AXPosition and text markers vs. the actual text contents. If extra spaces are needed, they should be added by Blink, not by the browser. This patch removes the code that computes the inner text completely since no other screen reader announces focusable items unless they have an accessible name, and it is not proper to add an accessible name if there is none. AX-Relnotes: On Mac and same as on all other platforms, navigating by tab now does not announce the text contained in a large container such as a table row if that container is focusable. R=dmazzoni@chromium.org Change-Id: Iac5f321113595a2372df03bb119ab1c7a6f1bbf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308649 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#794574}
-
Chris Harrelson authored
This fixes the referenced performance regression in which some such videos stopped being composited. Bug: 1108972 Change-Id: Ia77d33c1c50cf25427d825ae3969a120a8cde640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335648Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794573}
-
Nate Chapin authored
Bug: 1112031 Test: fast/media/readystate-update-in-detached-context.html Change-Id: Id3c865021b1331d83004b371bdf5b9b23d879e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335484Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#794572}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1e4158db1ce7..3000d6b8c25c 2020-08-04 brianosman@google.com Validate function return and parameter types in IR generator 2020-08-04 nifong@google.com Add ParagraphBuilder.pushPaintStyle to allow text to be colors with paints. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: Iae91a5dc69f81364e66165ac561ba3f71e83a69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336768Reviewed-by:
-
Hans Wennborg authored
Otherwise the function fails to do any copying in compiles which doesn't hit the cases above. Bug: 1103818 Change-Id: I18b99488df6852e3713c6b2dc7ae268eceedee52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336075 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#794570}
-
Maksim Sisov authored
Otherwise, they don't compile for use_x11 && use_ozone case Bug: 1085700 Change-Id: I56a2afd959a694cb6a80422f440f85419d35f1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333200Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#794569}
-
Steve Kobes authored
This will measure how often we fail to report FCP to UKM due to the tab becoming hidden during the flushing window (go/plm-flushing). Bug: 1010643 Change-Id: I0922f2d461407efb12bb9d02267a4620178a7dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329915Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#794568}
-
Xianzhu Wang authored
This reverts commit 84b0d040. Reason for revert: Caused crbug.com/1112642. Original change's description: > Reland "Use border box or layout overflow rect for layout shift tracking" > > This reverts commit 491b5a9c. > > The original CL was reverted because it caused failure on MSAN bots > due to use of uninitialized value. > > The reason was that PaintInvalidatorContext::tree_builder_context_ > pointed into an PrePaintTreeWalkContext entry in a vector, and the > vector could be reallocated when we added new entries, causing the > pointer in the parent PaintInvalidatorContext to point to an invalid > address. > > Now remove PaintInvalidatorContext::tree_builder_context_ and add > PaintInvalidatorContext::transform_ (which was the only used information > from the parent PaintInvalidatorContext) to avoid the problem. > > Original change's description: > > Revert "Use border box or layout overflow rect for layout shift tracking" > > > > This reverts commit 0933392f. > > > > Reason for revert: ASAN/MSAN failures due to "use of uninitialized value"; see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8873209606965810848/+/steps/browser_tests/0/logs/Deterministic_failure:_AllForms__x2f_FormStructureBrowserTest.DataDrivenHeuristics__x2f_148__status_FAILURE_/0 > > > > Original change's description: > > > Use border box or layout overflow rect for layout shift tracking > > > > > > This CL addresses the following issues of layout shift tracking: > > > - Changed visual overflows triggered layout shift report > > > (originally filed as crbug.com/1090763). > > > - Descendant layout overflows were not included in ancestor's layout > > > shift report. > > > - Unnecessary descendant layout shift report. > > > - Slow visual rect calculation for LayoutInline and LayoutText. > > > > > > It includes the following changes > > > - Track LayoutBoxes and LayoutTexts only. > > > - Track both old and new starting points and visual representations > > > instead of using location of visual rects as starting points. > > > - For a LayoutBox, the local visual representation is the layout > > > overflow rect if the LayoutBox has layout overflow and doesn't clip > > > overflow. Otherwise use the border box rect. > > > - For a LayoutText, suppose its shift causes shift of all contents > > > in containing block logically below the LayoutText, and use that > > > part of visual representation of the containing block as the visual > > > representation of the shift. > > > - Map both local starting points and local visual representations to > > > the initial containing block and viewport. > > > > > > This has the following benefits: > > > - More accurate starting points and visual representations, conforming > > > to the specs; > > > - Better performance by > > > * avoiding unnecessary layout shift reports of descendants > > > * avoiding slow LayoutInline and LayoutText visual rect calculation. > > > - sizeof(LayoutObject) is reduced by 16 bytes because now we use the > > > previous geometry data in LayoutBoxes for paint invalidation. > > > > > > Bug: 1108622 > > > Change-Id: I7ebb4e250e7ca2a03b4dadea50034e300e55ad84 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319538 > > > Reviewed-by: Steve Kobes <skobes@chromium.org> > > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#793806} > > > > TBR=wangxianzhu@chromium.org,skobes@chromium.org,kojii@chromium.org > > > > Change-Id: I590f2abc4a48ba65bdfe7a948ffce00b299f9e06 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1108622 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333578 > > Reviewed-by: Peter Kasting <pkasting@chromium.org> > > Commit-Queue: Peter Kasting <pkasting@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#793874} > > # Not skipping CQ checks because this is a reland. > > Bug: 1108622 > Change-Id: I253a24799b6d2a3af346d4f65e3889217064b035 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333648 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794218} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I06c05f8cab6b2cc2ecd3cf3febf930e6eb95f777 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108622, 1112642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336782Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794567}
-
Lukasz Anforowicz authored
The primary goal of this CL, is being able to add the following DCHECKs: DCHECK(loader_factories_); DCHECK(loader_factories_->HasBoundDefaultFactory()); to RenderFrameImpl::DidCommitNavigation. If these DCHECKs hold, then ChildURLLoaderFactoryBundle::GetFactory should always get the |base_result| from the base class and therefore shouldn't ever need to fall back ot the |direct_network_factory_| fallback (which wraps the deprecated, process-wide / frame-agnostic factory). One scenario where the new DCHECKs didn't hold before this CL is RenderFrameImpl::LoadHTMLString which is mostly used from tests, but also has a call in the product from MimeHandlerViewContainerManager::LoadEmptyPage which is used by MimeHandlerViewEmbedder::CheckSandboxFlags to load an empty page when security checks fail. Another scenario is unit tests like RenderViewImplTest going through TestRenderFrame (where tests drive the simulated commit). All of these cases don't actually use the factory bundle and therefore can just use the NotImplementedURLLoaderFactory. The CL splits GetLoaderFactoryBundleFallback from GetLoaderFactoryBundleFromCreator to make it more obvious when the fallback is actually needed. In particular, this allows the new DCHECKs in RenderFrameImpl::DidCommitNavigation to explicitly avoid the fallback. To facilitate reuse of NotImplementedURLLoaderFactory from //content/renderer the CL moves this class from //content/test into //services/network/public/cpp. The CL also adds NOTREACHED to NotImplementedURLLoaderFactory::CreateLoaderAndStart to ensure that future callers don't accidentally start using the factory. NOTREACHED is also added to the non-opaque-origin/DwoC case in ChildURLLoaderFactoryBundle::GetFactory (this probably should have been part of r792963 which added a test that would have hit this NOTREACHED before the fix). Bug: 1098938, 1105794 Change-Id: Ifaedf40be35871b0a30797c09a236ea131b24447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321346Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#794566}
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 1111134 Change-Id: Icf1bba68f665b44864614f724072719bac9b3b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331418Reviewed-by:
-
Xiaohan Wang authored
This CL adds support for MacOS ARM64 Widevine CDM so that it will be registered as a component. Currently the CDM is not available on the server for component update, not will it be bundled to Chrome. These will be resolved later, as tracked by crbug/1111381. Bug: 1110364,1111381 Change-Id: I4fa28d524f21bebdc13fbfb47ecdf8ece7b811ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333997Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#794564}
-
Fawaz Mohammad authored
Adds action for enabling virtual authenticator environment. Used as metric to track use of WebAuthn DevTools front-end. Related CL that implements metric: https://crrev.com/c/2333990 Design doc: https://docs.google.com/document/d/1A-cn0rxuHHAyGhywayk7xcTqSsR2X7va6H4kSMThOoY Bug: 1034663 Change-Id: I2e4145e3bb1951968770971a3f0bace8a8403f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332995Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Fawaz Mohammad <fawazm@google.com> Cr-Commit-Position: refs/heads/master@{#794563}
-
Peter Boström authored
This Can hopefully prevent confusion / wasted time when running TestSuite instead of TestSuite.*, Test instead of Test/0, etc. Bug: 999246 Change-Id: I26ecf8d641c6a3e72c5fbc29fedb881eb2622c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808728 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#794562}
-
Philip Rogers authored
Painted scrollbars are used for overlay scrollbars on MacOS. Thumb movement would cause a commit on every scroll change because the update rect (set via Layer::SetNeedsDisplay) would change. This patch ignores the update rect in PaintedScrollbarLayer::Update and uses part invalidation for causing commits. With this change, scroll offset changes do not cause commits. This is a reland of https://crrev.com/745544. Bug: 1048384f Change-Id: Ic7cb0eed729536dd39e87913324e89c01fa27094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333866Reviewed-by:
-
Chris Sharp authored
Also add a presubmit check that all unsupported policies have been marked as deprecated and fix all cases in policy_templates.json where that hadn't been done. Bug: 1018841 Change-Id: I8e7e69330746ec9c174ccbd1ed9ac66790c4a5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329674 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#794560}
-
Scott Violet authored
Specifically if the url is the same as the last page and the navigation is a same-document navigation, then FaviconHandler need not do anything. This scenario happens when using history.replaceState() and the like (which is used on the SRP). BUG=none TEST=covered by test Change-Id: Ida3aabeefb1cef033b68b667049fa724efe7b4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335024Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#794559}
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 1111134 Change-Id: I35fabb6b626d8763b37ce71e6bd01505cf5b74ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331417 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Currently, feature initialization looks like this: 1. The pref store is initialized (which contains saved flag states) 2. A FlagsState instance is initialized from that prefs store a. FlagsState computes which switches and features should be in what states based on flags b. FlagsState excludes switches and features from flags that are currently expired 3. A FeatureList is initialized from that FlagsState Unfortunately, deciding whether a flag is expired or not requires knowing the state of the various TemporaryUnexpireFlagsM$M features, which aren't initialized until step 3, so step 2b doesn't actually work properly. During step 2b, every unexpiry feature is treated as if it was in its default state (i.e. disabled), which means that every flag whose expiration has passed is treated as expired, regardless of the state of the unexpiry flag. As a result of *that*, when the FeatureList is initialized at step 3, any such flag's configured value gets ignored. The fix for this is deeply unfortunate: at step 2b, add a special case in checking whether a flag should be considered expired or not. Specifically, consider not just the state of the unexpiry feature (which may not have been initialized yet) but also the state of the backing unexpiry *flag*. To enable this, pass a FlagsStorage into the FlagsState::Delegate. Change-Id: Ia2b6423357d24318baaeb3ca34208d1a2f1c36aa Bug: 1101828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302925Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#794557}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d14d99cd75b8..46b0d8780f66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I583f21fe009238abe16fd7454c6b90ea4aa0f62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336505Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46b0d8780f66..7176f54720e6 2020-08-04 hjd@google.com Merge "Support armv7l in system_probes_parser" 2020-08-04 lalitm@google.com Merge "tp: switch from dict to list of pairs in descriptor generation script" 2020-08-04 hjd@google.com Merge "Call sendfile in a loop to handle short writes" 2020-08-04 lalitm@google.com Merge "ui: fix searching for data bounds on tracks" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I36af41efbcb71eba7c1b942c3c89e1fc9d2712e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336765Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 1111134 Change-Id: Id709ff4a489dd156ef6dd1daed24292eae0c9dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331439 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
