- 31 Jan, 2020 40 commits
-
-
Robert Ogden authored
Adds the integration to the last CL and a couple tests. Bug: 1023486 Change-Id: Ia0999fa09282df394944756e350f413867f45f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033426 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737390}
-
Nazerke authored
This CL removes public properties for BrowserState and dispatcher values and updates the coordinators implementation to get them from self.browser. The refactored coordinators: - Advanced Signin Settings Coordinator - Google Services Settings Coordinator - Signin Interaction Coordinator. Bug: 1029346 Change-Id: I9c7dda862e3d26898a84dd6c6d52f464d66441d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033256 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#737389}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5de415c5e3f9..c73475fb3c99 git log 5de415c5e3f9..c73475fb3c99 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 syoussefi@chromium.org Vulkan: Fix UtilsVk dirtying driver uniforms descriptor set binding Created with: gclient setdep -r src/third_party/angle@c73475fb3c99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I69f40ef43c62b45b5f5ddd671e155c8d41471723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033123Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737388}
-
Donn Denman authored
Adds support for new Contextual Search Resolve-request parameters to provide translation hints from the client. The server uses these params as additional hints from the Chrome Language Model for the user's preferred language and the language of the selection and page content. This means the returned Search Term may be translated or be accompanied by a Translation Card. The parameters we send in the Resolve request are the same parameters we currently send to force a translation one-box in the Search request: "&tlitesl=" for source language and "&tlitetl=" for the target language. BUG=952401 Change-Id: Ia79d8c0cf3706009c2b6213895ad8f6df543c24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032058 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#737387}
-
Scott Violet authored
This adds using base::android::Foo in a couple of places that make extensive use of the type. BUG=none TEST=none Change-Id: I798aa724cbbe5c18de1af538aea43bba0f6b3a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033330 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#737386}
-
Mark Yacoub authored
1. Get "CRTC_ID" DRM property for Connector. 2. Get "ACTIVE" and "MODE_ID" DRM props for CRTC. 3. Add Connector Props are part of MockDrmDevice. BUG=987274 TEST=HardwareDisplayPlaneManagerTest, HardwareDisplayControllerTest, DrmOverlayValidatorTest Change-Id: I9b500ade01ad9179e1417a6bc0471b3d9b412cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031741Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#737385}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. ARC has its own consent, unrelated to chrome browser sync consent. Switch to using the "unconsented" primary account. This account is always the main GAIA account for the signed-in user, and exists whether or not the user has consented to browser sync. This requires updating: * ArcAuthService * ArcSupportHost * ArcAndroidManagementChecker See go/cros-primary-account and go/cros-sync-mock for details. TBR=droger@chromium.org Bug: 1042400 Test: updated existing unit tests and browser tests Test: Set --use-unconsented-primary-account and --enable-features=SplitSettingsSync and verify Play Store runs and is signed in after: * Login with consumer @gmail.com * Enroll to @google.com and signin with @google.com * Enroll to @managedchrome.com and signin with managed guest Change-Id: I48abe048a95d6aa234d4b87e76b2d70c5e88aebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029307 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737384}
-
danakj authored
Mojo IPC channels are dropped when the main frame RenderWidget is deleted and recreated, so even though it maintains the same legacy IPC routing ID, IPCs sent toward the old RenderWidget will not be received by the new one for Mojo IPCs. Thus there is no race to guard against those IPCs arriving after a provisional frame with the same routing ID is created. R=avi@chromium.org Bug: 419087 Change-Id: If3e08de13e1ed20d97abc8d77c53c942fe6ac724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004790 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737383}
-
Virender Singh authored
This change modifies IDS_PDF_PAGE_INDEX string to follow formatting rules defined in: http://userguide.icu-project.org/formatparse/messages Bug: 1043505 Change-Id: Iba763c3d6c7229603d8bea28d81ff2a91f473024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032690Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Virender Singh <virens@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737382}
-
Connie Wan authored
Tabs are groupable if they aren't all in the same group. Otherwise, they will show as Grouped and be ungroupable. Bug: 1039924 Change-Id: Ifff4fff3a5c4274877595912c520107a1ed5edc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026695Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#737381}
-
Bo Liu authored
Apparently view becoming visible races with launching the activity. So do a poll instead of a simple check. Bug: 1035894 Change-Id: Icc62f70035af10318c5611f4bff3a0e0fbc4ab5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031434Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737380}
-
Eugene But authored
The bug appeared after crrev.com/1986242 because identityDisk is now placed on toolbar. Toolbar sits underneath the doodle and doodle simply covers the toolbar and steals the gesture. This CL swaps z-index for toolbar and doodle and disables user interactions for toolbar in landscape. This way the user can still tap on that toolbar in portrait and tap on doodle in landscape. Bug: 1046303 Change-Id: I76d49f9c440c1f4cf6be8ee24513ec78848b2b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028741Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#737379}
-
Mustaq Ahmed authored
Bug: 1047473 Change-Id: I5ccf13f3c11e0740498913712c324230d103c9da TBR: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031187 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737378}
-
Michael Thiessen authored
Replaces usages of java.net.URI with GURL. Bug: 783819 Change-Id: I1fbcabd96afaa3b55165f1bcff926d9b31d6a3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031559 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#737377}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I0b52e557c30b657d17bebf51e106b2f1025b6998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031910Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737376}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/631e93892acf..22ab8b24f234 git log 631e93892acf..22ab8b24f234 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 taylori@google.com Merge "perfetto-ui: Stop selection marker overflowing" Created with: gclient setdep -r src/third_party/perfetto@22ab8b24f234 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I98ad0ac46313a6799b55fa3916256206fdcfe47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033404Reviewed-by:
-
Joshua Pawlicki authored
The main thing here is to move get_parts into the parts.py. Bug: 926234 Change-Id: Icf7d9129281ef45438d1dfa27c992c011d0306bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016972 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#737374}
-
Ioana Pandele authored
TBR=xidachen@chromium.org Bug: 1047205 Change-Id: I67dac7a120396be9f1b260e1226cc202b9730d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033444Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#737373}
-
Aaron Leventhal authored
Chrome attempts to fire the event on an ignored parent of the text, and the method returns early. The event needs to be fired on an unignored ancestor. Bug: 1041290 Change-Id: I12cda65ec23c8ff3a771da3fe1c29ebf4b8cb0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015606 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#737372}
-
Gavin Williams authored
-Disable the Add button so the user can't save a printer if the Manufacturer or Model dropdowns have incorrect values. Fixed: 950887 Change-Id: I533748488b777eca7ac2329d2cb2e5402cca72be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018093Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#737371}
-
Torne (Richard Coles) authored
Pull in the latest BuildCompat implementation from androidx-master-dev and include R in the version list. Change-Id: I6c6242923d975538364ceb62962215d670902dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031433 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#737370}
-
Sahir Vellani authored
It is possible to now observe changes to content box and border box of an element that is being observed. However, changes to an element's content box without a change in its border box can not be observed yet, and will be addressed in a subsequent change. Bug: 1042537 Change-Id: I6415fc4f5cec783cc717051c11b2fdd95d3a28e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004051Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737369}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2cf1247bee6..539e9740e1cd Created with: gclient setdep -r src-internal@539e9740e1cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046782 Tbr: jbudorick@google.com Change-Id: I5d7b964fe8ff296c18983c7fec370a663d6a3be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737368}
-
Mikel Astiz authored
In particular, GUIDs are now validated against the client tag hash (if available), and all sync metadata is thrown away in situations like local bookmarks having duplicate GUIDs upon started (theoretically unreachable). In order to achieve this, the code is refactored to move some additional logic into SyncedBookmarkTracker, in particular because the mapping from local nodes to sync metadata entries must be available in order to enforce more strict validation logic. Change-Id: I0e084d2f53a4a5447192f9e3667b70df8630493e Bug: 978430,1032052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029370 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#737367}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/023284c1ce32..3c0114c6399a git log 023284c1ce32..3c0114c6399a --date=short --first-parent --format='%ad %ae %s' 2020-01-31 robertma@chromium.org Declare tags in expectation files Created with: gclient setdep -r src/third_party/devtools-frontend/src@3c0114c6399a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:986447 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iacb9a39d0c27615b18ac506b33d9bbe059274ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033122Reviewed-by:
-
Adam Langley authored
This change adds a hover button to the new transport selection sheet that allows the native Windows API to be triggered. This change is feature-flag protected behind WebAuthenticationPhoneSupport. BUG=1002262 Change-Id: I709186edb1d73014155b180c5c10fa7d68e46a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032013Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#737365}
-
Reilly Grant authored
Bug: 1020746 Change-Id: I6744bfd35bef56b5edc3c8e0963e3fd8459e7bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032178 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#737364}
-
Alex Clarke authored
and other embedders. There doesn't appear to be any existing tests for this functionality and I'm not sure how to easily test it. Bug: 1025612 Change-Id: I81354ff16a6bb9c9bc3a9ada99018ad1e2c82031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959034Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737363}
-
David Van Cleve authored
We're going to 50% beta on this feature (changing the default referrer policy to strict-origin-when-cross-origin) so it's time to add a field trial testing config. Also updates the following tests, which were failing with the testing config enabled: - ContextMenuBrowserTest.OpenInNewTabReferrer - DownloadReferrerPolicyTest.DownloadCrossDomainReferrerPolicy Bug: 1014207 Change-Id: Ic50657d9c2f642af8538fea47fe2263797d45018 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012087 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Sergey Silkin authored
This reverts commit 2f4fb261. Reason for revert: M80/M81 blocker. Bug 1046501. Original change's description: > Revert "Reland "media: use VEA SupportedProfile |min_resolution| for PeerConnection"" > > This reverts commit 49e19ab9. > > Reason for revert: Landed without testing (No-Try: true). Will revert, enable tests and reland. > > Original change's description: > > Reland "media: use VEA SupportedProfile |min_resolution| for PeerConnection" > > > > This reverts commit a629c52f. > > > > Reason for revert: M80/81 blocker. Bug 1046501. > > > > Original change's description: > > > Revert "media: use VEA SupportedProfile |min_resolution| for PeerConnection" > > > > > > This reverts commit 72037f82. > > > > > > Reason for revert: M80 Stable blocker bug 1046501 > > > > > > Original change's description: > > > > media: use VEA SupportedProfile |min_resolution| for PeerConnection > > > > > > > > crrev.com/c/1828078 added and wired the video encode acceleration > > > > minimum resolution; this CL uses this information from peerconnection's > > > > rtc_video_encoder.cc and video_codec_factory.cc to avoid using a > > > > hw accelerator for resolutions below the given one. > > > > > > > > TEST=https://codepen.io/miguelao/full/jONQBYb on nocturne (pixel slate), then > > > > inspecting chrome:webrtc-internals, verifying that resolutions below 321x241 > > > > are encoded using libvpx while larger ones are encoded using "ExternalEncoder", > > > > i.e. the video encode accelerator in Chrome, in this case VA-API. > > > > > > > > Bug: 1008491 > > > > Change-Id: Iccfe6be8811ca265d6dbc742beb3ec0901406a40 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848398 > > > > Commit-Queue: Miguel Casas <mcasas@chromium.org> > > > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#720981} > > > > > > TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,guidou@chromium.org,ilnik@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: 1008491 > > > Change-Id: Ie7279fcc02e041f4e1a4a0ed0cef248aa24d472e > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028889 > > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > > Commit-Queue: Miguel Casas <mcasas@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#736904} > > > > TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,hbos@chromium.org,guidou@chromium.org,ilnik@chromium.org,ssilkin@chromium.org > > > > Change-Id: I92b4e10f9ef39d2c642a6c9ae4d3a1e3f0fbb609 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1008491 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033345 > > Commit-Queue: Miguel Casas <mcasas@chromium.org> > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#737332} > > TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,hbos@chromium.org,guidou@chromium.org,ilnik@chromium.org,ssilkin@chromium.org,ssilkin@google.com > > Change-Id: I1cadec33578747fca04b44867a8951a9c69d3280 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1008491 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033348 > Commit-Queue: Ben Mason <benmason@chromium.org> > Reviewed-by: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737334} TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,hbos@chromium.org,guidou@chromium.org,ilnik@chromium.org,ssilkin@chromium.org,ssilkin@google.com,benmason@chromium.org Bug: 1008491 Change-Id: I4d44659b5bd9fb85cd3f1121a5633fb1b183424d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033257Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Sergey Silkin <ssilkin@google.com> Cr-Commit-Position: refs/heads/master@{#737361}
-
Anatoliy Potapchuk authored
We need some of these apps like Files app, and possibly in future the settings app. Bug: 1047211 Change-Id: I270e9bc86d849f76470e4befb49b2968fc87e3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031027 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#737360}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/79b36b640692..55890e1afe33 git log 79b36b640692..55890e1afe33 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 bclayton@google.com CMake: Add build rules for google benchmark. 2020-01-31 bclayton@google.com Add google benchmark submodule to third_party. Created with: gclient setdep -r src/third_party/swiftshader@55890e1afe33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ifc3caceaabda713568ed18d5316768951167f9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033116Reviewed-by:
-
Lorne Mitchell authored
LayerTree.getCompositingReasons was updated to return an array of compositingReasonIds. This CL updates the layer-compositing-reasons.js to match against the IDs instead of the messages. Bug: 946860 Change-Id: I4de8a6da10cb14c4def1ad0a726c0d51e591c029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028690 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737358}
-
Mikel Astiz authored
A BookmarkNode's title can only be changed from the UI thread, but is also read by the history backend thread via HistoryBookmarkModel::GetBookmarks(). Hence, a lock must be acquired before changing the title. In practice, this race should be extremely unlikely (if not impossible) since assignment of base::string16 may as well be atomic in practice. Change-Id: I8b31b977efe8fdcb918be8692984b2eab9dd0411 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031041Reviewed-by:
-
Bo Liu authored
Bug: 1042063 Change-Id: Iae03f34cd256bce803bd4c7e215ea3f56def168b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016852Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737356}
-
Evan Stade authored
The code in this component is unique to javascript dialogs, and does not cover all app modals. Further, it has some view code that isn't specifically for app modal javascript dialogs, but is re-used for tab modals. Some tab modal code from //chrome will be moved here soon, so rename from app_modal to javascript_dialogs. Class names reflect whether their use is specific to the app modal control flow. Also, rename some classes to better reflect their roles: . JavaScriptDialogManager (implements content::JavaScriptDialogManager) => AppModalDialogManager . JavaScriptAppModalDialog => AppModalDialogController . NativeAppModalDialog => AppModalDialogView etc. Bug: 1025256 Change-Id: I0a1865ec71897ae6549184bc317ede29cc56438a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031936Reviewed-by:
-
Michael Thiessen authored
Replaces usages of java.net.URI with GURL. GURL appends a trailing slash to pathless URIs to normalize them, which java.net.URI does not do, so AndroidPaymentAppFinder has to normalize URI methods in the same way Origins get normalized. Bug: 783819 Change-Id: I0574ff318309642ce3220488ef7f5c08a389478a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031525Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#737354}
-
Elly Fong-Jones authored
Dramatis personae: CredentialLeakDialogView (CLDV): a DialogDelegateView, owned by Views CredentialLeakDialogController (CLDC): an abstract interface used by CLDV. CredentialLeakDialogControllerImpl (CLDCI): a CLDC instance - actually the only one used in production ManagePasswordsUIController (MPUIC): a WebContentsUserData that controls any password-related UI showing for a given WebContents. Owns at most one CLDC instance. Right now, there are two ways that a CLDV can be closed: in response to something that happens in the browser, or in response to the user clicking one of the buttons on the CLDV. The former case looks like, e.g.: MPUIC::OnChooseCredentials calls CLDCI::~CLDCI calls CLDV::ControllerGone calls Widget::Close calls NonClientView::CanClose calls DialogClientView::CanClose calls CLDV::Close calls CLDCI::OnCloseDialog calls MPUIC::OnLeakDialogHidden and in MUPIC::OnLeakDialogHidden, dialog_controller_ is already null, so the stack unwinds. The *latter* case looks like this though: DialogClientView::ButtonPressed calls DialogClientView::AcceptWindow calls DialogDelegate::Accept [aka CLDV::Accept] calls CLDCI::OnAcceptDialog calls MPUIC::OnLeakDialogHidden calls CLDCI::~CLDCI calls CLDCI::ResetDialog calls CLDV::ControllerGone calls Widget::Close (!) calls NonClientView::CanClose calls DialogClientView::CanClose calls CLDV::Close calls CLDCI::OnCloseDialog calls MPUIC::OnLeakDialogHidden at that point in MPUIC::OnLeakDialogHidden, dialog_controller_ is null because of the previous call on the stack, so the stack unwinds. However, note that the controller got notified of the closure twice - once via OnAcceptDialog and once via OnCloseDialog. To avoid that double notification in case 2, CredentialLeakDialogView nulls out its own controller in {Accept,Cancel,Close}, with a scary block comment about why this is done. The actual issue, though, is the CLDCI::~CLDCI -> CLDV::ControllerGone -> Widget::Close steps - in case 2, the Widget is *already* in the process of closing, as soon as {Accept,Cancel,Close} return; it should not re-enter Widget::Close at all! In order to avoid that re-entry, this CL has CLDV only close itself if the controller is still not null in ControllerGone(), so the logic in the CLDV's accept/cancel/close callbacks that nulls the controller serves to prevent a recursive close. This allows dramatically simplifying the logic around closure in this dialog, and using the "new" closure methods for dialogs. Bug: 1011446 Change-Id: I60100a31614ba10c5e615b985ff3039a2bfbffe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028194 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Reviewed-by:
-
Nico Weber authored
Looks like all instances of the warning are fixed now. Bug: 1035171 Change-Id: I1a790f9c483525a8b72bda70f7dc27950321bfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031683 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737352}
-
Ben Pastene authored
This will fix e.g. src-internal autorolls that include an internal chrome trybot via cq_include_trybots, but are unable to launch them: https://chromium-review.googlesource.com/c/chromium/src/+/2032214 Note that it's silently failing to trigger for now, but a follow-up fix will make it fail loud and clear. Bug: 1047347 Change-Id: I74d6353fa30abfee3c5fbf65faf6dda4fa088fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031972Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#737351}
-
