- 28 Feb, 2018 40 commits
-
-
https://skia.googlesource.com/skia.git/+log/db1e5c6474c1..dabef9dddd4f $ git log db1e5c647..dabef9ddd --date=short --no-merges --format='%ad %ae %s' 2018-02-27 benjaminwagner Omit Chromecast test that seems to OOM. 2018-02-28 robertphillips Revert "Move atlas manager creation to GrContext derived classes" 2018-02-28 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 360098d5c..2f3a0dc5c (3 commits) 2018-02-27 bsalomon Refactor GrCaps::renderTargetWritePixelsSupported to support for some GL workarounds 2018-02-27 robertphillips Move atlas manager creation to GrContext derived classes 2018-02-27 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ e496333d5..40a19927b (1 commit) 2018-02-27 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 06a87ec83..360098d5c (3 commits) 2018-02-27 robertphillips Fission GrAtlasGlyphCache in two 2018-02-27 benjaminwagner Switch Win10 ShuttleC bots to new Windows image. 2018-02-27 benjaminwagner Switch Win10 AlphaR2 bots to new Windows image. 2018-02-27 reed date recent version bump for path serialization 2018-02-27 reed fix crasher in path-->region 2018-02-17 halcanary SkQP: optionally build make_universal_apk with debug on. 2018-02-27 egdaniel Fix unit tests that were causes vulkan unitialized memory warnings in validation 2018-02-27 egdaniel Make sure we add render target mem barriers after any last second copies 2018-02-26 benjaminwagner Upgrade Win Intel Haswell/Broadwell GPU drivers. 2018-02-27 mtklein prepare Google3 for the return of SkOpts_hsw.cpp 2018-02-27 caryclark avoid divide in pathopsquad 2018-02-27 caryclark updated includes 2018-02-27 kjlubick Tweak API fuzzers to run better in libfuzzer 2018-02-27 caryclark work on skimageinfo 2018-02-26 reed keep points as floats until after clipping 2018-02-27 reed limit crash small steps in 1dpatheffect Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I902377fffe8d387bc76eadc3aa694f69a9bf4046 Reviewed-on: https://chromium-review.googlesource.com/941381 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539891}
-
https://chromium.googlesource.com/angle/angle.git/+log/2f3a0dc5cbc2..d444255a779b $ git log 2f3a0dc5c..d444255a7 --date=short --no-merges --format='%ad %ae %s' 2018-02-27 jmadill Refactor signal utils into Observer pattern. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ic541c0a41284df331e8a29982a0d707347ebd146 Reviewed-on: https://chromium-review.googlesource.com/941403Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539890}
-
Misha Efimov authored
Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5819eab242ec2864d9bdc261868871179e80c8a3 Reviewed-on: https://chromium-review.googlesource.com/906951Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#539889}
-
Artur Khachatryan authored
The following tests are failing on Android Chromium build bot. Tests are disabled. Some of these tests are flaky. Bug: chromedriver:2286 Change-Id: I44a7fa01a4e2d909d78f2749a8f7f5ecdf8c34e5 Reviewed-on: https://chromium-review.googlesource.com/941420Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#539888}
-
https://chromium.googlesource.com/catapult.git/+log/c0485e380759..e544456fc734 $ git log c0485e380..e544456fc --date=short --no-merges --format='%ad %ae %s' 2018-02-28 perezju [soundwave] Store alerts data on local sqlite database Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I307a32cc35cd565844fb01efc82920db814011d3 Reviewed-on: https://chromium-review.googlesource.com/941408Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539887}
-
Kenneth MacKay authored
This reverts commit 070d31f1. Change-Id: I680c372a0e0dce7e24f889bf1a461db26329ed6d Reviewed-on: https://chromium-review.googlesource.com/941602Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#539886}
-
Vaclav Brozek authored
Based on a UI review decision (go/pppme), the title of the passwords settings on Android should be just "Passwords", instead of the dated "Save passwords" -- the settings page offers much more than the ability to switch password manager on or off. This CL splits the string used for the settings title and for the switch of the "save passwords" preference. It changes the former to "Passwords" and keeps the latter "Save passwords". Screenshots: https://crbug.com/788660#c4 Bug: 788660 Change-Id: I699b753932c379f971b13ada69470f807627ea7a Reviewed-on: https://chromium-review.googlesource.com/941215 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#539885}
-
kylechar authored
This CL implements ConfineCursorToBounds() for Ozone X11. By default we don't want to confine bounds on Ozone X11, because it makes development painful, so only if --ash-constrain-pointer-to-root is passed in. This requires some changes to AshWindowTreeHost to move the check for if we want to confine cursor into a place that an AshWindowTreeHost can check it every time ConfineCursorToRootWindow() is called. Bug: 771212 Change-Id: I3092c808e44d6f6c56c995ecd3e8547ba3b4a1cd Reviewed-on: https://chromium-review.googlesource.com/940276 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#539884}
-
Niklas Enbom authored
This reverts commit f8ad1b88. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=811780 Original change's description: > Fix crash in media picker and add test. > > In media picker dialog on Mac, when sharing tab, > when selected tab is deleted, there was no "Share" buttun state update > (which should disable it). That caused crash, report was auto uploaded > from Chrome Canary 66.0.3334.0: > > Bug: 807811 > Change-Id: I6cf29087b5cf0926b03b2c27e404fe0d57edcf21 > Reviewed-on: https://chromium-review.googlesource.com/895529 > Commit-Queue: Trent Apted <tapted@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533887} TBR=tapted@chromium.org,eugenebng@yandex-team.ru # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 807811 Change-Id: Ie4064ef9aed08716fce50a79eb036b28cb7f7ba9 Reviewed-on: https://chromium-review.googlesource.com/941541Reviewed-by:
George Zhou <gyzhou@chromium.org> Commit-Queue: Niklas Enbom <niklase@chromium.org> Cr-Commit-Position: refs/heads/master@{#539883}
-
Ella Ge authored
This cl removes 'floor's from a WebMouseEvent constructor. They are missed in previous changes. We don't need these floor since we already already remove other trunctions and use float value for WebMouseEvent coordinates. Bug: 456625 Change-Id: Ia1439ee2323369d0272649d5e98f632cfbdcf183 Reviewed-on: https://chromium-review.googlesource.com/940440Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#539882}
-
Anthony Vallee-Dubois authored
This CL exposes DialogClientView's kIsOkButtonOnLeftSide constant in views::PlatformStyle and uses it in the views:: implementation of TranslateBubble to provide the proper button order in the bubble. Bug: 814477 Change-Id: I2e4c9576fba01bd270310db7d483eb6a6327b192 Reviewed-on: https://chromium-review.googlesource.com/937884Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#539881}
-
rajendrant authored
Records the data savings percentage at Chrome startup for data saver enabled users who have browsed at least 10MB. Positive and negative savings are recorded in separate histograms. Bug: 813258 Change-Id: If764b59e72583aa495fcb604c771540aa1785287 Reviewed-on: https://chromium-review.googlesource.com/935665 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#539880}
-
Vladimir Levin authored
This patch ensures that when we paint the mask layer that is generated as a result of an inner border radius clip, we use the transform from LocalBorderBoxProperties, which does not include the scroll offset from the scrolled contents. R=chrishtr@chromium.org, trchen@chromium.org Bug: 814664 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4ba134134dda367e6ddc9d7005a6ff8ae7003426 Reviewed-on: https://chromium-review.googlesource.com/938319Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539879}
-
Ken MacKay authored
BUG= internal b/71559266 Change-Id: I2750dd2e4b8eb012c7035ebb144aab6613538550 Reviewed-on: https://chromium-review.googlesource.com/937805Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#539878}
-
Christopher Thompson authored
This makes TryCancelAll() additionally clear the flags map and invalidate any weak pointers, so that HasTrackedTasks() will return false immediately after calling TryCancelAll() (aligning calling TryCancelAll more with destroying the CancelableTaskTracker). This also updates the unit tests to account for this. Bug: 817054 Change-Id: I5d65847c2d230ed832d372f3980b847770638126 Reviewed-on: https://chromium-review.googlesource.com/939733Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#539877}
-
Douglas Creager authored
The format of the Report-To header recently changed so that endpoint groups are the top-level element, instead of individual endpoints. Bug: 704259 Change-Id: I7534c46abbbb86c367931ffc060972ac36b1084b Reviewed-on: https://chromium-review.googlesource.com/914687 Commit-Queue: Douglas Creager <dcreager@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#539876}
-
Xiaohan Wang authored
This will be exposed in Javascript on the about://components page so that tests can easily query component related information. BUG=810436 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1c53a8919ce5ba47a81ae887052629ba2aaf8c05 Reviewed-on: https://chromium-review.googlesource.com/939869Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#539875}
-
Colin Blundell authored
This CL is a small followup to https://chromium-review.googlesource.com/c/chromium/src/+/930335. That CL missed changing IdentityManagerFactory to supply the IdentityManager instance for the recording BrowserState rather than the current one. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icef1ad5ae99e32768b9d1d25e1619df1efa81fe9 Reviewed-on: https://chromium-review.googlesource.com/939622Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#539874}
-
Philip Rogers authored
This test had an expected result for the first layout node having width = 785 which is 800 - scrollbar width of 15. This size now excludes the scrollbar width both with and without root layer scrolling. Bug: 417782 Change-Id: If1b941963d84e9df8e8afccd3cbadd87a2bb2605 Reviewed-on: https://chromium-review.googlesource.com/940666Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers (OOO) <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539873}
-
Guido Urdaneta authored
This was renamed from MediaStreamDispatcher in https://crrev.com/c/786593. Bug: 817214 Change-Id: If3aac97652afbcf08c2ece7beb81a22534d58501 Reviewed-on: https://chromium-review.googlesource.com/941204 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#539872}
-
Gordana Cmiljanovic authored
tcmalloc is using very old version of linux_syscall_support.h The following mipsel related changes are pulled from lss project: https://chromiumcodereview.appspot.com/10067027 https://codereview.chromium.org/13846002 https://codereview.chromium.org/913723002/ https://codereview.chromium.org/836473006 Bug: 810356, 794147 Change-Id: I79c3c77a5b81eb84902aa82b72656a776053de1e Reviewed-on: https://chromium-review.googlesource.com/909216 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#539871}
-
Elad Alon authored
Before this fix, the DCHECK on line 370 was hit. Bug: 817376 Change-Id: Ifd97fcb29e64f0ba3368521ae6e7bd37effc99c6 Reviewed-on: https://chromium-review.googlesource.com/941443Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#539870}
-
Ahmed Fakhry authored
As we are getting ready to launch this feature, this CL converts the Docked Magnifier switch to a base::Feature which is enabled by default. BUG=709824 Change-Id: I3f94149d16d864584a393db8f40a290d911acf7f Reviewed-on: https://chromium-review.googlesource.com/940441Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#539869}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab7770e4. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13020 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: Ie89e049cceaa07348ddda6c7eaaddcdc4341e782 Reviewed-on: https://chromium-review.googlesource.com/940591 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#539868}
-
Troy Hildebrandt authored
K/L/M tablet testers are failing because LocationBarTablet goes through a code path that asserts running on UI thread. This CL ensures we run the offending call in the test's #setUp method on the UI thread. Bug: 817029 Change-Id: I54f91961d61e316bd61c84b59738c0892024e58c Reviewed-on: https://chromium-review.googlesource.com/939999Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539867}
-
Thomas Tangl authored
The sync error view in user menu is changed to match the new mocks which can be found here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr69mkGC_U_qcI187SvCwUkwM Screenshot of the new view: https://drive.google.com/file/d/1BK10ADCLqBE4Q-lXbbYYNAd9AV2BNYiq/view?usp=sharing Bug: 813497 Change-Id: I0a4e0590cadc8f3dec05221992c86341578fb60e Reviewed-on: https://chromium-review.googlesource.com/934510 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#539866}
-
Xi Cheng authored
This reverts commit 8e57bc69. Reason for revert: Broke the build -- https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20(dbg)/129796 Original change's description: > Update Crashpad to fa2a03fbdd0f8ca13511f66dded97a09cd08536e > > 14dbd3531d98 gn win: Get main test binaries building > 6cf4f928eb08 gn win: Add auxiliary test binaries used by > end_to_end_test.py > 36679d572ba0 win: Don't assume offsets the same when > kDoesNotObserveDaylightSavingTime > 9ab4fbf1e1a7 win: Improve child crash location test > 798f6540435f gn win: Use new toolchain names to support both x86 and x64 > 83a83c5b0050 Roll mini_chromium to e7e8237 > a483e2c599b8 Fix names of Windows trybots after server-side rename > 38b20ca57efc Relocate CaptureContext to misc and implement on Linux > a8ad3bdbdfb1 linux: fix incorrect fallthrough > 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build > b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too > f878f155172b fuchsia: Add flock() stub to get test binaries linking > again > e5bbdaff87a9 Pass FilePath to Settings in Initialize() > c45ba7920e01 Make NewReport objects own their associated database > resources > 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM > c406797ce620 Add UploadReport to manage database resources during > upload > 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic > symtab > 8d0d999d9245 Add a cross-platform database implementation > b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader > implementations > 6667fa25595a fuchsia: Fixes to TestPaths > 90cde8e30f7d Disable upload on Android > 4094c2628d33 Address review comments for 8d0d999 > a4d7fb4cc390 Use .long for pointers on 32-bit platforms > 5e5b927b38ca Build crashpad_client_linux.cc on Android > eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch > 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests > f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests" > 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests > 0429216f59b1 linux: Add CrashReportExceptionHandler > f38af628c9dc fuchsia: Don't fail rename if source == dest > 040360239343 Fix > CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt > ions > 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non- > functional > 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to > Settings > 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE > 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad > source root > 4a9d422652a1 Turn fuchsia trybots on by default > ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed > from SDK > 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac > d2a866978b89 Makes 'all' build on Linux > d8d03172c278 arm: Capture context around pc and registers > ebad8bd925c3 Don't spawn an upload thread if url is empty > 0520fdff1edc linux: Move ScopedPrSetPtracer to util/ > 38540eaf71cb Add handler options for Linux/Android > 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH() > 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work > cab259330f2e fuchsia: Pass more data out of module snapshot > 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into > ModuleSnapshotElf > 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of > ProcessSnapshotFuchsia > 2290a826af1e Pull (most) platform-specific MemorySnapshots out > 3030ae54171a fuchsia: Fix ninja auto-regen after run > 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a > test > c69ba3d52783 non-win: Add > Multiprocess::SetExpectedChildTerminationBuiltinTrap() > f130822b9f4b linux: Add CrashpadClient tests > 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions > fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler() > > Also: > Add new metrics enums values. > Use new CrashReportDatabase interface. > > Bug: crashpad:30 > Change-Id: Ibb9e8eafdd3f310e933bd7dab812254efed1b2be > Reviewed-on: https://chromium-review.googlesource.com/935486 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539856} TBR=jperaza@chromium.org,mark@chromium.org,siggi@chromium.org Change-Id: Ice1d4a445c2625a3403f0ea6371065db45d7b706 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: crashpad:30 Reviewed-on: https://chromium-review.googlesource.com/941386Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#539865}
-
Nicolas Dossou-gbete authored
Bug: 787005 Change-Id: I3ca8398b856a610a17f2d2c9a03901b58dbb5f65 Reviewed-on: https://chromium-review.googlesource.com/941445Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#539864}
-
Philip Rogers authored
This patch removes the virtual/threaded baselines for: virtual/threaded/compositing/visibility/visibility-image-layers-dynamic.html Bug: 417782 Change-Id: Id3dabaec9d3ea8b979d1f17941758529aa4a4176 Reviewed-on: https://chromium-review.googlesource.com/938979Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers (OOO) <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539863}
-
Philip Rogers authored
This patch rebaselines two tests for minor rounding differences that were introduced with root layer scrolling: fast/overflow/scrollRevealButton.html fast/frames/iframe-scaling-with-scroll.html Bug: 417782 Change-Id: Ic76981c6bd28db6d5be71474d961760b13140b93 Reviewed-on: https://chromium-review.googlesource.com/940638Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers (OOO) <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539862}
-
Becky Zhou authored
+ Add expand/collapse description to the expandable header + Fix "learn more" link not showing on restart because remote suggestions are disabled Bug: 813136, 813872 Change-Id: I3d527582629ef8d3bd9cf8f28876ca476cd2b959 Reviewed-on: https://chromium-review.googlesource.com/935285Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#539861}
-
Eugene But authored
Bug: 817385 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia4d71b62e3d6fa5dc1e7f5ae8a918c5a1af2c2cd Reviewed-on: https://chromium-review.googlesource.com/941405 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#539860}
-
Matthew Jones authored
This change replaces all of the usages of ChromeAnimation in the SimpleAnimationLayout with CompositorAnimators. For simplicity all of the properties used by this layout have been converted into FloatPropery. BUG=750381 Change-Id: I9ecf38725e8081926a0b85cab4ebea8905ed35a6 Reviewed-on: https://chromium-review.googlesource.com/833177 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#539859}
-
Adam Langley authored
This reverts commit 7df8cfae. Originally it broke because r539572 landed between the trybot runs and commit and broke it. Original commit message: webauthn: support the appid extension. This extension allows credentials that were registered with U2F to be used with webauthn. See https://w3c.github.io/webauthn/#sctn-appid-extension. The change does not include support for echoing the extension in the CollectedClientData[1], nor does it implement getClientExtensionResults[2]. It's fully usable without that logic and I have several questions about that part of the spec[3] that I would like to understand first. I did consider avoiding having a alternative app_param value in //device/u2f but a) the spec says that the given appid should be tried after the first one and b) this allows sites not to have to worry about which protocol they registered credentials with. Instead, they can just set this extension during the transition. [1] https://w3c.github.io/webauthn/#sec-client-data [2] https://w3c.github.io/webauthn/#iface-pkcredential [3] https://github.com/w3c/webauthn/issues/803 Bug: none Change-Id: Ie68e349af9b00de4fc986bfb1516e9650c61ef0b Reviewed-on: https://chromium-review.googlesource.com/940524Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#539858}
-
Pritam authored
Converts all instances of access to net::CookieStore over to network::mojom::CookieManager. Addressed the uses of cookie store in the following android-specific files: - chrome/browser/android/cookies - chrome/browser/android/profiles Bug: 792672 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Icdbacc17b7bee4cf191994fda3639865cbf31b01 Reviewed-on: https://chromium-review.googlesource.com/903307 Commit-Queue: Pritam Nikam <pritam.nikam@samsung.com> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#539857}
-
Joshua Peraza authored
14dbd3531d98 gn win: Get main test binaries building 6cf4f928eb08 gn win: Add auxiliary test binaries used by end_to_end_test.py 36679d572ba0 win: Don't assume offsets the same when kDoesNotObserveDaylightSavingTime 9ab4fbf1e1a7 win: Improve child crash location test 798f6540435f gn win: Use new toolchain names to support both x86 and x64 83a83c5b0050 Roll mini_chromium to e7e8237 a483e2c599b8 Fix names of Windows trybots after server-side rename 38b20ca57efc Relocate CaptureContext to misc and implement on Linux a8ad3bdbdfb1 linux: fix incorrect fallthrough 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too f878f155172b fuchsia: Add flock() stub to get test binaries linking again e5bbdaff87a9 Pass FilePath to Settings in Initialize() c45ba7920e01 Make NewReport objects own their associated database resources 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM c406797ce620 Add UploadReport to manage database resources during upload 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic symtab 8d0d999d9245 Add a cross-platform database implementation b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader implementations 6667fa25595a fuchsia: Fixes to TestPaths 90cde8e30f7d Disable upload on Android 4094c2628d33 Address review comments for 8d0d999 a4d7fb4cc390 Use .long for pointers on 32-bit platforms 5e5b927b38ca Build crashpad_client_linux.cc on Android eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests" 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests 0429216f59b1 linux: Add CrashReportExceptionHandler f38af628c9dc fuchsia: Don't fail rename if source == dest 040360239343 Fix CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt ions 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non- functional 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to Settings 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad source root 4a9d422652a1 Turn fuchsia trybots on by default ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed from SDK 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac d2a866978b89 Makes 'all' build on Linux d8d03172c278 arm: Capture context around pc and registers ebad8bd925c3 Don't spawn an upload thread if url is empty 0520fdff1edc linux: Move ScopedPrSetPtracer to util/ 38540eaf71cb Add handler options for Linux/Android 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH() 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work cab259330f2e fuchsia: Pass more data out of module snapshot 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into ModuleSnapshotElf 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of ProcessSnapshotFuchsia 2290a826af1e Pull (most) platform-specific MemorySnapshots out 3030ae54171a fuchsia: Fix ninja auto-regen after run 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a test c69ba3d52783 non-win: Add Multiprocess::SetExpectedChildTerminationBuiltinTrap() f130822b9f4b linux: Add CrashpadClient tests 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler() Also: Add new metrics enums values. Use new CrashReportDatabase interface. Bug: crashpad:30 Change-Id: Ibb9e8eafdd3f310e933bd7dab812254efed1b2be Reviewed-on: https://chromium-review.googlesource.com/935486Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#539856}
-
ckitagawa authored
In order to better debug any crashes of zucchini.exe this change adds debug symbols to the Chrome symbols archive on unsigned staging. Bug: 729154 Change-Id: I6ece17e8bedcb53801dc9f3e981d92186a759314 Reviewed-on: https://chromium-review.googlesource.com/940083Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Cr-Commit-Position: refs/heads/master@{#539855}
-
ckitagawa authored
Adds support to setup.exe to both upgrade itself and chrome.7z through Zucchini patches when "use_zucchini = true" as a gn arg. Zucchini patches are NOT created at this time! This is primarily for experimentation with the release infra. A security review will be conducted before launch. This has been successfully tested using Zucchini-based versions of chrome_updater.exe for the following cases: Patchers | setup.exe | chrome.7z | ------------------------- | Courgette | Courgette | Default (can also be used for downgrades) | Courgette | Zucchini | Upgrade: once enabled | Zucchini | Zucchini | Target Default | Zucchini | Courgette | Downgrade: in the event of issues Child Changes: - setup.rc PATCHERTYPE: https://chromium-review.googlesource.com/937400 - BUILD.gn zucchini.exe: https://chromium-review.googlesource.com/937396 Bug: 729154 Change-Id: Iec2e514a8b8a5ee311fe210505ac2b31c0418f54 Reviewed-on: https://chromium-review.googlesource.com/916553 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#539854}
-
Sorin Jianu authored
As part of the ddos mitigations, implemented all three ddos headers in the component updater. The base::Optional implementation of the feature is removed. Instead, the headers are passed using a map of string to string. There is an unrelated error handling change to invoke the callback if for some reason, the caller is passing in no component id in the Update call. Bug: 813193 Change-Id: I26e86564c13c0a5991027a6612dcdefbf991bfab Reviewed-on: https://chromium-review.googlesource.com/938636Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539853}
-
Tim Brown authored
This is in effect a temporary fix to always use libappindicator (when available, but we have deb/rpm dependency on the lib, so it should always be available), whilst I fix the dependency issue we have on the build bots which would allow me to add a hard dependency and clean up the code. Bug: 799144, 797332 , 419673 Change-Id: Id64a452029b00ec8d86f0d35d319bebcfd8bf99e Reviewed-on: https://chromium-review.googlesource.com/939732Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#539852}
-