- 11 Mar, 2020 40 commits
-
-
Shimi Zhang authored
Found by Tricium in http://crrev/c/2097537 Bug: None Change-Id: I53fedefb2f763bfc57080588eb95c8d07a7ba973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097529 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Auto-Submit: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#749046}
-
Takumi Fujimoto authored
Record the following metrics for the native Cast MediaRouteProvider: MediaRouter.CastStreaming.Session.Launch MediaRouter.CastStreaming.Session.Length MediaRouter.CastStreaming.Start.Failure.Native MediaRouter.CastStreaming.Start.Success These metrics are already being recorded by the Cast MRP in the component extension (MediaRouter.CastStreaming.Start.Failure is recorded instead of MediaRouter.CastStreaming.Start.Failure.Native in the extension because their enums are different). Bug: 954565 Change-Id: I476fdf417ccf085d3d122dc10d8ff976c8f8450f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080703Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#749045}
-
Rob Schonberger authored
- Palm Detection when the touchscreen reports the max radius - Palm Detection when the touchscreeen reports a palm itself Both are experimental features and documented as such, and or on by default already, etc. Bug: 1060051 Change-Id: I130c466a03b9a295c1b2777589ffc8a3ea8a5be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094908 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Cr-Commit-Position: refs/heads/master@{#749044}
-
Jinsuk Kim authored
Permission UI requires a ModalDialogaManager from the associated WindowAndroid instance, which was not available on Preview Tab. This CL overrides |ActivityWindowAndroid.getModalDialogManager| passed to the ThinWebView object of Preview Tab so that the permission UI can be displayed. Verified on a local device that this fixes the reported crash, and shows the permission UI as expected. Bug: 1057951 Change-Id: Ic7745d40edbea466ab1fef2de176743c3fda675d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094386Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#749043}
-
Jeevan Shikaram authored
UseLocalPrediction/LoadingPredictorBrowserTestWithOptimizationGuide. NavigationHasLocalPredictionNoOptimizationHint/0 is failing deterministically on linux-chromeos-rel. TBR=tbansal@chromium.org Bug: 1060426 Change-Id: I2c9b0b9781d1d51de8911f34aa7d1bb689416996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097618Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#749042}
-
Xiaocheng Hu authored
The function is only used by FontFallbackList::GetShapeCache(). This CL changes it into a private function for better code health. Change-Id: Ic1bcdf1393395bd527d971462b65383196d8a28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097151 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749041}
-
Jeevan Shikaram authored
This reverts commit c7695f63. Reason for revert: Possible reason for win10_chromium_x64_rel_ng failing builds with error: lld-link: error: undefined symbol: __llvm_profile_dump >>> referenced by .\..\..\base\test\clang_profiling.cc:23 >>> obj/base\base/clang_profiling.obj:(void __cdecl base::WriteClangProfilingProfile(void)) Original change's description: > Make the coverage config reusable for generic profiling. > > Most of the coverage configuration can be re-used for general > Clang-based profiling (e.g. the profiling step of a PGO build). > This changes most of the |use_clang_coverage| checks to > |use_clang_profiling|. > > The toolchain opt-out option is still limited to the coverage > builds (grep for "toolchain_use_clang_coverage" in CodeSearch). > I.e. targets built simply with |use_clang_profiling=true| won't > be opted out by the clang_code_coverage_wrapper.py script. > > This CL is a pure refactoring with no functional change. > Getting profiling information from the sandboxed renderers work > this way: > - After creating a new child process the browser will open a > profiling file for this process and pass the handle to the > child via the SetProfilingProfile Mojo call (see change in > content/browser/renderer_host/render_process_host_impl.cc). > - This process will used by the LLVM instrumentation to record > profiling information. > - When terminating, child processes will call > WriteClangProfilingProfile to write the data to the profiling > data file. > - Once all the raw profile data files have been collected, > they'll be merged (via the "llvm-profdata" tool) and used. > > Note that this isn't meant to be enabled into any build that > will be shipped to users (a profiling build is usually 10x > bigger than a normal build anyway, not really shippable). > > The goal of this refactoring is to make it possible to reuse > this mechanism for the instrumentation step of PGO builds. > > Bug: 1058979 > Change-Id: If8321234f6b6f86befd81f6e9e068a342728d605 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090493 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Sajjad Mirza <sajjadm@chromium.org> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749015} TBR=sky@chromium.org,thakis@chromium.org,wfh@chromium.org,sebmarchand@chromium.org,liaoyuke@chromium.org,sajjadm@chromium.org Change-Id: I6aaf638f6385afe35c488575aac84e3e952b76a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096332Reviewed-by:
-
John Budorick authored
waitForTabToFinishRestore currently checks whether there's *exactly one* existing navigation entry that matches the expected url. If it doesn't, they wait for *any* subsequent navigation that matches the expected url. Tab restoration appears to trigger navigations to about:blank and then the expected url; if we check after both navigations have been received, we'll wind up waiting on the latch until it times out. This CL updates waitForTabToFinishRestore to check for any previous or future navigation entry that matches the expected url, which should avoid that race. Bug: 1060317 Change-Id: I6fa584ff4537af74ee1ceafdfca57fdc6485fa84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097246Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#749039}
-
Anand K. Mistry authored
This only changes the base::Value API usage to the new style, and avoids changing functions signatures, except for private helper functions. Bug: 646113 Change-Id: I5dcd6d5c7df7dd185f7fc84d4563da82394fca9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089438 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#749038}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3e192165cb65..c2fe5ee2b3a1 git log 3e192165cb65..c2fe5ee2b3a1 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 reed@google.com refactor where we wrap clipshaders, in prep for gpu backend 2020-03-11 mtklein@google.com simplify skvm clip shaders 2020-03-11 mtklein@google.com skvm clip shader support 2020-03-11 mtklein@google.com skvm local matrix shader Created with: gclient setdep -r src/third_party/skia@c2fe5ee2b3a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: Ice3644fcbdaa1371b2eb0478b21732b5f391fef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097524Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749037}
-
Lukasz Anforowicz authored
This CL avoids sending |page_url| and |frame_url| as a payload of FrameHostMsg_ContextMenu. The CL accomplishes this by splitting the old ContextMenuParams struct into: 1. UntrustworthyContextMenuParams: - Sent over IPC. - Doesn't include |frame_url| nor |page_url|. 2. ContextMenuParams: - Never sent over IPC (no IPC traits are defined). - Includes |frame_url| and |page_url| which are populated based on browser-side data (rather than IPC-based data). - Cannot be copy-constructed directly from UntrustworthyContextMenuParams, except by RenderFrameHostImpl. Fixed: 534561, 1059083 Change-Id: I80239532aa693a0cb80aab29dcf4824bbb971e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091921Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#749036}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I83dd721bdc015497f807c406e3dbc10263a30617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097499Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749035}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/52d0627d5607..421684f9438d git log 52d0627d5607..421684f9438d --date=short --first-parent --format='%ad %ae %s' 2020-03-11 jiawei.shao@intel.com Support Storage Textures as Valid Binding Types Created with: gclient setdep -r src/third_party/dawn@421684f9438d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iea6b9e75a37cf4a486e3270461bead2d8a38ed9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097523Reviewed-by:
-
Joel Hockey authored
TerminalSource moved in crrev.com/c/2077318 without updating OWNERS. //chrome/browser/ui/webui/chromeos/terminal was empty except for OWNERS file which is deleted in this CL. Change-Id: I37a77eb1bc96a92a546c1cefc0d40e93e702dfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096173 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#749033}
-
Joel Hockey authored
Step 2 of 2 to disallow terminal from spawning crosh. * crrev.com/c/2094066 * crrev.com/c/2089558 Adds a new terminalPrivate.openVmshellProcess function which is to be used by terminal. This function can open vmshell, but not crosh. Terminal CL must be landed first which supports calling either openVmshellProcess or openTerminalProcess. Bug: 1056049 Change-Id: I0e4b54741aafcb3d6683f8ec668e94eaeec78ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089558Reviewed-by:
Jason Lin <lxj@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fe6381e8e366..dbb6fcdf4353 git log fe6381e8e366..dbb6fcdf4353 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 tsepez@chromium.org Fix indexing in CFXJSE_FormCalcContext::concat_fm_object(). 2020-03-11 tsepez@chromium.org Use WideStringViews in CPDF_InteractiveForm. 2020-03-10 tsepez@chromium.org Fix faulty indexing CFXJSE_FormCalcContext::unfoldArgs(). Created with: gclient setdep -r src/third_party/pdfium@dbb6fcdf4353 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1004106 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I08d130b1dcf9f28185533945ebbe082a6ea91deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097518Reviewed-by:
-
sauski authored
This is a reland of 01d497a6 Original change's description: > Safebrowsing radio toggle addition to the security page > > Adding a new collapsible radio toggle to the security page that includes a third safebrowsing option (enhanced), with more thorough explanations for this third option and the already available standard and disabled options. > > Bug: 1032584 > Change-Id: I6e4732ae464120d3d264b141dbb172aa125f9824 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088851 > Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> > Auto-Submit: Sean Harrison <harrisonsean@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748394} Bug: 1032584 Change-Id: I4a61ba4b0b17615c4e88553c102cf435af352979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096091 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#749030}
-
Alex Danilo authored
Clicking on the application to move focus away from the search box should collapse it. Change the collapse listener to trigger on event capture phase so that any calls to preventDefault in other UI components won't block the event and collapse will happen. Note, that clicking on UI elements such as the splitter bar and moving it does not take focus, so the search box will not collapse. Bug: 1058547 Change-Id: I145c5c1f0dda09b21175cf715c5f6d9960f05649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097615Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#749029}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/1bdc5980b3a4..cbf7f5178da6 git log 1bdc5980b3a4..cbf7f5178da6 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 rwkeane@google.com Platform: Add Operator < to IPAddress Created with: gclient setdep -r src/third_party/openscreen/src@cbf7f5178da6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0238407c5b3f468baa0a3b7ee6bfe9b2a015a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097522Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8bf3aecd3335..a8e510a1a6cb git log 8bf3aecd3335..a8e510a1a6cb --date=short --first-parent --format='%ad %ae %s' 2020-03-11 abennetts@google.com Fix minor errors in example command lines in bq_export README. 2020-03-10 phoglund@google.com Remove the proto test driver. 2020-03-10 phoglund@google.com Add a small proto->JSON tool. Created with: gclient setdep -r src/third_party/catapult@a8e510a1a6cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: eseckler@google.com Change-Id: I0b07061056783c46f40ac2c9625908bae6663e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095108Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9e263aa8a4e6..c5b3cbdb4502 git log 9e263aa8a4e6..c5b3cbdb4502 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 cclao@google.com Vulkan: Use VK_FORMAT_D24_UNORM_S8_UINT for 24 bit depth if available 2020-03-10 tikuta@chromium.org use go swarming client in trigger.py Created with: gclient setdep -r src/third_party/angle@c5b3cbdb4502 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I44aa9c7371615fde48d25eb5f35fdb90f5e460e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097471Reviewed-by:
-
David authored
chrome://media-app uses a postMessage API to communicate between its trusted and untrusted contexts to gain access to privileged functionality such as opening the feedback dialog. Use an object (Message) to indicate the action being communicated across the postMessage API instead of strings which are more error prone. Bug: 996088, b/138961540 Change-Id: I17185bdde143f8fb061ec2000075dd4a463cd7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096057 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#749025}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76a104eafd23..08d2ab0bcd7e Created with: gclient setdep -r src-internal@08d2ab0bcd7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586 Tbr: jbudorick@google.com Change-Id: I61adf7c211c082c7b9f46afd07047a482ce66bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097469Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749024}
-
Maggie Cai authored
The intent handling feature is not ready, extend the intent handling flag expiry milestone to 85. Bug: 853604 Change-Id: I4160c649598fba7ab5930c00d43ed8072b9c152f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096797Reviewed-by:
-
Nektarios Paisios authored
In BrowserAccessibilityManager, we were relying on the presence of other accessibility events, such as kChildrenChanged, in order to tricker the firing of a focus event. However, when page navigation is cancelled, or is simply completed after the page contents have been loaded in the accessibility tree, there are no other events that would tricker the focus event. This creates a situation where the screen reader does not move its virtual cursor to the web contents. As a result, focus appears to be nowhere, and the user develops the mistaken belief that the virtual buffer in screen readers such as NVDA is also blank. R=dmazzoni@chromium.org, kbabbitt@microsoft.com Bug: 1058959 Change-Id: I29150977d032152d5337889b1ae0c2e196fda065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095758Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#749022}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1052232 Change-Id: I733476b0febb6bb0db715b6710d69c4dd857b469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094874 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#749021}
-
Sam McNally authored
CrasAudioHandler converts media metadata from UTF-16 to ASCII. This is invalid if the metadata is non-ASCII, which it can be. This DCHECK fails when converting and later CHECK fails trying to send over D-Bus. Convert to UTF-8 instead. Bug: 1059929 Change-Id: I367e6ab718a1e875a69fd551e8c2e5c68a00f139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096328Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#749020}
-
Jonathan Kingston authored
Bug: 1011830 Change-Id: If411450952c0e4018933eba636d168d98ece90cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070201 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#749019}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8332950f4a88..430e4a09e0ca git log 8332950f4a88..430e4a09e0ca --date=short --first-parent --format='%ad %ae %s' 2020-03-10 minyue@chromium.org Allow to negotiate absolute capture time rtp header extension. Created with: gclient setdep -r src/third_party/webrtc@430e4a09e0ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I20f1a13f7bd93e730fbecdb51e355934a9e813de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097474Reviewed-by:
-
sczs authored
- If the Coordinator that owns the InfobarBannerVC is destroyed before the InfobarBannerVC finish disappearing then infobarBannerWasDismissed won't be called. This means that the InfobarContainerCoordinator in charge of queuing the InfobarCoordinators/Banners won't know its time to present a new Banner. In order to achieve this an InfobarBannerContainer delegate is set directly on the Banner. - If the Coordinator that owns the InfobarBannerVC still exists once the InfobarBannerVC has dissapeared then we should let it handle the next banner presentation (e.g. Translate might present another Banner) - When InfobarCoordinator is presenting a Banner, we currently do not hold a strong reference to it in the completion block, so if the InfobarCoordinator (along with the transition/presentation objects) gets destroyed then the presentation looks like Bug 1057125. We also do not do some cleanup tasks like configureAccessibilityForBannerInViewController, which are needed. Since stop is called whenever the Coordinator is destroyed then badgeDelegate should be nil and we shouldn't be trying to update the badge then. Bug: 1057125 Change-Id: I12f3437a2bf23d2e54ff05a146d2bd4bd0459e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090711 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#749017}
-
Peter Kasting authored
Also moves this to ui/base/pointer/, and while I'm touching all the lines anyway, renames GetInstance() to Get(). Bug: 940769 Tbr: gab Change-Id: I399c3502e8d67f8e70c513ce1d3a9d9648fa6e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092426 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#749016}
-
Sebastien Marchand authored
Most of the coverage configuration can be re-used for general Clang-based profiling (e.g. the profiling step of a PGO build). This changes most of the |use_clang_coverage| checks to |use_clang_profiling|. The toolchain opt-out option is still limited to the coverage builds (grep for "toolchain_use_clang_coverage" in CodeSearch). I.e. targets built simply with |use_clang_profiling=true| won't be opted out by the clang_code_coverage_wrapper.py script. This CL is a pure refactoring with no functional change. Getting profiling information from the sandboxed renderers work this way: - After creating a new child process the browser will open a profiling file for this process and pass the handle to the child via the SetProfilingProfile Mojo call (see change in content/browser/renderer_host/render_process_host_impl.cc). - This process will used by the LLVM instrumentation to record profiling information. - When terminating, child processes will call WriteClangProfilingProfile to write the data to the profiling data file. - Once all the raw profile data files have been collected, they'll be merged (via the "llvm-profdata" tool) and used. Note that this isn't meant to be enabled into any build that will be shipped to users (a profiling build is usually 10x bigger than a normal build anyway, not really shippable). The goal of this refactoring is to make it possible to reuse this mechanism for the instrumentation step of PGO builds. Bug: 1058979 Change-Id: If8321234f6b6f86befd81f6e9e068a342728d605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090493Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sajjad Mirza <sajjadm@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#749015}
-
Joseph Kim authored
Typo in comment and unused variable. Change-Id: I72ef1da2ec445d088faf61c181783c4b8f3b5f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091094Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Joseph Kim <josephkimsh@google.com> Cr-Commit-Position: refs/heads/master@{#749014}
-
Kevin Ellis authored
https://github.com/w3c/csswg-drafts/issues/4822 Bug: 1059772 Change-Id: Id21c3c152f8cf6771703a16fcab8e80686608170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090197 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#749013}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ab98a3792093..715c8c459f00 git log ab98a3792093..715c8c459f00 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 brcui@microsoft.com Infobar Improvements Created with: gclient setdep -r src/third_party/devtools-frontend/src@715c8c459f00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1056348 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I593aa05cee03aaabb044bb3118c73587d822eb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097473Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bf355123ae3b..3e192165cb65 git log bf355123ae3b..3e192165cb65 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 jvanverth@google.com Hoist GrVkResource up so it can be used for D3D and Metal. Created with: gclient setdep -r src/third_party/skia@3e192165cb65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I2196c14f5c9ff4230123de180cdc5f1427d297e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097472Reviewed-by:
-
Sajjad Mirza authored
crrev.com/c/2071164 created an unusued operator<< for this type which conflicts with the autogenerated one in the out/ directory. In most builds this is OK because the bad definition is `inline`, but never used, so the compiler never emits into an object file. However in a coverage build the symbol has to be emitted so that coverage can be tracked, and then it collides with the other operator<< definition. Note that it's illegal to have both inline and non-inline definitions of the same function in C++, so this was always invalid code, even though it took a behavior of the coverage system to expose it. Bug: 1060343 Change-Id: Ifb5f5143fa5d651e17305ba1b364b22af644b93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097128Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#749010}
-
Chris Lu authored
Adds metrics to track user taps on the overflow badge, the number of times the overflow badge is shown, and when a user taps on a row in the overflow menu. Fixed: 1055549 Change-Id: I43fa4fcb2bced7bdcda5209688fba5ffe5066e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076662 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Ryan Sleevi authored
This reverts commit d828e2eb. Reason for revert: Despite the original description, this didn't update schema_org_properties with the correct //base dep, causing build flakiness again. Original change's description: > Reland: "Add validator for schema org entities and types in doc metadata mojo." > > " > * Add a validator that removes properties that are not the right type. > * Add double, time, and timedelta types in the document metadata mojo > structure. > * Use the new mojo types in document metadata extractor. > " > > This is a reland of https://crrev.com/c/2062907 which was reverted in > https://crrev.com/c/2095670. > > The substantial changes are two-fold: > (1) add build dep on base in schema_org_properties. This should fix the > try bot issue which was somehow skipped. > (2) Rebase on top of https://crrev.com/c/2073337 which was submitted and > contains some changes to the mojo structure. > > Change-Id: I7f47d74e8833f76d4077028eac0dcb43790a1d26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097059 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Sam Bowen <sgbowen@google.com> > Cr-Commit-Position: refs/heads/master@{#748945} TBR=dcheng@chromium.org,beccahughes@chromium.org,sgbowen@google.com Change-Id: I3e6b80e0469267cc658ba2f2ac63bbcdc0d913e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097190Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#749008}
-
Kei Nakashima authored
In the current code, |insert| doesn't work correctly since it does not update prev/next indices when free list is not empty. This CL fixes it. Change-Id: I6355bfd61e4a7b8f928a462e45fb98702f005f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094491Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
