GitLab

This removes the dependency in chrome/browser/ui/views/web_dialog_view.h from
chromeos.

BUG=125846
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10695122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125875
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10758015

TBR=varunjain@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10694121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146018 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146017 0039d316-1c4b-4281-b951-d872f2087c98

We were expecting to receive GTK+ events in the following order:
  drag-motion
  drag-data-received
  drag-leave
but in some cases, we don't get the drag-data-received event (e.g.,
if the user is moving the mouse quickly). If that happens, don't send
a DragLeave event to the renderer since it doesn't think we're in a
drag.

BUG=129446
TEST=Open 2 chrome windows, quickly drag a file from the desktop over both
  windows. This should not crash.


Review URL: https://chromiumcodereview.appspot.com/10704144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146016 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10695135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146015 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10681003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146014 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10689149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146013 0039d316-1c4b-4281-b951-d872f2087c98

The crashes that it was hoped this patch would prevent didn't stop, and the actual bug was fixed in r145842.

BUG=136232
TBR=kalman@chomium.org

Review URL: https://chromiumcodereview.appspot.com/10701134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146012 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125875
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10758015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146011 0039d316-1c4b-4281-b951-d872f2087c98

TEST=passes new webgl conformance test
BUG=136538


Review URL: https://chromiumcodereview.appspot.com/10735038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=unit tests.

Review URL: https://chromiumcodereview.appspot.com/10704143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146009 0039d316-1c4b-4281-b951-d872f2087c98

As long as touch-events are processed correctly for modal windows, the
gesture-events should automatically do the right thing. So gesture-events should
not need similar treatment.

BUG=136360
TEST=ash_unittests

Review URL: https://chromiumcodereview.appspot.com/10763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146008 0039d316-1c4b-4281-b951-d872f2087c98

These defined constants are not used in this file.
They are defined and used in c/b/chromeos/gdata/gdata_operations.cc.

BUG=none
TEST=compile


Review URL: https://chromiumcodereview.appspot.com/10752021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146007 0039d316-1c4b-4281-b951-d872f2087c98

Connect is called on the thread where Channel::Send will be invoked (and where messages should be dispatched). But Channel might be _created_ on some other thread. Therefore, we need to post data that we read to the thread on which Connect is called. NOT the thread where the Channel was created.

This fixes an issue where sync messages were never getting their replies, because the DidRecvMsg task was being run on the thread where ChannelProxy::Send was called, not the Channel thread (which is the IO thread in this case).

BUG=116317
TEST=


Review URL: https://chromiumcodereview.appspot.com/10698138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146006 0039d316-1c4b-4281-b951-d872f2087c98

Some embedders do not want the additional view added by using ContentView,
so we are splitting out ContentViewCore so the functionality can be used
without forcing an additional FrameLayout.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10704049

TBR=tedchoc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10693134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146005 0039d316-1c4b-4281-b951-d872f2087c98

- Add a delegate interface for controlling keyboard brightness.
- Call the interface on Alt+F6 and Alt+F7.

BUG=135482
TEST=added some tests to aura_shell_unittests


Review URL: https://chromiumcodereview.appspot.com/10694118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146004 0039d316-1c4b-4281-b951-d872f2087c98

Fix a bug which caused the cutoff the status area right edge in vertical alignment.
Adjust ash tray status area and bubble position in vertical alignment.
Adjust layout and text color of vertical clock UI.

BUG=127577
TEST=Ash tray status and bubble should look right for left/right launcher.


Review URL: https://chromiumcodereview.appspot.com/10668009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146003 0039d316-1c4b-4281-b951-d872f2087c98

- F3 and Shift+F3 cycle windows forward and backward, respectively.
- F4 opens the app list.

BUG=123739
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10735035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123295
TEST=existing unittests


Review URL: https://chromiumcodereview.appspot.com/10694111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146001 0039d316-1c4b-4281-b951-d872f2087c98

Some embedders do not want the additional view added by using ContentView,
so we are splitting out ContentViewCore so the functionality can be used
without forcing an additional FrameLayout.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10704049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146000 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a segfault due to presumably invalid GL bindings.
Also add CHECKs verifying we were able to acquire display,
which otherwise would end up being cryptic segfaults as well.

BUG=136292
TEST=Manual runs on ARM and CrOS x86.

Review URL: https://chromiumcodereview.appspot.com/10736006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145999 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129471
TEST=


Review URL: https://chromiumcodereview.appspot.com/10759012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145998 0039d316-1c4b-4281-b951-d872f2087c98

Also enable it by default when building with the Android build system.

Review URL: https://chromiumcodereview.appspot.com/10702129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145997 0039d316-1c4b-4281-b951-d872f2087c98

SyncChanges now require the location they were created as a parameter. This
is then used in the case that the change violates and invariant. We display
the location and type of erroneous change in about:sync, in addition to
disabling the offending datatype.

TBR=kalman@chromium.org, mnissler@chromium.org, isherman@chromium.org
BUG=135108
TEST=unit_tests


Review URL: https://chromiumcodereview.appspot.com/10766016

TBR=zea@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10698141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145996 0039d316-1c4b-4281-b951-d872f2087c98

Revert 145969 - Removing last usage of default request context. Fixing up login_utils to not need it by adding a notification so that login_utils only accesses it when the request context getter has been initialized.

BUG=125292, 127693
TEST=unittest, manual

Review URL: https://chromiumcodereview.appspot.com/10657009

TBR=rlp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10735042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145995 0039d316-1c4b-4281-b951-d872f2087c98

required me to switch it from wrapping a ScriptExecutor to observing one.

Also write a simple test to demonstrate how to test ScriptBadgeController. This was the original point of the change. The associated refactoring turned out to be more useful, but was ultimately unnecessary for the test.

BUG=133139,136301


Review URL: https://chromiumcodereview.appspot.com/10754004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145994 0039d316-1c4b-4281-b951-d872f2087c98

SyncChanges now require the location they were created as a parameter. This
is then used in the case that the change violates and invariant. We display
the location and type of erroneous change in about:sync, in addition to
disabling the offending datatype.

TBR=kalman@chromium.org, mnissler@chromium.org, isherman@chromium.org
BUG=135108
TEST=unit_tests


Review URL: https://chromiumcodereview.appspot.com/10766016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134959
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10693130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145992 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133141

Review URL: https://chromiumcodereview.appspot.com/10699033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145991 0039d316-1c4b-4281-b951-d872f2087c98

Since the seccomp filter GPU sandbox blocks access to the file system,
we need to set an env var with the config line found in /etc/drirc on
Chrome OS. This allows games that use S3TC to work inside the sandbox.

BUG=127664
TEST=Bastion works on Chrome OS with '--enable-gpu-sandbox'.


Review URL: https://chromiumcodereview.appspot.com/10690116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145990 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dmazzoni
Review URL: https://chromiumcodereview.appspot.com/10736016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145989 0039d316-1c4b-4281-b951-d872f2087c98

After a good lunchtime discussion, I went off to implement some sort
of overriding functionality in ExtensionFunctionDispatcher, so that I
could tell it to instantiate Function' instead of Function when an
extension/app asked for function. I then discovered
ExtensionFunctionDispatcher::OverrideFunction(), which was pretty
much exactly what I wanted.

Using this facility, added a fake SerialOpenFunction that overrides
a new CreateSerialConnection method to instantiate a
FakeEchoSerialConnection. As its name implies, this class pretends
to echo bytes over a serial port.

The practical outcome of this CL is we test more of our code without
having a physical serial device attached to the machine.

BUG=135656
TEST=this lays the ground work for testing of crrev.com/10759004

Review URL: https://chromiumcodereview.appspot.com/10702138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145988 0039d316-1c4b-4281-b951-d872f2087c98

Specifying it seems to push Windows to clear its cache before the changes to the shortcut have actually gone in.

This results in losing Metro properties when the shortcut is modified on Windows 8.

BUG=136567
TEST=Over-install my custom 22.0.1200.0 build over 21.0.1180.15 beta-m (when its default) and make sure the shortcut keeps its Metro properties (I've confirmed many times that it doesn't on the same custom build without my fix).


Review URL: https://chromiumcodereview.appspot.com/10692138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132353
TEST=First run bubble should appear if skip_first_run_ui is set to false.

Review URL: https://chromiumcodereview.appspot.com/10756023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10701121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145985 0039d316-1c4b-4281-b951-d872f2087c98

Instead of allowing the Sync code to delete the DSP, we instead undelete the DSP. Here we prefer inconsistency to a far worse experience where the DSP is swapped due to a bug.

Tests are updated to reflect this change in functionality.

BUG=132446
TEST=


Review URL: https://chromiumcodereview.appspot.com/10694096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83199
TEST=still compiling.


Review URL: https://chromiumcodereview.appspot.com/10748008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145983 0039d316-1c4b-4281-b951-d872f2087c98

The Java file generation rule in java_aidl.gypi assumes the wrong output path
for the generated file. This leads to spurious rebuilds.

The problem is that by default, the aidl tool outputs the Java file to
<output-path>/<package-path>/<input-file-root>.java, not to
<output-path>/<input-file-root>.java as assumed by the rule. This change fixes
the problem by explicitly specifying the output path to aidl.

Also remove superfluous path components on input files.

Review URL: https://chromiumcodereview.appspot.com/10690092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136433
TEST=See instructions on the bug report.

Review URL: https://chromiumcodereview.appspot.com/10702126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145981 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136396
TEST=New VariationsServiceTest.StoreSeed and VariationsServiceTest.LoadSeed tests


Review URL: https://chromiumcodereview.appspot.com/10764005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145980 0039d316-1c4b-4281-b951-d872f2087c98