- 02 Oct, 2019 40 commits
-
-
John Chen authored
Enable ChromeDriver tests on Win10 bot, as win7-rel bot is no longer included by default in Chromium CQ. Change-Id: Ie8d42abe069ccbcd4313d5067a2c474913c36204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835068Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702214}
-
Travis Skare authored
QR Code generation itself is being added as a mojo service in a follow-on change. Launch with a feature flag: chrome --enable-features=SharingQRCodeGenerator Bug: 993908 Change-Id: Iba2772227ec2d494524e90e45bd0e4726047f66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769685 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#702213}
-
Brian Norris authored
They should also use the cros-network-metrics group. Bug: chromium:975070, chromium:975825 Test: validate_format.py, pretty_print.py, presubmits Change-Id: Id2afb8fed98206268d93a7f2d1f10a379badcf21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834654Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Brian Norris <briannorris@chromium.org> Cr-Commit-Position: refs/heads/master@{#702212}
-
Chris Lu authored
Made a mistake in the final patchset of crrev.com/c/1832157. Modified a unittest to cover this mistake. Bug: 976901 Change-Id: I21b06444ca31ba174d217051266c8edaba97aca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835097 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#702211}
-
Alison Maher authored
Forced colors is currently being sent to the render process over two pipelines. This change cleans up the repeated code to use the new pipeline introduced in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1728056 Similar to how system colors are accessed in https://chromium-review.googlesource.com/c/chromium/src/+/1793742, ForcedColors have been removed from WebPreferences/WebSettings and can now accessed through WebThemeEngine. A similar change for PreferredColorScheme will follow. Bug: 970285 Change-Id: Id552d8f77c1fe01027b76f0bae5adeae972aaf5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802392 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702210}
-
chrome://sandboxAlex Gough authored
This collects all chrome://sandbox webui plumbing files into a single subdirectory. No functional changes. Bug: 997273 Change-Id: Idf78f2423d96986e487fa2a383e5af3dce7b74c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835679 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#702209}
-
Matt Mueller authored
Bug: 1008994 Change-Id: I10a52af910605852786ffcf888276764d6660c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835158Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#702208}
-
John Lee authored
When the webview for the tab strip first loads, it thinks it's visible even when the container View for it is hidden. Forcing its WebContents to be hidden allows `document.hidden`, `document.visibilityState` and `visibilitychange` events on the document to all be correct even at load. Bug: 1005554 Change-Id: I5926b03bf86218574b6e644e2710efe8f475efbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834425 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702207}
-
Sergey Ulanov authored
This will make it easier to test CDM support as it'll be possible to play protected video in Shaka player in WebRunner. Change-Id: Ib1ef1b41b21cfbb837e0babdefaa0281458abcf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836379 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#702206}
-
Arthur Hemery authored
Mistake about junit tests. Since we do not work with any native code and do pure java, we do not need to run these. Bug: 976218 Change-Id: I7bc24b2ddadf8ff3ffc9d740d556e9725054c5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835620Reviewed-by:
-
Eric Karl authored
PooledSharedImageVideoProvider::GpuHelperImpl currently registers a stub destruction observer in its constructor. It does not remove this observer in its destructor, which can lead to a crash when CommandBufferStub attempts to notify it of destruction. I was going to unregister in destruction, but then noticed that this observer isn't needed: - CommandBufferHelper already registers its own observer internally - GpuHelperImpl just used this notification to clear |command_buffer_helper_|, which is already taken care of internally in that class. So instead this CL just removes the observer from GpuHelperImpl. Bug: 1010612 Change-Id: I47d1982d6ccaf8624650a4274e8cb1500aba4f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835168Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#702204}
-
Ahmed Mehfooz authored
With this change each notification that is in the message center but not visible will have an icon representing it in the stacking bar. The icons are removed as we scroll up through the message center. If there is not enough space to show all icons there will be a "+ x" appended after the icons to signify remaining notifications. Bug: 1002714 Change-Id: I2e7737a4cf0dd145e0868e7fbf11a15be897d51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803731 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702203}
-
Tommy Li authored
We're proceeding with a button-based remove interface instead of the context menu. We may add this back later for some other reason, but we don't need it currently, so this CL rips it out. Bug: 1205, 929477 Change-Id: I87a6b9b283e6d16656fe263c5271f51192d74adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834895Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#702202}
-
Xianzhu Wang authored
- Remove unused cc/layers/scrollbar_theme_painter.h - Add comments in cc::Scrollbar - Remove rect parameter from cc::Scrollbar::PaintPart() because the rect can be easily calculated by blink, given that the coordinate space of the canvas is clearly defined - Improve performance of blink::ScrollbarLayerDelegate::HasTickMarks (implementation of cc::Scrollbar::HasTickMarks()). The old implementation queried all tick marks and see if it was empty, which may be slow when there are a lot of tick marks (e.g. when searching in a huge document). - Add blink::ScrollbarTheme::PaintTrackAndButtonsForCompositor() to avoid exposing too much details of ScrollbarTheme to outside. This is a preparation for CompositeAfterPaint composited scrollbar implementation. Change-Id: Ibf8c7a90d80ddf972f215495d0fd89470fa2deb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834286Reviewed-by:
-
Jamie Madill authored
This will unblock supporting a build variant in ANGLE where we don't have Chromium supporting folders. This will enable us to port to the Skia standalone build. Bug: angleproject:3943 Change-Id: Ieb88f18b34d330458071c047f03a1c1d420b3d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834909Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#702200}
-
Toby Huang authored
For supervised users, if an extension is disabled due to requiring additional permissions, remove the code that sends a remote approval request to the custodian. The supervised user should be able to re-enable the extension themselves once local as opposed to remote parental approval is enabled. Bug: 1004851 Change-Id: I4fbb463332c50a354afde6d801f8e8f6a4445817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825173Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702199}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b4c2a88f36e..6154fb127e5c git log 6b4c2a88f36e..6154fb127e5c --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@6154fb127e5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Id6e6eb6c352f2b6f9eedfe569fc05d6eda7897c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836352Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702198}
-
Theresa Wellington authored
- ClipDrawableProgressBar - ContextMenuDialog - MaterialProgressBar - PaddedFrameLayout - PromoDialog - PromoDialogLayout - PromoDialogTest - RadioButtonLayout - RadioButtonLayoutTest - RadioButtonWithDescription - DragReorderableListAdapter - DragStateDelegate - ViewResourceFrameLayout BUG=951455 Change-Id: Ic5232c262edae50150ff0f3160a65ed8bd00e1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829676Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#702197}
-
liberato@chromium.org authored
Previously, VideoFrameFactoryImpl might be given a nullopt YCbCrInfo in response to a request for it. It would then clear the callback and crash the next time it tried to return a frame; it didn't check that the callback wasn't clear. Now, it only clears the callback when it actually gets YCbCrInfo, which is also when it quits asking for info on subsequent frames. Also adds a test for it. Bug: 1007196 Change-Id: Idfffe95b319e09285fdd4b6c8855d3e781fc606d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829771Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#702196}
-
Sophie Chang authored
Bug: 988670,988700,988694,988666,988661 Change-Id: Ib4947ced022fbdafdf280314e5e0d8d1a53128d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836145Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702195}
-
Tommy Li authored
No one is monitoring these metrics. Bug: 974982 Change-Id: I81676fd22bd354391f2acd38385152d90b4e8669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830362 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#702194}
-
Daniele Castagna authored
Originally this was reverted since crrev.com/c/1685909 needed to be reverted. crrev.com/c/1685909 now relanded. After crrev.com/c/1685909 we won't be reading from a buffer while scanning it out. We can re-enable partial swap on Mali. Bug: 457511 Change-Id: I6b41161925d0d4bb65eb19250ad5747af5493184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830084Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#702193}
-
Jeffrey Yasskin authored
This reverts commit 16cbcb68. Reason for revert: Broke https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/3254; see bug for details. Original change's description: > Add content_nocompile_tests to be run by some builders. > > Bug: 878706 > Change-Id: I5c3bd7d4393fe6c002171ff9937ad70d2b1ba191 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833297 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702132} TBR=martiniss@chromium.org,gbeaty@chromium.org Change-Id: Iacc49c8ad3330977d0779baa7815ebae7e807753 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835262Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702192}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2fc703395a92ebcc813ac8f3c6cb6a6d681e52cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836351Reviewed-by:
-
K Moon authored
crrev.com/700518 incorrectly assumed PreviewModeClient::ProposeDocumentLayout() could not be reached. In fact, the PreviewModeClient is used only when previewing non-PDF documents with more than 1 page. This change also adds a browser test to check the behavior of the print preview dialog when printing multiple pages: Current print preview tests only generate a single page, which fails to exercise this issue. The crash occurs after the print preview is "ready" (all pages have been rendered), but before the print preview dialog has "loaded" completely. Current tests only wait for the "ready" condition, but the new test must wait for the "loaded" condition. Since fully loading is slow, most tests continue waiting only for the "ready" condition. Bug: 885110 Change-Id: I20316fd658d5a125a13f08d07ced4dd79884fac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835211 Auto-Submit: K Moon <kmoon@chromium.org> Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#702190}
-
Sky Malice authored
Bug: 1009831 Change-Id: I9afd34546b9520f34a206a4d026761ab130162bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835705Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#702189}
-
Matthew Jones authored
Similar to https://chromium-review.googlesource.com/c/chromium/src/+/1836031 this patch disables another very flaky test causing failures on the bots. Example bot: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-arm64-rel/17969 Flakes: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=PasswordGenerationIntegrationTest TBR: vasilii@chromium.org, fhorschig@chromium.org Bug: 1010540 Change-Id: I684f794a971dc1b44a98e54184c8b0b475578d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835167Reviewed-by:
-
Robert Ogden authored
Adds a new PLMObserver, SubresourceLoading, to track these metrics. Bug: 995437 Change-Id: I049d96eafd93b089b06131fb8ad35eb30d0c3a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829881 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Lily Chen authored
Bug: 978172 Change-Id: I5ef4a0d189fc1e17bfa235f2aecef2853d89c006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834888Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#702186}
-
Oystein Eftevaag authored
Cleaned up the TraceController public API a little bit by removing the metadata DictionaryValue which is now inlined in the JSON rather than treated as separate data, and hold the tracing data in a std::unique_ptr<std::string> rather than a RefCountedString as the data only has one owner at any time. Split out from and already LGTM'd (the tracing bits) in https://chromium-review.googlesource.com/c/chromium/src/+/1817207/28 TBR=ssid@chromium.org,zork@chromium.org,erikchen@chromium.org,boliu@chromium.org Bug: 839086 Change-Id: I84a717e7c6915a81348d7e91fbd6fe2ba00a4d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834576 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4c982147..bbb8c722 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4d510151989360ca6ea1c461801ac55178320cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835712Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702184}
-
Raphael Kubo da Costa authored
Follow-up to commits 4ba0b61c ("Convert ShareService client to use BrowserInterfaceBroker"), 1dec3c1c ("Convert WakeLockService client to use BrowserInterfaceBroker") and e676be1f ("Convert PermissionService client to use BrowserInterfaceBroker"). Essentially, the BrowserInterfaceBroker conversion introduced flakiness to some unit tests, and this CL fixes the ones I have noticed. The flakiness is caused by the fact that we after the first test case we end up trying to rebind an already bound object, which often leads to DCHECKs and other crashes. Follow what is done in commits 567040bd ("[mojo] Convert CredentialManagerProxy to use BrowserInterfaceBroker") and b5630d76 ("Convert NFC client to use BrowserInterfaceBroker") and explicitly remove the test binders between test cases. Bug: 936482, 1010116 Change-Id: If31d8f3dfb95c69651265a6e8cdcebdfb3816728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835360 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#702183}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/514d5e281c03..d46e2fb1e341 git log 514d5e281c03..d46e2fb1e341 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 jmadill@chromium.org GN: Componentize vulkan back-end build. 2019-10-02 geofflang@chromium.org GL: Temporarily disable GPU copy paths for rectangle texture sources. 2019-10-02 jonahr@google.com Ensure Features* descriptions stay up to date Created with: gclient setdep -r src/third_party/angle@d46e2fb1e341 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:990368 Change-Id: I4dd6c32438de4eecc7786354704827a752ac7157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836271Reviewed-by:
-
Eric Stevenson authored
This CL was partially created by //base/android/jni_generator/jni_refactorer.py. The conversion also required converting unit tests to use the new JNI mocking approach provided by JniMocker. Bug: 929661 Change-Id: Iadd97ce4a911792b922cff8803143d0d8c847f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832297Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#702181}
-
Amr Aboelkher authored
The notification will be shown, when that accessibility feature is being managed by a policy, and is being disabled. Bug: 552439 Change-Id: I7d9d9332f64df992291939a620afcb0e736b8904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829354 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#702180}
-
Abigail Klein authored
Bug: 785493,959368 Change-Id: Id9aad4c62b617f2c0cd2b2269624dd1f211edb7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829951Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702179}
-
Matthew Mourgos authored
Bug: 1006965 Change-Id: I31e9b1c617f4718b08cea3e3d62e4c5ce429ec87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834567Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702178}
-
Donn Denman authored
was introduced without sufficient testing. We may have added monitoring selection-move requests for Smart Text Selection integration, but it's way too noisy, and still seems to work. BUG=956277, 1006676 Change-Id: Ia750c04070c5b214a0c63d52e1ce8bd97373f865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835173 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
-
BUG=762641 TBR=xiyuan@chromium.org Change-Id: If60a409571190b5fa88535a41cd31108b2909291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835214Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702176}
-
Lukasz Anforowicz authored
After recent CLs (r699929, r700322), there are no more overrides of ContentBrowserClient::ShouldAllowOpenURL. This CL takes advantage of that, and removes the ContentBrowserClient::ShouldAllowOpenURL method entirely. Removing callers of this method is straightforward - we just observe that the default implementation of the method always returns true. The CL is careful to preserve test coverage in tests that used to rely on ShouldAllowOpenURL overrides: 1. After the CL, the TestContentBrowserClient in //chrome/browser/prerender/prerender_browsertest.cc still "cancels all prerenders on OpenURL" (doing this from an overload of OverrideNavigationParams instead of from an overload of ShouldAllowOpenURL; OverrideNavigationParams is called from NavigatorImpl::RequestOpenURL exactly once during the test). 2. The CL refactors and moves service worker tests as follows: 2a. ServiceWorkerClientsApiBrowserTest.NavigateDisallowedUrl moves from //content to //chrome layer and becomes ExtensionResourceRequestPolicyTest. WebNavigationToNonWebAccessibleResource_ViaServiceWorkerNavigate 2b. ServiceWorkerClientsApiBrowserTest.OpenWindowDisallowedUrl moves from //content to //chrome layer and becomes ExtensionResourceRequestPolicyTest. WebNavigationToNonWebAccessibleResource_ViaServiceWorkerOpenWindow 2c. ServiceWorkerClientsApiBrowserTest.OpenWindow is refactored to use exiting testing helpers which are more detached from implementation details (using OpenURL is an example of an implementation detail) and more focused on end-to-end verification (e.g. that a new window is actually opened; not all calls to OpenURL end up opening a new window). 2a and 2b preserves the essence of the existing test coverage, since ShouldAllowOpenURL was mostly replaced by ExtensionNavigationThrottle - see r699929. To support the move in #2, the CL performs the following additional changes: - Moving the code to simulate dispatching of a service worker notification click from ServiceWorkerClientsApiBrowserTest to DispatchServiceWorkerNotificationClick - a standalone helper function in //content/public/test/service_worker_test_helpers.cc - Tweaking client_api_worker.js to support calling openWindow with a custom URL, provided by a test via notification body. Bug: 1003957 Change-Id: I486d153ca03a10a30a39204cfe6dc88e726f854d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829539 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#702175}
-
