- 12 Nov, 2018 40 commits
-
-
Mathias Carlen authored
Before this patch, we stopped autofill assistant with an error message when the cvc step got cancelled. We are currently not able to distinguish between a bad cvc and cancel. This patch makes a first step towards a nicer flow where stop script becomes a graceful shutdown with a status message. Bug: 806868 Change-Id: I5d0e3f74d21f54df1276f994be2ae8c798fa2c0f Reviewed-on: https://chromium-review.googlesource.com/c/1331394 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607247}
-
Daniel Vogelheim authored
Change the client header announcing OP capability to use the value "0". This is meant to mitigate an apparently reasonably common bug where the header value is blindly copied into the request (as observed in the referenced bug). Bug: 751996, 901477 Change-Id: I85c67cfdad3d15fc8e76e62bf1f84323faa1f790 Reviewed-on: https://chromium-review.googlesource.com/c/1328982Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#607246}
-
Xida Chen authored
Right now at PassthroughTouchEventQueue::ProcessTouchAck, we fetch an event from outstanding_touches_ queue, modify its ack info and latency info, and put the event back in the queue again. Note that the outstanding_touches_ is a std::set sorted according to each event's unique_touch_id. Setting ack info and latency info won't change the unique_touch_id on the event, in order words, it won't affect the ordering of the event in that set. So it is un-necessary to remove the event and put it back in the queue again. This CL does clean up. It sets ack and latency info directly on the event in the outstanding_touches_. The only catch here is that the iter of a std::set is always const, so we have to do a const_cast. Bug: None Change-Id: I45cf1001ce82b3fd876b856618c99df25d5b9b4a Reviewed-on: https://chromium-review.googlesource.com/c/1297714Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607245}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: Ic159261bb0296e11d58bd7adb98b6a5a8fb5cece Reviewed-on: https://chromium-review.googlesource.com/c/1329747Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607244}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: I753f512b660e613d8e6f622f81ef2aa3600d4310 Reviewed-on: https://chromium-review.googlesource.com/c/1329631Reviewed-by:
-
Nicolas Ouellet-Payeur authored
The test runs an 'echo' command to a temporary file when the user visits example.com, and then checks that the temporary file exists and contains the right string. Bug: 884211 Change-Id: Ifa8a129aa8e98583a6060274bb85a8bc4d235b8d Reviewed-on: https://chromium-review.googlesource.com/c/1318057Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#607242}
-
Owen Min authored
DeveloperToolsDisabled policy is marked as deprecated in policy_templates and DeveloperToolsPolicyHandler. Remove the one in handler so that the deprecation message only appears once. Bug: 902603 Change-Id: Ia9a78cd4667eb39b5ec3e82399fcd44ae1556de1 Reviewed-on: https://chromium-review.googlesource.com/c/1326843Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607241}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c7a34cae21d2..0243949545eb git log c7a34cae21d2..0243949545eb --date=short --no-merges --format='%ad %ae %s' 2018-11-12 reed@google.com Revert "route getFontMetrics to SkFont" 2018-11-12 reed@google.com add getwidths to SkFont 2018-11-11 reed@google.com impl SkFont::measureText 2018-11-11 reed@google.com route getFontMetrics to SkFont 2018-11-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2018-11-11 mtklein@google.com work around Flutter/Fuchsia GN problems 2018-11-11 mtklein@google.com Reland "Improve degenerate 2pt conical gradient cases" 2018-11-10 fmalita@chromium.org [skottie] Make animated image support generally available 2018-11-10 reed@google.com move GlyphCacheProc into fontpriv 2018-11-10 reed@google.com add fontmetrics to SkFont 2018-11-10 kjlubick@google.com Convert skottie's cloud build to use CanvasKit Created with: gclient setdep -r src/third_party/skia@0243949545eb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I12e66c7ffa4160419dbf559753c4758ac4b62fb5 Reviewed-on: https://chromium-review.googlesource.com/c/1331410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607240}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowBaseSyncPrimitives in non-test files * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 766678 Change-Id: Id041725a059110494a5805f98f3eba5b5bab6bff Reviewed-on: https://chromium-review.googlesource.com/c/1324453Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#607239}
-
Philip Rogers authored
When a canvas is accelerated, the background is sometimes painted into the content layer (see ContentLayerSupportsDirectBackgroundComposition). When this occurs, we can skip painting the background but still need to paint the hit test rects. Bug: 903480 Change-Id: Iec5d564ffed9611011d78adc381c9d7d7153e960 Reviewed-on: https://chromium-review.googlesource.com/c/1329854Reviewed-by:
Xianda Sun <sunxd@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607238}
-
Shawn Gallea authored
Created FullscreenShellSurface class, similar to ShellSurface but without any ash dependencies, to be used with fullscreen wayland protocol to allow EXO use on other platforms. Added unit test for FullscreenShellSurface for cast. Bug: 896710 Test: Compiled on ChromeOS Change-Id: I542c9b0729b847f4cde2fa67d727143e18f4a2a5 Reviewed-on: https://chromium-review.googlesource.com/c/1298172 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#607237}
-
Philip Rogers authored
There was an early-out in ReplacedPainter::Paint that would skip painting touch-action hit test rects if the replaced element did not also paint a background. This patch skips the early-out if there is a hit test rect that should be painted. This does not fully fix https://crbug.com/903480 because accelerated canvases still do not generate the correct touch action rects. Bug: 903480 Change-Id: If6cda7339c5a20a04fe669c4d54fae30e83debf2 Reviewed-on: https://chromium-review.googlesource.com/c/1331033Reviewed-by:
-
Shawn Gallea authored
Moved shell and aura shell checks to when not using fullscreen shell. This is needed for cast to run fullscreen clients. Bug: 896710 Test: Compiled client on ChromeOS. Change-Id: Ie4c408d8266a0957ad9b57ea332a8e38171b2be9 Reviewed-on: https://chromium-review.googlesource.com/c/1331170Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/279259d2591e..4e5366120355 Created with: gclient setdep -r src-internal@4e5366120355 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1942c7d861d9619559010043f5a53141152bc9bf Reviewed-on: https://chromium-review.googlesource.com/c/1331412Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607234}
-
Mustaq Ahmed authored
|RenderFrameImpl::CommitNavigation*| functions got |WebScopedUserGesture|s few years ago to fix a PasswordManager test (crrev.com/2378393002). Those artificial user gesture tokens seem to have become redundant in the meantime through changes in navigation and/or PasswordManager. This CL removes those tokens because they are causing popup-blocker failure with UAv2. Bug: 865243 Change-Id: I6ed7d73a5784f82ce3ba695067a4cbff0a9c24b4 Reviewed-on: https://chromium-review.googlesource.com/c/1323626 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#607233}
-
Daniel Vogelheim authored
HTMLScriptElement::text() and setText() functions modified to accept TrustedScript as an argument. Added HTMLScriptElement::innerText and HTMLScriptElement:textContent attributes to override existing implementations in HTMLElement and Node, and to accept TrustedScript. Changed HTMLElement::innerText and Node::textContent .idl definitions and adjusted setters and getters to accept TrustedScript. Bug: 739170 Change-Id: I63da5714ffac328c6ae2f76e5da58c05f44a1cbf Reviewed-on: https://chromium-review.googlesource.com/c/1178046 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#607232}
-
Peter Wen authored
Original CL: https://crrev.com/c/1327157 Fixes: - Cronet target: cronet_sample_apk_java__lint - Removes suppression for autofill TBR=mheikal@chromium.org Bug: 900912 Change-Id: Ib3c7fd69e394ade0b2b80aed72a993e02b0a153c Reviewed-on: https://chromium-review.googlesource.com/c/1331011 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607231}
-
Leonard Grey authored
Despite the expectation that capture has been turned off when we enter a move loop, traces show that when the mystery move loop crash happens, capture is indeed on. Let's see if: - Releasing capture actually works - Whether we're succesfully releasing capture on the widget entering the move loop, but still have capture on another widget. Bug: 876493 Change-Id: I22db7aca92d25df9e97fd57f9b005b45770191b5 Reviewed-on: https://chromium-review.googlesource.com/c/1329903Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#607230}
-
Jeremy Roman authored
In the intervening almost-nine years, we have managed to add this #include. Change-Id: I68673f7c0f6e83fd604e8d227062acd179a18a9e Reviewed-on: https://chromium-review.googlesource.com/c/1330210Reviewed-by:
-
Egor Pasko authored
The orderfile bot currently produces a warning like this: WARNING:root:2540 symbols repeated with multiple offsets: __ThumbV7PILongThunk__lala 26256476 38958560 __ThumbV7PILongThunk__tada 26232216 38911480 ... // 10 examples, to avoid expanding the log a lot It is expected that multi-jump thunks would be duplicated, and we suspect they would have the same symbol name. This change makes the warning to ignore such cases in order to leave space for more suspicious cases. Bug: 893981 Change-Id: I9e1ad0f1e0786c1d12d7490c7a597c7d9344b8a6 Reviewed-on: https://chromium-review.googlesource.com/c/1331395Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607228}
-
Takuto Ikuta authored
This is to reduce the number of files sent to swarming under third_party/perl directory. e.g. https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=91c35f024b8949020a3a25f3421f27689f35dff5 from https://chromium-swarm.appspot.com/task?id=40da578fadf59310&refresh=10&show_raw=1 Bug: 899991 Change-Id: I8608283399e817c8d3d8558782d67587a735e96a Reviewed-on: https://chromium-review.googlesource.com/c/1331097Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#607227}
-
Mike Reed authored
Strictly an alias/name change. No functional changes. TBR= Change-Id: I81e1482b91c23feaa7c24b6a0ca241988c01538b Reviewed-on: https://chromium-review.googlesource.com/c/1331134 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#607226}
-
John Budorick authored
Bug: 817842 Change-Id: I1d360830b8e2a7c72dbca5083f9d803d4a229917 Reviewed-on: https://chromium-review.googlesource.com/c/1331036Reviewed-by:
-
Leonard Grey authored
This is a reland of 002dfaef Original change's description: > Mac: Disallow dragging tab into blocked tabstrip > > This is a really longwinded way for me to fix some NOTIMPLEMENTED spam, > though I'm pretty sure the thing that happens right now when you open > a certificate prompt and drag a tab into the parent window is bad. > > This introduces a new method because we're not sure if it matches the > Aura semantics, and this is better than the nothing we were doing previously. > > Bug: 825834 > Change-Id: I316ca4fbaa7a27dacb09bce0866203b79567016d > Reviewed-on: https://chromium-review.googlesource.com/c/1315956 > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606619} Bug: 825834 Change-Id: Ice8fa3f991e3e672a2266c444e281bbad1b47819 Reviewed-on: https://chromium-review.googlesource.com/c/1329350Reviewed-by:
-
Fredrik Söderquist authored
This if cascade consumes both a fair bit of footprint while it makes the switch slightly less readable. Change-Id: Ia8cb0d14ec831ccfcf7f22154a12f16d44fbc9ad Reviewed-on: https://chromium-review.googlesource.com/c/1329147 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#607223}
-
Boris Sazonov authored
This CL removes passwords checkbox enabled state dependency on ProfileSyncService::IsCryptographerReady(). This datatype can be configured without cryptographer being ready (that's what other platforms do) and removing this dependency fixes issues when this checkbox was spontaneously becoming disabled. Bug: 902880 Change-Id: I58f8b1b0375bc2bdfb77c1db1cf3f998020b935d Reviewed-on: https://chromium-review.googlesource.com/c/1323720Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#607222}
-
Boris Sazonov authored
This CL modifies SigninHelper.validateAccountSettings so that accounts are accessed only after AccountManagerFacade cache is populated. SigninHelper.validateAccountSettings is called early during startup, so postponing this call should reduce the amount of time spent waiting for accounts on UI thread. Bug: 837374 Change-Id: Ica027806d9a329e08b880abec12dc0954c540e63 Reviewed-on: https://chromium-review.googlesource.com/c/1329247Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#607221}
-
Peter Wen authored
- Submit this only when 3.4 is available on internal canary. TBR=agrieve@chromium.org Bug: 620034 Change-Id: Iebcec3271b37ecfea8ba4f3eac36ab576ec5acf1 Reviewed-on: https://chromium-review.googlesource.com/c/1324871Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 251b2c57. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" 687313c5 "Add action_sequence in testdriver" 395cf32d "Preparation of moving LayoutTests to web_tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I6c56958cb13ea9fcd3418d6e3a77a8cefef274f3 Reviewed-on: https://chromium-review.googlesource.com/c/1331009 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607219}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c8e54cc..5ac7f8c6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie77677170120878281daa491b29b3531cbc26f4e Reviewed-on: https://chromium-review.googlesource.com/c/1331010Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607218}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/768184982153..279259d2591e Created with: gclient setdep -r src-internal@279259d2591e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2f6b305c7e9037f5197d90294fbc85b6292a4516 Reviewed-on: https://chromium-review.googlesource.com/c/1331218Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/662c038f3fdd..d1eeca86af6e git log 662c038f3fdd..d1eeca86af6e --date=short --no-merges --format='%ad %ae %s' 2018-11-12 pasko@chromium.org compare_samples: trivial fix in Main Created with: gclient setdep -r src/third_party/catapult@d1eeca86af6e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:903730 TBR=sullivan@chromium.org Change-Id: I4d634429ea4da913126e51853cedacfe48ab37b4 Reviewed-on: https://chromium-review.googlesource.com/c/1331409Reviewed-by:
-
Jan Krcal authored
This CL introduces notification of remote changes for wallet metadata sync. This is vital for two reasons: - PersonalDataManager loads up to date data as soon as it gets changed; - It allows to write integration tests for wallet metadata that only observe the PDM (and thus test as end-to-end as it gets). The approach to block self-notification is a bit hacky; it will get removed in the new USS bridge as this will not listen to MultipleChanged any more. Bug: 894001 Change-Id: I1bcdd4b80187c2980c4343bfd37584ad64d93d01 Reviewed-on: https://chromium-review.googlesource.com/c/1309744 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607215}
-
Mythri Alle authored
We used to use GetCachePath as a means to control the parameters of the code caching. To disable code caching embedder returned an empty path. Now, we replaced this with a better interface with GeneratedCodeCacheSettings [cl]. We no longer need GetCachePath interface for BrowserContext [cl]: https://chromium-review.googlesource.com/c/chromium/src/+/1213093 BUG: chromium:867552 Change-Id: Ifc7993548fa73d8713b935a7cb8cc5876ff3d431 Reviewed-on: https://chromium-review.googlesource.com/c/1301973 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#607214}
-
Boris Sazonov authored
This CL adds bsazonov@chromium.org to chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS. Bug: None Change-Id: Ic66e1b62b1efe5655273c6c528ea9dc1381994f0 Reviewed-on: https://chromium-review.googlesource.com/c/1326493Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#607213}
-
Colin Blundell authored
I just noticed that the variant that issues an access token for all accounts has an overload for passing |id_token|, while the variant that specifies an account has it as an optional argument. Let's use the optional argument approach for both, as we're shortly going to need to add another optional argument for scopes. Bug: 798699 Change-Id: I610cc5bf1ba596b92ccd7d18ad6aa3bcc32ac246 Reviewed-on: https://chromium-review.googlesource.com/c/1329794 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
The test left orphans / widows at their initial value (2), but did assume that we could freely break wherever we wanted. Blink honors orphans and widows requirements inside multicol containers, so set them to 1, to get the behavior that the test expects. Bug: 904263 Change-Id: Ia138da5c65b1c5da450441f38e033320bc983a94 Reviewed-on: https://chromium-review.googlesource.com/c/1331389Reviewed-by:
-
Mohamed Amir Yosef authored
Mobile bookmarks folder always exists in the local model, however it gets created on the server only after signing in with a mobile device. Therefore, when checking persisted metadata for corruption, the mobile bookmarks should be treated as optional and its absence shouldn't signal metadata corruption. Bug: 516866 Change-Id: I8be50719f0978c4fa60091e5943ee2ce80006b16 Reviewed-on: https://chromium-review.googlesource.com/c/1329679 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#607210}
-
Tanja Gornak authored
sync_listen_notifications istn't used neither in production code, nor in tests. Hence removing. Bug: 880056, 801985 Change-Id: If518c9dad72b3f718ee649844a6cf3a4703bc0c7 Reviewed-on: https://chromium-review.googlesource.com/c/1307434 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: 903823, 892176 Change-Id: I30a2f92478a4b260191deb7faf4aa2a21acc2609 Reviewed-on: https://chromium-review.googlesource.com/c/1329346Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#607208}
-
