- 29 Nov, 2018 40 commits
-
-
Clark DuVall authored
ChromeMockCertVerifier was forgetting to call the parent class methods that set up the in-process NS cert verifier. Bug: 908993 Change-Id: I15251a705006c7f5dd1dc99027999e1b8739e416 Reviewed-on: https://chromium-review.googlesource.com/c/1355194Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#612327}
-
bsheedy authored
Adds a TL;DR to the XR instrumentation test documentation on how to locally reproduce most VR issues since many VR breakages at this point are caused by non-VR CLs, and their authors often need to ask how to reproduce the issue. Change-Id: I2a4585969a859cb9c9256c8cfa0715d9cc07b71c Reviewed-on: https://chromium-review.googlesource.com/c/1352488Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612326}
-
Mason Freed authored
This set includes a few more known issues, and changes the definition of opacity to match our more recent proposal. Under that proposal, the opacity of the backdrop-filter element applies to the filtered backdrop image as well. Bug: 497522 Change-Id: I2fa0bbb710b7a4ba5592c9a4b9ea5ecaaf5b9ddf Reviewed-on: https://chromium-review.googlesource.com/c/1354347Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#612325}
-
Donn Denman authored
Adds the ability to specify a threshold replacement to apply when predicting using an Assist-Ranker model. For Contextual Search the threshold is read from a FieldTrial variations parameter associated with the existing ContextualSearchRankerQuery Feature. For Translate, threshold setting is supported but unused. BUG=899134 Change-Id: Ia0b664ce1e0949f755e7d8898fb2769fc91ae536 Reviewed-on: https://chromium-review.googlesource.com/c/1312296 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612324}
-
Avi Drissman authored
This avoids it getting triggered by URL requests to quit/restart. BUG=909592, 142944 Change-Id: I353c1334decd556554399349bb207e63fca1352b Reviewed-on: https://chromium-review.googlesource.com/c/1354399Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612323}
-
John Delaney authored
Add a browsertest to verify that we are not counting overhead for responses with "Transfer-Encoding: chunked" towards network body bytes. Rename PageLoadMetricsTestWaiter methods to use "network bytes" instead of "resource bytes". Bug: 894168 Change-Id: Id83af484f210063761dcbf4552406f08cdd5a171 Reviewed-on: https://chromium-review.googlesource.com/c/1351383Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612322}
-
Matthew Denton authored
Adds periodic pausing/resuming of random mojo bindings, to test whether Mojo users are relying on FIFO ordering of messages sent over different message pipes. Bug: 830815 Change-Id: Ie765813235a6ff720b2c4c3be550ad474b7be566 Reviewed-on: https://chromium-review.googlesource.com/c/1325551 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#612321}
-
Jonathan Metzman authored
These are needed to stand up a builder for libFuzzer on Chrome OS Bug: 909849, 906214 Change-Id: Ifade90c138a7297a2cd5cc02e7d00628c3408d46 Reviewed-on: https://chromium-review.googlesource.com/c/1355433Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612320}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f38fffb7aa2f..9dbf638d6f75 Created with: gclient setdep -r src-internal@9dbf638d6f75 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifc8506cc400887fd8ba4c5b874b50606dc88f555 Reviewed-on: https://chromium-review.googlesource.com/c/1355363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612319}
-
Pavel Shmakov authored
The following metrics were added. TWA usage: - TrustedWebActivity.TimeInVerifiedOrigin and TrustedWebActivity.TimeOutOfVerifiedOrigin - time histograms for the time spent in and out of verified origin. - Enabled Ukm recording, as implemented in org.chromium.chrome.browser.browserservices.UkmRecorder Disclosure: - TrustedWebActivity.DisclosureShown - TrustedWebActivity.DisclosureAccepted Clear Data Dialog - Boolean histograms TrustedWebActivity.ClearDataDialogOnUninstallAccepted, TrustedWebActivity.ClearDataDialogOnClearAppDataAccepted - Enum histogram SingleWebsitePreferences.NavigatedFromToReset recorded when user clicks “Clear & Reset” to tell which way did the user navigate into settings. Manage Data Activity - TrustedWebActivity.OpenedSettingsViaManageSpace - Included in enum histogram above Notification Delegation - SystemNotificationType.TRUSTED_WEB_ACTIVITY_SITES entry. - TrustedWebActivity.DelegatedNotificationSmallIconFallback which tells which fallback (if any) was used for the small icon of a delegated notification. Bug: 888961 Change-Id: If1cfe70754f474536c1d242a554a8ae517c5d15b Reviewed-on: https://chromium-review.googlesource.com/c/1353925 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#612318}
-
Devlin Cronin authored
Update the underlying BaseSetOperators<T>::Map type to use std::unique_ptrs instead of linked_ptrs. Bug: 907661 Change-Id: I2161ca2acc513ee5d78cc32b14f27199f5a7d1b7 Reviewed-on: https://chromium-review.googlesource.com/c/1351422 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612317}
-
John Abd-El-Malek authored
Revert "Alias the url for webui code with network service to get more information in debugging the crash." This reverts commit 660d336d. Got the information I needed. Original change's description: > Alias the url for webui code with network service to get more information in debugging the crash. > > Bug: 891074 > Change-Id: I8904c8d0285b8b2f245456509d88206f4789fc8d > Reviewed-on: https://chromium-review.googlesource.com/c/1330064 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606965} TBR=jam@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 891074 Change-Id: Id739d25531997bcdacafa5c49a13bfd849edd32a Reviewed-on: https://chromium-review.googlesource.com/c/1355430Reviewed-by:
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/find_in_page. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: I9741755b7ed101a5baf4e6bacc38abd7ad0a4029 Reviewed-on: https://chromium-review.googlesource.com/c/1351955Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#612315}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: Ibcc14267aaa966b1833dd1537989a7bc5ae9a010 Reviewed-on: https://chromium-review.googlesource.com/c/1351952Reviewed-by:
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/sessions. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: Ia6e2ae8b3dc9334e9cec18328d7dda086f7ab57a Reviewed-on: https://chromium-review.googlesource.com/c/1351961Reviewed-by:
-
Clark DuVall authored
This fixes the last DRP browser test. Factors the code to a common location so it can be used in the DRP throttle. Bug: 721403 Change-Id: I47330f7e9cad75861787caa843d55147a42fb8a4 Reviewed-on: https://chromium-review.googlesource.com/c/1354653Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#612312}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/tabs. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: I6b33f5491423d55455e912ee01adec2c73686122 Reviewed-on: https://chromium-review.googlesource.com/c/1351079Reviewed-by:
-
Mike Dougherty authored
This CL removes macro usage from /ios/web_view. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: I91645c283c518b67e1a7efe866d30ba566815273 Reviewed-on: https://chromium-review.googlesource.com/c/1351965Reviewed-by:
-
Nicolas Pena authored
This CL exposes the PerformanceMark and PerformanceMeasure interfaces to Worker, thus fixing the idlharness tests in performance-timeline and user-timing. Blink-dev thread: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/Z3RKovFsA1s/DWt78xngAgAJ Bug: 898791 Change-Id: Ic4e3e8c61ac087d13ffc86e462b45ab2ddbd097f Reviewed-on: https://chromium-review.googlesource.com/c/1351562Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#612309}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/infobars. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: I4b9a1e4e554819b741e0901208665dc7142db08e Reviewed-on: https://chromium-review.googlesource.com/c/1351074Reviewed-by:
-
Sami Kyostila authored
This patch removes the deprecated MessageLoop{UI,IO}::{current,IsCurrent} functions and rewrites clients to MessageLoopCurrentFor{UI,IO}::{Current,IsSet}. No functional changes. # chrome/ TBR=sky@chromium.org # extensions/ TBR=finnur@chromium.org # net/ TBR=morlovich@chromium.org # remoting/ TBR=garykac@chromium.org # services/ TBR=rockot@google.com # ui/ TBR=sadrul@chromium.org Bug: 891670 Change-Id: I283cd67940e21e5b737d566a2ac351b69756e176 Reviewed-on: https://chromium-review.googlesource.com/c/1354010Reviewed-by:Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#612307}
-
Gang Wu authored
User Actions: Suggestions.ScrolledAfterOpen Suggestions.Card.SwipedAway UMA: ContentSuggestions.FetchPendingSpinner.VisibleDuration Also add Guard against calls from Feed after destroy(), like https://chromium-review.googlesource.com/c/chromium/src/+/1345422 Bug: 908706 Change-Id: Ifdd9dcab594d74eb79d0161d1ee66027a7adcea0 Reviewed-on: https://chromium-review.googlesource.com/c/1351932 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#612306}
-
Robert Ogden authored
Reverts all of the PLM changes in https://chromium-review.googlesource.com/c/chromium/src/+/1334944 and a partial revert of the previews code because of merge conflicts. git checkout 967d3a9b \ chrome/browser/page_load_metrics/page* \ chrome/browser/page_load_metrics/metrics* Bug: 874150 Change-Id: Ic943baa1c8945c3dd033de5890ba0d70b2efd5bc Reviewed-on: https://chromium-review.googlesource.com/c/1355331Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#612305}
-
Quan Nguyen authored
This CL includes a new Mojo service for controlling the ContainedShell, as well as a feature flag for enabling it. Bug: 902571 Change-Id: I645643270a5e595a0cadb6f781f400d700ae3bed Reviewed-on: https://chromium-review.googlesource.com/c/1323718 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#612304}
-
Garrett Beaty authored
Bug: 889992 Change-Id: I9a8d8f787507c7e461b8a02ad5b130389a9f876c Reviewed-on: https://chromium-review.googlesource.com/c/1351489Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#612303}
-
Bret Sepulveda authored
At least on Windows, the screen reader will not read non-menu-item Views in a menu. Currently, extensions hidden in the app menu and the zoom plus and minus buttons are not read. This patch tags them as kMenuItem, which fixes the bug. Bug: 835738 Change-Id: I507c9595f6aa02d8768330f18a8b725ef1b440e4 Reviewed-on: https://chromium-review.googlesource.com/c/1354482Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#612302}
-
John Rummell authored
Original change's description: > MediaLicenses can be cleared from the ClearBrowsingData dialog, so update the > BrowsingDataRemoverBrowserTest to check them as well. This uses the test-only > External Clear Key CDM to store the license in the file system, if it is > available. > > The original CL was flaky due to Mac's only saving file timestamps to > second granularity. As a result it was possible for the newly created license > to be saved with a timestamp prior to the current actual time, and deleting > "old" licenses would include it in the deletion. Change is to wait for some > time on Macs only to ensure that the "new" license has a later timestamp. This reverts commit b6bfa2b7. BUG=808690 TEST=new browser_tests pass Change-Id: Iad919ec23bf157a9bc4af3e6d54af2b28fdc217e Reviewed-on: https://chromium-review.googlesource.com/c/1354498Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#612301}
-
Adam Langley authored
(This doesn't apply to U2F register responses because there's no flags byte there.) Bug: 896980 Change-Id: I02c63d4bc63db4a8e2e7256a428d8349c34f5443 Reviewed-on: https://chromium-review.googlesource.com/c/1355242 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#612300}
-
Vladimir Levin authored
Change-Id: Icb4017f98f8edea6692d84ef82872a2182e3d29c Reviewed-on: https://chromium-review.googlesource.com/c/1355325Reviewed-by:
-
Joe Downing authored
Follow-up CL fixing a leak identified post check-in. Bug: 902041 Change-Id: I733cc6037f5c29f0decabae72d51a6470de17f91 Reviewed-on: https://chromium-review.googlesource.com/c/1355332Reviewed-by:
-
John Budorick authored
Updating android_deps is a bit more involved & will be in a separate CL. Bug: 877304 Change-Id: Ic297766125ffd638b8190033736d301ce650a86e Reviewed-on: https://chromium-review.googlesource.com/c/1350879 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612297}
-
Abhishek Arya authored
R=mmoroz@chromium.org,ochang@chromium.org Bug: 909950 Change-Id: I00c7a8dcab631a8e4f7334847733c4a10a1376f0 Reviewed-on: https://chromium-review.googlesource.com/c/1354684Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612296}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a1442ecdf514..471358f39a6a git log a1442ecdf514..471358f39a6a --date=short --no-merges --format='%ad %ae %s' 2018-11-29 syoussefi@chromium.org Vulkan: fix pipeline stages of memory barriers 2018-11-29 matavenrath@nvidia.com Optimize State::syncDirtyObjects Created with: gclient setdep -r src/third_party/angle@471358f39a6a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Iad8707cc33c68cf716b17b6f184389220509bba7 Reviewed-on: https://chromium-review.googlesource.com/c/1355241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612295}
-
Charlie Andrews authored
This is necessary in order to fix http://crbug.com/894906, where all tests disabled on Nexus 5 were accidentally disabled on Nexus 5X "Nexus 5X" contains the string "Nexus 5", and we were targeting the disables based on substring matching. I erred on the side of being redundant: if there was both a "Nexus 5" disable and an "Android" disable, I added a corresponding "Nexus 5X" disable. My idea here was that, if at some later point the "All" bug got fixed and the test got reenabled, I didn't want the person doing that to be confused why the story was failing on Nexus 5X still. Associating the logic bug with the disable explicitly reduces that confusion. Bug: 894906 Change-Id: I601304a979c7b7c6451d1571f8ffce61a60f4ecd Reviewed-on: https://chromium-review.googlesource.com/c/1355482Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#612294}
-
Mark authored
This change further changes direct calls to Time::Now or the default base::Clock instance to an OfflineClock module for ease of testing within production files and their related tests in: components/offline_pages/core/background/ Bug: 906903 Change-Id: Iee19708b9297e3e3b3944c457b163d5555914948 Reviewed-on: https://chromium-review.googlesource.com/c/1352045Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Mark Lieu <mtlieuu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612293}
-
Frank Kastenholz authored
```----------------------------------------------- Date: Tue Nov 13 01:34:33 2018 +0000 Deprecate FLAGS_quic_reloadable_flag_quic_fix_path_degrading_alarm. Merge internal change: 221188379 https://chromium-review.googlesource.com/c/1351736/ ``` ----------------------------------------------- Date: Tue Nov 13 15:59:56 2018 +0000 Deprecate FLAGS_quic_reloadable_flag_quic_fix_reset_zombie_streams. Merge internal change: 221267071 https://chromium-review.googlesource.com/c/1351737/ -------------------------------------------------- Date: Tue Nov 13 16:00:26 2018 +0000 Fix the bug where v44 packets are rejected by a connection close. Fix the bug where v44 packets are rejected by a connection close framed by a framer with an incorrect version. Protected by default true flag FLAGS_quic_reloadable_flag_quic_fix_reject_by_session_type. This bug happens when the rejection packet is framed before the framer version is set, rejections from unsupported session type is an example of this bug. This bug was discovered while we trying to disable UDP proxying traffic. Merge internal change: 221267139 https://chromium-review.googlesource.com/c/1351725/ Bug: 116200989 -------------------------------------------------- Date: Tue Nov 13 20:36:06 2018 +0000 Send version negotiations n response to 1200 byte packets. Only send QUIC version negotiation packets in response to packets which are at least 1200 bytes. Protected by FLAGS_quic_reloadable_flag_quic_limit_version_negotiation Merge internal change: 221314259 https://chromium-review.googlesource.com/c/1351726/ Bug: 119156969 -------------------------------------------------- Date: Tue Nov 13 20:44:37 2018 +0000 Move #include .../quic_mem_slice_storage.h from .h to .cc file. The included class is only used in the .cc file. Merge internal change: 221315750 https://chromium-review.googlesource.com/c/1351738/ -------------------------------------------------- Date: Tue Nov 13 21:50:51 2018 +0000 Deprecate FLAGS_quic_reloadable_flag_quic_deprecate_post_process_after_data. Merge internal change: 221327286 https://chromium-review.googlesource.com/c/1351739/ -------------------------------------------------- Date: Wed Nov 14 19:36:56 2018 +0000 Remove an incorrect expectation in the unit test. On a network with sufficiently large RTT, it's possible to be 120ms into PROBE_RTT and still occasionally receive samples from packets sent before the connection has entered PROBE_RTT phase. Merge internal change: 221481262 https://chromium-review.googlesource.com/c/1351740/ Bug: 119213623 -------------------------------------------------- Date: Wed Nov 14 20:45:59 2018 +0000 Ensure BBR pacing starts above 1.25xBW Estimate. Ensure the pacing rate in QUIC BBR doesn't decrease below 1.25 * BandwidthEstimate() when in STARTUP and rate based startup is enabled. Protected by existing not-enabled flag FLAGS_quic_reloadable_flag_quic_bbr_startup_rate_reduction. Merge internal change: 221492597 https://chromium-review.googlesource.com/c/1351728/ Bug: 68184215 -------------------------------------------------- Date: Thu Nov 15 17:06:50 2018 +0000 Remove redundant const: kMaximumStreamIdSupported. Merge internal change: 221633247 https://chromium-review.googlesource.com/c/1352329/ -------------------------------------------------- Date: Thu Nov 15 18:25:07 2018 +0000 Route OnDataAvailable() for QuicSpdyStream and its subclasses to OnBodyAvailable(). When data is available in sequencer, QuicSpdyStream::OnDataAvailable() will be invoked and it will be able to do the decoding job. Once the decoded data is ready, OnBodyAvailable() will be invoked and pure body data can be passed to upper layer. For now OnDataAvailable() simply calls OnBodyAvailable(). This prepares for HTTP/3 implementation where HTTP body will be encoded in data frames. no hehavior change. Merge internal change: 221646112 https://chromium-review.googlesource.com/c/1352337/ -------------------------------------------------- Date: Thu Nov 15 19:38:01 2018 +0000 Stop caching ephemeral key shares in QUIC. We don't do this for TLS, so might as well stop doing it in QUIC too. Protected by --gfe2_restart_flag_quic_no_ephemeral_key_source. Merge internal change: 221660656 https://chromium-review.googlesource.com/c/1352342/ -------------------------------------------------- Date: Fri Nov 16 00:38:54 2018 +0000 Add a max_retransmission_count to QuartcStream. This is used (along with MaybeSetTtl) for go/quartc-data-channels to provide the partial reliability parameters needed in WebRTC data channels. This is a more flexible variant of cancel_on_loss mode, which causes a stream to immediately cancel itself if the stream tries to retransmit any lost frames. It allows the caller to specify a fixed maximum number of retransmissions for the stream, after which the stream will cancel itself. Up to max_retransmission_count stream frames are allowed to be retransmitted. If a max_retransmission_count + 1st frame would be retransmitted, the stream cancels itself. Setting the value to zero is equivalent to setting cancel_on_loss. In theory, it might be preferable to retransmit *each* stream frame up to max_retransmission_count times, rather than allowing that number of retransmissions for the whole stream. However, this requires complex bookkeeping and isn't required for WebRTC data channels. WebRTC data channels use the semantics of SCTP, which disallows fragmentation of unreliable messages (see https://tools.ietf.org/html/draft-ietf-sigtran-usctp-01#section-4.2). For data channels, we can refuse unreliable messages that don't fit in one packet. Merge internal change: 221712381 https://chromium-review.googlesource.com/c/1352346/ -------------------------------------------------- Date: Fri Nov 16 01:26:34 2018 +0000 Add missing using declaration or qualification for names in the testing namespace. Merge internal change: 221719195 https://chromium-review.googlesource.com/c/1352348/ -------------------------------------------------- Date: Fri Nov 16 14:56:35 2018 +0000 Add QpackInstructionDecoder; convert QpackDecoder to use it. Add general purpose instruction decoder QpackInstructionDecoder and use it in QpackDecoder. The next steps are: * convert QpackEncoderStreamReceiver to use QpackInstructionDecoder; * implement QpackDecoderStreamReceiver using QpackInstructionDecoder; * implement QpackInstructionEncoder; * convert QpackEncoder to use QpackInstructionEncoder; * convert QpackEncoderStreamSender to use QpackInstructionEncoder; * implement QpackDecoderStreamSender using QpackInstructionEncoder. Merge internal change: 221787819 https://chromium-review.googlesource.com/c/1352478/ Bug: 112770235 -------------------------------------------------- Date: Fri Nov 16 16:48:54 2018 +0000 Fix a TSAN bug in QuicDispatcherTest.NoVersionNegotiationWithSmallPacket Merge internal change: 221800371 https://chromium-review.googlesource.com/c/1351104/ Bug: 119623391 -------------------------------------------------- Date: Fri Nov 16 18:54:34 2018 +0000 Add a fuzz mode to GfeQuicConfig. Add a fuzz mode to GfeQuicConfig which allows skipping handshake in GfeQuicServerStream with the presence of connection option'FUZZ' in handshake message. Not flag protected as the new behavior is protected by a new field in QuicConfigProto which should only be used in fuzzing test. Merge internal change: 221818256 https://chromium-review.googlesource.com/c/1351105/ Bug: 69366971 -------------------------------------------------- Date: Fri Nov 16 22:46:09 2018 +0000 Temporary fix to make SendMessage API safer Make quic message frame copy message to prevent dangerous use case described in b/118998735. We agreed that long term solution would be new API with MemSlice. This is temporary fix to make existing API safer to use. One use case which Quartc is interested is calling SendMessage from OnCanWrite notification, which is currently called under flusher. In QUIC SendMessage API implementation copy message to prevent dangerous use case when SendMessage delays flushing and keeps reference to input QuicStringPiece until flusher gets out of scope. No changes in functionality. Merge internal change: 221856121 https://chromium-review.googlesource.com/c/1351107/ Bug: 118998735 -------------------------------------------------- Date: Sat Nov 17 01:23:43 2018 +0000 Use QpackInstructionDecoder in QpackEncoderStreamReceiver. * Rip out complicated state machine from QpackEncoderStreamReceiver and use shiny new complicated state machine of QpackInstructionDecoder. * Rename index to varint (enum members, class members, accessors) to reflect that integer can mean things other than an index, for example, stream ID or maximum size. * Do early returns in ProgressiveDecoder::OnInstructionDecoded(), also use DCHECK_EQ instead of DCHECK(a==b) for pointers (this is generally preferred unless there is no ostream<< override). Merge internal change: 221877696 https://chromium-review.googlesource.com/c/1352691/ Bug: 112770235 -------------------------------------------------- Date: Mon Nov 19 00:53:47 2018 +0000 Add QuicStreamSequencer::StreamInterface class Add a new QuicStreamSequencer::StreamInterface class which the sequencer uses to communicate with the Stream instead of talking directly to the stream. This will permit the sequencer to be used with "pending" unidirectional streams while they wait for initial data to arrive. It also allows the sequencer tests to be simplified. Merge internal change: 222005123 https://chromium-review.googlesource.com/c/1352674/ -------------------------------------------------- Date: Mon Nov 19 15:31:51 2018 +0000 Add move constructors for QuicStreamSequencer Add move constructors (and tests) to QuicStreamSequencer, QuicStreamSequencerBuffer and QuicFlowController. This will allow a QuicStream to be constructed from buffered stream frames. Merge internal change: 222073117 https://chromium-review.googlesource.com/c/1352534/ -------------------------------------------------- Date: Mon Nov 19 17:46:54 2018 +0000 Fix QpackEncoder bug. Fix bug in QpackEncoder that if last header is encoded by index and |max_encoded_bytes| equals the number of bytes necessary for encoding, then DoVarintDone() must be executed in order to increment |header_list_iterator_| so that HasNext() correctly returns false. This will soon be obsoleted by QpackInstructionEncoder, but we wanted to land the regression test in before that change to make sure this bug is not replicated by QpackInstructionEncoder. Prototype code not used in production yet. Merge internal change: 222091323 https://chromium-review.googlesource.com/c/1352675/ -------------------------------------------------- Date: Mon Nov 19 19:05:54 2018 +0000 Implement support for SendMessage in quartc session Quic now support simple unreliable SentMessage API. Currently it does not support re-transmissions and does not break large messages (assumes that message fits in quic frame), but for audio this is exactly what we need right now. If connection is congestion controlled, SentMessage returns error and we need to queue messages and re-send on OnCanWrite. This CL adds support for SendMessage quartc session. n/a (Quartc only) Merge internal change: 222104840 https://chromium-review.googlesource.com/c/1352676/ R=rch@chromium.org Change-Id: Id232dc5e538c0081b3b8222966eb05a400a2284b Reviewed-on: https://chromium-review.googlesource.com/c/1354264 Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#612292}
-
Justin Cohen authored
Bug: 909724 Change-Id: I24c3341ca5245d599ce43cba8b17c164e38e3618 Reviewed-on: https://chromium-review.googlesource.com/c/1354414 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612291}
-
Aaron Leventhal authored
TBR=rockot@google.com Bug: 910205 Change-Id: I01cc1a4d38bd4108f6d609f7fdbea9d1c9de4446 Reviewed-on: https://chromium-review.googlesource.com/c/1355519Reviewed-by:
-
Justin Cohen authored
Enables WebKit based side swipe, and only enables Chrome side swipe when the page swiped page is to or from an NTP. This reverts commit 1baa2855. Change-Id: If29fd2c98bf475bfe9251e3eae18b24cb9c9c773 Reviewed-on: https://chromium-review.googlesource.com/c/1352958Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612289}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eee0f6ad0df5..b88aa2d8ba8e git log eee0f6ad0df5..b88aa2d8ba8e --date=short --no-merges --format='%ad %ae %s' 2018-11-29 charliea@chromium.org Fix typos in expectations_unittest for Nexus 6P tests Created with: gclient setdep -r src/third_party/catapult@b88aa2d8ba8e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iee75e2f3ddff78c8d29f79b3a459545b74ecfd0f Reviewed-on: https://chromium-review.googlesource.com/c/1355559Reviewed-by:
-
