- 19 Jun, 2020 40 commits
-
-
Muyao Xu authored
Add metrics to measure the usage of self-mirroring on Slides and Meet. The metrics record whether audio playback happens on the sender device (used on Meet) or the receiver device (used on Slides). Bug: b/158093883, 1095967 Change-Id: I6baa2af56671a3085c16e7d317c5a4349ebd0ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247326 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#780385}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6e722f2eaa58..f594ffdc357a 2020-06-19 sebras@gmail.com [cff] Fix another two memory leaks (#58629). 2020-06-19 sebras@gmail.com [psaux] Fix memory leak (#58626). 2020-06-19 sebras@gmail.com Fix memory leak (#58624). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ice90c0e8cf7b97013ae5bead79c1ac38b3fdf5e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254719Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#780384}
-
Etienne Bergeron authored
Thread priority should not be modified after a test. If that is happening, it needs to be fixed in the code. This CL remove the code that disable the priority checks. NOTE TO SHERIFF: * please paste failure logs when reverting, the goal is to remove flaky tests related to thread priority. * assigned flaky test to etienneb@ Bug: 1097092 Change-Id: Id39eac9370d7f554ea16562f422818a44a539adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254579 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#780383}
-
Alex Gough authored
This is a reland of c3de1340 Original change's description: > Adds icon loading service with sandbox for Windows. > > Adds a new |SandboxType::kIconReader| with token and integrity > levels that allow PrivateExtractIcon to do its thing. The service is > only used for PE files which, as a complex format, should not > be parsed in the browser. Other icons are found based only on a > file's extension. These are handled in the browser as this is both > faster and allows a tighter sandbox to be applied to the PE file > parsing. PrivateExtractIcon (a documented but discouraged Windows API) > is used instead of SHGetFileInfo as SHGetFileInfo requires COM > which considerably weakens sandboxing. > > Adds basic icon loading test for all platforms. > > A follow-on CL will add a fallback for PE files for which no embedded > icon is available. > > Testing: adds a unit test for groups, plus > manual testing on Windows 7 x86 and Windows 10 x64. > > Bug: 1032250 > Change-Id: I6975e5612d8b6f35e3216a67fc98592a45895c1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987273 > Commit-Queue: Alex Gough <ajgo@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779502} TBR=robliao@chromium.org Bug: 1032250 Change-Id: I7b5bd3c66ff7c6935939c1f21ef9c45384183522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252842Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#780382}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/75c9c5bd26ae..d4928d03e285 2020-06-19 egdaniel@google.com Implement flush finish proc support for d3d backend. 2020-06-19 michaelludwig@google.com Revert "Snap coordinates for shader nearest-neighbor decal filtering" 2020-06-19 brianosman@google.com Add ceil to skvx/skvm/JIT, and floor/ceil intrinsics to ByteCode 2020-06-19 kjlubick@google.com HTML typo egde => edge 2020-06-19 robertphillips@google.com Fix flippity GM for *ooprddl configs (take 2) 2020-06-19 bsalomon@google.com GrTextureGradientColorizer uses GrTextureEffect 2020-06-19 michaelludwig@google.com Snap coordinates for shader nearest-neighbor decal filtering 2020-06-19 robertphillips@google.com Revert "Fix flippity GM for *ooprddl configs" 2020-06-19 johnstiles@google.com Optimize CPP code generation. 2020-06-19 robertphillips@google.com Fix flippity GM for *ooprddl configs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I12d558184ba84ca3c589db70006fc04ef5433b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254212Reviewed-by:
-
Nate Chapin authored
* Remove Document::SetReferrerPolicy and OutgoingReferrer, use the LocalDOMWindow variants * Remove most of the uses of Document::GetReferrerPolicy Bug: 1029822 Change-Id: Ic986b75733fc217e268dc0e5fbcb4db8ffe67073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250787 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#780380}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592568001-645f451bc013d681af722dc2b85e4992534cb0fa.profdata to chrome-win64-master-1592582404-8222a440e7e5a063efaa22c6430adc77286858ae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I6b6135c48c5bf2d0cb7835afc22d2d5767714945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254462Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42bed4306e2e..cb20536fca26 2020-06-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I693c354ab7fd084a788ff22f89511a30effecd01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254718Reviewed-by:
-
Siye Liu authored
Interim character selection is a standard UI element of Korean and some Chinese compositions. The interim char selection spans exactly one char and is visually represented as a solid rectangle behind the text, which is the visually the same as text selection highlight. In order to render the blue background highlight during composition that has interim char selection, we need to introduce a new flag |interim_char_selection| in ui::ImeTextSpan and new flag |interim_char_selection_| in blink::ImeTextSpan. If the flag is set to true, then one composition marker is added with background color equal to active background text selection highlight color. Bug: 1095682 Change-Id: If06b0ce38c2993427c04efecf6f3e2e4d9f6ec7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249051 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780377}
-
Dana Fried authored
Tab group underline animation is now tied to tab and tab group header animation and dragging, rather than the underline repositioning itself during OnPaint(), which caused visual artifacts. Appears to also solve crbug.com/1094043 Bug: 1095954, 1094043 Change-Id: I7aab620c16e69366ffed65ee7599b8731833e428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250588Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#780376}
-
Aaron Krajeski authored
These tests are already flaky, but are also causing crashes and timeouts. http/tests/devtools/console/console-object-preview.js http/tests/devtools/console/console-preserve-scroll.js http/tests/devtools/console/console-search.js TBR=szuend@chromium.org https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/18959/blink_web_tests/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/18958/blink_web_tests/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/18957/blink_web_tests/layout-test-results/results.html Bug: 1046784 Change-Id: Id3182dcd2f56f5a6536f4dc03f4b69e00ea7a11e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254580Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#780375}
-
Aaron Gable authored
Change-Id: I95178dde14672080b562d1cccbb978509adddd2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216569 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#780374}
-
Michael Crouse authored
The original check for clearing hints when a new optimization type is registered the first time is racy because of when register is called by OptimizationGuide clients. This change adds additional logic to either clear if the store is available when the type is registered or defers until the store becomes available. This also changes the first run experience logic to only clear hints that are also persisted to disk, which currently is only host-keyed hints. Bug: 1068754 Change-Id: I1bc2df217c178b4ef257380c3efd04740a07468b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252478 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#780373}
-
David Schinazi authored
This CL replaces instances of flag-setting with calls to QuicEnableVersion and QuicDisableVersion. Some tests were using version flags as any flags, and those have been replaced with test flags. This will make changing versions easier. R=renjietang@chromium.org Change-Id: Id96f2fc92a10de3e410b4995190582e657dc57dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253209 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#780372}
-
Paul Moy authored
Report two new disk statistics: I/O and discard time. Bug: chromium:1067670 Change-Id: I98234cb745501574f758842d3939c147cdfd610b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242199 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#780371}
-
Daniel Vogelheim authored
The Function constructor is defined in terms of string operations, and will thus string-ify its arguments before constructing the actual function. TrustedScript instances passed into the Function constructor will thus work as specified, but not as expected, and their contents will still undergo the TT check. Fixing this requires ECMAScript changes in TC39, which are being considered, but not(yet?) approved. This adds a message to alert developers to this pitfall. See issue for details. Bug: 1087743 Change-Id: If414e6476bd778203e7f69f7d6a78019f26c5034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246149 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#780370}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592568001-0b6b26a9a978d83410a95ed47a0a1a3dcdc59066.profdata to chrome-win32-master-1592571521-6d5e90687ec4debf3bbc06836041d35bc022b0d5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8d1bf9f5fe349f88573a3e57b54dcf5e9f719a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254206Reviewed-by:
-
Chris Lu authored
This change adds SaveCardInfobarBannerInteractionHandler and SaveCardInfobarBannerOverlayRequestCallbackInstaller to handle banner responses. Mock delegate and InteractionHandler classes are added to allow for testing of the added classes. Bug: 1071914 Change-Id: I4d58b9443458946a9001aa73f6e79015e8198db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250896 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#780368}
-
Sorin Jianu authored
Such code leads to circular dependencies between //chrome/updater:base and //chrome/updater/win:base. The platform-specific sources has been moved to //chrome/updater:lib Bug: 1097123 Change-Id: I739d609d8aa90b91ce151aae483f543fa81b7880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254701Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780367}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/73bba61486a0..c72bf636e9e3 2020-06-19 hashimoto@google.com cros_chrome_sdk: Add --official and --chrome-branding If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ifef33b40cdfe08e400b39180516838f6f94e5569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254201Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idac13e3dcb97f079284cfc0ad7160c4131b33629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254346Reviewed-by:
-
rbpotter authored
- Add pak_base_dir option to map generated files based on a root directory other than the directory where the pak file is located. This is the case for the os settings build, where the pak file is under gen/c/b/r/settings/chromeos, but paths should be based on gen/c/b/r/settings. - Add exclude option to exclude certain files from being unpacked. This is to allow UIs like the NTP, downloads, and OS settings to keep files that should not be created by unpack_pak in their grd files. - Add an assert, ensure unpack_pak.py never creates files/directories outside of the unpak folder in future. Creating these directories can cause post-CQ build failures due to race conditions, as seen in the linked bug. Bug: 1093405 Change-Id: If85ea9f08c4dbe008ec16ca0a457390012833c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251050Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#780364}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/42f585a5ad09..f18c0ac2f735 2020-06-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-06-19 tvanderlippe@chromium.org Remove style three-dot menu in favor of autocompletions 2020-06-19 tvanderlippe@chromium.org Add missing e2e resources to BUILD.gn 2020-06-19 soxia@microsoft.com [DevTools] More info for Service Worker Fetch Responses 2020-06-19 petermarshall@chromium.org Disable tests to unblock chromium roller If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1066595,chromium:1088463,chromium:1097061 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9051e2654d1611b009d4df5ab50b15eaa921e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254210Reviewed-by:
-
Dave Tapuska authored
Convert these two messages to mojo messages on the blink WidgetHost interface. Calculation of the composition bounds, current input type are all moved from RenderWidget into WidgetBase. Some intermediate plumbing is required since not all input is in blink yet. BUG=1073560 Change-Id: I67bf118049d3bf186bdd4ff261f25917c097ee17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243531 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780362}
-
Chris Sharp authored
Change-Id: I2e8e6b066fee60218dcc8de247ea79a80318b842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252741 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780361}
-
Bailey Berro authored
Per discussion over email, change to "Small" and "Large" Change-Id: I3952847bcffd44202c3ec9dd6285e58d4e2de1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253204 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#780360}
-
chenjiadong authored
Previously,we judge whether the current media contains a video track to decide to pause the current playback after switching to the background. Because the media played through MediaPlayer are assumed to contain both audio and video tracks, they will all pause. In this scenario, we should judge whether the original size of the current media meta video is empty to determine whether it contains a video track. Bug: 1093697 Change-Id: I702465f677d9dd01b827051b21f77c20633a80c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241053Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#780359}
-
Vincent Boisselle authored
Bug: 1096614 Change-Id: Ib52bebaaca8cf2f361ed6ddf496e2ecb6fcc476f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252923Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#780358}
-
Maxime Charland authored
This CL is part of the Chrome Empties project for Bling. (Googlers only links) Design Doc: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing UX Specs with mocks: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1093575 Change-Id: I82b4914111f0b7a3f6050f8929b10bf7008e980b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246623Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#780357}
-
Mohamed Amir Yosef authored
When the account reauth fails, saving location is automatically switched to local store. In addition we should an IPH to make it clear to the user that the password will actually be stored locally. Namely this CL is doing the following: - Cache the results of reauth in ManagerPasswordState. - Adds plumbing for this value in UI controller and bubble controller. - Use the value in the view to show the IPH when the reauth fails. Screencast: https://screencast.googleplex.com/cast/NTk0NzE0NzA4ODI5Nzk4NHw0M2ZkYzk1Zi05OQ Bug: 1044038 Change-Id: I8ba4bc718fb322ec391b1292c1475eea3027dad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252239Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#780356}
-
Sean Gilhuly authored
This test needs a separate baseline on Windows using real GL. TBR=kbr@chromium.org Bug: 1096568 Change-Id: I20e8fbad74a0f1932bcc257137f851392327f724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254520Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#780355}
-
Michael Ludwig authored
Bug: 1097104 Change-Id: Id155df59b7e57cfc5db05988123d38197ba8d8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254083 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#780354}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/051c6fed884b..e20ac35adbfd 2020-06-19 johnkslang@users.noreply.github.com Merge pull request #2281 from ben-clayton/moar-kokoro If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I4ce39e968430f46df6e11b88cecefb3dbfc19a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254209Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6c42c47badbc59742f907f87d9e7223a8f3ed2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254340Reviewed-by:
-
Collin Baker authored
A previous UAF fix, https://chromium-review.googlesource.com/c/chromium/src/+/2242435, introduced this new UAF on browser shutdown. The new crash is likely caused by logging the session duration on Profile destruction. This logging was added in the previous fix but the new crash wasn't caught in the CQ. This CL drops the logging but still ensures ProfileActivityMetricsRecorder's Profile pointer is dropped when it's deleted. Fixed: 1096395 Change-Id: I3c357c18029c57a70f99a8be76fef376cda2b3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252657 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#780351}
-
chrome://internals/query-tiles.Hesen Zhang authored
Fixed closure build failure. set closure_compile = true in gn args and verified locally. This is a reland of 7981cdda Original change's description: > Setup chrome://internals/query-tiles. > > - Setup chrome://internals for future merge. > - Complete the front end code for chrome://internals/query-tiles. > > Bug: 1066556 > Change-Id: I51529f6e11dd37e15df2b7a3da1864dbbc5da58b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247544 > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780087} Bug: 1066556 Change-Id: I732e90165cf9a4489c84e3a364aaa063fb1a4218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253212Reviewed-by:
-
Khushal Sagar authored
R=zmo@chromium.org Bug: 10253933 Change-Id: I04269785755d7d606bde28375d8cd60fafddc0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253565 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#780349}
-
Regan Hsu authored
* Tooltip should be on RHS * Previously, refreshing DLC subpage would result in no DLCs being shown. Fixed: 1096354 Change-Id: I20feb64a36137cb22fa35b2e34526440728b8130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252847Reviewed-by:
-
Regan Hsu authored
Fixed: 1096430 Change-Id: Id2225cf0c19a55228adef2e207eca32c179cd16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251749 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3133dfdb809431669c15dc91e2a861cf85787298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254207Reviewed-by:
-
