- 11 Oct, 2019 40 commits
-
-
danakj authored
The WidgetInputHandlerImpl always checks that the RenderWidget is not undead before calling into it, so these methods always have a WebWidget present. The context menu method is an IPC handler which is only received when not undead or provisional, so it always has a WebWidget present. SimulateImeFinishComposingText() is never called. ImeCommitTextOnMainThread() is called from RunOnMainThread() which only executes the callback when the RenderWidget is not undead, so a WebWidget is always present. R=avi@chromium.org Bug: 419087 Change-Id: I1b29030638f9e31f6c5646c5e6894f07a1e9b860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856718Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#705240}
-
John Lee authored
- The entire favicon container, including the loading spinners, should be hidden when TabRendererData has show_icon set to false (ex: New Tab Page). - The favicon itself should be hidden whenever a tab is still waiting. - The favicon itself should be hidden whenever a tab is still loading and the favicon is the default favicon (the globe icon). This is an effort to mimic the behavior of the existing tab strip. Bug: 1004985 Change-Id: Ide7f2daa2c72bfed2a072c40ea1eac00f894ab31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853848 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#705239}
-
Allen Webb authored
This will record if USB devices are attached before sign-in, after sign-in, or at the lock screen, along with the device class. Bug: 1011122 Change-Id: I83ad38b3d1fcb8e805de4014e81dda8c603d2d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838526Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Allen Webb <allenwebb@google.com> Cr-Commit-Position: refs/heads/master@{#705238}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d99c8fdb68b..0912f5e649f3 Created with: gclient setdep -r src-internal@0912f5e649f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4ce7df6ed436e56168c4797dd71a7f8a5ac882eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856589Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705237}
-
Morten Stenshorne authored
Whatever comes before the start of the column (due to negative margins) shouldn't affect the block-size of balanced columns, since it won't take up any space in them. This fixes two tests, although that means that they'll now crash, :-P because of incomplete fragment painting support. When loaded manually, the tests pass, but when run by the test runner, they crash, presumably due to differences in how the layout tree is treated after the page has loaded and displayed, or because we're using a different allocator? There's a pointer to a dead object in there; see crbug.com/994172 Bug: 829028 Change-Id: Ida3a5269f93672e01c3a7572fc919af0b8fede84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855739Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#705236}
-
Henrique Nakashima authored
Use the flag map through generic methods instead. Move the check isHighEndPhone() to the flag caching. This is a slight functional change since isHighEndPhone()'s value is not necessarily stable through a Chrome run. Bug: 1012975 Change-Id: Ifc245b486eae29410278b3733306c37f5cca0c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853858 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705235}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5740f3e2b8fd..80f53b785b37 git log 5740f3e2b8fd..80f53b785b37 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 eladalon@webrtc.org Extend WebRTC-Video-MinVideoBitrate to experiment per-codec 2019-10-11 srte@webrtc.org Merging TransportFeedbackAdapter and SendTimeHistory. 2019-10-11 terelius@webrtc.org Plot delay feedback in RTCP arrival order. Created with: gclient setdep -r src/third_party/webrtc@80f53b785b37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ie49046d51007f7106bdf09d28f0ad8b761747753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705234}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4e284d62..8be37a6d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I17b9d2ffe23d8417bf72f74c7f4f1508c735670f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855402Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705233}
-
Yi Gu authored
The feature has been run on stable(1%) for over a month and the metrics are as expected [1]. Turning it on by default on non-cros before pushing it to 100%. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=874919#c45 Bug: 874919 Change-Id: I08e4271ae2e12b58f52c47bd25f5326288c0be81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856620Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705232}
-
Justin Cohen authored
Don't expose internal placeholder URLs to the UI and to URL-sensing components outside of //ios/web layer. Instead, set virtual URL to the placeholder original URL. Bug: 1003680 Change-Id: Ibcdc2a88814ea33d985aa6cc269d916e88d59683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855299Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#705231}
-
Andrew Xu authored
Now in ScrollableShelfView, |shelf_container_view_|'s bounds change depending on the layout strategy. In this CL, |shelf_container_view_|'s bounds are never changed. Instead, its layer is clipped and the clip rectangle is calculated with the layout strategy. It lays the basis to solve the issue 1009368. This CL should not introduce any visual change In detail, this CL does the following things: (1) For |shelf_container_view_|, use layer clip instead of setting bounds. (2) Handles the tooltip correctly. In the current code, we use |shelf_container_view_|'s bounds to decide whether to show/hide the app icon's tooltip. (3) Handles located events correctly. |shelf_container_view_| should only handle those events within the area after clip. Bug: 1009368 Change-Id: Iead6a53da1d06d831d13a7847722f51ea5c9b9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849096 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705230}
-
Ben Kelly authored
This CL adds the CacheStorageEagerReading feature. When enabled cache.match() responses will be eagerly read if the call was made during a FetchEvent with the same URL. When this occurs the body of the response will be contained in a mojo::DataPipe. The blob is still passed via the side_data_blob field in order to support reading code cache. This CL also moves the previous use of the response |side_data_blob| field for storing code cache into cache_storage to a new field called |side_data_blob_for_cache_put|. This is done to avoid confusion over how to read the code cache out of the value. When putting into cache_storage the code cache is stored in the primary data stream, but when reading out of cache_storage its in the side data stream. With additional work on blobs it should be possible to unify these in the future. Bug: 1010624 Change-Id: If6ae293e48f7db07f15690692755c03c453f6254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836391 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#705229}
-
Oriol Brufau authored
The specification added a step to increase sizes to accommodate spanning items crossing flexible tracks instead of ignoring their contents completely. This is done after handling all grid items that don't cross such tracks, and this time items are considered together, not grouped by their span size. Spec: https://drafts.csswg.org/css-grid/#algo-spanning-flex-items BUG=935102 TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html TEST=third_party/blink/web_tests/fast/css-grid-layout/flex-and-content-sized-resolution-columns.html TEST=third_party/blink/web_tests/fast/css-grid-layout/grid-gutters-and-flex-content.html Change-Id: Ic91a2eb471fae23cde1570c461f491cd5335d771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492337Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#705228}
-
Rohit Rao authored
Removes the ios12-beta-simulator FYI and try bots. BUG=934252 Change-Id: I26f076db0fc97d8cc2dd72b0198c5984a6bc5592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852486Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#705227}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome BUG=762641 TBR=rkc@chromium.org Change-Id: I6e3d2cabb591f4d82b496a69956bdbfa27f5e959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856684Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705226}
-
Ian Kilpatrick authored
This is needed for BoxFragment painting (and FragmentItems work?) as a box (without a NGPaintFragment) can have "outline: solid" which needs to be painted. Bug: 988015 Change-Id: Ib58b228c671a5e7e9e36152d3aa0add893087238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856540 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#705225}
-
Sebastien Marchand authored
Bug: 980533 Change-Id: I3c4f1e12e048ba953500d8f7173220e04da997ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856879 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#705224}
-
Tommy Steimel authored
This CL updates the DialogContainsText logic in MediaDialogViewBrowserTest to more explicitly depend on the structure of the MediaNotificationView. Bug: 1008905 Change-Id: Ia6350710dbf70b07dcaa9a9473ece3969f8942eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854663 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#705223}
-
Moe Ahmadi authored
This is a follow up to crrev.com/c/1809966. Disables Vasco chips in the NTP when zero-prefix suggestions are enabled using omnibox::kOnFocusSuggestions Bug: 996516 Change-Id: I8ee718d710fd150eabf4f2943cdc9b489a76b33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856861Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705222}
-
Ken Rockot authored
ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within media, geolocation, and permissions related code. This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: I48856217d97c1b5d0acf44c4b36ebb138a3beee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850731Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#705221}
-
Alison Maher authored
WebThemeEngineImplDefaultBrowserTest.GetSystemColor fails non-deterministically on Windows2008Server. To fix this, the test is updated to only run on Win7 and above. Bug: 1010924 Change-Id: Ibda98ca611c27176ff831d0c85462579ae2c37dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856578 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
-
Alex Cooper authored
This feature is intended to ship in 79, so the feature needs to be enabled. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/CHCM_xALBG4/JeQQYkONBwAJ Bug: 1007537 Change-Id: I3e4dac8da7a24806e652ef3d97f8e1fb7bee6daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823881 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705219}
-
Rune Lillesveen authored
Direction and writing-mode is propagated from body to the viewport, but when the computed value of those properties are different between the root and body elements, their used values are the computed values of the body element. The computed values are not affected by this. We implement this propagation by using a ComputedStyle on the HTMLHtmlElement's LayoutObject which has the propagated values for direction and writing-mode. The modified tests relied on direction on #container being different from the #container parent. That is no longer possible with body being container and the used direction value of body propagated to html. The tests were modified to use a child of body as container instead, the removed 8px margin was just replicating the body margin and we do not want that on the #container div. Spec: https://drafts.csswg.org/css-writing-modes-3/#principal-flow TEST=external/wpt/css/css-writing-modes/wm-propagation-002.html TEST=external/wpt/css/css-writing-modes/wm-propagation-body-033.html TEST=external/wpt/css/css-writing-modes/wm-propagation-body-037.html Bug: 988585 Change-Id: I2879c8fdc082940d2baaf67e126b28915f9f1eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852786 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Marialicia Villarreal Garcia authored
This change intends to fix touch with a screen reader in nested elements across the browser frame, as the tabs and the location bar. The issue here is that the focus ring is the first child found and returned by HitTestSync and does not allow to continue looking for the nested view child. For example, if touching the bookmark button inside the location bar, focus ring (which covers all the area of the location bar) will be found before the bookmark button. This fix adjusts HitTestSync by now calling View::GetEventHandlerForPoint which returns the hit child on the view. Then we still iterate the children of this view since we need to return the deepest-most child it can find. The benefit on calling now GetEventHandlerForPoint is that this method already knows how to handle overlapping views. Bug: 990560 Change-Id: I9076c3dfaa1424b69eb49b83c07b10ebeb26776d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817289Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Maria Villarreal <mavill@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705217}
-
Shawn Gallea authored
This is to allow associating cast apps with platform views. WebviewService will be deprecated in future change. Bug: b/136460199 Test: Compile cast_shell Change-Id: I5bad0fe7817ec65e3719d9c43d0b08fcb679cd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856278Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#705216}
-
behdad authored
Now there are 16 pages in mobile representatives, 15 pages in desktop (Windows) representatives, 16 pages in desktop (Mac) representatives, Page below visualizes all the clusters of each platform, over the data capture in the past 50 days. https://x20web.corp.google.com/users/be/behdadb/clusterDashboard/charts.html The clusters re created using the scripts provided in tools/perf/experimental/story_clustering with some modifications which I'll upstream. New upper limits are set for representatives, which will be temporary and after collecting one week of data on gpu-fyi bot we can adjust and update. The current limits are chosen based on the last 50 values on dashboard for each story. TBR=crouleau@chromium.org Bug: chromium:1011969 Change-Id: Ie9ed124e162dbcc161365fbc93d18c2efa3580e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846232 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#705215}
-
Alex Cooper authored
There are some potential breaking changes for the WebXr gamepad module that may make it so that it cannot be shipped at the same time with the main WebXr Device API. Adding this flag enables the flexibility to ship the WebXr Device API without the optional Gamepad module if breaking changes are needed to the gamepad module. Bug: 1013415 Change-Id: I2c79a2a9991a6497197357ecc9f38719b0379a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854863 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
Jenny Wong authored
This reverts commit 776645cc. This CL was reverted because it caused on-device crash loops: base::CreateSequencedTaskRunner() would fail on a DCHECK because of lack of access to |g_thread_pool|. Now that the libcast_media_1.0_audio target is statically linked when possible, this is no longer an issue. See: https://chromium-review.googlesource.com/c/chromium/src/+/1846314 Bug: internal b/135280530 Change-Id: Ib84ff58f17dec31abe3ba438a1a87a53763942af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848576Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Jenny Wong <jyw@google.com> Cr-Commit-Position: refs/heads/master@{#705213}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/af9c6ce85491..4d4275fc6a5d git log af9c6ce85491..4d4275fc6a5d --date=short --no-merges --format='%ad %ae %s' 2019-10-11 achuith@chromium.org flash: Prefer full_payload download. Created with: gclient setdep -r src/third_party/chromite@4d4275fc6a5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic27275d31bd1c1e63b92441e56b5c96cc61ac33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856627Reviewed-by:
-
Ken Rockot authored
ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within Chrome Notificatios, Push messaging, Sharing, and Autofill browser tests. This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: I81ab8aa383c385c90980377842656c402d8dd2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850734Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#705211}
-
Andrey Kosyakov authored
Bug: 1013000 Change-Id: I225064e4cdbeab4ed23588df8ec0154f00d6dd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851225 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#705210}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I556dc4abd7e9688782bdbaced5198d06561b8c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855420Reviewed-by:
-
Kristi Park authored
It's possible for width to be non-zero while the icon is hidden. In this case, we do want to grow the label starting from 0 width. Change-Id: I80d6d216aef5f5ec8d849fd844ce21e38079f863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850966Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#705208}
-
Mathieu Binette authored
I updated the chromium bot configs to exclude Chrome-only tests in https://crrev.com/c/1838375, but the new category filter flags are not available in the CELab package we use in chromium/src, so this broke our bots. Oops. Updating the package will fix this. Notable changes since the last version: - Implement @category & filter arguments for EnterpriseTestCase: https://crrev.com/c/1823607 Bug: 1013507 Change-Id: I0aeee6021d25b2a3dd0f514f35821dd66069c4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856398Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#705207}
-
Piotr Bialecki authored
This CL brings in changes in mojo and browser needed to surface the subscription-based variant of the API to JavaScript. The explainer can be currently found in the following URL: https://github.com/immersive-web/hit-test/blob/master/hit-testing-explainer.md Changes related to floor height estimation are due to the fact that in order to implement hit test for local-floor reference spaces, the current height estimation needs to be known to ArCoreImpl. Additionally, if we ever decide to estimate the floor height more intelligently, it would have to be done in ArCoreImpl so it's one more reason to move floor height information there. Bug: 928481 Change-Id: I2d21bfa021c3a238455dd3489353233c5c848a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829942Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#705206}
-
Toby Huang authored
Site Settings page currently shows the enterprise "office" icon instead of the "kite" icon for supervised users. This CL fixes this and ensures that the kite icon and "This setting is managed by a parent." tooltip is shown in Site Settings when a supervised user is logged in. Bug: 1005547 Change-Id: I91d81337b3f1b5cd070163ecc032a1695592dc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838652 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#705205}
-
Collin Baker authored
This moves Browser away from listening to for INVALIDATE_TYPE_AUDIO for audibility state changes. This is part of a refactor detailed in the attached bug. Bug: 846374 Change-Id: I09cd8395c16bba812e9417f2ca6364d43864d39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854214 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705204}
-
chrome://webapksdpapad authored
Use JS modules instead, since HTML Imports are being removed. Replace CallJavascriptFunction() with FireWebUIListener(), since within a JS module context, all variables/functions are private (unlike previous behavior of being global), and can't be called from the outside Bug: 937747 Test: Visit chrome://webapks, should no longer see HTML import warnings in DevTools. Change-Id: I4319d6b78a9a4c370a2f9152e7448e7c3325adf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850271 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#705203}
-
Oystein Eftevaag authored
Tracing_controller_impl.cc/.h now uses the Consumer Mojo interface rather than the old Agent/Coordinator interface, allowing the latter to be deleted in the next CL. As part of this, the option to anonymize the data has to be moved from the TraceConfig struct to be an explicit argument to StopTracing instead, as the filtering/whitelisting done at JSON export time needs the full unfiltered proto data available. BUG=839086 Change-Id: Id73b73a1cdbc6c7a6c8d343c391136abc5914743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817207Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#705202}
-
Jacques Newman authored
Bug: 1012831 Change-Id: I40adeaa1c625ee45f21cd3cc1f1ada50d8760c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854719 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
