- 12 Mar, 2020 40 commits
-
-
https://crbug.com/1006814Fergal Daly authored
The widget host is unexpectedly initialized when we go to initialize the view. So, check at the earliest stage possible if the widget host is already initialized. If it's not, then finding out when and how it flips should be easy. Bug: 1006814 Change-Id: I0a592c9411323ef8966357da960e347cb2647d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100588 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#749962}
-
Nektarios Paisios authored
This is a class that puts down the foundations for re-writing the Views accessibility on top of the AXTreeSerializer/Unserializer and an AXTree, exercising the same code as in the web contents. Bug: 1049261 R=dmazzoni@chromium.org, kbabbitt@microsoft.com Change-Id: If8ce232279cc53f9fbf5097bb86f84930d532e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067151 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#749961}
-
Victor Costan authored
This CL refactors the plumbing for the Quota (Storage) API in the browser process, to bring it in line with other modern implementations of storage APIs. 1) QuotaDispatcherHost is renamed to QuotaManagerHost. The old name was misleading, because *Dispatcher* classes tend to be singletons, or at most have one instance per RenderProcessHost. The renamed interface is already instantiated once for each connection from a frame or worker. The renaming was mostly carried out using the mechanical substitutions below: * QuotaDispatcherHost -> QuotaManagerHost * quota_dispatcher_host -> quota_manager_host * QUOTA_DISPATCHER_HOST -> QUOTA_MANAGER_HOST 2) The url::Origin parameters are removed from QuotaManagerHost methods, and are replaced with an Origin member provided at construction time. The origin is supplied from BrowserInterfaceBinders, and therefore known to be good. This is a security improvement over the current situation, where Origin parameters are received from the renderer process. 3) A QuotaContext class is introduced between StoragePartitionImpl and QuotaManagerHost. This is an improvement over the current situation, where each QuotaManagerHost is owned by its mojo connection, and holds a reference to storage::QuotaManager. After this CL, StoragePartitionImpl owns exactly one QuotaContext, which owns all QuotaManagerHost instances via a mojo::ReceiverSet. QuotaManagerHost only holds a raw pointer to storage::QuotaManager, because we can rely on QuotaContext to own storage::QuotaManager and keep it alive. 4) In the Blink-side quota implementation, enumerations in the blink::mojom:: namespace are replaced with their aliases in the blink::mojom::blink:: namespace. This is needed to make presubmit checks happy. Bug: 1030901 Change-Id: If424dfbaa22e01499fbf1b82dac0b1fb1211eacc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097545Reviewed-by:Chris Palmer <palmer@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#749960}
-
yilkal authored
This Cl adds 3 metrics for per app time limits. The metrics include: 1. Engagment recorded as the number of apps with time limit at the beginning of every session. 2. Number of updates to `PerAppTimeLimits` policy. 3. Number of apps with the limit set and recorded per policy update. 4. Number of blocked apps recorded per policy updated. Bug: 1059906 Change-Id: Ie6c307e9ce1c49dedd7d8549928efb612522e9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095083Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#749959}
-
Abhijeet Singh authored
This CL fixes the bug where the User-Consent view for Quick-Answers feature incorrectly displays the label-buttons by shrinking them for words of certain lengths. Bug: b:151294161 Test: Tested on Chrome OS VM Change-Id: I3b24abebd42ddbf735998360538f1cec76cc91e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100487Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#749958}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3c1179495673..595eb19165b3 git log 3c1179495673..595eb19165b3 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 ehmaldonado@google.com PRESUBMIT.py: Add timeout to tests. Created with: gclient setdep -r src/third_party/depot_tools@595eb19165b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ifbaeb5886527a7b97c1370c1c7dbe5825d603e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101595Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749957}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a4304ac5a864..d35a6865178a git log a4304ac5a864..d35a6865178a --date=short --first-parent --format='%ad %ae %s' 2020-03-12 srte@webrtc.org Reland "Fix for out-of-bounds write in square test frame generator." Created with: gclient setdep -r src/third_party/webrtc@d35a6865178a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia077fefce81640baf7d12d63d517bff02681447c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101429Reviewed-by:
-
Rushan Suleymanov authored
This patch introduces a new field to store full title of Bookmark without truncating and escaping of symbols. Bug: 1058376 Change-Id: I9b8ec53406d1831d210b7ee97590b632ef41ea0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095549 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#749955}
-
Noel Gordon authored
Wheel events over the drop-down menu (a <dialog>) will draw file-list and file-grid view vertical scrollbars. However, user cannot interact with (let alone scroll) these views while the menu <dialog> is open. Do not draw the file-{list,grid} vertical scrollbars if the drop-down menu <dialog> is open: disable file-{list,grid} CSS overflow-x. See CL:2098169 for the related change to the directory tree. Bug: 1035691 Change-Id: Iad0f060889eaf12188e3a32a893667853c6ee0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100428Reviewed-by:Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#749954}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0d44b517474f..40469eb52e4f git log 0d44b517474f..40469eb52e4f --date=short --first-parent --format='%ad %ae %s' 2020-03-12 oksamyt@chromium.org Disable testPlayWaitForEnded for chromeos Created with: gclient setdep -r src/third_party/catapult@40469eb52e4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:855885 Tbr: rmhasan@google.com Change-Id: Ie9d8acf11fdd97c8d0ec89b9329156051dc6aafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101588Reviewed-by:
-
Sunny Sachanandani authored
Only direct composition surface can create HDR swap chains so do not advertise HDR support without it. Doing so will cause the compositor to output to the incorrect color space (scRGB linear or PQ) which will appear either washed out or too dark. Bug: 1059112 Change-Id: I04fd12cd2ba187e42cdeb99741624853a661c526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090919 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#749952}
-
Bo Liu authored
Android specifically generally do not use exit_code or TerminationStatus to communicate how a "child" process exited. Android does not have real child processes; they are separate service processes forked from android's zygote. One scenario that is correctly detected is if the child process exists cleanly by quitting its main loop. So avoid treating case this in BrowserChildProcessHostImpl as a crash. This is in preparation fo cleanly shutting down the gpu process when not in need. Not Android will still call NotifyProcessKilled. NotifyProcessKilled is used more like a general process exited notification due to the reasons above, so keep calling it. Bug: 1058509 Change-Id: I07102e7ddbec7d68c8ce3d3ffaf5a3d56a4309fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100729Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749951}
-
Rob Schonberger authored
Note that this feels like it's missing from the other metrics here. Bug: chromium:1009290,chromium:1060051 Change-Id: I9c6de45943cff157415668430db928d32f0b07c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099348Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#749950}
-
Joel Hockey authored
Terminal system app currently has a tabbed window (TYPE_APP) and a settings page (TYPE_APP_POPUP). Both of these windows have the same app_id and should be tracked independently. Bug: 1058670 Change-Id: Ib7c44121b53f692981aba72c70e8cad960cc30b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094388 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#749949}
-
Bugs Nash authored
Bug: 1030935 Change-Id: I8c96d7681f7c7888950a2cabfbdf4ce63cd64eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099350Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#749948}
-
Qingwen Pi authored
The requirement was to get rid of the ToMediaBuffer() function from DecoderBufferBase. Created a subclass of ::media::DecoderBuffer that wraps the data of DecoderBufferBase. Merge-With: eureka-internal/371205 Bug: b/149771309 Change-Id: Idde0f6519e5122964f5eb33f6a44407e595898e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085600 Commit-Queue: Qingwen Pi <qwp@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749947}
-
Charles Zhao authored
(1) Navigating to a new url triggers a TabNavigated event. (2) Showing a tab triggers a TabForegrounded event. (3) Open another URL triggers a TabOpened event. Bug: 1012936 Change-Id: I330f280e41d39e652653918baded6ffca809900f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082422 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#749946}
-
Rakesh Soma authored
new local user. Bug: 1061228 Change-Id: I491fba5fe7dd6ff7eb1e564cf3ee27a675aa8366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101719 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#749945}
-
Nate Chapin authored
Use GetExecutionContext(), which should always be non-null, instead of GetDocument::ToExecutionContext(). Bug: 1060885, 1060969 Test: fast/dom/DOMImplementation/move-meta-to-createDocument-crash.html Change-Id: I89e652643323956415b9dd204c0349b03e360a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100715 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#749944}
-
Daniel Murphy authored
R=pwnall@chromium.org Change-Id: I1d29c19d2982b091eed6edea0d8816b30b1ebbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101381 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#749943}
-
Livvie Lin authored
Bug: 1058898 Change-Id: I131f6807fc654b6003a4e30169bb0d9f57b6aaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095152 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#749942}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08052a2e9556..f57bd0f33100 Created with: gclient setdep -r src-internal@f57bd0f33100 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iec390ab1a72ff472eb111c4c3881b7e01dfd0b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101163Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749941}
-
Mustaq Ahmed authored
The HTML spec was changed here: https://github.com/whatwg/html/commit/8f8c1f50158736b3cf16188377a0974a20367c8b Change-Id: I316217072fccffb4419c3eef477f641fc3aafa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097120 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#749940}
-
dalyk authored
This cl adds Net.DNS.UI.DropdownSelectionEvent.[Ignored,Selected, Unselected], Net.DNS.UI.ProbeAttemptSuccess, and Net.DNS.UI.ValidationAttemptSuccess. Bug: 1037944 Change-Id: I19ef70e58d370d42111532a192edd2dbc7bbe223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097000 Commit-Queue: Katharine Daly <dalyk@google.com> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Katharine Daly <dalyk@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#749939}
-
Ben Joyce authored
This is an unfortunately large CL, but these 3 need to migrate together as preference and appcompat extend fragments. weblayer is not migrated because of weblayer/public can't change as others use it for api calls. Bug: 1052460 Change-Id: I75a53705d76096e0d3f0c05807cfd68b2acca334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099028 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#749938}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I29c489186e2332bb5ec97ca8c1ca8062c48d3e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101238Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#749937}
-
Toni Barzic authored
Updates the logic for whether a drag handle should be shown to consider when back gesture and drag handle nudge were last shown, to ensure that they are not shown at approximately same time: * back gesture nudge is only shown if the drag handle gesture is not expected to be shown - i.e. if the drag handle has been shown within the last show interval * back gesture nudge is only shown if the drag handle nudge has been shown more than 1 minute ago * drag handle nudge is only shown if the back gesture nudge is not showing, or has been shown within the last minute While here, delay showing drag handle nudge if the shelf is hidden (given that the nudge would not be visible at that time). This requires updating the shelf nudges state when the shelf state changes (so the nudge is shown if the shelf is dragged up), instead of just on the shelf config changes. BUG=1060376, 1060462 Change-Id: I63292b0aacd3c61b6533459c19665dede64907ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099591Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#749936}
-
Caroline Rising authored
Bug: 1059716 Change-Id: Idda3439a4f4bb23a57a7229eda1843bfded5d03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096783Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#749935}
-
Donn Denman authored
Reverts support for the exact-search bit as a CoCa integration mixin. We got support for the additional parameter needed to support this critical feature correctly so we don't need the mixin. BUG=1060669 Change-Id: I86ef31a19305fcbb95cbf0883a3b928c79e12d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101538 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#749934}
-
Rakina Zata Amni authored
Find-in-page previously used idle tasks, which was changed by https://chromium-review.googlesource.com/c/chromium/src/+/2041711 - now we use tasks with very-high/normal priority. This CL adds an experiment where we use best-effort priority for find-in-page tasks to emulate the previous condition (using idle tasks) to experiment and compare the performance. Bug: 1057917 Change-Id: Ic3b10a41833766822c7aecddd164148c4eec22fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096795 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749933}
-
Ben Pastene authored
Includes desktop + cros duts & VMs. Bug: 812428 Change-Id: Icc115cf54094c1de3a51d5ef0d28b16622b5f07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101229 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#749932}
-
Zhongyi Shi authored
https://quiche.googlesource.com/quiche.git/+log/1c2d1ab18e85..3ecc53bf310c $ git log 1c2d1ab18..3ecc53bf3 --date=short --no-merges --format='%ad %ae %s' 2020-03-12 fayang gfe-relnote: Initialize packet_number_space to invalid value in GetRetransmissionTime. No functional change expected, not protected. 2020-03-12 bnc gfe-relnote: Change error code sent on unknown unidirectional stream type. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-03-11 renjietang Let QuicSession's various write methods set transmission type. 2020-03-11 fayang Internal QUICHE change 2020-03-11 dschinazi Enable additional warning 2020-03-11 bnc Rewrite QuicTypesTest.QuicIetfTransportErrorCodeString. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I1bdc374934728b1b8d708b3e0ac4fe204917bdd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101409 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#749931}
-
Sergey Ulanov authored
Each WebEngine integration test starts its own instance of WebEngine, but WebEngineDebugIntegrationTests were assuming that there is only one WebEngine instance running, so they were failing in some cases, particularly after new tests were added. Fixed WebEngineDebugIntegrationTest to handle the case when there are more than one WebEngine. Now WebEngine is started with an argument that allows it to distinguish different WebEngine instances. Bug: 955589 Change-Id: I768197db05c694bbb6593f8d1e003a2897ef7cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101244Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749930}
-
Oksana Zhuravlova authored
Example of failed build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/17499 Bug: 1061131 TBR=alancutter@chromium.org Change-Id: I0b7c61911508bdae5fae1b42531ea06955bfd804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101648Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#749929}
-
Xianzhu Wang authored
Change-Id: I0442482b9f867a4764c6ffb67e061dceb44b69c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097544Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749928}
-
Daniele Castagna authored
When applying a backdrop filter, it is possible to specify a quality factor that will be used to resize the canvas Skia uses to apply filters. CrOS UI takes advantage of this scale factor. Reducing the size of the canvas used for the UI blur decreases GPU load without significantly affecting the blurred result quality. Currently the whole area needed for the backdrop blur is copied from the framebuffer to a texture, then blitted/scaled to the canvas. This CL uses the same factor to scale the texture as it's read from the framebuffer, reducing significantly bw on the GPU, and reducing the size of the image that needs to be allocated for the backdrop. Test: viz_unittests --gtest_filter="GLRendererPixelTestWithBackdropFilter.FilterQuality" Change-Id: I828ac15bd042641c9143ecd1238c2e8b3fdb6085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093016 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#749927}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/77b43d681f65..7454c94414c0 git log 77b43d681f65..7454c94414c0 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 capn@google.com Fix building with latest LLVM Created with: gclient setdep -r src/third_party/swiftshader@7454c94414c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I68d60383c1f2672f5ec4be3628afae59972b7e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101165Reviewed-by:
-
Manas Verma authored
Currently the checkbox on the CVC prompt is always shown if the flag is turned on. However, it should be hidden in the case that the user is not verifiable or GetDetailsForGetRealPan returns false for `offer_fido_opt_in`. The information of whether or not to show the checkbox on the card unmask prompt on Android is stored in CreditCardAccessManager. This information needs to be propagated to CardUnmaskPrompt. The path is as follows -- 1. CreditCardAccessManager (implements CreditCardCVCAuthenticator::Requester) 2. CreditCardCVCAuthenticator (implements FullCardRequest::UIDelegate) 3. FullCardRequest (implements CardUnmaskDelegate) 4. CardUnmaskPromptController 5. CardUnmaskPromptViewAndroid 6. CardUnmaskBridge (Java) 7. CardUnmaskPrompt (Java) Bug: 949269 Change-Id: I5b747856604750f8a30da066ffda84e9c3cda7ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087983Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#749925}
-
Bugs Nash authored
Adds Media App as a built in app and adds web apps as accepted task type for fallback file handlers. Because FindExtensionAndAppTasks appends web tasks the the tasks list first, the Media App is selected as default before the Gallery app (a file handler task) is considered in ChooseAndSetDefaultTask. Bug: 1030935 Change-Id: I70c83876a77391a4589c649f347b1001990dd1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087203Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/621f40b7a140..25016e3eb5ac git log 621f40b7a140..25016e3eb5ac --date=short --first-parent --format='%ad %ae %s' 2020-03-12 lalitm@google.com Merge "api: fix compile on mac" Created with: gclient setdep -r src/third_party/perfetto@25016e3eb5ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic7d4403a5be83362083c78cc2a795c61a12288c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101590Reviewed-by:
-
