- 29 Oct, 2020 40 commits
-
-
Richard Townsend authored
Corrects a build error resulting from a mismatching GUID for this component. Bug: 1143261 Change-Id: Id179d0a0927a6e85c1053d4a44475635c3dc93f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507290 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#822139}
-
Sylvain Defresne authored
Bug: none Change-Id: I3961c70baed54dbe945906a62089719a2d0d8b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506437 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822138}
-
Mustaq Ahmed authored
We encountered use-cases where the user hits the Esc key to release a PointerLock then expects to request another lock soon afterwards. If the second request comes within 2secs of the Esc keypress, we have been deliberately ignoring the second request to suppress abusive uses of requestPointerLock (e.g. to prevent users from exiting the locked state, see crbug.com/1084618). To address the above problem while also preventing abusive uses, this CL reduces the delay to 1.25sec as a trade-off. Fixed: 1127223 Change-Id: I37a5e8e16e8387ac4717fc90fecf946257199575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505911Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#822137}
-
Luciano Pacheco authored
Nits addressed: - Add type check. - Remove "#export" markup. - Use Object.assign() to export test functions to global scope. Files updated: - command_test.m.js - event_target_test.m.js - cr_test.m.js (removed as it's redundant with //test/data/webui/js/cr_test.js) Bug: 1133198 Change-Id: I808675afb4419a97252fe355ed7f7b2c6f0705fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505700 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#822136}
-
Antonio Gomes authored
chromeos::TabletState's functionality will be embedded into display::ScreenBase in the future. But for now, remove direct references to it from //ui/ozone/platform/wayland. This CL also works as a precursor CL to crrev.com/c/2491517 (see relation chain), given that chromeos::TabletState instances will need to have PlatformScreen instance already set up. BUG=1113900 R=jamescook@chromium.org, rjkroege@chromium.org Change-Id: I2c89775deabae2a4a16aa45a35c707739b463a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505608 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#822135}
-
Jérôme Lebel authored
This patch adds the method interfaces in ChromeIdentityService: * virtual void RunAfterCacheIsPopulated(base::OnceClosure callback); * virtual void WaitUntilCacheIsPopulated(); This is the first patch to solve issue to load the identity list from SSO. Design doc: http://go/async-identityservice-api => crrev.com/c/2489915 Adding methods in ChromeIdentityService crrev.com/i/3353161 Implementing in ChromeIdentityServiceImpl crrev.com/c/2490110 Adding metrics crrev.com/i/3353162 Implementing the metrics crrev.com/c/2490010 Adding WaitUntilCacheIsPopulated calls crrev.com/i/3354983 Adding DCHECK for cache state Bug: 897470 Change-Id: Ie37f0424fbe4eef710ccf6b75b155a48d0b2d498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489915 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#822134}
-
Darren Shen authored
These protos are shared with google3, so this allows google3 to use the full protos for testing. Bug: b/161490915 Change-Id: Idc3630936f22401f1b614a1fe7bf5eb8fe50b365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505346 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#822133}
-
Vincent Boisselle authored
Bug: 1141737 Change-Id: I9573f6c839f9113f8c2ff03bfdb53d5d108d7740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501663Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#822132}
-
Omar Morsi authored
This CL introduces KeyPermissionsManager (KPM). KPMs are responsible for managing platform keys permissions by reading and writing permissions into chaps keys' attributes. Bug: 1113115, 1127284, 1082459 Change-Id: I5d242604fe784566d086d2012313f77ca0fdbc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435386 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#822131}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e4c794ee0a5..d7b7cafac212 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC futhark@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: futhark@google.com Change-Id: I4981aa7eac2a189118cc86286ca71d6fd569ec22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507098Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822130}
-
David Jean authored
This reverts commit 1ba5940e. Reason for revert: Fails on iOS simularor (6s 13.6) Original change's description: > Enable 0-RTT for Cronet idempotent request. > > Currently Cronet disables 0-RTT features for all POST requests, as they > are not considered idempotent. But for Youtube /videoplayback request, > we are POSTing client abr state information. We want to create an > option in Cronet UrlRequestParams to specify enabling 0-RTT when > creating idempotent requests. > > This cl only makes it available for iOS. Enabling 0-RTT for idempotent > request in Android interface will be implemented in the next cl, > since it requires a different env. > > Change-Id: Id2f1aa1fd89c654d6a374cb70566c6c72e18233e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497468 > Reviewed-by: David Schinazi <dschinazi@chromium.org> > Commit-Queue: Yu Su <yuyansu@google.com> > Cr-Commit-Position: refs/heads/master@{#821977} TBR=dschinazi@chromium.org,yuyansu@google.com Change-Id: I3bef9239635bc9758b3dce4719e72ce74e0431f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505804Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#822129}
-
Jan Wilken Dörrie authored
This change adds a C++14 backport of C++17's std::not_fn to base/functional. Bug: None Change-Id: Ib441a7210e9992786c2dc241438dc8ea538ef73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498486 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822128}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1603884477-f14a1ebfd4bd191c8d016252078cbad2c54f6d16.profdata to chrome-win32-master-1603918565-280375955eaa6ff7fe0c1e66a947d33ea408d529.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5e99148766ef68d8c7515f5b95a369906589e394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506599Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822127}
-
Yuichiro Hanada authored
The extra title of ClientControlledShellSurface can be sent before Widget of it is created. This CL makes it remember the extra title and apply it after Widget is created. Bug: 1143236 Test: Enable the debug option and open any ARC app Change-Id: I9d992e3febf6370f32d915174ed30f87ce13c9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505351Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#822126}
-
Sara Kato authored
b/35786193 has been fixed, but the feature has not been turned on. Update comment to reflect the state of this. Bug: None (cleanup) Test: manual. Change-Id: Ie1e06f7a87ec3d1a8ef5e0113bcf19a01d95f02e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505400 Auto-Submit: Sara Kato <sarakato@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#822125}
-
Jan Wilken Dörrie authored
This change adds a new base/functional/ folder and moves base::invoke and base::identity from base/stl_util.h to the new location. Bug: None Change-Id: I98cb577b5154561c82d41bfb7dc23e0ff9abee27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494923 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#822124}
-
Ramin Halavati authored
Calls to Constructor of browser class are replaced with Browser::Create function. This is the first step for making Browser constructor private and enforcing more checks before creating a browser object. Bug: 916859 Change-Id: I0a62c0d78587ff376a4f478ffe359cac87e82a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506434Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#822123}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bd4ea599. With Chromium commits locally applied on WPT: f3573769 "[:is/:where] Add WPT is-specificity-shadow.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I651fdd98cc8c9fe684e1ac8be72b8de6ac281ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505561Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822122}
-
Sylvain Defresne authored
Add new toolchains for using 14.0 deployment target. This will be used by Widget extensions (which needs to have that deployment target). Add new gn variables to detect if a secondary toolchain exists for "fat" build or not. This was previously done by checking whether the current_toolchain is the default_toolchain but this is no longer valid with toolchains used for other purposes. Bug: 1138714 Change-Id: I7705dafd2d6273a0cc77d78e5630d5c8651ea3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504229 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#822121}
-
Trent Apted authored
Rather than requiring input to start with the Jpeg DQT frames, detect whether an APP1 frame is already present. This allows an in-between layer to add an APP2 frame for the colorspace. Bug: b/169717921 Change-Id: I326575b33df4d8e609c9ca4a6c810a55d8f093a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500390Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#822120}
-
Philipp Hancke authored
similar to WebRTC.PeerConnection.SdpFormatReceived but counting answers. WebRTC implementation CL: https://webrtc-review.googlesource.com/c/src/+/186701 BUG=chromium:857004 Change-Id: Ie09d8bb4a92a4509216351d111b0b3d7c8100e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460888 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#822119}
-
Aya ElAttar authored
Given that data_transfer_* files will be used for clipboard and drag-and-drop, so - Moved data_transfer_endpoint.h/.cc and data_transfer_filter.h/.cc files from ui/base/clipboard to ui/base/data_transfer_filter - Added a new build target for DLP files to be able to include them in base/dragdrop without depending on :clipboard. Bug: 1142426 Change-Id: I10106912a91216bf2d7347b3d0da9bb88883a4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498542 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#822118}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1603767556-44fda54b3a92e9d2336119e8c5ad34567957992b.profdata to chrome-win64-master-1603907949-4ffda8056377a01132d9724a51a14693bc70ab3c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I11eb29af61c41e4046a84b751182ab82a3bc0453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506378Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822117}
-
Alice Wang authored
This CL refactors the incognito interstitial view setup by regrouping it in the same class as the view binding method so that we can have all the view related methods in one place. There is no behavior change with this refactoring. Bug: 1138824 Change-Id: Iaeceed44202e1973c765ac7c807b122e4be696d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506435Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#822116}
-
Sergey Poromov authored
According to the latest UX mocks, Capture Mode shouldn't be started if confidential content is currently visible on the screen. So, it needs to be checked upfront while starting it. However, it's still possible that a user will choose restricted area for already initiated Capture Mode session, so the existing checks should also be left. See https://docs.google.com/presentation/d/1v0GM-lwHCznFJ6hnZlUH37eBOuAkJMw5Q6UnSkcKOgA/edit?hl=en#slide=id.g9ea2b2eb9f_9_256 for mocks. Bug: 1133324 Change-Id: Iec4594b92118bf1e206bfafcadefd1e30fd070c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501743 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#822115}
-
Finnur Thorarinsson authored
This creates an empty BUILD.gn file downstream can depend on. TBR: nyquist Bug: 1135551 Change-Id: Ia283c64f5c37b9e7afc245a5fc27170dc91c2d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506179Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#822114}
-
Trent Apted authored
Bug: b/171927920 Change-Id: I5dd36a5b3600193e60820a7339e04989d44d6723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505259 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#822113}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a566e7c6849..9e4c794ee0a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC futhark@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: futhark@google.com Change-Id: I48a495f883ccff78205f2c88c2ae39373e17264e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507091Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822112}
-
Nidhi Jaju authored
In an effort to change the blink implementation of readable streams to better match the Web IDL descriptions in the Streams API Standard, this CL adds the ReadableWritablePair dictionary [1] to the ReadableStream class. ReadableWritablePair is used as a parameter for pipeThrough() to avoid unnecessary extraction of the readable and writable streams separately. This CL also includes changing the return type of pipeThrough() to ReadableStream*. Furthermore, the comments and ordering of operations in pipeThrough have also been changed to better reflect how the steps outlined in the Streams API Standard. [2] [1] https://streams.spec.whatwg.org/#dictdef-readablewritablepair [2] https://streams.spec.whatwg.org/#rs-pipe-through Bug: 1093862 Change-Id: I4a602f8bd03d300de5c4342d932b1ef8573943eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505260 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#822111}
-
Nick Harper authored
Change-Id: I432f63e305fdf9e9d6ad5303ddb1cbe41752934b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505940 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#822110}
-
Rune Lillesveen authored
Test is flakily timing out. Bug: 1133412 Change-Id: I5689bbf030931731c4e3122fffa938a22e5f3571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506432Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#822109}
-
Rayan Kanso authored
This reverts commit 9593ee49. Reason for revert: Breaking tests on Android. Looks like Mockito is failing to mock 'WindowAndroid' Sample build: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/27576? Bug: 1143640 Original change's description: > [SharingHub] Changed the way firstPartyOptions are created. > > They will not be created on demand. This simplifies the logic to decide > which options are relevant given the current state of the Chrome app. > > Change-Id: I9b3ebf3030cfaa48088d7c1d0082d659b47f28cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485838 > Commit-Queue: Tanya Gupta <tgupta@chromium.org> > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821914} TBR=kmilka@chromium.org,tgupta@chromium.org,sophey@chromium.org Change-Id: I904fb819d2fd37899faefb6c71140cd9c54ad419 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506576Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#822108}
-
Wei Lee authored
We should fix the circular dependencies to avoid potential wrong order when importing modules. For example, if the dependencies of modules are like: A --> B --> ... --> A If we import B but A needs B when loading A, it might hit "access before initialization" error. Bug: 1121457 Test: tast run [DUT] camera.CCAUI* Test: npx madge --circular main.js Test: (Replace some js with SWA version and run "npx madge" again) Change-Id: Ib41b85425fc256a3394b31a8c573f68177d45c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505397 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#822107}
-
Sergey Poromov authored
According to the latest mocks we need to show a notification instead of a toast when printing is blocked due to Data Leak Prevention configuration. See mocks: https://docs.google.com/presentation/d/1v0GM-lwHCznFJ6hnZlUH37eBOuAkJMw5Q6UnSkcKOgA/edit?hl=en#slide=id.ga3a0b63111_0_321 Bug: 1124651 Change-Id: I3bf1f73610d2f2723f75b9801bb131c7b2bf77b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505790Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#822106}
-
Antonio Gomes authored
This CL is a preparation CL, where the final goal is to move away from using chromeos::TabletState, embedding its functionality into //display/ScreenBase class. The first step to to dismantle this enum from it, so that it can be referenced to independently. TBR=jamescook@chromium.org BUG=1113900 R=jamescook@chromium.org, oshima@chromium.org, rjkroege@chromium.org Change-Id: I4d907b9d322723f581bfc1a278577088028795ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505944 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#822105}
-
Danila Kuzmin authored
When user tries to enroll their CBEdu into a non-EDU account (e.g. enterprise) they will see a new error message, added in this CL. Bug: 1113395 Change-Id: Ib73244dc65e98be6c3497e9b711dae67411b897c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465746Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#822104}
-
Robbie Gibson authored
This reverts commit 7ffe1230. Reason for revert: Disabled test on iOS 12 devices (test passes on other OS versions). Original change's description: > Revert "[iOS] Fix tab strip views when using FullscreenProvider" > > This reverts commit c756c75c. > > Reason for revert: Suspected cause of crbug.com/1142873 > > Original change's description: > > [iOS] Fix tab strip views when using FullscreenProvider > > > > When the FullscreenProvider is used, the layout of the browser views is > > slightly different. Instead of having the web content views start from > > the bottom of the toolbar, the web content extends all the way to the > > top of the BrowserContainerViewController, behind the tab strip. > > > > This means that the prior approach of making all the top background > > views clear does not work when using FullscreenProvider. Instead, this > > CL uses the following approach: set these background views to have > > the same background color as the tab grid. As soon as the panning > > gesture starts, make them clear so the tab grid shows through and the > > animations appear correctly. At the same time, move the web content > > views down so they don't obstruct the animations either. > > > > Bug: 1094335 > > Change-Id: Ieea7d268e781da5e1ccd4c2c0ad3c0925407d133 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489898 > > Reviewed-by: Mark Cogan <marq@chromium.org> > > Commit-Queue: Robbie Gibson <rkgibson@google.com> > > Cr-Commit-Position: refs/heads/master@{#821200} > > TBR=marq@chromium.org,rkgibson@google.com,mouraroberto@google.com > > Change-Id: I2b026d35000d34b29de9235ed2752273f6f7dd33 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1142873 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502574 > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821278} TBR=szager@chromium.org,marq@chromium.org,rkgibson@google.com,mouraroberto@google.com # Not skipping CQ checks because this is a reland. Bug: 1142873, 1143299 Change-Id: I052c3b730e92855b3edcbfac17b7bdf5c8c305f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502347 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#822103}
-
Mark Cogan authored
The New Window overflow menu item wasn't setting a window origin, so no metrics were recorded for it. This CL adds the appropriate origin. Bug: 1143280 Change-Id: I4a85fff19b72d35cbc8d0254086553042fb5d273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505873Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#822102}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I18816e9d92da591d92867b58ebb01ac49d40467f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506347Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822101}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cd60eacd..74cd21ef Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If09955db5d75ee0abdff859033948944947c1981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506364Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822100}
-