- 08 Dec, 2020 40 commits
-
-
Yaron Friedman authored
Continue propagation of https://chromium-review.googlesource.com/c/chromium/src/+/2572244 and switching WebContentsObserver to use GURL. BUG=783819 Change-Id: Ifeef8d149dfafb1b5b74dc48c656e7c76f50ff28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574603 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#834693}
-
Aaron Leventhal authored
Avoid "Check failed: false. We don't support iterating over objects excluded from the accessibility tree." by using ParentObjectIncludedInTree() while computing NextOnLine(), PreviousOnLine(). Bug: 1153437 Change-Id: Iebd58d44912dcf9ac20b3e0e618af3e7b7b56b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576625Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834692}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ie05076f5f7ad9543e4e6a45eb95a6847da0e66c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560119 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#834691}
-
Illia Klimov authored
PERIODIC_BACKGROUND_SYNC is registered in ContentSettingsRegistry but does not contain any data. EphemeralProvider will be removed in the future cleanup. Due to that reason, I remove the registration of PERIODIC_BACKGROUND_SYNC. Bug: 1149381 Change-Id: Ifdb68504733ee987115fe9801f0eadbb064c6c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577471Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Illia Klimov <elklm@chromium.org> Cr-Commit-Position: refs/heads/master@{#834690}
-
Vasilii Sukhanov authored
- All data about phished and leaked passwords is moved from 'compromised_credentials' to 'insecure_credentials'. - 'insecure_credentials' uses a foreign key to the 'logins' table. Thus, the properties about compromised passwords are stored only for saved passwords. - 'insecure_credentials' additionally has 'is_muted' which is not used today in Chrome but gonna be synced and used by Google password manager. Bug: 1137775 Change-Id: I2d43d99dbdeaeba521cea016c8b63f5158ad0a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565434 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#834689}
-
Maksim Ivanov authored
Drop std::move() call that has no effect and only triggers the "bugprone-use-after-move" clang-tidy warning. Bug: 1122844 Change-Id: I526182ca5e829cdd738740c0a081387481cc2ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560126 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
-
Eric Seckler authored
Disabling in memory_desktop + common_desktop for flakiness TBR: wenbinzhang@google.com Bug: 1156571 Change-Id: Ic6d78c5ee63cd9bc8486385832084675d083d96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574986Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#834687}
-
Christian Dullweber authored
Sometimes the render test takes a screenshot before the subpage is displayed. Prevent this failure by waiting for an element on the subpage to be loaded. Since the subpages are Preference fragments, we can't wait for a specific id. Instead a text fragment on the page is used as selector. Bug: 1156285 Change-Id: I4b1243307bfd648e56bf618c03a6622a824f5336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578956 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#834686}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f9233f23f55..67c8b0cbaef8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC engedy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: engedy@google.com Change-Id: I4befdf5773018989057441f6cd050369c3366322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578916Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2e018a8f25cf..9e7836c35d48 2020-12-08 wolfi@chromium.org [DarkMode] serviceWorkersView.css 2020-12-08 tvanderlippe@chromium.org Fix proxy configuration for images when debugging Karma tests 2020-12-08 jacktfranklin@chromium.org Fix keyboard usage of docking menu If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id1c7a79bc5afaa97b6e7457c2021a5e2ce2f0973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578919Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834684}
-
Antonio Sartori authored
A Web Platform Test for Content Security Policy was wrongly expecting the violated directive of a CSP report for a <script> element violation to be 'script-src'. This change fixes that. Bug: 694525, 651742 Change-Id: Ia499dbf49678e4d6e834c51ab472f874063badf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577683Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#834683}
-
Roman Sorokin authored
Also modified MultiStepBehavior in a way that it hides current step before hide the whole screen. And shows the current step back when screen is show again. Bug: 1155468 Change-Id: Iae4d920774360c5379b0adb5c32a70747c728cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571100 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#834682}
-
Maksim Moskvitin authored
This reverts commit a1c5cc32. Reason for revert: likely culprit for increasing server-side exceptions count. Original change's description: > [Sync] Process commit failure in Nigori model type processor > > In case when the server returns commit failure, it is possible that > entities will be in the transient state. This CL resets this state of > the entity for nigori data type on any commit failure. > > Bug: 1137817 > Change-Id: I042015e4f211351ad13469e510f22ae71be28c24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563302 > Commit-Queue: Rushan Suleymanov <rushans@google.com> > Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com> > Cr-Commit-Position: refs/heads/master@{#831876} TBR=mmoskvitin@google.com,rushans@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1137817 Change-Id: Ib4be790ff8b53b8c959b6bcd76849a78b9728812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577474Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#834681}
-
Balazs Engedy authored
The test is flaky on trybots, in particular on Fuchia x64, but on other platforms as well. Bug: 1154178 Change-Id: I8f3ef8b8961c4de209a76c9bacd838091e0e83fd TBR: mek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575035Reviewed-by:
-
Mikhail Khokhlov authored
This speeds up TBMv3 metric computation in results_processor. Change-Id: I76ef0ffc369b45a1104f750eb79d214931093d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577499 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Deep Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#834679}
-
Balazs Engedy authored
Bug: 1154445 Change-Id: Ibe49296b24ba6ff94835f5aa19d3728aef62ea1b TBR: roagarwal@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578839 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium fdc7a4b3. With Chromium commits locally applied on WPT: 86af9c78 "Revert "[blinkpy] Re-enable four css-background/ tests that need fuzzy reftest"" d3ae6478 "[Trusted Types] Use sample script value that is actually a script." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I1eeed22014124cef2cc8b7807c29ba3e7b2971cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575581Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834677}
-
Balazs Engedy authored
This reverts commit 7ecd3d78. Reason for revert: `crashpad_tests` failures on `Linux MSan Tests`: DebugRendezvous.Self ProcessReaderLinux.ChildModules ProcessReaderLinux.SelfModules Original change's description: > Update Crashpad to 83f194ee8544aec1c00683e1cf4e86458f33e035 > > bccb9504d1fb Roll crashpad/third_party/edo/edo/ 97121c640..6ffbf8331 (19 > commits) > 70f1ec86f95d ios: Fix setup_ios_gn.py after gn roll > 0917d31d19ef Update lss README.crashpad to point to corrected name for > license > ed132d5ec247 [syslog] Expect logsink client includes > 121d92ca3f1a Roll crashpad/third_party/mini_chromium/mini_chromium/ > cb82d7129..c748b289b (2 commits) > 6c270cf239df linux: Refactor test modules > 20cbfa49719c linux: Use mmap for attachments in PtraceBroker > 00491d58ee29 linux: Correct handling of load bias > 83f194ee8544 linux: Add linux-gate.so to valid vdso prefixes > > Bug: chromium:1147922, chromium:1128441 > Change-Id: If032f0e3c81b5fc1452867ecab4211fa713c276c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573518 > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834592} TBR=jperaza@chromium.org,mark@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idc66bf0f9c5d65738dec1a55fb58eb503a500dc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1147922 Bug: chromium:1128441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578976Reviewed-by:
-
Yoav Weiss authored
Failed navigations currently don't get a ResourceTiming entry. This CL changes that by properly reporting them. Bug: 1131929, 1105875 Change-Id: I0808f35e1b0d596c2bafa7630ed873c947254c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567925 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#834675}
-
Balazs Engedy authored
Bug: 1155107 Change-Id: Ia0fe38242513ba5e0d6c5fd67b984bab5a3dd2b0 TBR: triploblastic@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574955Reviewed-by:
-
Mikel Astiz authored
SyncData::ToString() is used for logging and, starting with https://crrev.com/c/2562659, it can DCHECK-fail if the sync entity's title is empty. This patch removes the DCHECK from SyncData::GetTitle(), since it seems overly strict, and the main calling site in SyncableServiceBasedBridge already verifies that the title is non-empty. To make this more obvious, an additional DCHECKs is introduced (which is redundant with pre-existing DCHECKs) and two functions renamed for clarity. Change-Id: Ib499e6a07132ab21033d83a241e5e380226913b0 Fixed: 1156130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577468 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Ramin Halavati authored
Password manager client and and generated password leak pref are updated to be disabled for ephemeral Guest profiles, similar to off-the-record Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I3a2187c25f5940047d61722769f8d286886818e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577501 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53fee9259fa3..2e018a8f25cf 2020-12-08 sigurds@chromium.org Mutually link requests with their prefetch requests 2020-12-08 changhaohan@chromium.org Temporarily disable two wasm-related tests. 2020-12-08 sigurds@chromium.org Prevent name-clash of CSS class names If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141824,chromium:1156555 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I50563645779b732c24fd38b5305de6cdfd076431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578669Reviewed-by:
-
dpapad authored
In this CL creating subfolders for - chrome://flags - chrome://interventions - chrome://version - chrome://webapks This is part of an effort to clean up chrome/browser/resources folder, such that most (if not all) files are under a subfolder dedicated to to the WebUI page that uses them, along with appropriate OWNERS files. Bug: None Change-Id: Idd2d85fa0b938a0f51937adc4ae79cd0991fbf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575953Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#834670}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e94373d60dc3..9f9233f23f55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC engedy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: engedy@google.com Change-Id: I234fcf774800f98c9f3652a491be01c4faf55ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578667Reviewed-by:
-
Maksim Moskvitin authored
This reverts commit f357a95c. Reason for revert: rollout is not completed yet and has to be done using finch. Original change's description: > Enable SyncTriggerFullKeystoreMigration by default > > Bug: 1094326 > Change-Id: I1cc440f13b92fc825cc749c042e8599fdab793c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455447 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814665} TBR=mastiz@chromium.org,mmoskvitin@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1094326 Change-Id: I4df81e8a74ba25d6cb3ff3c71989e701f4b21b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576239Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#834668}
-
Balazs Engedy authored
Bug: 1156285 Change-Id: Ib2abc6d9524fde559d52be9c8498fa3868bad355 TBR: dullweber@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574987Reviewed-by:
-
Balazs Engedy authored
Bug: 1156576 Change-Id: I463f384ab10fa81d1a2888de85dd03374c2a1d0f TBR: shengfa@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577367Reviewed-by:
-
Elizabeth Popova authored
The new input is placed above the name field and only shown if Address Editor is opened from Autofill Settings (purpose = AUTOFILL_SETTINGS) and kAutofillEnableUIForHonorificPrefixesInSettings feature is enabled. The entered value will not be saved, because honorifics are temporarily disabled (crbug/1113617). Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/4dcf597fed4da10035e80a4f22cf4a73b927a84e Bug: 1141884 Change-Id: I2ff12dfb6935d576e3ca73c3b3cdaddd75b82b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571759Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#834665}
-
Zakhar Voit authored
This adds a test for the previous CL: https://crrev.com/2564643 BUG=1113272 Change-Id: Ia43f3d0d788cb79ce4ec91baee5c0207660dfd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566960Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Commit-Queue: Zakhar Voit <zvoit@igalia.com> Cr-Commit-Position: refs/heads/master@{#834664}
-
Wojciech Dzierżanowski authored
Introduce a GetOverlayWindow() getter that returns the overlay window object cast to the intended type OverlayWindowViews. This avoids a fair amount of repetition in the test. No functionality change. Bug: 985303 Change-Id: I0e1a4a510e9703b1480480bcadc2c75070ba7b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575022 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#834663}
-
Ramin Halavati authored
The "force signin" policy is updated to handle ephemeral Guest profiles similar to off the record Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I5527423c3fbc9abe3ac005242b11203d25121066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577682 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#834662}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e59d8716b300..a13f6847238e 2020-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bbe26af2 to a3984b7e (468 revisions) 2020-12-08 syoussefi@chromium.org Suppress flaky multithreading swiftshader test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I12ee3f84b478a59d567fdceb8d157892f08ed5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578780Reviewed-by:
-
arthursonzogni authored
With real users, we are seeing unexpected difference in between the sandbox flags computed from the renderer and the browser process. This is implemented by those two functions: - content::NavigationRequest::ComputeSandboxFlagsToCommit() - blink::FrameLoader::CalculateSandboxFlags After a navigation, the new document gets sandbox_flags from: - FramePolicy.sandbox, which contains everything except CSP. - The response's CSP sandbox. That's basically it. Both function does the same and are fed from the same data. The only difference is blink, which used "forced_sandbox_flags". This looked a bit mysterious at first. It turns out to be needed only for setting the sandbox flags for the initial empty document and the second 'initial empty document'. (e.g. not via navigation). Removing forced_sandbox_flags from CalculateSandboxFlags helps guaranteeing both browser side and renderer side computation always match. This make it explicit in the code from where the inheritance happens. This patch aligns inheriting sandbox from the opener with "OpenerFeatureState" (1), by moving it toward Frame, instead of the FrameLoader. (1) Turns out this will be removed: https://chromium-review.googlesource.com/c/chromium/src/+/2564396 Change-Id: I7098b459e485485630ab9edc99d392fcdbfdef4e Bug: 1153708 Fixed: 1153708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573362 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#834660}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I15d8d049626c71d53e06afe21437ac0b64aed21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578479Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834659}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607374595-14878fd6c473cc4aebbe55be6f54c0ff79c3ed8e.profdata to chrome-win32-master-1607396289-70fddd0960b2020da66aa7308994f58594fe5850.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1a8e7dae44013f1b9dd93d079a22a6d8c58f383a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578399Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607374595-d12d27ca344e18f0b40a9dc8f54420fe6b49bde9.profdata to chrome-win64-master-1607396289-b814d12d89d9aa0b6942a46cc974733f2726887a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I628099855f27bcc8065e6183d1aac2d67a30089b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578108Reviewed-by:
-
Ramin Halavati authored
Updates ProfilePickerHandler to record ephemeral Guest profiles launch similar to off the record Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I12625f7db4addfe6f8dcd7bc05584dbf45d404c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574755Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7843c257dbae..53fee9259fa3 2020-12-08 sigurds@chromium.org Improve types in front_end/sdk/SDKModel.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibf01fc2779e7e81a88f9c21af5b49cecb5e8fd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578663Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib0da17331a3638a708a8b43a79a74bf0f7702017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578658Reviewed-by:
-
