1. 17 Aug, 2011 9 commits
    • abarth@webkit.org's avatar
      Add a CG qualifier similar to the GPU qualifier · a56b4a0b
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66359
      
      Reviewed by Eric Seidel.
      
      Once we have a Skia configuration on Chromium Mac, we'll use this CG
      qualifier to note that expectations apply only to the CG configuration.
      
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93190 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a56b4a0b
    • msaboff@apple.com's avatar
      Crash in Structure::visitChildren running iAd.js regression test suite under memory pressure · 67e810dd
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66351
      
      JIT::privateCompilePutByIdTransition expects that regT0 and regT1
      have the basePayload and baseTag respectively.  In some cases,
      we may get to this generated code with one or both of these
      registers trash.  One know case is that regT0 on ARM may be
      trashed as regT0 (r0) is also arg0 and can be overrun with sp due
      to calls to JIT::restoreReturnAddress().  This patch uses the
      values on the stack.  A longer term solution is to work out all
      cases so that the register entry assumptions can assured.
      
      While fixing this, also determined that the additional stack offset
      of sizeof(void*) is not needed for ARM.
      
      Reviewed by Gavin Barraclough.
      
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::privateCompilePutByIdTransition):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93189 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      67e810dd
    • levin@chromium.org's avatar
      REGRESSION (r89086): All worker xhr requests trigger preflight requests. · 6ff986bb
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66340
      
      Reviewed by Adam Barth.
      
      Test coming in a more comprehensive patch shortly. This is just a very targetted
      patch to allow for easier merging.
      
      * loader/CrossOriginAccessControl.cpp:
      (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
      of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
      set before calling this function. This is similar to what is done for "origin" in here.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93188 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6ff986bb
    • hayato@chromium.org's avatar
      Add two sample mismatch reftests to make sure that reftests work correctly. · 966db87f
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66218
      
      Reviewed by Tony Chang.
      
      One mismatch reftest is expected to pass, the other is expected to
      fail. The failed one is marked as 'WONTFIX' in test expectations
      in chromium port and is skipped in other ports.
      
      * fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html: Added.
      * fast/harness/sample-fail-mismatch-reftest.html: Added.
      * fast/harness/sample-mismatch-reftest-expected-mismatch.html: Added.
      * fast/harness/sample-mismatch-reftest.html: Added.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/Skipped:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93187 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      966db87f
    • commit-queue@webkit.org's avatar
      Computing screen-space transform for LayerChromium and CCLayerImpl · c4daaeea
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66114
      
      Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-16
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Test: compositing/backface-visibility-hierarchical-transform.html
      
      Added a data member to LayerChromium and CCLayerImpl that holds
      the screen-space transform.   The transform is computed in
      calculateDrawTransformsAndVisibility(), which is used during
      updating (LayerChromium) and drawing (CCLayerImpl).  This transform
      will also be used for other things, such as HUD drawing, in upcoming
      patches.
      
      Also fixed a FIXME in LayerRendererChromium::drawLayer, which
      was not computing the entire hierarchy of transforms to determine
      back-face visibility.  Now it simply uses the screen space transform.
      
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore::LayerChromium::screenSpaceDrawTransform):
      (WebCore::LayerChromium::setScreenSpaceDrawTransform):
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::updateLayers):
      (WebCore::LayerRendererChromium::drawLayersInternal):
      (WebCore::LayerRendererChromium::drawLayer):
      (WebCore::calculateDrawTransformsAndVisibility):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore::CCLayerImpl::screenSpaceDrawTransform):
      (WebCore::CCLayerImpl::setScreenSpaceDrawTransform):
      
      LayoutTests:
      
      This case tests if backface visibility properly accounts for a hierarchy
      of transforms.
      
      * compositing/backface-visibility-hierarchical-transform-expected.png: Added.
      * compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
      * compositing/backface-visibility-hierarchical-transform.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93186 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c4daaeea
    • rniwa@webkit.org's avatar
      More rebaselines for Windows WebKit2 port. · 6c364acd
      rniwa@webkit.org authored
      * platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
      * platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt:
      * platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93185 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6c364acd
    • hayato@chromium.org's avatar
      Implement proper handling of events which happen in children of shadow hosts. · f101ebb5
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66285
      
      Reviewed by Dimitri Glazkov.
      
      Fix the issue where a shadow host stops an event propagation if an
      event happens at the children of shadow hosts, outside of the shadow root.
      
      Source/WebCore:
      
      Test: fast/dom/shadow/shadow-contents-event.html
      
      * dom/EventDispatcher.cpp:
      (WebCore::EventDispatcher::adjustToShadowBoundaries):
      
      LayoutTests:
      
      * fast/dom/shadow/details-summary-mouseover-expected.txt: Removed.
      * fast/dom/shadow/details-summary-mouseover.html: Removed.
      * fast/dom/shadow/shadow-contents-event-expected.txt: Added.
      * fast/dom/shadow/shadow-contents-event.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93184 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f101ebb5
    • eric@webkit.org's avatar
      REGRESSION(92717): WinPort needs to parse version information from port_name · 0b0918e4
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66325
      
      Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
      
      * Scripts/webkitpy/layout_tests/port/mac.py:
      * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93183 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0b0918e4
    • commit-queue@webkit.org's avatar
      Make it possible to explicitly prevent a preflight via ThreadableLoaderOptions · d090f6cc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65694
      
      Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2011-08-16
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      No new tests since there is no change in behavior.
      
      * fileapi/FileReaderLoader.cpp:
      (WebCore::FileReaderLoader::start):
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
      (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
      * loader/ThreadableLoader.h:
      (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
      * notifications/Notification.cpp:
      (WebCore::Notification::startLoading):
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::createRequest):
      
      Source/WebKit/chromium:
      
      * src/AssociatedURLLoader.cpp:
      (WebKit::AssociatedURLLoader::loadAsynchronously):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93182 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d090f6cc
  2. 16 Aug, 2011 31 commits
    • abarth@webkit.org's avatar
      Change webkit-patch analyze-baselines to print in a more unix-friendly way · 60b25d59
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66349
      
      Reviewed by James Robinson.
      
      As requested by jamesr.
      
      * Scripts/webkitpy/tool/commands/rebaseline.py:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93178 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      60b25d59
    • rniwa@webkit.org's avatar
      win-wk2 needs updated baselines for some editing tests · 558d158f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66344
      
      win-wk2 didn't have some necessary baselines for an earlier patch;
      they have been copied directly from LayoutTests/platform/chromium-win
      
      Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-16
      Reviewed by Ryosuke Niwa.
      
      * platform/win-wk2/editing/deleting: Added.
      * platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt.
      * platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-003-expected.txt.
      * platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-004-expected.txt.
      * platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93177 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      558d158f
    • eric@webkit.org's avatar
      REGRESSION(92717): WinPort needs to parse version information from port_name · 339bcbc7
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66325
      
      Reviewed by Adam Barth.
      
      WinPort didn't have any port_name parsing logic.
      Seemed it was best to just share the logic from MacPort.
      Sharing the logic from MacPort seemed easiest with a shared superclass.
      Once I created ApplePort (the superclass) there was a bunch of logic to share.
      I found LeakDetector was just in the way when switching back and forth
      between win.py and mac.py so I moved it into its own file.
      
      The only logic change here is that WinPort should now be
      able to parse port_name values like MacPort (and other ports)
      can.  The fact that ports do this in their constructors is
      wrong and a source of many bugs.  But at least now WinPort
      matches the status-quo.
      
      * Scripts/webkitpy/layout_tests/port/apple.py: Added.
      * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
      * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
      * Scripts/webkitpy/layout_tests/port/mac.py:
      * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
      * Scripts/webkitpy/layout_tests/port/port_testcase.py:
      * Scripts/webkitpy/layout_tests/port/win.py:
      * Scripts/webkitpy/layout_tests/port/win_unittest.py:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93176 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      339bcbc7
    • abarth@webkit.org's avatar
      Add webkit-patch analyze-baselines, as requested by jamesr. · 1e1e9a52
      abarth@webkit.org authored
      * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
      * Scripts/webkitpy/tool/commands/rebaseline.py:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93175 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1e1e9a52
    • commit-queue@webkit.org's avatar
      Fix spelling error. · ba99e73f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66261
      
      Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-16
      Reviewed by Adam Barth.
      
      No functional change, no tests needed.
      
      * platform/ScrollAnimator.cpp:
      (WebCore::ScrollAnimator::scroll):
      (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollAnimator::notifyPositionChanged):
      * platform/ScrollAnimator.h:
      * platform/ScrollAnimatorNone.cpp:
      (WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollAnimatorNone::animationTimerFired):
      * platform/ScrollAnimatorWin.cpp:
      (WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollAnimatorWin::animateScroll):
      * platform/chromium/ScrollAnimatorChromiumMac.h:
      * platform/chromium/ScrollAnimatorChromiumMac.mm:
      (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
      (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
      (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
      (WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
      (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
      (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
      (WebCore::ScrollAnimatorMac::notifyPositionChanged):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93174 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ba99e73f
    • abarth@webkit.org's avatar
      Fold bulk-optimize-baselines into optimize-baselines · 448778e6
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66345
      
      Reviewed by James Robinson.
      
      bulk-optimize-baselines is now a superset of optimize-baselines, so
      they can be combined.
      
      * Scripts/webkitpy/tool/commands/rebaseline.py:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93173 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      448778e6
    • tony@chromium.org's avatar
      Add placeholder directories so the chromium canary bots can update. · a5210645
      tony@chromium.org authored
      * platform/chromium-mac: Added.
      * platform/chromium-mac/fast: Added.
      * platform/chromium-mac/fast/events: Added.
      * platform/chromium-mac/http: Added.
      * platform/chromium-mac/http/tests: Added.
      * platform/chromium-mac/http/tests/workers: Added.
      * platform/chromium-mac/storage: Added.
      * platform/chromium-mac/storage/domstorage: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93172 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a5210645
    • joepeck@webkit.org's avatar
      <http://webkit.org/b/66328> ASSERT in fast/css/custom-font-xheight.html · 27b7190b
      joepeck@webkit.org authored
      Reviewed by Dan Bernstein.
      
      In r93140 the temporary font created for a remote CSS font face
      was created without being retained. We need to protect the
      font from being purged while we hold onto it, so add a font cache
      purge preventer.
      
      * css/CSSFontFaceSource.cpp:
      (WebCore::CSSFontFaceSource::getFontData):
      
      * platform/chromium/test_expectations.txt:
      Unskipped.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93171 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      27b7190b
    • rniwa@webkit.org's avatar
      Skip tests modified by r93134 on WebKit2 since they now sets editing behavior explicitly, · cbe857af
      rniwa@webkit.org authored
      which WebKitTestRunner does not support yet.
      
      * platform/wk2/Skipped:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93170 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cbe857af
    • jam@chromium.org's avatar
      [chromium] cleanup after previous webkit change rolled into chrome · e96a64be
      jam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66177
      
      Reviewed by James Robinson.
      
      * DEPS:
      * WebKit.gyp:
      * public/WebScrollbar.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93169 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e96a64be
    • abarth@webkit.org's avatar
      a600339a
    • abarth@webkit.org's avatar
      2a7829b3
    • abarth@webkit.org's avatar
      Move chromium-mac to chromium-cg-mac to prepare for Skia switchover · c34fc975
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66334
      
      Reviewed by Tony Chang.
      
      This patch moves us closer to switching the Chromium port from
      CoreGraphics to Skia.  This patch teaches our tools that the current
      Chromium Mac configuration is actually chromium-cg-mac, which makes
      room for a future chromium-mac configuration that uses Skia.
      
      Shortly after this patch lands, I'll do a server-side move of the
      chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
      and chromium-cg-mac-leopard.
      
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
      * Scripts/webkitpy/common/config/build.py:
      * Scripts/webkitpy/common/config/build_unittest.py:
      * Scripts/webkitpy/layout_tests/port/base.py:
      * Scripts/webkitpy/layout_tests/port/builders.py:
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
      * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
      * Scripts/webkitpy/layout_tests/port/dryrun.py:
      * Scripts/webkitpy/layout_tests/port/factory.py:
      * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
      * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
      * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
      * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
      * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
      * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
      * TestResultServer/static-dashboards/flakiness_dashboard.html:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93166 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c34fc975
    • tony@chromium.org's avatar
      [chromium] fast/css/custom-font-xheight.html is asserting on all · 4c786fb8
      tony@chromium.org authored
      chromium builds.
      
      Also mark 2 repaint tests as failing on mac.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93165 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4c786fb8
    • tony@chromium.org's avatar
      [chromium] fast/repaint/canvas-putImageData.html is now passing · be82d80e
      tony@chromium.org authored
      because of the win baselines added in r93139.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93164 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      be82d80e
    • dglazkov@chromium.org's avatar
      garden-o-matic frontend needs a friendly relative time description method. · 56c6ff7d
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66324
      
      Reviewed by Adam Barth.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93163 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      56c6ff7d
    • aroben@apple.com's avatar
      Add Windows results for scripts-panel.html · b7eea66d
      aroben@apple.com authored
      The Windows results match the cross-platform results, not the Mac results.
      
      * platform/win/inspector/debugger/scripts-panel-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93162 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b7eea66d
    • dglazkov@chromium.org's avatar
      Summary view should not add multiple entries for the same test failure. · ef310332
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66318
      
      Reviewed by Adam Barth.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
          equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93161 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ef310332
    • joepeck@webkit.org's avatar
      Unreviewed Chromium Windows build fix after r93140. Take 4. · 1ea19571
      joepeck@webkit.org authored
      Namespace the now public enum as FontCache::ShouldRetain.
      
      * platform/graphics/chromium/FontCacheChromiumWin.cpp:
      (WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93160 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1ea19571
    • aroben@apple.com's avatar
      Add Windows results for overlapped-iframe-iframe.html · ad155dbc
      aroben@apple.com authored
      The Windows results match the cross-platform results, not the Mac results.
      
      * platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt: Copied from compositing/iframes/overlapped-iframe-iframe-expected.txt.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93159 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ad155dbc
    • aroben@apple.com's avatar
      Skip another test that relies on eventSender.scalePageBy on Windows · 893d4205
      aroben@apple.com authored
      * platform/win/Skipped: Added fast/repaint/background-scaling.html.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93158 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      893d4205
    • senorblanco@chromium.org's avatar
      Canvas resizing can be slow · d29c4640
      senorblanco@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66251
      
      Canvas resizing was slow due to re-allocation of the ImageBuffer on
      each size change (width or height).  This was introduced inadvertently
      by calls to isAccelerated() during canvas reset().  Since we won't 
      know if we have successfully accelerated until ImageBuffer creation,
      move the compositor invalidation to createImageBuffer() as well.
      This patch also attempts to unify the Skia and CG accelerated canvas
      paths.  The DrawingBuffer used by the Skia path is now owned by 
      ImageBuffer[Skia], similar to how the IOSurface is owned by
      ImageBuffer[CG].  Some of the logic for when to accelerate was moved
      into HTMLCanvasElement and unified with the CG path.  Acceleration is
      also now enabled by the same "Accelerated" ImageBuffer create flag
      used by the CG path.  DrawingBuffer is now re-created even for a 
      same-size change (same as the memory buffer), but we speed it up
      by calling GraphicsContext3D::texImage2D() with a NULL pixels ptr
      instead of GraphicsContext3D::teximage2DResourceSafe() (no need to
      clear it, since it's done with a glClear anyway).
      
      Reviewed by Kenneth Russell.
      
      Covered by existing tests in fast/canvas and canvas/philip.
      
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::reset):
      Don't call isAccelerated() from reset(), since we don't want to
      inadvertently create the ImageBuffer.  Also, since we won't know if
      we have successfully accelerated until createImageBuffer() is
      called, defer the compositor invalidation to createImageBuffer() as
      well.
      (WebCore::HTMLCanvasElement::shouldAccelerate):
      Unify the CG and Skia ports' logic for when to accelerate (Skia
      logic moved in from CanvasRenderingContext2D).
      (WebCore::HTMLCanvasElement::createImageBuffer):
      Use the unified shouldAccelerate() logic, and pass it as a flag
      to ImageBuffer.  Do compositor invalidation as well.
      * html/HTMLCanvasElement.h:
      (WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
      Expose hasCreatedImageBuffer() publically, so
      CanvasRenderingContext2D::isAccelerated() doesn't inadvertently create
      it.
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
      (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
      Remove all acceleration setting and resetting, since it's now done
      during ImageBuffer creation.
      (WebCore::CanvasRenderingContext2D::isAccelerated):
      Check if the image buffer was created, so we don't inadvertently
      create it here.
      (WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
      Don't call GraphicsContext3D::paintsIntoCanvasBuffer(), since its
      WebViewImpl may be null.  Ask the render tree instead.
      (WebCore::CanvasRenderingContext2D::reset):
      Don't reset acceleration here, since we don't own it anymore.
      (WebCore::CanvasRenderingContext2D::platformLayer):
      Call into the ImageBuffer to get our PlatformLayer.
      * html/canvas/CanvasRenderingContext2D.h:
      Remove m_drawingBuffer, and all acceleration-related calls.
      * platform/graphics/GraphicsContext.cpp:
      * platform/graphics/GraphicsContext.h:
      Remove setGraphicsContext3D(), and paintsIntoImageBuffer().
      * platform/graphics/ImageBuffer.cpp:
      (WebCore::ImageBuffer::platformLayer):
      Implement a dummy platformLayer() call for non-skia ports.
      * platform/graphics/ImageBuffer.h:
      Declare a platformLayer() call (USE(ACCELERATED_COMPOSITING) only).
      * platform/graphics/chromium/ImageBufferDataSkia.h:
      Add a DrawingBuffer data member.
      * platform/graphics/gpu/DrawingBuffer.cpp:
      (WebCore::DrawingBuffer::reset):
      Use texImage2D() with a NULL ptr, not texImage2DResourceSafe().
      Since we immediately clear the framebuffer via glClear(), this whole
      resource safe business is overkill.
      * platform/graphics/skia/GraphicsContextSkia.cpp:
      Remove setGraphicsContext3D() and paintsIntoImageBuffer().  This
      functionality is handled by ImageBuffer now.
      * platform/graphics/skia/ImageBufferSkia.cpp:
      (WebCore::ImageBuffer::ImageBuffer):
      Give the ImageBufferData ownership of the DrawingBuffer.
      (WebCore::ImageBuffer::platformLayer):
      Implement an accessor for the DrawingBuffer's PlatformLayer.
      * platform/graphics/skia/PlatformContextSkia.cpp:
      (WebCore::PlatformContextSkia::setGraphicsContext3D):
      * platform/graphics/skia/PlatformContextSkia.h:
      Remove isPathSkiaSafe() extern (unused).
      Remove paintsIntoImageBuffer() (now unused).  Remove IntSize param
      from setGraphicsContext3D() (unused).
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93157 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d29c4640
    • joepeck@webkit.org's avatar
      Unreviewed Chromium Windows build fix after r93140. Take 3. · 66b0c5f3
      joepeck@webkit.org authored
      Include the proper includes!
      
      * platform/graphics/FontCache.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93156 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      66b0c5f3
    • aroben@apple.com's avatar
      Teach TestFailures that tests that have failed or passed many times in a row are not flaky · a8e45b2d
      aroben@apple.com authored
      The basic strategy here is that once a test has failed or passed many times in a row we
      never again consider it as a possibly flaky test. It's a simple strategy but seems to result
      in many fewer false positives than our current behavior.
      
      Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
      flaky, including tests that failed for a while but then were fixed
      
      Reviewed by Dan Bates.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
      (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
      number of non-too-many-failure builds we've seen.
      (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
      failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
      tests, keep track of how many times they have passed or failed in a row. If they pass or
      fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
      considered flaky it doesn't matter how many times it passes or fails.)
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
      Added tests for the above.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93155 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a8e45b2d
    • tony@chromium.org's avatar
      [chromium] fast/css/custom-font-xheight.html is hitting an assert · 1ee044b5
      tony@chromium.org authored
      in debug on Linux.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93154 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1ee044b5
    • tony@chromium.org's avatar
      [chromium] Mark new tests as failing. Will pull results from the · d8c230b2
      tony@chromium.org authored
      bots when they cycle.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93153 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d8c230b2
    • dglazkov@chromium.org's avatar
      garden-o-matic needs a summary view with actions for each problem. · f6d1a7af
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66144
      
      Reviewed by Adam Barth.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93152 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f6d1a7af
    • joepeck@webkit.org's avatar
      Unreviewed Chromium Windows build fix after r93140. Take 2. · a22323bf
      joepeck@webkit.org authored
      This just makes the troublesome enum public. If this
      fixes the build I will file a follow-up bug to clean-up
      these build issues and either keep the enum public and
      cleanup other functions or restore the enum to private.
      There is no harm in making the enum public right now.
      
      * platform/graphics/FontCache.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93151 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a22323bf
    • commit-queue@webkit.org's avatar
      Unmatrix algorithm implementation is wrong · b365c094
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66080
      
      Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-16
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Current version of the algorithm negates only the scaleX while
      it should negate also scaleY and scaleZ when appropriate.
      
      Test: animations/animation-matrix-negative-scale-unmatrix.html
      
      * platform/graphics/transforms/TransformationMatrix.cpp:
      (WebCore::decompose):
      
      LayoutTests:
      
      * animations/animation-matrix-negative-scale-unmatrix-expected.txt: Added.
      * animations/animation-matrix-negative-scale-unmatrix.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93150 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b365c094
    • joepeck@webkit.org's avatar
      Unreviewed Chromium Windows build fix after r93140. · 69a3d559
      joepeck@webkit.org authored
      * platform/graphics/FontCache.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93149 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      69a3d559
    • eric.carlson@apple.com's avatar
      Make video-controls-no-scripting.html results platform independent. · c521cf50
      eric.carlson@apple.com authored
      * media/video-controls-no-scripting-expected.txt:
      * media/video-controls-no-scripting.html:
      * platform/chromium/media/video-controls-no-scripting-expected.txt: Removed.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93148 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c521cf50